node-red-contrib-ntrip 0.2.9 → 0.2.11

package/doc/architecture/overview.md

@@ -1,77 +0,0 @@
-# Overview
-
-## What this package is
-
-`node-red-contrib-ntrip` is a Node-RED contribution package that adds four
-GNSS-related nodes to a Node-RED palette. The package is distributed via npm
-and consumed by users through Node-RED's "Manage palette" UI — there is no
-standalone application binary.
-
-The four nodes:
-
-| Node | Direction | Library | Purpose |
-|------|-----------|---------|---------|
-| `NtripClient` | network ↔ flow | [`ntrip-client`](https://github.com/dxhbiz/ntrip-client) (extended) | Connect to an NTRIP caster as either a *client* (download corrections) or a *server* (upload corrections to a mountpoint). |
-| `RtcmDecoder` | binary → object | [`@gnss/rtcm`](https://github.com/node-ntrip/rtcm) | Decode RTCM 3 binary frames into JavaScript objects. |
-| `NmeaDecoder` | text → object | [`@gnss/nmea`](https://github.com/node-ntrip/nmea) | Decode NMEA 0183 ASCII sentences into JavaScript objects. |
-| `NmeaEncoder` | object → text | [`@gnss/nmea`](https://github.com/node-ntrip/nmea) | The inverse — emit a NMEA sentence string from an object. |
-
-## Who uses it
-
-Practitioners building RTK/PPP/DGNSS pipelines in Node-RED — typically:
-
-- Receiving correction streams from a public NTRIP caster (RTK2Go, SAPOS,
-  Centipede, Onocoy) and forwarding them to a rover (e.g. an ESP32-XBee, an
-  RTKLib instance, a u-blox receiver) over TCP, Serial, MQTT.
-- Operating a private base station (e.g. RTKBase) and pushing corrections to a
-  caster for others to consume.
-- Logging or inspecting GNSS messages live for monitoring or debugging.
-
-## How the nodes fit together
-
-A typical flow looks like:
-
-```
-                                   ┌────────────────┐
-                                   │  RTCM Decoder  │──► (per-frame objects, output 1)
-                                   │                │──► (decode errors,    output 2)
-   ┌────────────────┐  RTCM bytes  └────────────────┘
-   │  NTRIP Client  │──────────────►
-   │   (download)   │              ┌────────────────┐
-   └────────────────┘              │  NMEA Decoder  │──► (per-sentence objects, output 1)
-                                   │                │──► (decode errors,        output 2)
-                                   └────────────────┘
-```
-
-```
-   ┌─────────────────┐   RTCM bytes  ┌────────────────┐
-   │  TCP In / RTK   │──────────────►│  NTRIP Client  │──► (caster replies, optional pass-through)
-   │  Base / etc.    │               │   (upload)     │
-   └─────────────────┘               └────────────────┘
-```
-
-For VRS / network-RTK casters that require a position fix from the client:
-
-```
-   ┌─────────────┐ msg.payload=[x,y,z] ┌────────────────┐
-   │ Position    │────────────────────►│  NTRIP Client  │──(internal: synthesise NMEA GGA periodically)──► caster
-   │ source      │                     │   (download)   │
-   └─────────────┘                     └────────────────┘
-```
-
-## Runtime model
-
-- **Pure JavaScript, no build step.** Files in [ntrip/](../../ntrip/) are loaded by Node-RED at startup.
-- **Single registration entry point** — [ntrip/99-ntrip.js](../../ntrip/99-ntrip.js) `require`s the four node implementations and calls `RED.nodes.registerType` for each. See [ADR-0001](adr/0001-single-registration-file.md).
-- **Editor HTML co-located** — all four node configuration dialogs and help text live in [ntrip/99-ntrip.html](../../ntrip/99-ntrip.html).
-- **Node ≥ 18** — runtime requires `AggregateError` and modern syntax.
-- **Stateless across restarts** — node configuration is persisted by Node-RED's flow file; the nodes themselves carry only in-memory state (counters, the NTRIP socket, the RTCM pending buffer).
-
-## Reading order for new contributors
-
-1. This file.
-2. [Structural Design](structural-design.md) — how files and modules relate.
-3. [Behavioural Design](behavioural-design.md) — runtime flow, state machines, error paths.
-4. [Architecture Decisions](architecture-decisions.md) — links to each ADR.
-5. [Errors and Weaknesses](errors-and-weaknesses.md) — current known limitations.
-6. [Statistics](statistics.md) — LOC, test count, and a simple quality index.

package/doc/architecture/refactoring-recommendations.md

@@ -1,114 +0,0 @@
-# Refactoring Recommendations
-
-Items below are *recommendations*, not blockers. They are ordered by leverage —
-the changes near the top would simplify the code or unlock further improvements;
-the ones near the bottom are nice-to-have polish.
-
-## 1. Split `NtripClient` node into mode-specific handlers
-
-[ntrip/nodes/ntrip-client-node.js](../../ntrip/nodes/ntrip-client-node.js) is the
-biggest file in the package (~180 LOC) and mixes:
-
-- Configuration parsing and validation
-- Coordinate gating
-- Download vs upload branching
-- Handshake state machine
-- Status badge updates
-- Input dispatch (Array → `setXYZ` vs Buffer → `write`)
-- Error coercion (AggregateError vs plain Error)
-- Close cleanup
-
-Suggested decomposition:
-
-```
-ntrip-client-node.js          (90 LOC — wiring, lifecycle, status)
-  ├── parse-config.js         (50 LOC — host/port/coords validation, returns options)
-  ├── handshake-state.js      (40 LOC — the `connected` machine + buffer-tail splitter)
-  └── input-router.js         (30 LOC — Array→setXYZ vs Buffer→write)
-```
-
-This unlocks per-piece unit tests (you can test `handshake-state.js` without a
-socket) and makes future protocol additions (e.g. NTRIP V2 keep-alive
-heartbeat) localisable.
-
-## 2. Pull the handshake protocol bytes into a constants module
-
-The four authentication-mode handshake strings live as template literals
-inside [ntrip/lib/ntrip-client.js](../../ntrip/lib/ntrip-client.js) `_connect`.
-Moving them to a `lib/handshake-protocols.js` table makes them:
-
-- testable without standing up a TCP server
-- comparable side-by-side
-- replaceable per-protocol when a caster requires a quirk header
-
-```javascript
-// lib/handshake-protocols.js
-module.exports = {
-    legacy:   ({mp, user, pw}) => user || pw
-        ? `SOURCE ${pw} /${mp}\r\nSource-Agent: NTRIP ${user}\r\n\r\n`
-        : `SOURCE ${mp}\r\n\r\n`,
-    hybrid:   ({mp, auth}) => `SOURCE ${mp}\r\nAuthorization: Basic ${auth}\r\n\r\n`,
-    ntripv1:  ({mp, ua, auth}) => `POST /${mp} HTTP/1.0\r\n...`,
-    ntripv2:  ({mp, host, port, ua, auth}) => `POST /${mp} HTTP/1.1\r\nHost: ${host}:${port}\r\n...`,
-};
-```
-
-## 3. Delegate `_connect` instead of replacing it
-
-Today `NtripClientUploader._connect()` is a full re-implementation of the
-upstream `NtripClient._connect()` — copy-paste of timeout/connect/data/end/
-close/error wiring with only the on-connect handshake string differing. Any
-fix to the upstream socket lifecycle won't reach the uploader.
-
-A delegation refactor: override only `_buildHandshake()` (a new hook) and call
-`super._connect()`. Requires either upstream cooperation or carefully scoping a
-local fork. See [ADR-0002](adr/0002-ntrip-uploader-extension.md).
-
-## 4. Generate the editor HTML from a schema
-
-[ntrip/99-ntrip.html](../../ntrip/99-ntrip.html) is ~470 lines, most of which
-is repeated `<dl class="message-properties">` markup for help text. A small
-build step (`prebuild` npm script + JS that reads a JSON/JS schema) would
-shrink the source and eliminate drift between code and help text. Trade-off:
-introduces a build step the package currently doesn't have.
-
-## 5. Stop attaching the raw `input` Buffer to every emitted message
-
-Decoders today emit `payload.input = <slice of the consumed buffer>` on
-success. For high-rate RTCM streams (~100 frames/s) this means each downstream
-node holds a reference to that buffer until it discards the message — extra GC
-pressure for no functional reason. An emit-on-error-only policy would halve
-memory churn.
-
-Caveat: callers may be using `input` for round-trip or replay tooling — would
-need a deprecation cycle.
-
-## 6. Pull the `updateStatus` helper into a shared mixin
-
-All four node files have a near-identical `updateStatus()` function. Extracting
-it to `lib/node-helpers.js` saves ~12 LOC × 4 files and provides one place to
-adjust the badge format. Marginal savings, but it also unlocks a single place
-to gate badge updates (e.g. throttle to 1 Hz for noisy streams).
-
-## 7. Validate the editor form on save, not on connect
-
-Currently the editor `validate:` callbacks only run for `host`/`mountpoint`/
-`port` (and were missing on `host`/`mountpoint` before 0.2.5). Stricter
-front-end validation (CR/LF rejection, mountpoint character class) avoids the
-"saved fine, fails at runtime" failure mode and surfaces errors in the editor
-ribbon.
-
-## 8. Replace `node.passthrough = config.passthrough || false` with a tagged
-   pass-through message
-
-When upload-mode pass-through is enabled, written bytes are re-emitted on the
-same output as caster replies, with no tag distinguishing them. A
-`msg._upload_echo = true` flag (or a second output port — breaking change) lets
-downstream nodes tell the streams apart without sniffing the payload.
-
-## 9. Extract common Mocha test helpers
-
-The three spec files share boilerplate (`helper.startServer` / `helper.unload`,
-flow factory, `helper.load(..., () => ... )` promise wrapping). A
-`test/helpers/load-node.js` that returns `{n1, ok, err, done}` would cut the
-spec files by ~30%.

package/doc/architecture/statistics.md

@@ -1,118 +0,0 @@
-# Statistics
-
-Snapshot taken at **v0.2.6** (commit `ecf02ba`).
-
-## Lines of code
-
-### Source
-
-| File | LOC |
-|------|----:|
-| [ntrip/99-ntrip.html](../../ntrip/99-ntrip.html) | 467 |
-| [ntrip/nodes/ntrip-client-node.js](../../ntrip/nodes/ntrip-client-node.js) | 182 |
-| [ntrip/nodes/nmea-encoder-node.js](../../ntrip/nodes/nmea-encoder-node.js) | 177 |
-| [ntrip/lib/ntrip-client.js](../../ntrip/lib/ntrip-client.js) | 114 |
-| [ntrip/nodes/nmea-decoder-node.js](../../ntrip/nodes/nmea-decoder-node.js) | 98 |
-| [ntrip/nodes/rtcm-decoder-node.js](../../ntrip/nodes/rtcm-decoder-node.js) | 91 |
-| [ntrip/99-ntrip.js](../../ntrip/99-ntrip.js) | 26 |
-| **Total** | **1155** |
-
-- JavaScript-only source: **688 LOC** across 6 files.
-- HTML editor UI: **467 LOC** in one file.
-
-### Tests
-
-| File | LOC | Tests |
-|------|----:|------:|
-| [test/nmea-decoder.spec.js](../../test/nmea-decoder.spec.js) | 134 | 6 |
-| [test/rtcm-decoder.spec.js](../../test/rtcm-decoder.spec.js) | 108 | 4 |
-| [test/nmea-encoder.spec.js](../../test/nmea-encoder.spec.js) | 96 | 4 |
-| **Total** | **338** | **14** |
-
-### Ratios
-
-| Metric | Value |
-|--------|------:|
-| Test LOC / JS source LOC | 49 % |
-| Tests per JS source file (4 of 6 covered by specs) | 3.5 avg |
-| Comments + blank lines (rough estimate) | ~20 % of source |
-
-## Test suite
-
-Run with `npm test`. Latest local run: **14 passing, 0 failing, ~500 ms**.
-
-Breakdown:
-
-- **NmeaDecoder** (6 specs) — golden GGA decode, multi-sentence split, Buffer
-  input, `payload.nmeaMessage` shape, Buffer preservation in error output, no
-  `node.error` flood (regression).
-- **NmeaEncoder** (4 specs) — `NmeaMessage` instance passthrough, unknown
-  `messageType` routed to error output, missing fields routed to error output,
-  empty payload handled.
-- **RtcmDecoder** (4 specs) — golden RTCM 1005 decode, two concatenated frames
-  fan out, frame split across two input events reassembled, no `node.error`
-  flood under garbage (regression).
-
-3 of the 14 specs are explicitly tagged `(regression: …)` and lock in
-previously-shipped bug fixes. Run them in isolation with
-`npx mocha test/**/*.spec.js -g regression`.
-
-NtripClient is *not* covered by the suite — it requires a fake TCP server.
-See [Future Improvements](future-improvements.md).
-
-## Coverage
-
-**Not measured.** No `c8` / `nyc` / Istanbul integration is configured. To
-enable, add `c8` as a dev dep and a `coverage` script (`c8 --reporter=text
---reporter=html mocha test/**/*.spec.js`). Statement coverage of the three
-spec'd nodes should be ≥ 85 % at the current spec count; the missing 15 % is
-mostly edge-case branches inside `RtcmTransport.decode` failures.
-
-## Repository history
-
-Snapshot from `git log`:
-
-| Metric | Value |
-|--------|------:|
-| Total commits on `main` | 28 |
-| Commits matching `/fix/i` | 8 |
-| Releases tagged in [CHANGELOG.md](../../CHANGELOG.md) | 9 (0.1.0 → 0.2.6) |
-| Bug-fix-only releases (0.2.4 / 0.2.5 / 0.2.6) | 3 (last 14 days) |
-
-## Dependencies
-
-| Class | Count | Names |
-|-------|------:|-------|
-| Runtime | 3 | `@gnss/nmea`, `@gnss/rtcm`, `ntrip-client` |
-| Dev | 4 | `mocha`, `chai`, `node-red`, `node-red-node-test-helper` |
-| Transitive (dev tree) | ~600 | from `npm audit` |
-
-After installing dev deps: `6 vulnerabilities (1 low, 2 moderate, 3 high)` —
-all inside the `node-red` dev tree, none reachable from the published package
-because the runtime dep set is just three packages.
-
-## Quality Index
-
-A composite, intentionally rough — a way to track movement over time, not an
-absolute scale. Each criterion is scored 0–10; the index is the unweighted
-mean.
-
-| Criterion | Score | Reasoning |
-|-----------|------:|-----------|
-| Test coverage (proxy: spec count vs node count) | 7 | 14 specs over 3 of 4 nodes. `NtripClient` untested. |
-| Bug-fix cadence (lower is better, scored inversely) | 5 | 3 patch releases in 2 weeks indicates churn from recent rewrite — settling now. |
-| Documentation completeness | 8 | Per-node help text, README usage notes, this architecture doc. |
-| Type safety | 2 | No TypeScript or JSDoc-with-`@ts-check`. |
-| Lint / style enforcement | 1 | No `eslint` or `prettier`. Style is consistent by convention only. |
-| Dependency hygiene | 7 | 3 runtime deps, 0 known runtime vulns. Dev tree carries `node-red` itself. |
-| CI rigour | 6 | Builds + tests on three Node versions. No coverage gate, no lint gate. |
-| Bus factor | 4 | Single primary maintainer (`Karl-Heinz Wind`). 1 active contributor. |
-| **Overall** | **5.0** | Median: 5.5. Headroom in lint, types, and `NtripClient` coverage. |
-
-### How to improve the index quickly
-
-- **+1.0 each** — adopting `eslint` (covers Type safety bump via `@ts-check`
-  on JSDoc) and adding coverage reporting.
-- **+0.5** — writing one round of `NtripClient` integration specs against a
-  fake caster.
-- **+0.5** — pinning dev deps in `package.json` more strictly (`~` instead of `^`).

package/doc/architecture/structural-design.md

@@ -1,141 +0,0 @@
-# Structural Design
-
-## Repository layout
-
-```
-node-red-contrib-ntrip/
-├── ntrip/
-│   ├── 99-ntrip.js          # Node-RED registration entry point
-│   ├── 99-ntrip.html        # Editor UI for all four nodes (forms + help text)
-│   ├── nodes/
-│   │   ├── ntrip-client-node.js
-│   │   ├── rtcm-decoder-node.js
-│   │   ├── nmea-decoder-node.js
-│   │   └── nmea-encoder-node.js
-│   └── lib/
-│       └── ntrip-client.js  # Local extension of the upstream ntrip-client package
-├── examples/                # Sample flows (ntripclient.json, sapos.json, upload.json, …)
-├── test/                    # Mocha specs (one per node, suffixed .spec.js)
-├── images/                  # Screenshots referenced by README.md
-├── doc/architecture/        # This documentation tree
-├── package.json
-├── package-lock.json
-├── CHANGELOG.md
-├── CLAUDE.md
-└── README.md
-```
-
-## Module dependency graph
-
-```
-   ┌────────────────────────┐
-   │   ntrip/99-ntrip.js    │  (Node-RED entry, registerType x 4)
-   └─────────┬──────────────┘
-             │ require
-   ┌─────────┴────────────────────────────────────────────────────────┐
-   ▼              ▼                  ▼                   ▼            │
- ntrip-client-  rtcm-decoder-      nmea-decoder-      nmea-encoder-   │
- node.js        node.js            node.js            node.js         │
-   │              │                  │                   │            │
-   │ require      │ require          │ require           │ require    │
-   ▼              ▼                  ▼                   ▼            │
- lib/ntrip-     @gnss/rtcm         @gnss/nmea          @gnss/nmea     │
- client.js                                                            │
-   │                                                                  │
-   │ require                                                          │
-   ▼                                                                  │
- ntrip-client  (npm package, upstream)                                │
-                                                                      │
-                                                                      ▼
-                                                       package.json reads
-                                                       version into log line
-```
-
-## File responsibilities
-
-### Entry layer
-
-| File | Responsibility |
-|------|----------------|
-| [ntrip/99-ntrip.js](../../ntrip/99-ntrip.js) | Imports each node implementation. Registers the four types with `RED.nodes.registerType`. Declares the `credentials` block for `NtripClient`. Reads the package version from `package.json` and logs it. |
-| [ntrip/99-ntrip.html](../../ntrip/99-ntrip.html) | Per-node `registerType` call (client side), the configuration `<template>`, and the help text shown in Node-RED's info sidebar. The credentials block is duplicated here — Node-RED requires both. |
-
-### Node implementations
-
-| File | Type | Inputs | Outputs |
-|------|------|--------|---------|
-| [ntrip/nodes/ntrip-client-node.js](../../ntrip/nodes/ntrip-client-node.js) | `NtripClient` | 1 | 1 (data from caster + optional pass-through of writes) |
-| [ntrip/nodes/rtcm-decoder-node.js](../../ntrip/nodes/rtcm-decoder-node.js) | `RtcmDecoder` | 1 | 2 (decoded, error) |
-| [ntrip/nodes/nmea-decoder-node.js](../../ntrip/nodes/nmea-decoder-node.js) | `NmeaDecoder` | 1 | 2 (decoded, error) |
-| [ntrip/nodes/nmea-encoder-node.js](../../ntrip/nodes/nmea-encoder-node.js) | `NmeaEncoder` | 1 | 2 (encoded, error) |
-
-All four follow the same skeleton:
-
-```javascript
-module.exports = function (RED) {
-    function Node(config) {
-        RED.nodes.createNode(this, config);
-        const node = this;
-        node.<counter>Received = 0;
-        node.invalidMessagesReceived = 0;
-
-        // ... wire up the on('input') handler, possibly an external resource
-
-        this.on('close', function (done) {
-            // cleanup
-            node.status({});
-            done();
-        });
-    }
-    return Node;
-};
-```
-
-### Library layer
-
-[ntrip/lib/ntrip-client.js](../../ntrip/lib/ntrip-client.js) — a thin local
-adapter around the upstream `ntrip-client` npm package. Exposes two factories:
-
-- `createDownloader(options)` — returns the upstream `NtripClient` unchanged.
-- `createUploader(options)` — returns a subclass `NtripClientUploader` that
-  overrides `_connect()` to switch the handshake string by `authmode`
-  (`legacy`, `hybrid`, `ntripv1`, `ntripv2`). The constructor also rejects
-  CR/LF in `mountpoint`/`username`/`password` to prevent header injection.
-
-The override pattern is a full replacement of the parent's `_connect`, not a
-delegation — see [ADR-0002](adr/0002-ntrip-uploader-extension.md) for the
-rationale and trade-offs.
-
-## Class / type hierarchy
-
-```
-ntrip-client (npm)
-  └── NtripClient            # download
-        └── NtripClientUploader (lib/ntrip-client.js)   # upload
-```
-
-No other classes are defined in this package; every Node-RED node is a plain
-function passed to `registerType`, and decoder/encoder state lives on the node
-instance via simple property assignment (`node.pendingBuffer`, `node.messagesReceived`).
-
-## Coupling
-
-- **High cohesion within each node file.** A node's input handler, status
-  updates, and close handler are co-located. There is no shared mutable state
-  across node instances.
-- **No cross-node imports.** The decoders do not know about `NtripClient` and
-  vice versa; they communicate only through Node-RED wires at flow runtime.
-- **Two seams to the outside world:**
-  - The `ntrip-client` upstream package (via [lib/ntrip-client.js](../../ntrip/lib/ntrip-client.js)).
-  - `@gnss/rtcm` and `@gnss/nmea` for codec work.
-- **Implicit coupling between [99-ntrip.js](../../ntrip/99-ntrip.js) and [99-ntrip.html](../../ntrip/99-ntrip.html)** — both must declare the `credentials` block, and the registered node-type names must match exactly. The HTML form field IDs (`node-input-host`, `node-input-port`, …) must align with the property names read in the JS (`config.host`, `config.port`, …).
-
-## Distribution shape
-
-- `node-red.nodes` in [package.json](../../package.json) points only at
-  `ntrip/99-ntrip.js` — Node-RED loads that file, which transitively pulls in
-  everything else.
-- Runtime dependencies: `@gnss/nmea`, `@gnss/rtcm`, `ntrip-client`. No transient
-  runtime dependency on Node-RED itself.
-- Dev-only dependencies: `mocha`, `chai` (CJS v4), `node-red`,
-  `node-red-node-test-helper`.

package/eslint.config.js

@@ -1,36 +0,0 @@
-'use strict';
-
-const js = require('@eslint/js');
-const globals = require('globals');
-const prettierConfig = require('eslint-config-prettier');
-
-module.exports = [
-    {
-        ignores: ['node_modules/**', 'examples/**', 'doc/**', 'ntrip/99-ntrip.html'],
-    },
-    js.configs.recommended,
-    prettierConfig,
-    {
-        languageOptions: {
-            ecmaVersion: 2022,
-            sourceType: 'commonjs',
-            globals: {
-                ...globals.node,
-            },
-        },
-        rules: {
-            'no-unused-vars': ['warn', { argsIgnorePattern: '^_', varsIgnorePattern: '^_' }],
-            'no-console': 'off',
-            'no-prototype-builtins': 'off',
-        },
-    },
-    {
-        files: ['test/**/*.js'],
-        languageOptions: {
-            globals: {
-                ...globals.node,
-                ...globals.mocha,
-            },
-        },
-    },
-];

package/test/nmea-decoder.spec.js

@@ -1,146 +0,0 @@
-'use strict';
-
-const helper = require('node-red-node-test-helper');
-const { expect } = require('chai');
-const ntripModule = require('../ntrip/99-ntrip.js');
-
-helper.init(require.resolve('node-red'));
-
-const GGA = '$GPGGA,123519,4807.038,N,01131.000,E,1,08,0.9,545.4,M,46.9,M,,*47';
-const GLL = '$GPGLL,4916.45,N,12311.12,W,225444,A,*1D';
-
-function flow() {
-    return [
-        { id: 'n1', type: 'NmeaDecoder', wires: [['ok'], ['err']] },
-        { id: 'ok', type: 'helper' },
-        { id: 'err', type: 'helper' },
-    ];
-}
-
-describe('NmeaDecoder', function () {
-    before(() => helper.startServer());
-    after(() => helper.stopServer());
-    afterEach(() => helper.unload());
-
-    it('decodes a valid GGA sentence on the success output', function () {
-        return new Promise((resolve, reject) => {
-            helper.load(ntripModule, flow(), () => {
-                const n1 = helper.getNode('n1');
-                const ok = helper.getNode('ok');
-                ok.on('input', (msg) => {
-                    try {
-                        expect(msg.payload.messageType).to.equal('GGA');
-                        expect(msg.payload.nmeaMessage).to.have.property('latitude');
-                        expect(msg.payload.input).to.equal(GGA);
-                        resolve();
-                    } catch (e) {
-                        reject(e);
-                    }
-                });
-                n1.receive({ payload: GGA });
-            });
-        });
-    });
-
-    it('splits a multi-sentence chunk into separate output messages', function () {
-        return new Promise((resolve, reject) => {
-            helper.load(ntripModule, flow(), () => {
-                const n1 = helper.getNode('n1');
-                const ok = helper.getNode('ok');
-                const types = [];
-                ok.on('input', (msg) => {
-                    types.push(msg.payload.messageType);
-                    if (types.length === 2) {
-                        try {
-                            expect(types).to.deep.equal(['GGA', 'GLL']);
-                            resolve();
-                        } catch (e) {
-                            reject(e);
-                        }
-                    }
-                });
-                n1.receive({ payload: GGA + '\r\n' + GLL + '\r\n' });
-            });
-        });
-    });
-
-    it('accepts a Buffer payload and decodes it as UTF-8', function () {
-        return new Promise((resolve, reject) => {
-            helper.load(ntripModule, flow(), () => {
-                const n1 = helper.getNode('n1');
-                const ok = helper.getNode('ok');
-                ok.on('input', (msg) => {
-                    try {
-                        expect(msg.payload.messageType).to.equal('GGA');
-                        resolve();
-                    } catch (e) {
-                        reject(e);
-                    }
-                });
-                n1.receive({ payload: Buffer.from(GGA, 'utf8') });
-            });
-        });
-    });
-
-    it('reads payload.nmeaMessage when payload is an object', function () {
-        return new Promise((resolve, reject) => {
-            helper.load(ntripModule, flow(), () => {
-                const n1 = helper.getNode('n1');
-                const ok = helper.getNode('ok');
-                ok.on('input', (msg) => {
-                    try {
-                        expect(msg.payload.messageType).to.equal('GGA');
-                        resolve();
-                    } catch (e) {
-                        reject(e);
-                    }
-                });
-                n1.receive({ payload: { nmeaMessage: GGA } });
-            });
-        });
-    });
-
-    it('error output preserves Buffer input as `input`, utf8 as `inputString`', function () {
-        return new Promise((resolve, reject) => {
-            helper.load(ntripModule, flow(), () => {
-                const n1 = helper.getNode('n1');
-                const err = helper.getNode('err');
-                const garbage = Buffer.from([0xd3, 0x00, 0x13, 0x3e, 0xd0, 0x00]);
-                err.on('input', (msg) => {
-                    try {
-                        expect(Buffer.isBuffer(msg.payload.input)).to.equal(true);
-                        expect(msg.payload.input).to.deep.equal(garbage);
-                        expect(msg.payload.inputString).to.be.a('string');
-                        resolve();
-                    } catch (e) {
-                        reject(e);
-                    }
-                });
-                n1.receive({ payload: garbage });
-            });
-        });
-    });
-
-    it('does not call node.error on decode failure (regression: log flood)', function () {
-        return new Promise((resolve, reject) => {
-            helper.load(ntripModule, flow(), () => {
-                const n1 = helper.getNode('n1');
-                let errorCalled = false;
-                const originalError = n1.error.bind(n1);
-                n1.error = function (...args) {
-                    errorCalled = true;
-                    return originalError(...args);
-                };
-                n1.receive({ payload: Buffer.from([0xd3, 0x00, 0x13, 0x3e]) });
-                setTimeout(() => {
-                    try {
-                        expect(errorCalled).to.equal(false);
-                        resolve();
-                    } catch (e) {
-                        reject(e);
-                    }
-                }, 50);
-            });
-        });
-    });
-});