node-red-contrib-modbus-modpackqt 1.1.4 → 1.1.5

package/nodes/modpackqt-master-read.js

@@ -10,7 +10,7 @@ module.exports = function(RED) {
     node.functionCode = parseInt(config.functionCode) || 3;
     node.address      = parseInt(config.address)      || 0;
     node.quantity     = parseInt(config.quantity)     || 1;
-    node.pollInterval = parseInt(config.pollInterval) || 0;
+    node.pollInterval = config.pollInterval ? parseInt(config.pollInterval, 10) : 0;
 
     const FC_TO_REGISTER_TYPE = { 1: 'coil', 2: 'discrete', 3: 'holding', 4: 'input' };
 
@@ -31,7 +31,9 @@ module.exports = function(RED) {
           address:      node.address,
           quantity:     node.quantity
         });
-        node.status({ fill: 'green', shape: 'dot', text: `FC${node.functionCode} @${node.address}` });
+        const ts = new Date().toLocaleTimeString();
+        const pollLabel = node.pollInterval > 0 ? ` (poll ${node.pollInterval}ms)` : '';
+        node.status({ fill: 'green', shape: 'dot', text: `FC${node.functionCode} @${node.address} · ${ts}${pollLabel}` });
         node.send({ payload: result, topic: `modbus/read/${node.targetHost}:${node.targetPort}` });
       } catch (err) {
         node.status({ fill: 'red', shape: 'dot', text: err.message });
@@ -40,11 +42,12 @@ module.exports = function(RED) {
     }
 
     if (node.pollInterval > 0) {
+      node.status({ fill: 'yellow', shape: 'ring', text: `polling every ${node.pollInterval}ms…` });
       timer = setInterval(doRead, node.pollInterval);
     }
 
     node.on('input', async function() { await doRead(); });
-    node.on('close', function() { if (timer) clearInterval(timer); });
+    node.on('close', function() { if (timer) { clearInterval(timer); timer = null; } });
   }
   RED.nodes.registerType('modpackqt-master-read', ModPackQTMasterReadNode);
 };

package/nodes/modpackqt-master-write.js

@@ -18,8 +18,25 @@ module.exports = function(RED) {
         return;
       }
       try {
-        const values = Array.isArray(msg.payload) ? msg.payload : [msg.payload];
+        // Accept string JSON (e.g. "[100,200,300]" from inject string type),
+        // plain number, or actual array/number from inject JSON type.
+        let raw = msg.payload;
+        if (typeof raw === 'string') {
+          try { raw = JSON.parse(raw); } catch (_) { raw = Number(raw); }
+        }
+
+        // Always convert every value to an integer to avoid byte-encoding corruption.
+        const values = Array.isArray(raw)
+          ? raw.map(v => parseInt(v, 10))
+          : [parseInt(raw, 10)];
+
+        if (values.some(v => isNaN(v))) {
+          throw new Error(`Invalid payload — expected number or array of numbers, got: ${msg.payload}`);
+        }
+
         const registerType = FC_TO_REGISTER_TYPE[node.functionCode] || 'holding';
+        node.status({ fill: 'blue', shape: 'ring', text: `writing ${values.length} value(s)…` });
+
         await server.request('POST', '/api/modbus/tcp/write', {
           host:         node.targetHost,
           port:         node.targetPort,
@@ -28,8 +45,10 @@ module.exports = function(RED) {
           address:      node.address,
           values
         });
-        node.status({ fill: 'green', shape: 'dot', text: `FC${node.functionCode} @${node.address}` });
+
+        node.status({ fill: 'green', shape: 'dot', text: `wrote ${values.length} @ addr ${node.address}` });
         msg.success = true;
+        msg.valuesWritten = values;
         node.send(msg);
       } catch (err) {
         node.status({ fill: 'red', shape: 'dot', text: err.message });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-modbus-modpackqt",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "description": "Node-RED nodes for ModPackQT — read/write Modbus TCP registers (master & slave) via the ModPackQT Gateway app. Supports FC1/FC2/FC3/FC4 reads and FC5/FC6/FC15/FC16 writes.",
   "keywords": [
     "node-red",