node-red-contrib-lorawan-bacnet-server 1.4.0 → 1.5.0

package/nodes/lora-bacnet-bridge/lora-bacnet-bridge.html

@@ -7,10 +7,12 @@
             server: { value: '', type: 'bacnet-server', required: true },
             instanceOffset: { value: '1000' },
             autoDiscover: { value: true },
-            outputOnWrite: { value: true }
+            outputOnWrite: { value: true },
+            writablePatterns: { value: 'setpoint,command,relay,valve,output,target,mode,enable,disable,on,off,speed,level,position' }
         },
         inputs: 1,
-        outputs: 1,
+        outputs: 2,
+        outputLabels: ['uplink data', 'downlink commands'],
         icon: 'font-awesome/fa-exchange',
         label: function () {
             return this.name || 'lora-bacnet-bridge';
@@ -80,6 +82,12 @@
         <span>Emit message when BACnet client writes a value</span>
     </div>
 
+    <div class="form-row">
+        <label for="node-input-writablePatterns"><i class="fa fa-edit"></i> Writable Patterns</label>
+        <input type="text" id="node-input-writablePatterns" placeholder="setpoint,command,relay,valve,...">
+        <div class="form-tips">Comma-separated keywords. Points matching these patterns will be writable (for downlinks)</div>
+    </div>
+
     <div class="form-row">
         <label><i class="fa fa-list"></i> Discovered Devices</label>
         <button type="button" id="node-input-refresh-devices" class="red-ui-button">
@@ -131,15 +139,31 @@
     </dl>
 
     <h3>Outputs</h3>
+    <p><strong>Output 1 (Uplink Data):</strong></p>
     <dl class="message-properties">
         <dt>payload <span class="property-type">any</span></dt>
         <dd>Original payload passed through</dd>
 
         <dt>bacnetPoints <span class="property-type">array</span></dt>
         <dd>List of BACnet points created/updated</dd>
+    </dl>
 
+    <p><strong>Output 2 (Downlink Commands):</strong></p>
+    <dl class="message-properties">
         <dt>topic <span class="property-type">string</span></dt>
-        <dd>For write events: bacnet/write/{deviceId}/{sensorKey}</dd>
+        <dd>lora/downlink/{deviceId}/{sensorKey}</dd>
+
+        <dt>payload <span class="property-type">any</span></dt>
+        <dd>Value written by BACnet client</dd>
+
+        <dt>deviceId <span class="property-type">string</span></dt>
+        <dd>Target LoRa device identifier</dd>
+
+        <dt>sensorKey <span class="property-type">string</span></dt>
+        <dd>Target sensor/actuator key</dd>
+
+        <dt>downlink <span class="property-type">object</span></dt>
+        <dd>Pre-formatted downlink data for Milesight/ChirpStack</dd>
     </dl>
 
     <h3>Details</h3>
@@ -168,12 +192,37 @@
     </ul>
     <p>Use this to trigger LoRa downlinks for actuators.</p>
 
-    <h3>Example Flow</h3>
+    <h3>Writable Points (Downlinks)</h3>
+    <p>Points with names matching the "Writable Patterns" are automatically created as writable BACnet points. When a BACnet client writes to these points, a downlink message is emitted on Output 2.</p>
+    <p>Default writable patterns: setpoint, command, relay, valve, output, target, mode, enable, speed, level, position</p>
+
+    <h3>Example Flow - Bidirectional</h3>
     <pre>
-    [MQTT LoRa] → [LoRaBAC] → [LoRa-BACnet Bridge]
-                                     ↓
-                              [BACnet Server]
-                                     ↓
-                              External BACnet clients
+    ┌─────────────────────────────────────────────────────────┐
+    │                      UPLINK (sensors)                    │
+    │  [MQTT/LoRa] → [LoRa-BACnet Bridge] → [BACnet Server]   │
+    │                        │                                 │
+    │                   Output 1                               │
+    └─────────────────────────────────────────────────────────┘
+
+    ┌─────────────────────────────────────────────────────────┐
+    │                    DOWNLINK (actuators)                  │
+    │  [BACnet Client writes] → [LoRa-BACnet Bridge]          │
+    │                                  │                       │
+    │                             Output 2                     │
+    │                                  ↓                       │
+    │                         [MQTT Publish] → LoRa Device    │
+    └─────────────────────────────────────────────────────────┘
+    </pre>
+
+    <h3>Use Case: HVAC Control</h3>
+    <pre>
+    Sensors (uplink):
+      - temperature → AV (read-only)
+      - humidity    → AV (read-only)
+
+    Actuators (downlink):
+      - valve_setpoint → AV (writable) → LoRa downlink
+      - relay_command  → BV (writable) → LoRa downlink
     </pre>
 </script>

package/nodes/lora-bacnet-bridge/lora-bacnet-bridge.js

@@ -43,6 +43,9 @@ module.exports = function (RED) {
         node.autoDiscover = config.autoDiscover !== false;
         node.outputOnWrite = config.outputOnWrite !== false;
 
+        // Patterns for writable (downlink) points
+        node.writablePatterns = (config.writablePatterns || 'setpoint,command,relay,valve,output,target,mode,enable,disable,on,off,speed,level,position').toLowerCase().split(',').map(p => p.trim());
+
         // Registry of discovered LoRa devices and their BACnet points
         // Key: deviceEUI or deviceName, Value: { points: Map, lastSeen: Date }
         node.loraDevices = new Map();
@@ -81,6 +84,12 @@ module.exports = function (RED) {
             return ObjectType.ANALOG_VALUE;
         }
 
+        // Determine if point should be writable (for downlink/actuators)
+        function isWritablePoint(key) {
+            const keyLower = key.toLowerCase();
+            return node.writablePatterns.some(pattern => keyLower.includes(pattern));
+        }
+
         // Determine units from key name
         function determineUnits(key) {
             const keyLower = key.toLowerCase();
@@ -119,6 +128,8 @@ module.exports = function (RED) {
 
                 const objectName = `${deviceId}_${sensorKey}`.replace(/[^a-zA-Z0-9_-]/g, '_');
 
+                const writable = isWritablePoint(sensorKey);
+
                 pointData = {
                     objectType: objectType,
                     instanceNumber: instanceNumber,
@@ -126,7 +137,7 @@ module.exports = function (RED) {
                     sensorKey: sensorKey,
                     deviceId: deviceId,
                     units: determineUnits(sensorKey),
-                    writable: false,  // LoRa uplink values are read-only
+                    writable: writable,
                     value: value
                 };
 
@@ -147,19 +158,31 @@ module.exports = function (RED) {
                     outputOnWrite: node.outputOnWrite,
                     emitReadEvent: () => { },
                     emitWriteEvent: (val, priority, sender) => {
-                        // Output write event
-                        node.send({
-                            topic: `bacnet/write/${deviceId}/${sensorKey}`,
+                        // Output write event on second output (for downlink)
+                        const downlinkMsg = {
+                            topic: `lora/downlink/${deviceId}/${sensorKey}`,
                             payload: val,
+                            deviceId: deviceId,
+                            sensorKey: sensorKey,
                             bacnet: {
-                                deviceId: deviceId,
-                                sensorKey: sensorKey,
                                 objectType: objectType,
                                 instanceNumber: instanceNumber,
+                                objectName: objectName,
                                 priority: priority,
                                 sender: sender
+                            },
+                            // For Milesight/ChirpStack compatibility
+                            downlink: {
+                                devEUI: deviceInfo?.devEUI || deviceId,
+                                deviceName: deviceId,
+                                confirmed: false,
+                                fPort: 85,
+                                data: val
                             }
-                        });
+                        };
+                        // Send to second output [null, msg]
+                        node.send([null, downlinkMsg]);
+                        node.debug(`BACnet write -> LoRa downlink: ${deviceId}/${sensorKey} = ${val}`);
                     }
                 });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-lorawan-bacnet-server",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "Custom Node-RED nodes to interface LoRaWAN devices with BACnet protocol. ",
   "keywords": [
     "LoRaWAN",