node-red-contrib-lorawan-bacnet-server 1.2.1 → 1.2.3

package/nodes/bacnet-server/bacnet-server.js

@@ -160,29 +160,30 @@ module.exports = function (RED) {
             if ((lowLimit === undefined || node.deviceId >= lowLimit) &&
                 (highLimit === undefined || node.deviceId <= highLimit)) {
 
-                // Respond with I-Am
+                // Respond with I-Am (null = broadcast)
                 node.client.iAmResponse(
+                    null,
                     node.deviceId,
                     bacnet.enum.Segmentation.NO_SEGMENTATION,
                     node.vendorId
                 );
 
-                node.debug(`Responded to Who-Is from ${data.address}`);
+                node.debug(`Responded to Who-Is from ${data.header?.sender?.address || 'broadcast'}`);
             }
         };
 
         // Handle Read Property requests
         node.handleReadProperty = function (data) {
-            const objectId = data.request.objectId;
-            const propertyId = data.request.property.id;
-            const arrayIndex = data.request.property.index;
+            const objectId = data.payload.objectId;
+            const propertyId = data.payload.property.id;
+            const arrayIndex = data.payload.property.index;
 
             try {
                 const value = node.getPropertyValue(objectId, propertyId, arrayIndex);
 
                 if (value !== null && value !== undefined) {
                     node.client.readPropertyResponse(
-                        data.address,
+                        data.header.sender,
                         data.invokeId,
                         objectId,
                         { id: propertyId, index: arrayIndex },
@@ -196,7 +197,7 @@ module.exports = function (RED) {
                     }
                 } else {
                     node.client.errorResponse(
-                        data.address,
+                        data.header.sender,
                         bacnet.enum.ConfirmedService.READ_PROPERTY,
                         data.invokeId,
                         bacnet.enum.ErrorClass.PROPERTY,
@@ -206,7 +207,7 @@ module.exports = function (RED) {
             } catch (err) {
                 node.error(`Read Property error: ${err.message}`);
                 node.client.errorResponse(
-                    data.address,
+                    data.header.sender,
                     bacnet.enum.ConfirmedService.READ_PROPERTY,
                     data.invokeId,
                     bacnet.enum.ErrorClass.OBJECT,
@@ -217,17 +218,17 @@ module.exports = function (RED) {
 
         // Handle Write Property requests
         node.handleWriteProperty = function (data) {
-            const objectId = data.request.objectId;
-            const propertyId = data.request.property.id;
-            const priority = data.request.priority || 16;
-            const value = data.request.value;
+            const objectId = data.payload.objectId;
+            const propertyId = data.payload.property.id;
+            const priority = data.payload.priority || 16;
+            const value = data.payload.value;
 
             try {
                 const result = node.setPropertyValue(objectId, propertyId, value, priority);
 
                 if (result.success) {
                     node.client.simpleAckResponse(
-                        data.address,
+                        data.header.sender,
                         bacnet.enum.ConfirmedService.WRITE_PROPERTY,
                         data.invokeId
                     );
@@ -235,14 +236,14 @@ module.exports = function (RED) {
                     // Notify point node
                     const pointNode = node.getPointNode(objectId);
                     if (pointNode) {
-                        pointNode.emitWriteEvent(result.value, priority, data.address);
+                        pointNode.emitWriteEvent(result.value, priority, data.header.sender.address);
                     }
 
                     // Check COV notifications
                     node.checkCovNotifications(objectId);
                 } else {
                     node.client.errorResponse(
-                        data.address,
+                        data.header.sender,
                         bacnet.enum.ConfirmedService.WRITE_PROPERTY,
                         data.invokeId,
                         bacnet.enum.ErrorClass.PROPERTY,
@@ -252,7 +253,7 @@ module.exports = function (RED) {
             } catch (err) {
                 node.error(`Write Property error: ${err.message}`);
                 node.client.errorResponse(
-                    data.address,
+                    data.header.sender,
                     bacnet.enum.ConfirmedService.WRITE_PROPERTY,
                     data.invokeId,
                     bacnet.enum.ErrorClass.OBJECT,
@@ -263,7 +264,7 @@ module.exports = function (RED) {
 
         // Handle Read Property Multiple requests
         node.handleReadPropertyMultiple = function (data) {
-            const properties = data.request.properties;
+            const properties = data.payload.properties;
             const results = [];
 
             for (const prop of properties) {
@@ -309,7 +310,7 @@ module.exports = function (RED) {
             }
 
             node.client.readPropertyMultipleResponse(
-                data.address,
+                data.header.sender,
                 data.invokeId,
                 results
             );
@@ -317,17 +318,17 @@ module.exports = function (RED) {
 
         // Handle Subscribe COV requests
         node.handleSubscribeCov = function (data) {
-            const subscriberProcessId = data.request.subscriberProcessId;
-            const objectId = data.request.monitoredObjectId;
-            const issueConfirmedNotifications = data.request.issueConfirmedNotifications;
-            const lifetime = data.request.lifetime || 0;
+            const subscriberProcessId = data.payload.subscriberProcessId;
+            const objectId = data.payload.monitoredObjectId;
+            const issueConfirmedNotifications = data.payload.issueConfirmedNotifications;
+            const lifetime = data.payload.lifetime || 0;
 
             const objectKey = `${objectId.type}:${objectId.instance}`;
             const obj = node.objects.get(objectKey);
 
             if (!obj) {
                 node.client.errorResponse(
-                    data.address,
+                    data.header.sender,
                     bacnet.enum.ConfirmedService.SUBSCRIBE_COV,
                     data.invokeId,
                     bacnet.enum.ErrorClass.OBJECT,
@@ -336,16 +337,17 @@ module.exports = function (RED) {
                 return;
             }
 
-            const subscriptionKey = `${data.address}:${subscriberProcessId}:${objectKey}`;
+            const senderAddress = data.header?.sender?.address || 'unknown';
+            const subscriptionKey = `${senderAddress}:${subscriberProcessId}:${objectKey}`;
 
-            if (lifetime === 0 && data.request.cancellationRequest) {
+            if (lifetime === 0 && data.payload.cancellationRequest) {
                 // Cancel subscription
                 node.covSubscriptions.delete(subscriptionKey);
                 node.debug(`COV subscription cancelled: ${subscriptionKey}`);
             } else {
                 // Create/update subscription
                 node.covSubscriptions.set(subscriptionKey, {
-                    address: data.address,
+                    address: data.header.sender,
                     processId: subscriberProcessId,
                     objectId: objectId,
                     confirmed: issueConfirmedNotifications,
@@ -357,7 +359,7 @@ module.exports = function (RED) {
             }
 
             node.client.simpleAckResponse(
-                data.address,
+                data.header.sender,
                 bacnet.enum.ConfirmedService.SUBSCRIBE_COV,
                 data.invokeId
             );

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-lorawan-bacnet-server",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "Custom Node-RED nodes to interface LoRaWAN devices with BACnet protocol. ",
   "keywords": [
     "LoRaWAN",

package/tools/bacnet-scan.js

@@ -0,0 +1,134 @@
+#!/usr/bin/env node
+/**
+ * BACnet Scanner CLI Tool
+ * Scans the network for BACnet devices using Who-Is broadcast
+ */
+
+const bacnet = require('node-bacnet');
+const dgram = require('dgram');
+
+const args = process.argv.slice(2);
+const timeout = parseInt(args.find(a => a.startsWith('--timeout='))?.split('=')[1]) || 5000;
+const target = args.find(a => a.startsWith('--target='))?.split('=')[1] || null;
+
+if (args.includes('--help') || args.includes('-h')) {
+    console.log(`
+BACnet Scanner - Discover BACnet devices on the network
+
+Usage: node bacnet-scan.js [options]
+
+Options:
+  --timeout=MS      Scan timeout in milliseconds (default: 5000)
+  --target=IP       Target specific IP address
+  --help, -h        Show this help
+
+Examples:
+  node bacnet-scan.js
+  node bacnet-scan.js --timeout=10000
+  node bacnet-scan.js --target=192.168.1.100
+`);
+    process.exit(0);
+}
+
+console.log('========================================');
+console.log('       BACnet Network Scanner');
+console.log('========================================');
+console.log(`Timeout: ${timeout}ms`);
+if (target) console.log(`Target: ${target}`);
+console.log('----------------------------------------');
+console.log('Scanning for BACnet devices...\n');
+
+const devices = new Map();
+
+// Parse I-Am from raw packet
+function parseIAm(buffer, rinfo) {
+    try {
+        // Check for valid BACnet/IP header (0x81)
+        if (buffer[0] !== 0x81) return null;
+
+        // Skip BVLC header (4 bytes) and NPDU
+        let offset = 4;
+
+        // Find NPDU length - skip to APDU
+        const npduLength = buffer[1] === 0x0b ? 0 : buffer[offset + 1];
+        offset += 2 + npduLength;
+
+        // Check for Unconfirmed Request (0x10) and I-Am service (0x00)
+        if (offset >= buffer.length) return null;
+
+        const apduType = buffer[offset] >> 4;
+        if (apduType !== 1) return null; // Not unconfirmed
+
+        const serviceChoice = buffer[offset + 1];
+        if (serviceChoice !== 0) return null; // Not I-Am
+
+        offset += 2;
+
+        // Parse Object Identifier (Device ID)
+        if (buffer[offset] !== 0xc4) return null; // Not object-id tag
+        offset++;
+
+        const objectIdRaw = buffer.readUInt32BE(offset);
+        const objectType = (objectIdRaw >> 22) & 0x3FF;
+        const instanceNumber = objectIdRaw & 0x3FFFFF;
+
+        if (objectType !== 8) return null; // Not a device object
+
+        return {
+            deviceId: instanceNumber,
+            address: rinfo.address
+        };
+    } catch (e) {
+        return null;
+    }
+}
+
+// Create raw UDP listener with reuseAddr
+const listener = dgram.createSocket({ type: 'udp4', reuseAddr: true });
+
+listener.on('message', (msg, rinfo) => {
+    const device = parseIAm(msg, rinfo);
+    if (device && !devices.has(device.deviceId)) {
+        devices.set(device.deviceId, device);
+        console.log(`[FOUND] Device ID: ${device.deviceId}`);
+        console.log(`        Address: ${device.address}\n`);
+    }
+});
+
+listener.on('error', (err) => {
+    console.error(`[ERROR] ${err.message}`);
+});
+
+listener.bind(47808, () => {
+    listener.setBroadcast(true);
+
+    // Use separate client to send Who-Is
+    const client = new bacnet({ port: 47810 + Math.floor(Math.random() * 100) });
+
+    client.on('error', () => {}); // Ignore client errors
+
+    // Send Who-Is request
+    if (target) {
+        client.whoIs({ address: target });
+    } else {
+        client.whoIs();
+    }
+
+    // Wait for responses
+    setTimeout(() => {
+        console.log('----------------------------------------');
+        console.log(`Scan complete. Found ${devices.size} device(s).`);
+
+        if (devices.size > 0) {
+            console.log('\nSummary:');
+            let i = 1;
+            for (const [id, d] of devices) {
+                console.log(`  ${i++}. Device ${id} at ${d.address}`);
+            }
+        }
+
+        listener.close();
+        client.close();
+        process.exit(0);
+    }, timeout);
+});

package/tools/bacnet-server-test.js

@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+/**
+ * BACnet Server Test - Simple standalone server
+ */
+
+const bacnet = require('node-bacnet');
+
+const deviceId = 123456;
+const port = 47808;
+
+console.log('========================================');
+console.log('     BACnet Server Test');
+console.log('========================================');
+console.log(`Device ID: ${deviceId}`);
+console.log(`Port: ${port}`);
+console.log('----------------------------------------');
+
+const client = new bacnet({ port: port });
+
+// Respond to Who-Is
+client.on('whoIs', (data) => {
+    console.log(`[WHO-IS] Received from ${data.address}`);
+
+    client.iAmResponse(
+        deviceId,
+        bacnet.enum.Segmentation.NO_SEGMENTATION,
+        999  // vendor ID
+    );
+
+    console.log(`[I-AM] Responded with Device ID ${deviceId}`);
+});
+
+client.on('error', (err) => {
+    console.error(`[ERROR] ${err.message}`);
+});
+
+console.log('\nServer running. Press Ctrl+C to stop.\n');
+console.log('Test with: node bacnet-scan.js --target=<YOUR_IP>');

package/tools/test-server-unicast.js

@@ -0,0 +1,22 @@
+const bacnet = require('node-bacnet');
+const dgram = require('dgram');
+
+const client = new bacnet({ port: 47808 });
+
+console.log('BACnet server on port 47808 (with unicast reply)...\n');
+
+client.on('whoIs', (data) => {
+    console.log('[WHO-IS] from', data.header?.sender?.address);
+    
+    // Send broadcast I-Am
+    client.iAmResponse(123456, bacnet.enum.Segmentation.NO_SEGMENTATION, 999);
+    console.log('[I-AM] Broadcast sent');
+    
+    // Also try unicast to sender
+    if (data.header?.sender?.address) {
+        const sender = data.header.sender.address;
+        console.log('[I-AM] Sending unicast to', sender);
+    }
+});
+
+client.on('error', (err) => console.error('[ERROR]', err.message));

package/tools/test-server.js

@@ -0,0 +1,21 @@
+const bacnet = require('node-bacnet');
+
+const client = new bacnet({ port: 47808 });
+
+console.log('BACnet test server on port 47808...');
+
+client.on('whoIs', (data) => {
+    console.log('[WHO-IS RECEIVED]', data);
+    client.iAmResponse(123456, bacnet.enum.Segmentation.NO_SEGMENTATION, 999);
+    console.log('[I-AM SENT]');
+});
+
+client.on('error', (err) => console.error('[ERROR]', err.message));
+
+// Broadcast I-Am now
+setTimeout(() => {
+    client.iAmResponse(123456, bacnet.enum.Segmentation.NO_SEGMENTATION, 999);
+    console.log('[BROADCAST I-AM]');
+}, 1000);
+
+console.log('Waiting for Who-Is requests...\n');