node-red-contrib-knx-ultimate 3.2.1 → 3.2.3

package/CHANGELOG.md

@@ -6,6 +6,11 @@
 
 # CHANGELOG
 
+**Version 3.2.3** - September 2024<br/>
+- KNX engine: fix oldest invalid KNX queue interval, by defaulting it to 25ms.<br/>
+
+**Version 3.2.2** - September 2024<br/>
+- KNX engine: Bump to 3.0.2: fixed an issue with the KNX queue.<br/>
 
 **Version 3.2.1-beta.0** - September 2024<br/>
 - Rewrote the logger engine and fixed some issues in the KNXUltimate package.<br/>

package/nodes/knxUltimate-config.html

@@ -5,7 +5,7 @@
         category: 'config',
         defaults: {
             host: { value: "224.0.23.12", required: true },
-            port: { value: 3671, required: true, validate: RED.validators.number() },
+            port: { value: 3671, required: true, validate: RED.validators.number(), min: 20, max: 500 },
             // the KNX physical address we'd like to use
             physAddr: { value: "15.15.22", required: true },
             hostProtocol: { value: "Auto", required: false }, // TunnelUDP/TunnelTCP/Multicast
@@ -18,7 +18,7 @@
             loglevel: { value: "error" },
             name: { value: "KNX Gateway" },
             localEchoInTunneling: { value: true },
-            delaybetweentelegrams: { value: 25, required: false },
+            delaybetweentelegrams: { value: 25, required: false, validate: RED.validators.number() },
             ignoreTelegramsWithRepeatedFlag: { value: false, required: false },
             keyringFileXML: { value: "" },
             knxSecureSelected: { value: false },

package/nodes/knxUltimate-config.js

@@ -104,7 +104,8 @@ module.exports = (RED) => {
     node.allowLauch_initKNXConnection = true; // See the node.timerKNXUltimateCheckState function
     node.hostProtocol = config.hostProtocol === undefined ? "Auto" : config.hostProtocol; // 20/03/2022 Default
     node.knxConnection = null; // 20/03/2022 Default
-    node.delaybetweentelegrams = config.delaybetweentelegrams === undefined ? 25 : config.delaybetweentelegrams;
+    node.delaybetweentelegrams = (config.delaybetweentelegrams === undefined || config.delaybetweentelegrams === null) ? 25 : Number(config.delaybetweentelegrams);
+    if (node.delaybetweentelegrams < 20) node.delaybetweentelegrams = 20; // Protection avoiding handleKNXQueue hangs
 
     // 05/12/2021 Set the protocol (this is undefined if coming from ild versions
     if (node.hostProtocol === "Auto") {
@@ -216,7 +217,7 @@ module.exports = (RED) => {
         node.exposedGAs = JSON.parse(fs.readFileSync(sFile, "utf8"));
       } catch (err) {
         node.exposedGAs = [];
-        if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.warn("KNXUltimate-config: unable to read peristent file " + sFile + " " + err.message);
+        if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error("KNXUltimate-config: unable to read peristent file " + sFile + " " + err.message);
       }
     }
 
@@ -513,7 +514,8 @@ module.exports = (RED) => {
     //     localEchoInTunneling: true,
     //     localIPAddress: "",
     //     jKNXSecureKeyring: node.jKNXSecureKeyring
-    //     interface: ""
+    //     interface: "",
+    //     KNXQueueSendIntervalMilliseconds: Number(node.delaybetweentelegrams)
     // };
 
     node.setKnxConnectionProperties = () => {
@@ -679,7 +681,7 @@ module.exports = (RED) => {
             } catch (error) {
               if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error("knxUltimate-config: DoInitialReadFromKNXBusOrFile " + error.stack);
             }
-          }, 6000); // 17/02/2020 Do initial read of all nodes requesting initial read
+          }, 1000); // 17/02/2020 Do initial read of all nodes requesting initial read
           const t = setTimeout(() => {
             // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
             node.setAllClientsStatus("Connected.", "green", "On duty.");
@@ -1151,7 +1153,7 @@ module.exports = (RED) => {
         if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.warn(
           "knxUltimate-config: handleTelegramQueue: the KNXEngine is busy or is waiting for a telegram ACK with seqNumner " +
           node.knxConnection.getSeqNumber() +
-          ". Delay handling queue. YOUR COMPUTER COULD BE TOO SLOW OR BUSY TO KEEP UP WITH THE STRICT TIMING, REQUIRED FOR KNX TO FUNCTION PROPERLY.",
+          ". Delay handling queue. YOUR COMPUTER COULD BE TOO SLOW OR BUSY TO KEEP UP ADDED TELEGRAM TO COMMANDQUEUE. Len: 3",
         );
       }
 

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "3.2.1",
+  "version": "3.2.3",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",
@@ -11,7 +11,7 @@
     "dns-sync": "0.2.1",
     "eventsource": "2.0.2",
     "js-yaml": "4.1.0",
-    "knxultimate": ">=3.0.0",
+    "knxultimate": ">=3.0.3",
     "limiter": "^2.1.0",
     "lodash": "4.17.21",
     "node-color-log": "12.0.1",