node-red-contrib-knx-ultimate 3.0.7 → 3.0.9

package/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 # CHANGELOG
 
+**Version 3.0.9** - August 2024<br/>
+- Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
+- KNX Auto Responder node (BETA): fixed issue with malformed responses. Please be aware that until the node exits beta, there can be breaking changes.<br/>
+
 **Version 3.0.7** - August 2024<br/>
 - Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
 - KNX Auto Responder node (BETA): at start, it loads the last states saved in a persistent file. Please be aware that until the node exits beta, there can be breaking changes.<br/>

package/nodes/knxUltimateAutoResponder.js

@@ -99,7 +99,7 @@ module.exports = function (RED) {
       node.server.csv.forEach(element => {
         const curGa = node.exposedGAs.find(a => a.address === element.ga);
         if (curGa === undefined) {
-          node.exposedGAs.push({ address: element.ga, dpt: element.dpt, default: undefined, payload: undefined });
+          node.exposedGAs.push({ address: element.ga, dpt: element.dpt, default: undefined, payload: undefined, enabled: false }); // "enabled" will be used to filter only the node.commandText directiver
         }
       })
       node.status({ fill: 'green', shape: 'ring', text: 'ETS file loaded', payload: '', dpt: '', devicename: '' });
@@ -128,19 +128,24 @@ module.exports = function (RED) {
             // Add also to the exposedGAs list, if not already present
             let curGa = node.exposedGAs.find(a => a.address === decAdd);
             if (curGa === undefined) {
-              node.exposedGAs.push({ address: decAdd, dpt: dpt, default: defaultVal, payload: undefined });
+              node.exposedGAs.push({ address: decAdd, dpt: dpt, default: defaultVal, payload: undefined, enabled: true });
             } else {
               if (dpt !== undefined) curGa.dpt = dpt; // Take the Datapoint from the commandText directive, replacing from ETS CSV file, if exists.
+              curGa.enabled = true;
             }
           }
         } else {
           let curGa = node.exposedGAs.find(a => a.address === element.ga);
           if (curGa === undefined) {
-            node.exposedGAs.push({ address: element.ga, dpt: dpt, default: defaultVal, payload: undefined });
+            node.exposedGAs.push({ address: element.ga, dpt: dpt, default: defaultVal, payload: undefined, enabled: true });
           } else {
             if (dpt !== undefined) curGa.dpt = dpt; // Take the Datapoint from the commandText directive, replacing from ETS CSV file, if exists.
+            curGa.enabled = true;
           }
         }
+        // Delete all not wanted GAs, that aren't in the node.commandText directive list.
+        node.exposedGAs = node.exposedGAs.filter(a => a.enabled === true || a.enabled === undefined);
+
         node.status({ fill: 'green', shape: 'ring', text: 'JSON parsed: ' + node.commandText.length + " directive(s).", payload: '', dpt: '', devicename: '' });
       } else {
         // Error
@@ -162,10 +167,11 @@ module.exports = function (RED) {
           if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error(`knxUltimateAutoResponder: var oGa = node.exposedGAs.find(ga => ga.address === msg.knx.destination) ${error.stack}`);
         }
         if (oGa !== undefined) {
+          let decodedPayload;
           try {
             // Don't care about the decoded payload, because knxUltimate-config could pass a TryToFindDatapoint from raw data
             // Take only RAW data and decode it with the dpt specified by the commandText directive
-            const decodedPayload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(oGa.dpt));
+            decodedPayload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(oGa.dpt));
           } catch (error) {
             node.status({ fill: 'red', shape: 'dot', text: 'const decodedPayload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(oGa.dpt)); ' + error.message, payload: '', dpt: '', devicename: '' });
             if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error(`knxUltimateAutoResponder: const decodedPayload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(oGa.dpt)); ${error.stack}`);
@@ -185,8 +191,12 @@ module.exports = function (RED) {
           }
           if (retVal !== undefined) {
             const dDate = new Date()
-            node.status({ fill: 'blue', shape: 'dot', text: 'Respond ' + oFoundGA.address + ' => ' + retVal + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ')' })
-            node.server.writeQueueAdd({ grpaddr: oFoundGA.address, payload: retVal, dpt: oFoundGA.dpt, outputtype: 'response', nodecallerid: node.id });
+            if (oFoundGA.address !== undefined && oFoundGA.dpt !== undefined && retVal !== undefined) {
+              node.server.writeQueueAdd({ grpaddr: oFoundGA.address, payload: retVal, dpt: oFoundGA.dpt, outputtype: 'response', nodecallerid: node.id });
+              node.status({ fill: 'blue', shape: 'dot', text: 'Respond ' + oFoundGA.address + ' => ' + retVal + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ')' })
+            } else {
+              node.status({ fill: 'yellow', shape: 'ring', text: 'Issue responding ' + oFoundGA.address + ' => ' + retVal + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ')' })
+            }
           }
         } catch (error) {
           if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error(`knxUltimateAutoResponder: after bFound ${error.stack}`);

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "3.0.7",
+  "version": "3.0.9",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",