node-red-contrib-knx-ultimate 2.4.28 → 2.5.1

package/CHANGELOG.md

@@ -6,13 +6,33 @@
 
 # CHANGELOG
 
-**Version 2.4.28**
-- temporary reveft to 2.4.23
+**Version 2.5.1** - Mai 2024<br/>
+- Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
+- NEW: HUE light node: you can now override the day/night mode by setting the day mode temporary, whenever you fast toggles the light switch on then off within 10 seconds. There are multiple choiches to select from. <br/>
+
+**Version 2.5.0** - Mai 2024<br/>
+- Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
+- HUE light node: internally calculate the average color xy and temp in kelvin, for group_lights (not emitted by the HUE Bridge).<br/>
+- KNOW ISSUE: HUE light node: grouped_lights: the status group address is updated multiple times, equals to the lights contained in the grouped_light. To avoid repeating the same telegram multiple times, simply enable the RBE filter on the KNX node. <br/>
+
+**Version 2.4.27** - Mai 2024<br/>
+- Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
+- HUE light node: fixed status refresh of kelvin and brightness of a light belonging to a grouped_light.<br/>
+- KNOW ISSUE: HUE light node: grouped_lights: the status group address is updated multiple times, equals to the lights contained in the grouped_light. To avoid repeating the same telegram multiple times, simply enable the RBE filter on the KNX node. <br/>
+
+**Version 2.4.25** - Mai 2024<br/>
+- Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
+- HUE light node: fixed status sent to the KNX bus after issuing a read request for grouped_lights.<br/>
+- KNOW ISSUE: HUE light node: grouped_lights: the status group address is updated multiple times, equals to the lights contained in the grouped_light. To avoid repeating the same telegram multiple times, simply enable the RBE filter on the KNX node. <br/>
+
+**Version 2.4.24** - Mai 2024<br/>
+- Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
+- HUE light node: fixed kelvin temp status with datapoint 7.600, that sent wrong values to the bus.<br/>
 
 **Version 2.4.23** - Mai 2024<br/>
 - Warning: Node-Red version **equals or major than 3.1.1** is needed to run this node.<br/>
 - HUE Scene node: fixed max scene count to 64.<br/>
-
+ 
 **Version 2.4.22** - April 2024<br/>
 - Warning: this version uses the Node-Red plugin system; the  Node-Red version must be **equals or major than 3.1.1**<br/>
 - HUE button node: NEW: now you can select the value and the dim direction to be transmitted, when Toggle Status is set to unchecked. Thanks @cybersmart-eu for the suggestion.<br/>

package/README.md

@@ -50,14 +50,17 @@ msg.payload = {red:255, green:200, blue:30} // Put some colors in our life
 
 * See <a href="https://github.com/Supergiovane/node-red-contrib-knx-ultimate/blob/master/CHANGELOG.md">here the changelog</a>
 
+
+## SUPPORTED TECHNOLOGIES
+
 |Technology|Supported|
 |--|--|
 | KNX Tunnelling | ![](https://placehold.co/200x20/green/white?text=YES) |
 | KNX Routing | ![](https://placehold.co/200x20/green/white?text=YES) |
 | KNX Secure Tunnelling | ![](https://placehold.co/200x20/orange/white?text=UNDER+DEVELOPMENT) |
 | KNX Secure Routing | ![](https://placehold.co/200x20/red/white?text=NO) |
-| KNX 3rd PARTY IOT API | ![](https://placehold.co/200x20/orange/white?text=UNDER+DEVELOPMENT) |
-
+| KNX 3rd PARTY IOT API client | ![](https://placehold.co/200x20/orange/white?text=UNDER+DEVELOPMENT) |
+| Matter | ![](https://placehold.co/200x20/blue/white?text=UNDER+BRAINSTORMING) |
 
 <br/>
 

package/nodes/hue-config.js

@@ -9,6 +9,7 @@ const HueClass = require("./utils/hueEngine").classHUE;
 const loggerEngine = require("./utils/sysLogger");
 const hueColorConverter = require("./utils/colorManipulators/hueColorConverter");
 
+
 module.exports = (RED) => {
   function hueConfig(config) {
     RED.nodes.createNode(this, config);
@@ -50,6 +51,9 @@ module.exports = (RED) => {
         node.nodeClients.forEach((_oClient) => {
           const oClient = _oClient;
           try {
+            // if (_event.type === "light" || _event.type === "grouped_light") {
+            //   console.log(_event);
+            // }            
             if (oClient.handleSendHUE !== undefined) oClient.handleSendHUE(_event);
           } catch (error) {
             if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error(`Errore node.hueManager.on(event): ${error.message}`);
@@ -65,7 +69,9 @@ module.exports = (RED) => {
           node.timerDoInitialRead = setTimeout(() => {
             (async () => {
               try {
+                if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info(`HTTP getting resource from HUE bridge : ${node.name}`);
                 await node.loadResourcesFromHUEBridge();
+                if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info(`Total HUE resources count : ${node.hueAllResources.length}`);
               } catch (error) {
                 node.linkStatus = "disconnected";
                 node.nodeClients.forEach((_oClient) => {
@@ -114,6 +120,7 @@ module.exports = (RED) => {
     };
     node.startWatchdogTimer();
 
+    // Functions called from the nodes ----------------------------------------------------------------
     // Query the HUE Bridge to return the resources
     node.loadResourcesFromHUEBridge = async () => {
       if (node.linkStatus === "disconnected") return;
@@ -173,11 +180,22 @@ module.exports = (RED) => {
     };
 
     // Return an array of light belonging to the groupID
-    node.getAllLightsBelongingToTheGroup = async function getAllLightsBelongingToTheGroup(_groupID) {
+    node.getAllLightsBelongingToTheGroup = async function getAllLightsBelongingToTheGroup(_groupID, refreshResourcesFromBridge = true) {
       if (node.hueAllResources === undefined || node.hueAllResources === null) return;
       const retArr = [];
+      let filteredResource;
       try {
-        await node.loadResourcesFromHUEBridge();
+        if (refreshResourcesFromBridge === true) {
+          await node.loadResourcesFromHUEBridge();
+        }
+        // filteredResource = node.hueAllResources.filter((a) => a.id === _groupID);
+        // if (filteredResource[0].type === "grouped_light") {
+        //   filteredResource = node.hueAllResources.filter((a) => a.services);
+        //   filteredResource = filteredResource.filter((a) => a.services).filter((b) => b.type === "light");
+        //   if (filteredResource.length > 0) {
+        //     console.log(filteredResource)
+        //   }
+        // }
         node.hueAllResources.forEach((res) => {
           if (res.services !== undefined && res.services.length > 0) {
             res.services.forEach((serv) => {
@@ -187,7 +205,8 @@ module.exports = (RED) => {
                   for (let index = 0; index < children.length; index++) {
                     const element = children[index];
                     const oLight = node.hueAllResources.filter((a) => a.id === element.rid);
-                    if (oLight !== null && oLight !== undefined) retArr.push({ groupID: _groupID, light: oLight });
+                    //if (oLight !== null && oLight !== undefined) retArr.push({ groupID: _groupID, light: oLight[0] });
+                    if (oLight !== null && oLight !== undefined) retArr.push(oLight[0]);
                   }
                 }
               }
@@ -363,6 +382,46 @@ module.exports = (RED) => {
       }
     };
 
+    /**
+    * Get average color XY from a light array
+    * @param {array} _arrayLights - Light array
+    * @returns { x,y,mirek,brightness } - Object containing all infos
+    */
+    node.getAverageColorsXYBrightnessAndTemperature = async function getAverageColorsXYBrightnessAndTemperature(_arrayLights) {
+      let x; let y; let mirek; let brightness;
+      let countColor = 0, countColor_Temperature = 0, countDimming = 0;
+      _arrayLights.forEach((element) => {
+        if (element.color !== undefined && element.color.xy !== undefined) {
+          if (x === undefined) { x = 0; y = 0; }
+          x += element.color.xy.x;
+          y += element.color.xy.y;
+          countColor += 1;
+        }
+        if (element.color_temperature !== undefined && element.color_temperature.mirek !== undefined) {
+          if (mirek === undefined) mirek = 0;
+          mirek += element.color_temperature.mirek;
+          countColor_Temperature += 1;
+        }
+        if (element.dimming !== undefined && element.dimming.brightness !== undefined) {
+          if (brightness === undefined) brightness = 0;
+          brightness += element.dimming.brightness;
+          countDimming += 1;
+        }
+      });
+      // Calculate and return the averages
+      const retX = countColor === 0 ? undefined : x / countColor;
+      const retY = countColor === 0 ? undefined : y / countColor;
+      const retMirek = countColor_Temperature === 0 ? undefined : mirek / countColor_Temperature;
+      const retBrightness = countDimming === 0 ? undefined : brightness / countDimming;
+
+      return {
+        x: retX, y: retY, mirek: retMirek, brightness: retBrightness
+      };
+    };
+    // END functions called from the nodes ----------------------------------------------------------------
+
+
+
     node.addClient = (_Node) => {
       // Update the node hue device, as soon as a node register itself to hue-config nodeClients
       if (node.nodeClients.filter((x) => x.id === _Node.id).length === 0) {

package/nodes/knxUltimateHueLight.html

@@ -129,6 +129,8 @@
 
         hueDevice: { value: "" },
         hueDeviceObject: { value: {} },
+
+        restoreDayMode: { value: "no" }
       },
       inputs: 0,
       outputs: 0,
@@ -1406,11 +1408,21 @@
               </div>
               <div class="form-row">
                 <label style="width:170px" for="node-input-invertDayNight">
-                  <i class="fa fa-shuffle"></i> Invert day/night values
+                  <i class="fa fa-shuffle"></i> Invert day/night value
                 </label>
                 <input type="checkbox" id="node-input-invertDayNight"
                   style="display:inline-block; width:auto; vertical-align:top;" />
               </div>
+              <div class="form-row">
+                <label for="node-input-restoreDayMode" style="width:260px;">
+                  <i class="fa fa-circle"></i> Override night mode
+                </label>
+                <select id="node-input-restoreDayMode">
+                  <option value="no">No</option>
+                  <option value="setDayByFastSwitchLightSingle">Switch to DAY mode by rapid switching the ligth off then on. (This light only)</option>
+                  <option value="setDayByFastSwitchLightALL">Switch to DAY mode by rapid switching the ligth off then on (apply yo ALL light nodes)</option>
+                </select>
+              </div>
             </div>
           </div>
           <br/>
@@ -1521,8 +1533,9 @@ For controlling the "V" (brightness) of the HSV, please use the standard control
 | Switch on behaviour                       | It sets the behaviour of your lights when switched on. You can choose from differents behaviours.<br/>**Select color:** the light will be switched on with the color of your choice. To change color, just CLICK on the color selector (under the *Select color* control).<br/>**Select temperature and brightness:** the light will be switched on with the temperature (Kelvin) and brightness (0-100) of your choice.<br/>**None:** the light will retain its last status. In case you've enable the night lighting, after the night time ends, the lamp will resume the color/temperature/brightness state set at day time.  |
 | Night Lighting                            | It allows to set a particular light color/brightness at nighttime. The options are the same as the daytime. You could select either a temperature/brightness or color. A cozy temperature of 2700 Kelvin, with a brightness of 10% or 20%, is a good choice for  bathroom's night light.|
 | Day/Night                                 | Select the group address used to set the day/night behaviour. The group address value is _true_ if daytime, _false_ if nighttime.                                                                                                                                                                                                                                                                                                                                                                    |
-| Invert day/night values                   | Invert the values of _Day/Night_ group address. Default value is **unchecked**.                                                                                                                                                                                                                                                                                                                                                                                                                      |
+| Invert day/night value                   | Invert the values of _Day/Night_ group address. Default value is **unchecked**.                                                                                                                                                                                                                                                                                                                                                                                                                      |
 | Read status at startup | Read the status at startup and emit the event to the KNX bus at startup/reconnection. (Default "no")|
+| Override night mode | You can override the night mode by manually switching the light as described here:  **Switch to DAY mode by rapid switching the ligth off then on (This light only)** does what described and acts only on this light. **Switch to DAY mode by rapid switching the ligth off then on (apply yo ALL light nodes)** acts to ALL Light nodes, by setting the Day/Night group address to Day mode. |
 | Node Input/Output PINs | Hide or show the input/output PINs. Input/output PINS allow the node to accept msg input from the flow and send msg output to the flow. Input msg must follow the HUE API v.2 Standards. This is an example msg, that turns on the light: <code>msg.on = {"on":true}</code>. Please refer to the [official HUE Api page](https://developers.meethue.com/develop/hue-api-v2/api-reference/#resource_light__id__put) | 
 
 ### Note

package/nodes/knxUltimateHueLight.js

@@ -62,7 +62,10 @@ module.exports = function (RED) {
     config.colorAtSwitchOnNightTime = config.colorAtSwitchOnNightTime.replace("geen", "green");
     config.dimSpeed = (config.dimSpeed === undefined || config.dimSpeed === '') ? 5000 : Number(config.dimSpeed);
     config.HSVDimSpeed = (config.HSVDimSpeed === undefined || config.HSVDimSpeed === '') ? 5000 : Number(config.HSVDimSpeed);
-    config.invertDimTunableWhiteDirection = config.invertDimTunableWhiteDirection === undefined ? false : true;
+    config.invertDimTunableWhiteDirection = config.invertDimTunableWhiteDirection !== undefined;
+    config.restoreDayMode = config.restoreDayMode === undefined ? "no" : config.restoreDayMode; // no or setDayByFastSwitchLightSingle or setDayByFastSwitchLightALL
+    node.timerCheckForFastLightSwitch = null;
+    config.invertDayNight = config.invertDayNight === undefined ? false : config.invertDayNight;
     node.HSVObject = null; //{ h, s, v };// Store the current light calculated HSV
 
     // Transform HEX in RGB and stringified json in json oblects.
@@ -96,7 +99,6 @@ module.exports = function (RED) {
         RED.log.error(`knxUltimateHueLight:  config.colorAtSwitchOnDayTime = JSON.parse(config.colorAtSwitchOnNightTime): ${error.message} : ${error.stack || ""} `);
         config.colorAtSwitchOnNightTime = "";
       }
-
     }
 
     // Used to call the status update from the config node.
@@ -134,6 +136,42 @@ module.exports = function (RED) {
           switch (msg.knx.destination) {
             case config.GALightSwitch:
               msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightSwitch));
+
+              // 15/05/2024 Supergiovane: check the Override to Day option
+              // config.restoreDayMode can be: no or setDayByFastSwitchLightSingle or setDayByFastSwitchLightALL
+              // ----------------------------------------------------------
+              if (config.restoreDayMode === "setDayByFastSwitchLightSingle" || config.restoreDayMode === "setDayByFastSwitchLightALL") {
+                if (node.DayTime === false) {
+                  if (msg.payload === true) {
+                    if (node.timerCheckForFastLightSwitch === null) {
+                      node.timerCheckForFastLightSwitch = setTimeout(() => {
+                        node.DayTime = false;
+                        RED.log.debug("knxUltimateHueLight: node.timerCheckForFastLightSwitch: set daytime to false after node.timerCheckForFastLightSwitch elapsed");
+                        node.timerCheckForFastLightSwitch = null;
+                      }, 10000); // 10 seconds
+                    } else {
+                      if (config.restoreDayMode === "setDayByFastSwitchLightALL") {
+                        // Turn off the Day/Night group address
+                        if (config.GADaylightSensor !== undefined && config.GADaylightSensor !== "") {
+                          if (node.timerCheckForFastLightSwitch !== null) { clearTimeout(node.timerCheckForFastLightSwitch); node.timerCheckForFastLightSwitch = null; }
+                          RED.log.debug(`knxUltimateHueLight: node.timerCheckForFastLightSwitch: set daytime the group address ${config.GADaylightSensor}`);
+                          node.server.writeQueueAdd({
+                            grpaddr: config.GADaylightSensor,
+                            payload: config.invertDayNight === false,
+                            dpt: config.dptDaylightSensor,
+                            outputtype: "write",
+                            nodecallerid: node.id,
+                          });
+                        }
+                      }
+                      node.DayTime = true;
+                      RED.log.debug("knxUltimateHueLight: node.timerCheckForFastLightSwitch: set daytime to true");
+                    }
+                  }
+                }
+              }
+              // ----------------------------------------------------------
+
               if (msg.payload === true) {
                 // From HUE Api core concepts:
                 // If you try and control multiple conflicting parameters at once e.g. {"color": {"xy": {"x":0.5,"y":0.5}}, "color_temperature": {"mirek": 250}}
@@ -309,7 +347,7 @@ module.exports = function (RED) {
               break;
             case config.GADaylightSensor:
               node.DayTime = Boolean(dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptDaylightSensor)));
-              if (config.invertDayNight !== undefined && config.invertDayNight === true) node.DayTime = !node.DayTime;
+              if (config.invertDayNight === true) node.DayTime = !node.DayTime;
               if (config.specifySwitchOnBrightness === "no") {
                 // This retains the HUE device status while daytime, to be restored after nighttime elapsed. https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/298
                 if (node.DayTime === false) {
@@ -317,7 +355,7 @@ module.exports = function (RED) {
                   if (node.isGrouped_light === true) {
                     (async () => {
                       try {
-                        const retLights = await node.serverHue.getAllLightsBelongingToTheGroup(node.hueDevice);
+                        const retLights = await node.serverHue.getAllLightsBelongingToTheGroup(node.hueDevice, false);
                         node.HUELightsBelongingToGroupWhileDaytime = cloneDeep(retLights); // DayTime has switched to false: save the lights belonging to the group into the HUELightsBelongingToGroupWhileDaytime array
                       } catch (error) { /* empty */ }
                     })();
@@ -509,16 +547,56 @@ module.exports = function (RED) {
               if (ret !== undefined) node.updateKNXLightColorState(node.currentHUEDevice.color, "response");
               break;
             case config.GALightKelvinPercentageState:
+              // The kelvin level belongs to the group defice, so i don't need to get the first light in the collection (if the device is a grouped_light)
               ret = node.currentHUEDevice.color_temperature.mirek;
               if (ret !== undefined) node.updateKNXLightKelvinPercentageState(ret, "response");
+              // if (node.isGrouped_light === false) {
+              //   ret = node.currentHUEDevice.color_temperature.mirek;
+              //   if (ret !== undefined) node.updateKNXLightKelvinPercentageState(ret, "response");
+              // } else {
+              //   (async () => {
+              //     try {
+              //       // Find the first light in the collection, having the color_temperature capabilities
+              //       const devices = await node.serverHue.getAllLightsBelongingToTheGroup(node.hueDevice, false);
+              //       for (let index = 0; index < devices.length; index++) {
+              //         const element = devices[index];
+              //         if (element.light[0].color_temperature !== undefined) {
+              //           ret = element.light[0].color_temperature.mirek;
+              //           break;
+              //         }
+              //       }
+              //       if (ret !== undefined) node.updateKNXLightKelvinPercentageState(ret, "response");
+              //     } catch (error) { /* empty */ }
+              //   })();
+              // }
               break;
             case config.GALightBrightnessState:
               ret = node.currentHUEDevice.dimming.brightness;
               if (ret !== undefined) node.updateKNXBrightnessState(ret, "response");
               break;
             case config.GALightKelvinState:
+              // The kelvin level belongs to the group defice, so i don't need to get the first light in the collection (if the device is a grouped_light)
               ret = node.currentHUEDevice.color_temperature.mirek;
               if (ret !== undefined) node.updateKNXLightKelvinState(ret, "response");
+              // if (node.isGrouped_light === false) {
+              //   ret = node.currentHUEDevice.color_temperature.mirek;
+              //   if (ret !== undefined) node.updateKNXLightKelvinState(ret, "response");
+              // } else {
+              //   (async () => {
+              //     try {
+              //       // Find the first light in the collection, having the color_temperature capabilities
+              //       const devices = await node.serverHue.getAllLightsBelongingToTheGroup(node.hueDevice, false);
+              //       for (let index = 0; index < devices.length; index++) {
+              //         const element = devices[index];
+              //         if (element.light[0].color_temperature !== undefined) {
+              //           ret = element.light[0].color_temperature.mirek;
+              //           break;
+              //         }
+              //       }
+              //       if (ret !== undefined) node.updateKNXLightKelvinState(ret, "response");
+              //     } catch (error) { /* empty */ }
+              //   })();
+              // }
               break;
             default:
               break;
@@ -870,22 +948,93 @@ module.exports = function (RED) {
     };
     // ***********************************************************
 
-    node.handleSendHUE = (_event) => {
+    node.handleSendHUE = async (_event) => {
+      if (_event === undefined) return;
+      if (_event.type !== 'grouped_light' && _event.type !== 'light') return;
+
+      // !!!! >>> if the node is a grouped_light, the only values required, thus present, by HUE apis are "on" and "dimming".
+      // !!!! >>> For all others properties like for example color and tunable white, i must get the data from one of the child lights.
+
+      //(async () => {
+      // Check and set canContinue true or false ------------------------------------------------------------
       try {
-        const deviceByRef = cloneDeep(_event);
-        if (deviceByRef.id === node.hueDevice) {
-          if (node.currentHUEDevice === undefined || node.serverHue === null || node.serverHue === undefined) {
-            node.setNodeStatusHue({
-              fill: "red",
-              shape: "ring",
-              text: "Rejected HUE message. I'm connecting to the Bridge...",
-              payload: "",
-            });
-            return;
+        if (node.currentHUEDevice === undefined || node.serverHue === null || node.serverHue === undefined) {
+          node.setNodeStatusHue({
+            fill: "red",
+            shape: "ring",
+            text: "Rejected HUE light settings. I'm still not ready...",
+            payload: "",
+          });
+          return;
+        }
+
+        const receivedHUEObject = cloneDeep(_event);
+
+        //#region "CALCULATE COLOR AND COLOR TEMPERATURE OF THE LIGHTS BELONGING TO THE GROUPED_LIGHT"
+        // Check wether the incoming _event belongs to a light belonging to the group_light
+        if (node.isGrouped_light === true && receivedHUEObject.type === 'light') {
+          // Handling of not by HUE handled Color Temperature and ColorXY
+          let modifiedLight;
+          const groupChilds = [];
+          let AverageColorsXYBrightnessAndTemperature; // Average color xy and color temp if the node is a grouped light.
+          // If the current node is a grouped lights, i must check wether the receivedHUEObject (containing a light) belongs to the node lights collection.
+          // Find all the lights in the collection, having the color_temperature capabilities, belonging to the group.
+          const devices = await node.serverHue.getAllLightsBelongingToTheGroup(node.hueDevice, false);
+          if (devices.length === 0) {
+            devices.push(receivedHUEObject);
           }
 
+          for (let index = 0; index < devices.length; index++) {
+            const element = devices[index];
+            if (receivedHUEObject.id === element.id) {
+              modifiedLight = element;
+              // The dimming is not necessary, beacause the HUE API already sends a group_light event with the average brightness //if (receivedHUEObject.dimming !== undefined) modifiedLight.dimming = { brightness: receivedHUEObject.dimming.brightness };
+              if (receivedHUEObject.color !== undefined && receivedHUEObject.color.xy !== undefined) modifiedLight.color = receivedHUEObject.color;
+              if (receivedHUEObject.color_temperature !== undefined) modifiedLight.color_temperature = receivedHUEObject.color_temperature;
+              groupChilds.push(modifiedLight);
+            } else {
+              // Simply append the light
+              if ((element.color_temperature !== undefined && element.color_temperature.mirek !== undefined)
+                || (element.color !== undefined && element.color.xy !== undefined)) {
+                groupChilds.push(element);
+              }
+            }
+          }
+
+          // Use the arithmetic average of color xy, brightness and color temperature "averageColorXYandKelvinOfGroupedLights"
+          if (groupChilds !== undefined) AverageColorsXYBrightnessAndTemperature = await node.serverHue.getAverageColorsXYBrightnessAndTemperature(groupChilds);
+
+          // Set the new values based on average calculated above            
+          // CHECK FIRST THE COLOR_TEMPERATURE, because it can be undefined, because the current selected color
+          // is out of the mirek range, so it cannot be represented with the colore temperature.
+          if (receivedHUEObject.color_temperature !== undefined && AverageColorsXYBrightnessAndTemperature.mirek !== undefined) {
+            receivedHUEObject.color_temperature.mirek = AverageColorsXYBrightnessAndTemperature.mirek;
+            node.currentHUEDevice.color_temperature.mirek = AverageColorsXYBrightnessAndTemperature.mirek;
+            node.updateKNXLightKelvinPercentageState(receivedHUEObject.color_temperature.mirek);
+            node.updateKNXLightKelvinState(receivedHUEObject.color_temperature.mirek);
+          } else if (receivedHUEObject.color !== undefined && receivedHUEObject.color.xy !== undefined && AverageColorsXYBrightnessAndTemperature.x !== undefined) {
+            receivedHUEObject.color.xy.x = AverageColorsXYBrightnessAndTemperature.x;
+            receivedHUEObject.color.xy.y = AverageColorsXYBrightnessAndTemperature.y;
+            node.currentHUEDevice.color.xy.x = AverageColorsXYBrightnessAndTemperature.x;
+            node.currentHUEDevice.color.xy.y = AverageColorsXYBrightnessAndTemperature.y;
+            node.updateKNXLightColorState(receivedHUEObject.color);
+          }
+          // The dimming is not necessary, beacause the HUE API already sends a group_light event with the average brightness 
+          // if (receivedHUEObject.dimming !== undefined && AverageColorsXYBrightnessAndTemperature.brightness !== undefined) {
+          //   receivedHUEObject.dimming = { brightness: AverageColorsXYBrightnessAndTemperature.brightness };
+          // }
+          // --------------------------------------------------------------------------------------------------
+          if (modifiedLight !== undefined && modifiedLight.metadata !== undefined && modifiedLight.metadata.name !== undefined) {
+            receivedHUEObject.lightName = modifiedLight.metadata.name;
+          }
+          node.send(receivedHUEObject);
+          return;
+        }
+        //#endregion
+
+        if (receivedHUEObject.id === node.hueDevice) {
           // Output the msg to the flow
-          node.send(deviceByRef);
+          node.send(receivedHUEObject);
 
           // // DEBUG testing enable/disable HTML UI Tabs
           //delete _event.dimming;
@@ -893,53 +1042,39 @@ module.exports = function (RED) {
           //delete _event.color_temperature;
           //delete _event.color_temperature_delta;
 
-          // As grouped_light doesn't contain all requested properties, i find the first light in the group, and use this below in the code
-          // If the event type is grouped light, and there are missing properties, i infer these missing properties from the first light in the group!
-          if ((deviceByRef.color !== undefined || deviceByRef.dimming !== undefined || deviceByRef.color_temperature !== undefined) && deviceByRef.type === 'grouped_light') {
-            try {
-              const firstLightInGroup = node.serverHue.getFirstLightInGroup(deviceByRef.id);
-              if (firstLightInGroup !== null && firstLightInGroup !== undefined) {
-                if (deviceByRef.color === undefined) {
-                  deviceByRef.color = firstLightInGroup.color;
-                }
-                if (deviceByRef.color_temperature === undefined) {
-                  deviceByRef.color_temperature = firstLightInGroup.color_temperature;
-                }
-              }
-            } catch (error) { }
-          }
-
-          if (deviceByRef.on !== undefined) {
-            node.updateKNXLightState(deviceByRef.on.on);
+          if (receivedHUEObject.on !== undefined) {
+            node.updateKNXLightState(receivedHUEObject.on.on);
             // In case of switch off, set the dim to zero
-            if (deviceByRef.on.on === false && (config.updateKNXBrightnessStatusOnHUEOnOff === undefined || config.updateKNXBrightnessStatusOnHUEOnOff === "onhueoff")) {
+            if (receivedHUEObject.on.on === false && (config.updateKNXBrightnessStatusOnHUEOnOff === undefined || config.updateKNXBrightnessStatusOnHUEOnOff === "onhueoff")) {
               node.updateKNXBrightnessState(0);
-              if (deviceByRef.dimming !== undefined) delete deviceByRef.dimming; // Remove event.dimming, because has beem handled by this function and i don't want the function below to take care of it.
-            } else if (deviceByRef.on.on === true && node.currentHUEDevice.on.on === false) {
-              // Turn on always update the dimming KNX Status value as well.
+              if (receivedHUEObject.dimming !== undefined) delete receivedHUEObject.dimming; // Remove event.dimming, because has beem handled by this function and i don't want the function below to take care of it.
+            } else if (receivedHUEObject.on.on === true && node.currentHUEDevice.on.on === false) {
               let brightVal = 50;
-              if (node.currentHUEDevice.dimming !== undefined && node.currentHUEDevice.dimming.brightness !== undefined) brightVal = node.currentHUEDevice.dimming.brightness;
+              // Turn on always update the dimming KNX Status value as well.
+              if (node.currentHUEDevice.dimming !== undefined && node.currentHUEDevice.dimming.brightness !== undefined) {
+                brightVal = node.currentHUEDevice.dimming.brightness;
+              }
               node.updateKNXBrightnessState(brightVal);
             }
-            node.currentHUEDevice.on.on = deviceByRef.on.on;
+            node.currentHUEDevice.on.on = receivedHUEObject.on.on;
           }
 
-          if (deviceByRef.color !== undefined) { // fixed https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/287
-            node.updateKNXLightColorState(deviceByRef.color);
-            node.currentHUEDevice.color = deviceByRef.color;
+          if (receivedHUEObject.color !== undefined && receivedHUEObject.color.xy !== undefined) { // fixed https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/287
+            node.updateKNXLightColorState(receivedHUEObject.color);
+            node.currentHUEDevice.color = receivedHUEObject.color;
           }
 
-          if (deviceByRef.dimming !== undefined && deviceByRef.dimming.brightness !== undefined) {
+          if (receivedHUEObject.dimming !== undefined && receivedHUEObject.dimming.brightness !== undefined) {
             // Once upon n a time, the light transmit the brightness value of 0.39.
             // To avoid wrongly turn light state on, exit
-            if (deviceByRef.dimming.brightness < 1) deviceByRef.dimming.brightness = 0;
-            if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && deviceByRef.dimming.brightness === 0) {
+            if (receivedHUEObject.dimming.brightness < 1) receivedHUEObject.dimming.brightness = 0;
+            if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && receivedHUEObject.dimming.brightness === 0) {
               // Do nothing, because the light is off and the dimming also is 0
             } else {
-              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (deviceByRef.on === undefined || (deviceByRef.on !== undefined && deviceByRef.on.on === true))) node.updateKNXLightState(deviceByRef.dimming.brightness > 0);
-              node.updateKNXBrightnessState(deviceByRef.dimming.brightness);
+              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (receivedHUEObject.on === undefined || (receivedHUEObject.on !== undefined && receivedHUEObject.on.on === true))) node.updateKNXLightState(receivedHUEObject.dimming.brightness > 0);
+              node.updateKNXBrightnessState(receivedHUEObject.dimming.brightness);
               // If the brightness reaches zero, the hue lamp "on" property must be set to zero as well
-              if (deviceByRef.dimming.brightness === 0 && node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === true) {
+              if (receivedHUEObject.dimming.brightness === 0 && node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === true) {
                 node.serverHue.hueManager.writeHueQueueAdd(
                   node.hueDevice,
                   { on: { on: false } },
@@ -947,13 +1082,14 @@ module.exports = function (RED) {
                 );
                 node.currentHUEDevice.on.on = false;
               }
-              node.currentHUEDevice.dimming.brightness = deviceByRef.dimming.brightness;
+              node.currentHUEDevice.dimming.brightness = receivedHUEObject.dimming.brightness;
             }
           }
-          if (deviceByRef.color_temperature !== undefined && deviceByRef.color_temperature.mirek !== undefined) {
-            node.updateKNXLightKelvinPercentageState(deviceByRef.color_temperature.mirek);
-            node.updateKNXLightKelvinState(deviceByRef.color_temperature.mirek);
-            node.currentHUEDevice.color_temperature.mirek = deviceByRef.color_temperature.mirek;
+
+          if (receivedHUEObject.color_temperature !== undefined && receivedHUEObject.color_temperature.mirek !== undefined) {
+            node.updateKNXLightKelvinPercentageState(receivedHUEObject.color_temperature.mirek);
+            node.updateKNXLightKelvinState(receivedHUEObject.color_temperature.mirek);
+            node.currentHUEDevice.color_temperature.mirek = receivedHUEObject.color_temperature.mirek;
           }
         }
       } catch (error) {
@@ -964,8 +1100,10 @@ module.exports = function (RED) {
         });
         RED.log.error(`knxUltimateHueLight: node.handleSendHUE = (_event): ${error.stack}`);
       }
+      // })();
     };
 
+
     // Leave the name after "function", to avoid <anonymous function> in the stack trace, in caso of errors.
     node.updateKNXBrightnessState = function updateKNXBrightnessState(_value, _outputtype = "write") {
       if (config.GALightBrightnessState !== undefined && config.GALightBrightnessState !== "") {
@@ -1128,11 +1266,11 @@ module.exports = function (RED) {
     //     };
 
     /**
-  * Update the KNC colors and HSV states group addresses
-  * @param {object} _value {xy:{x,y}} in 0-1 scale
-  * @param {string} _outputtype "write" is the default KNX command
-  * @returns {}
-  */
+    * Update the KNC colors and HSV states group addresses
+    * @param {object} _value {xy:{x,y}} in 0-1 scale
+    * @param {string} _outputtype "write" is the default KNX command
+    * @returns {}
+    */
     node.updateKNXLightColorState = function updateKNXLightColorState(_value, _outputtype = "write") {
       if (config.GALightColorState !== undefined && config.GALightColorState !== "") {
         if (_value.xy === undefined || _value.xy.x === undefined) return;
@@ -1229,8 +1367,8 @@ module.exports = function (RED) {
         knxMsgPayload.topic = config.GALightKelvinState;
         knxMsgPayload.dpt = config.dptLightKelvinState;
         if (config.dptLightKelvinState === "7.600") {
-          kelvinValue = hueColorConverter.ColorConverter.mirekToKelvin(_value);
-          knxMsgPayload.payload = hueColorConverter.ColorConverter.scale(kelvinValue, [2000, 6535], [0, 65535]);
+          knxMsgPayload.payload = hueColorConverter.ColorConverter.mirekToKelvin(_value);
+          //knxMsgPayload.payload = hueColorConverter.ColorConverter.scale(kelvinValue, [2000, 6535], [0, 65535]);
         } else if (config.dptLightKelvinState === "9.002") {
           knxMsgPayload.payload = hueColorConverter.ColorConverter.mirekToKelvin(_value);
         }
@@ -1250,7 +1388,7 @@ module.exports = function (RED) {
             fill: "blue",
             shape: "ring",
             text: "HUE->KNX Kelvin",
-            payload: kelvinValue,
+            payload: knxMsgPayload.payload,
           });
         }
       }
@@ -1305,6 +1443,6 @@ module.exports = function (RED) {
       }
       done();
     });
-  };
+  }
   RED.nodes.registerType("knxUltimateHueLight", knxUltimateHueLight);
 };

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "2.4.28",
+  "version": "2.5.1",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",