node-red-contrib-knx-ultimate 2.4.12 → 2.4.13

package/CHANGELOG.md

@@ -6,13 +6,15 @@
 
 # CHANGELOG
 
-**Version 2.4.12** - April 2024<br/>
+**Version 2.4.13** - April 2024<br/>
 - Warning: this version uses the Node-Red plugin system; the  Node-Red version must be **equals or major than 3.1.1**<br/>
 - NEW: Home Assistant translator node: translates the HA input msg, to a KNX value. Comes with a built-in translation table, that's user editable.<br/>
 - NEW: HUE Contact Sensor node.<br/>
+- NEW: You can now get a list of all node's GA, to paste it into your KNX/IP routing table list. (See in the Gateway config window, TAB Utility.<br/>
 - Updated KNX-Ultimate device node help.<br/>
 - Minor KNX-Ultimate device node UI changes.<br/>
 
+
 **Version 2.4.9** - March 2024<br/>
 - WARNING: this version uses the Node-Red plugin system; the  Node-Red version must be **equals or major than 3.1.1**<br/>
 - Fixed [this](https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/338).<br/>

package/KNXEngine/src/dptlib/index.js

@@ -161,13 +161,17 @@ dpts.fromBuffer = function (buf, dpt) {
   //  knxLog.get().trace('generic fromBuffer buf=%j, value=%j', buf, value);
   return value;
 };
-
 function cloneDpt(d) {
   let result = {};
-  result = JSON.parse(JSON.stringify(d));
-  result.fromBuffer = d.fromBuffer;
-  result.formatAPDU = d.formatAPDU;
-  return result;
+  try {
+    result = JSON.parse(JSON.stringify(d));
+    result.fromBuffer = d.fromBuffer;
+    result.formatAPDU = d.formatAPDU;
+    return result;
+  } catch (error) {
+
+  }
+
 }
 
 module.exports = dpts;

package/nodes/knxUltimate-config.html

@@ -122,10 +122,25 @@
 
             var sRetDebugText = "";
             $("#getinfocam").click(function () {
+                sRetDebugText = "";
                 $("#divDebugText").show();
                 for (const [key, value] of Object.entries(node)) {
                     sRetDebugText += (`-> ${key}: ${value}\r`);
                 }
+                sRetDebugText = 'Open a new github issue and paste this text into it. https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/new?assignees=Supergiovane&labels=&template=bug_report.md&title=KNXDebugText\r\r' + sRetDebugText;
+                $("#debugText").val(sRetDebugText); // Store the config-node);
+            });
+            $("#getallgaused").click(function () {
+                sRetDebugText = "";
+                $("#divDebugText").show();
+                let aFound = [];
+                RED.nodes.eachNode(function (node) {
+                    if (!aFound.includes(node.topic)) {
+                        aFound.push(node.topic);
+                        sRetDebugText += node.topic + "\r"
+                    }
+                });
+                sRetDebugText = 'Copy these group addresses in your routing table list of your KNX/IP router.\r' + sRetDebugText;
                 $("#debugText").val(sRetDebugText); // Store the config-node);
             });
 
@@ -265,7 +280,7 @@
         <li><a href="#tabs-1"><i class="fa fa-list-ol"></i> Configuration</a></li>
         <li><a href="#tabs-2"><i class="fa fa-braille"></i> Advanced</a></li>
         <li><a href="#tabs-3"><i class="fa fa-code"></i> ETS file import</a></li>
-        <li><a href="#tabs-4"><i class="fa fa-key"></i> Maintenance</a></li>
+        <li><a href="#tabs-4"><i class="fa fa-key"></i> Utility</a></li>
     </ul>
     <div id="tabs-1">
         <p>
@@ -359,8 +374,6 @@
             </div>
         </p>
     </div>
-
-
     <div id="tabs-3">
         <p>
             <div id="etsCSVListBox">
@@ -407,10 +420,12 @@
                 <input type="button" id="getinfocam" class="ui-button ui-corner-all ui-widget"
                     style="background-color:#AEE1FF;width:150px" value="Read">
             </div>
-            <div class="form-row" id="divDebugText" style="display: none;">
-                Copy this text, open a new github issue <a target="_blank"
-                    href="https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/new?assignees=Supergiovane&labels=&template=bug_report.md&title=KNXDebugText">
-                    ->by CLICKING HERE</a>, or paste it to an already open issue.
+            <div class="form-row">
+                <label style="width:300px"><i class="fa fa-sign-in"></i> Get all used GA for KNX routing filter</label>
+                <input type="button" id="getallgaused" class="ui-button ui-corner-all ui-widget"
+                    style="background-color:#AEE1FF;width:150px" value="Read">
+            </div>
+            <div class="form-row" id="divDebugText" style="display: none;">                
                 <textarea rows="10" id="debugText" style="width:100%"></textarea>
             </div>
         </p>
@@ -459,10 +474,11 @@
 
 <br/>
 
-**Maintenance**
+**Utility**
 |Property|Description|
 |--|--|
 | Gather debug info for troubleshoot | Please click the button and add it to the gitHub issue you want to open, it will help me a lot to helping you. |
+| Get all used GA for KNX routing filter | Press READ to retrieve a plain text list of all group address belonging to this gateway, that has been used in the flows. You can use this list to populate your KNX/IP router filter table. |
 
 <br/>
 

package/nodes/knxUltimateHueContactSensor.html

@@ -236,7 +236,7 @@
 
   |Property|Description|
   |--|--|
-  | Contact | As soon as a contact sensor is being opene/closed, a *true* KNX value is sent to this group address, otherwise *false* is sent. |
+  | Contact | As soon as a contact sensor is being open/closed, a *true* KNX value is sent to this group address, otherwise *false* is sent. |
 
   ### Outputs
 

package/nodes/knxUltimateHueLight.js

@@ -74,7 +74,12 @@ module.exports = function (RED) {
         config.colorAtSwitchOnDayTime = { kelvin: 3000, brightness: 100 };
       }
     } else {
-      config.colorAtSwitchOnDayTime = JSON.parse(config.colorAtSwitchOnDayTime);
+      try {
+        config.colorAtSwitchOnDayTime = JSON.parse(config.colorAtSwitchOnDayTime);
+      } catch (error) {
+        RED.log.error(`knxUltimateHueLight:  config.colorAtSwitchOnDayTime = JSON.parse(config.colorAtSwitchOnDayTime): ${error.message} : ${error.stack || ""} `);
+        config.colorAtSwitchOnDayTime = "";
+      }
     }
     // Same thing, but with night color
     if (config.colorAtSwitchOnNightTime.indexOf("#") !== -1) {
@@ -85,7 +90,13 @@ module.exports = function (RED) {
         config.colorAtSwitchOnNightTime = { kelvin: 2700, brightness: 20 };
       }
     } else {
-      config.colorAtSwitchOnNightTime = JSON.parse(config.colorAtSwitchOnNightTime);
+      try {
+        config.colorAtSwitchOnNightTime = JSON.parse(config.colorAtSwitchOnNightTime);
+      } catch (error) {
+        RED.log.error(`knxUltimateHueLight:  config.colorAtSwitchOnDayTime = JSON.parse(config.colorAtSwitchOnNightTime): ${error.message} : ${error.stack || ""} `);
+        config.colorAtSwitchOnNightTime = "";
+      }
+
     }
 
     // Used to call the status update from the config node.

package/nodes/utils/http.js

@@ -28,14 +28,18 @@ module.exports.use = (config) => {
                     } else {
                         // log.trace('http data ' + data);
                         if (res.statusCode >= 100 && res.statusCode < 400) {
-                            let result = JSON.parse(data);
-                            if (result.errors && result.errors.length > 0) {
-                                reject(new Error("The response for " + opt.url + " returned errors " + JSON.stringify(result.errors)));
+                            try {
+                                let result = JSON.parse(data);
+                                if (result.errors && result.errors.length > 0) {
+                                    reject(new Error("The response for " + opt.url + " returned errors " + JSON.stringify(result.errors)));
+                                }
+                                if (!result.data) {
+                                    reject(new Error("Unexpected result with no data. " + JSON.stringify(result)));
+                                }
+                                resolve(result.data);
+                            } catch (error) {
+                                RED.log.error(`utils.https: config.http.call: let result = JSON.parse(data); =: ${error.message} : ${error.stack || ""} `);
                             }
-                            if (!result.data) {
-                                reject(new Error("Unexpected result with no data. " + JSON.stringify(result)));
-                            }
-                            resolve(result.data);
                         } else {
                             reject(new Error("Error response for " + opt.url + " with status " + res.statusCode + " " + res.statusMessage));
                         }

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "2.4.12",
+  "version": "2.4.13",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",