node-red-contrib-knx-ultimate 2.2.39 → 2.3.0

package/CHANGELOG.md

@@ -6,6 +6,12 @@
 
 # CHANGELOG
 
+**Version 2.3.0** - Jan 2024<br/>
+- HUE Light: partially rewrote code to cloneDeep(oHUEDevice) not to duplicate the brightness status of a single ligh, at node-red restart. https://github.com/Supergiovane/node-red-contrib-knx-ultimate/issues/312#issue-2064480332 <br/>
+
+**Version 2.2.40** - Jan 2024<br/>
+- HUE Light: fixed an issue with initial status read from HUE Bridge (on/off status was incorrectly set).<br/>
+
 **Version 2.2.39** - Jan 2024<br/>
 - Fixed DPT 9.001 issue when sending numbers having > 2 decimals.<br/>
 - HUE Light node: fixed an issue in dimming, when the minimum dim level is set to the minimum level defined by the HUE bridge.<br/>

package/nodes/hue-config.js

@@ -7,6 +7,7 @@ const dptlib = require("../KNXEngine/src/dptlib");
 const HueClass = require("./utils/hueEngine").classHUE;
 const loggerEngine = require("./utils/sysLogger");
 const hueColorConverter = require("./utils/hueColorConverter");
+const cloneDeep = require("lodash/cloneDeep");
 
 function getRandomIntInclusive(min, max) {
   min = Math.ceil(min);
@@ -206,7 +207,7 @@ module.exports = (RED) => {
                   shape: "ring",
                   text: "Ready :-)",
                 });
-                _node.currentHUEDevice = oHUEDevice;
+                _node.currentHUEDevice = cloneDeep(oHUEDevice);
                 if (_node.initializingAtStart === true) _node.handleSendHUE(oHUEDevice);
               }
             }
@@ -417,7 +418,7 @@ module.exports = (RED) => {
         if (node.hueAllResources !== undefined && node.hueAllResources !== null && _Node.initializingAtStart === true) {
           const oHUEDevice = node.hueAllResources.filter((a) => a.id === _Node.hueDevice)[0];
           if (oHUEDevice !== undefined) {
-            _Node.currentHUEDevice = oHUEDevice;
+            _Node.currentHUEDevice = cloneDeep(oHUEDevice);
             _Node.handleSendHUE(oHUEDevice);
             // Add _Node to the clients array
             _Node.setNodeStatusHue({

package/nodes/knxUltimateGlobalContext.js

@@ -87,14 +87,14 @@ module.exports = function (RED) {
         node.context().global.set(node.name + '_WRITE', [], node.contextStorage) // Delete the var
         for (let index = 0; index < oContext.length; index++) {
           const element = oContext[index]
-          if (!element.hasOwnProperty('address')) {
+          if (element.hasOwnProperty('address') === false) {
             node.setNodeStatus({ fill: 'RED', shape: 'dot', text: 'NO Group Address set', payload: '', GA: '', dpt: '', devicename: '' })
             RED.log.error('knxUltimateGlobalContext: No group address set in node ' + node.id)
             oContext = null // 21/03/2022
             node.goTimerGo()
             return
           }
-          if (!element.hasOwnProperty('payload')) {
+          if (element.hasOwnProperty('payload') === false) {
             node.setNodeStatus({ fill: 'RED', shape: 'dot', text: 'NO payload set', payload: '', GA: '', dpt: '', devicename: '' })
             RED.log.error('knxUltimateGlobalContext: No payload set for address ' + element.address + ' in node ' + node.id)
             oContext = null // 21/03/2022
@@ -103,7 +103,7 @@ module.exports = function (RED) {
           }
 
           // 13/09/2021 retrieve the datapoint if not specified
-          if (!element.hasOwnProperty('dpt') || element.dpt === undefined || element.dpt === '') {
+          if (element.hasOwnProperty('dpt') === false || element.dpt === undefined || element.dpt === '') {
             try {
               const sDPT = node.server.csv.find(item => item.ga === element.address).dpt
               element.dpt = sDPT

package/nodes/knxUltimateHueLight.js

@@ -667,7 +667,7 @@ module.exports = function (RED) {
             // In case of switch off, set the dim to zero
             if (_event.on.on === false && (config.updateKNXBrightnessStatusOnHUEOnOff === undefined || config.updateKNXBrightnessStatusOnHUEOnOff === "onhueoff")) {
               node.updateKNXBrightnessState(0);
-              //node.currentHUEDevice.dimming.brightness = 0;
+              if (_event.dimming !== undefined) delete _event.dimming; // Remove event.dimming, because has beem handled by this function and i don't want the function below to take care of it.
             } else if (_event.on.on === true && node.currentHUEDevice.on.on === false) {
               // Turn on always update the dimming KNX Status value as well.
               let brightVal = 50;
@@ -689,7 +689,7 @@ module.exports = function (RED) {
             if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && _event.dimming.brightness === 0) {
               // Do nothing, because the light is off and the dimming also is 0
             } else {
-              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (!_event.on !== undefined || (_event.on !== undefined && _event.on.on === true))) node.updateKNXLightState(_event.dimming.brightness > 0);
+              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (_event.on === undefined || (_event.on !== undefined && _event.on.on === true))) node.updateKNXLightState(_event.dimming.brightness > 0);
               node.updateKNXBrightnessState(_event.dimming.brightness);
               // If the brightness reaches zero, the hue lamp "on" property must be set to zero as well
               if (_event.dimming.brightness === 0 && node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === true) {
@@ -715,7 +715,7 @@ module.exports = function (RED) {
           shape: "dot",
           text: `HUE->KNX error ${node.id} ${error.message}. Seee Log`,
         });
-        RED.log.error(`knxUltimateHueLight: node.handleSendHUE = (_event): ${error.message}`);
+        RED.log.error(`knxUltimateHueLight: node.handleSendHUE = (_event): ${error.stack}`);
       }
     };
 

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "2.2.39",
+  "version": "2.3.0",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",