node-red-contrib-knx-ultimate 2.2.39 → 2.2.40

package/CHANGELOG.md

@@ -6,6 +6,9 @@
 
 # CHANGELOG
 
+**Version 2.2.40** - Jan 2024<br/>
+- HUE Light: fixed an issue with initial status read from HUE Bridge (on/off status was incorrectly set).<br/>
+
 **Version 2.2.39** - Jan 2024<br/>
 - Fixed DPT 9.001 issue when sending numbers having > 2 decimals.<br/>
 - HUE Light node: fixed an issue in dimming, when the minimum dim level is set to the minimum level defined by the HUE bridge.<br/>

package/nodes/knxUltimateGlobalContext.js

@@ -87,14 +87,14 @@ module.exports = function (RED) {
         node.context().global.set(node.name + '_WRITE', [], node.contextStorage) // Delete the var
         for (let index = 0; index < oContext.length; index++) {
           const element = oContext[index]
-          if (!element.hasOwnProperty('address')) {
+          if (element.hasOwnProperty('address') === false) {
             node.setNodeStatus({ fill: 'RED', shape: 'dot', text: 'NO Group Address set', payload: '', GA: '', dpt: '', devicename: '' })
             RED.log.error('knxUltimateGlobalContext: No group address set in node ' + node.id)
             oContext = null // 21/03/2022
             node.goTimerGo()
             return
           }
-          if (!element.hasOwnProperty('payload')) {
+          if (element.hasOwnProperty('payload') === false) {
             node.setNodeStatus({ fill: 'RED', shape: 'dot', text: 'NO payload set', payload: '', GA: '', dpt: '', devicename: '' })
             RED.log.error('knxUltimateGlobalContext: No payload set for address ' + element.address + ' in node ' + node.id)
             oContext = null // 21/03/2022
@@ -103,7 +103,7 @@ module.exports = function (RED) {
           }
 
           // 13/09/2021 retrieve the datapoint if not specified
-          if (!element.hasOwnProperty('dpt') || element.dpt === undefined || element.dpt === '') {
+          if (element.hasOwnProperty('dpt') === false || element.dpt === undefined || element.dpt === '') {
             try {
               const sDPT = node.server.csv.find(item => item.ga === element.address).dpt
               element.dpt = sDPT

package/nodes/knxUltimateHueLight.js

@@ -689,7 +689,7 @@ module.exports = function (RED) {
             if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && _event.dimming.brightness === 0) {
               // Do nothing, because the light is off and the dimming also is 0
             } else {
-              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (!_event.on !== undefined || (_event.on !== undefined && _event.on.on === true))) node.updateKNXLightState(_event.dimming.brightness > 0);
+              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (_event.on === undefined || (_event.on !== undefined && _event.on.on === true))) node.updateKNXLightState(_event.dimming.brightness > 0);
               node.updateKNXBrightnessState(_event.dimming.brightness);
               // If the brightness reaches zero, the hue lamp "on" property must be set to zero as well
               if (_event.dimming.brightness === 0 && node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === true) {

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "2.2.39",
+  "version": "2.2.40",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",