node-red-contrib-knx-ultimate 2.2.38 → 2.2.39

package/CHANGELOG.md

@@ -6,8 +6,9 @@
 
 # CHANGELOG
 
-**Version 2.2.38** - December 2023<br/>
-- NEW: HUE Light Node: added support for the HUE SMART PLUG.<br/>
+**Version 2.2.39** - Jan 2024<br/>
+- Fixed DPT 9.001 issue when sending numbers having > 2 decimals.<br/>
+- HUE Light node: fixed an issue in dimming, when the minimum dim level is set to the minimum level defined by the HUE bridge.<br/>
 
 **Version 2.2.37** - December 2023<br/>
 - HUE Light Node: you can now set the DIM direction for tunable white lights. Fixed some issues as well.<br/>

package/KNXEngine/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 # CHANGELOG
 
+<p>
+<b>Version 1.0.43</b> - December 2023<br/>
+- Fixed DPT 9.001 issue when sending numberso having > 2 decimals.<br/>
+</p>
 <p>
 <b>Version 1.0.43</b> - October 2023<br/>
 - Added help description for DPT 3.001 DIMMING stop telegram.<br/>

package/KNXEngine/package.json

@@ -1,7 +1,7 @@
 {
   "name": "knxultimate",
   "description": "KNX IP protocol implementation for Node. This is the ENGINE of Node-Red KNX-Ultimate node.",
-  "version": "1.0.43",
+  "version": "1.0.44",
   "engines": {
     "node": ">=14"
   },

package/KNXEngine/src/dptlib/dpt9.js

@@ -38,6 +38,7 @@ exports.formatAPDU = function (value) {
   if (!isFinite(value)) {
     knxLog.get().warn('DPT9: cannot write non-numeric or undefined value')
   } else {
+    value = value.toFixed(2); // Fix issue with float having too many decimals.
     const arr = frexp(value)
     const mantissa = arr[0]; const exponent = arr[1]
     // find the minimum exponent that will upsize the normalized mantissa (0,5 to 1 range)

package/nodes/knxUltimateHueLight.js

@@ -502,15 +502,21 @@ module.exports = function (RED) {
         if (node.brightnessStep === null || node.brightnessStep === undefined) node.brightnessStep = node.currentHUEDevice.dimming.brightness || 50;
         node.brightnessStep = Math.ceil(Number(node.brightnessStep));
 
-        // Set the speed
-        _dimSpeedInMillisecs /= numStep;
-        numStep = Math.round((config.maxDimLevelLight - config.minDimLevelLight) / numStep, 0);
-
         // We have also minDimLevelLight and maxDimLevelLight to take care of.
-        let minDimLevelLight = config.minDimLevelLight === undefined ? 10 : Number(config.minDimLevelLight);
-        if (config.minDimLevelLight === "useHueLightLevel" && node.currentHUEDevice.dimming.min_dim_level === undefined) minDimLevelLight = 10;
+        let minDimLevelLight;
+        if (config.minDimLevelLight === undefined) {
+          minDimLevelLight = 10;
+        } else if (config.minDimLevelLight === "useHueLightLevel") {
+          minDimLevelLight = node.currentHUEDevice.dimming.min_dim_level === undefined ? 10 : node.currentHUEDevice.dimming.min_dim_level;
+        } else {
+          minDimLevelLight = Number(config.minDimLevelLight);
+        }
         const maxDimLevelLight = config.maxDimLevelLight === undefined ? 100 : Number(config.maxDimLevelLight);
 
+        // Set the speed
+        _dimSpeedInMillisecs /= numStep;
+        numStep = Math.round((maxDimLevelLight - minDimLevelLight) / numStep, 0);
+
         if (_KNXbrightness_Direction > 0 && _KNXaction === 1) {
           // DIM UP
           if (node.timerStepDim !== undefined) clearInterval(node.timerStepDim);

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "2.2.38",
+  "version": "2.2.39",
   "description": "Control your KNX intallation via Node-Red! A bunch of KNX nodes, with integrated Philips HUE control and ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "binary-parser": "2.2.1",