node-red-contrib-knx-ultimate 2.2.3 → 2.2.5

package/nodes/knxUltimateAlerter.js

@@ -54,233 +54,233 @@ module.exports = function (RED) {
         dpt = (typeof dpt === 'undefined' || dpt == '') ? '' : ' DPT' + dpt
         payload = typeof payload === 'object' ? JSON.stringify(payload) : payload
         node.status({ fill, shape, text: GA + payload + (node.listenallga === true ? ' ' + devicename : '') + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ' ' + text })
-        } catch (error) {
-        }
+      } catch (error) {
       }
+    }
 
     // Used to call the status update from the config node.
     node.setLocalStatus = ({ fill, shape, text, payload, GA, dpt, devicename }) => {
-        const dDate = new Date()
-        // 30/08/2019 Display only the things selected in the config
-        GA = (typeof GA === 'undefined' || GA == '') ? '' : '(' + GA + ') '
-        devicename = devicename || ''
-        dpt = (typeof dpt === 'undefined' || dpt == '') ? '' : ' DPT' + dpt
-        try {
-          node.status({ fill, shape, text: GA + payload + (node.listenallga === true ? ' ' + devicename : '') + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ' ' + text })
-        } catch (error) {
-        }
+      const dDate = new Date()
+      // 30/08/2019 Display only the things selected in the config
+      GA = (typeof GA === 'undefined' || GA == '') ? '' : '(' + GA + ') '
+      devicename = devicename || ''
+      dpt = (typeof dpt === 'undefined' || dpt == '') ? '' : ' DPT' + dpt
+      try {
+        node.status({ fill, shape, text: GA + payload + (node.listenallga === true ? ' ' + devicename : '') + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ' ' + text })
+      } catch (error) {
       }
+    }
 
-      // This function is called by the knx-ultimate config node, to output a msg.payload.
-      node.handleSend = msg => {
-        try {
-          if (!msg.knx.dpt.startsWith('1.')) return
-        } catch (error) {
-          return
-        }
-        let bFound = false // 24/04/2021 true if the cycle below found a match, otherwise false
+    // This function is called by the knx-ultimate config node, to output a msg.payload.
+    node.handleSend = msg => {
+      try {
+        if (!msg.knx.dpt.startsWith('1.')) return
+      } catch (error) {
+        return
+      }
+      let bFound = false // 24/04/2021 true if the cycle below found a match, otherwise false
 
-        // Update the node.rules with the values taken from the file, if any, otherwise leave the default value
-        for (let i = 0; i < node.rules.length; i++) {
-          // rule is { topic: rowRuleTopic, devicename: rowRuleDeviceName, longdevicename: rowRuleLongDeviceName}
-          var rule = node.rules[i]
-          if (msg.topic === rule.topic) {
-            if (msg.payload == true) {
-              bFound = true
-              // Add the device to the array of alertedDevices
-              const oTrovato = node.alertedDevices.find(a => a.topic === rule.topic)
-              if (oTrovato === undefined) {
-                node.alertedDevices.unshift({ topic: rule.topic, devicename: rule.devicename, longdevicename: rule.longdevicename }) // Add to the begin of array
-                if (node.whentostart === 'ifnewalert') node.send([null, null, node.getThirdPinMSG()])
-              }
-              node.setLocalStatus({ fill: 'red', shape: 'dot', text: 'Alert', payload: '', GA: msg.topic, dpt: '', devicename: rule.devicename })
-            } else {
-              // Remove the device from the array
-              node.alertedDevices = node.alertedDevices.filter(a => a.topic !== msg.topic)
-              node.setLocalStatus({ fill: 'green', shape: 'dot', text: 'Restore', payload: '', GA: msg.topic, dpt: '', devicename: rule.devicename })
+      // Update the node.rules with the values taken from the file, if any, otherwise leave the default value
+      for (let i = 0; i < node.rules.length; i++) {
+        // rule is { topic: rowRuleTopic, devicename: rowRuleDeviceName, longdevicename: rowRuleLongDeviceName}
+        var rule = node.rules[i]
+        if (msg.topic === rule.topic) {
+          if (msg.payload == true) {
+            bFound = true
+            // Add the device to the array of alertedDevices
+            const oTrovato = node.alertedDevices.find(a => a.topic === rule.topic)
+            if (oTrovato === undefined) {
+              node.alertedDevices.unshift({ topic: rule.topic, devicename: rule.devicename, longdevicename: rule.longdevicename }) // Add to the begin of array
+              if (node.whentostart === 'ifnewalert') node.send([null, null, node.getThirdPinMSG()])
             }
+            node.setLocalStatus({ fill: 'red', shape: 'dot', text: 'Alert', payload: '', GA: msg.topic, dpt: '', devicename: rule.devicename })
+          } else {
+            // Remove the device from the array
+            node.alertedDevices = node.alertedDevices.filter(a => a.topic !== msg.topic)
+            node.setLocalStatus({ fill: 'green', shape: 'dot', text: 'Restore', payload: '', GA: msg.topic, dpt: '', devicename: rule.devicename })
           }
         }
-
-        // If there's some device to alert, stop current timer and restart
-        // This allow the last alerted device to be outputted immediately
-        if (bFound && node.whentostart === 'ifnewalert' && node.alertedDevices.length > 0) {
-          clearTimeout(node.timerSend)
-          // Send directly the second and third message PIN
-          node.send([null, node.getSecondPinMSG(), null])
-          node.curIndexAlertedDevice = 0 // Restart form the beginning
-          node.startTimer()
-        }
       }
 
-      // Get the msg to be outputted on second PIN
-      node.getSecondPinMSG = () => {
-        if (node.alertedDevices.length > 0) {
-          const msg = {}
-          let sRet = ''
-          let sRetLong = ''
-          let sTopic = ''
-          node.alertedDevices.forEach(function (item) {
-            sTopic += item.topic + ', '
-            if (item.devicename !== undefined && item.devicename !== '') sRet += item.devicename + ', '
-            if (item.longdevicename !== undefined && item.longdevicename !== '') sRetLong += item.longdevicename + ', '
-          })
-          sTopic = sTopic.slice(0, -2)
-          if (sRet.length > 2) sRet = sRet.slice(0, -2)
-          if (sRetLong.length > 2) sRetLong = sRetLong.slice(0, -2)
-          msg.topic = sTopic
-          msg.devicename = sRet
-          msg.longdevicename = sRetLong
-          msg.count = node.alertedDevices.length
-          msg.payload = true
-          return msg
-        }
+      // If there's some device to alert, stop current timer and restart
+      // This allow the last alerted device to be outputted immediately
+      if (bFound && node.whentostart === 'ifnewalert' && node.alertedDevices.length > 0) {
+        clearTimeout(node.timerSend)
+        // Send directly the second and third message PIN
+        node.send([null, node.getSecondPinMSG(), null])
+        node.curIndexAlertedDevice = 0 // Restart form the beginning
+        node.startTimer()
       }
+    }
 
-      // Get the msg to be outputted on third PIN
-      node.getThirdPinMSG = () => {
-        if (node.alertedDevices.length > 0) {
-          const msg = {}
-          let sRet = ''
-          let sRetLong = ''
-          let sTopic = ''
-          const item = node.alertedDevices[0] // Pick the last alerted device
-          sTopic = item.topic
-          if (item.devicename !== undefined && item.devicename !== '') sRet = item.devicename
-          if (item.longdevicename !== undefined && item.longdevicename !== '') sRetLong = item.longdevicename
-          msg.topic = sTopic
-          msg.devicename = sRet
-          msg.longdevicename = sRetLong
-          msg.count = node.alertedDevices.length
-          msg.payload = true
-          return msg
-        }
+    // Get the msg to be outputted on second PIN
+    node.getSecondPinMSG = () => {
+      if (node.alertedDevices.length > 0) {
+        const msg = {}
+        let sRet = ''
+        let sRetLong = ''
+        let sTopic = ''
+        node.alertedDevices.forEach(function (item) {
+          sTopic += item.topic + ', '
+          if (item.devicename !== undefined && item.devicename !== '') sRet += item.devicename + ', '
+          if (item.longdevicename !== undefined && item.longdevicename !== '') sRetLong += item.longdevicename + ', '
+        })
+        sTopic = sTopic.slice(0, -2)
+        if (sRet.length > 2) sRet = sRet.slice(0, -2)
+        if (sRetLong.length > 2) sRetLong = sRetLong.slice(0, -2)
+        msg.topic = sTopic
+        msg.devicename = sRet
+        msg.longdevicename = sRetLong
+        msg.count = node.alertedDevices.length
+        msg.payload = true
+        return msg
       }
+    }
 
-      // 24/04/2021 perform a read on all GA in the rule list. Called both from node.on("input") and knxUltimate-config
-      node.initialReadAllDevicesInRules = () => {
-        if (node.server) {
-          let grpaddr = ''
-          for (let i = 0; i < node.rules.length; i++) {
-            // rule is { topic: rowRuleTopic, devicename: rowRuleDeviceName, longdevicename: rowRuleLongDeviceName}
-            const rule = node.rules[i]
-            // READ: Send a Read request to the bus
-            grpaddr = rule.topic
-            try {
-              // Check if it's a group address
-              // const ret = Address.KNXAddress.createFromString(grpaddr, Address.KNXAddress.TYPE_GROUP)
-              node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'Read', payload: '', GA: grpaddr, dpt: '', devicename: rule.devicename })
-              node.server.writeQueueAdd({ grpaddr, payload: '', dpt: '', outputtype: 'read', nodecallerid: node.id })
-            } catch (error) {
-              node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'Not a KNX GA ' + error.message, payload: '', GA: grpaddr, dpt: '', devicename: rule.devicename })
-            }
-          }
-        } else {
-          node.setLocalStatus({ fill: 'red', shape: 'ring', text: 'No gateway selected. Unable to read from KNX bus', payload: '', GA: '', dpt: '', devicename: '' })
-        }
+    // Get the msg to be outputted on third PIN
+    node.getThirdPinMSG = () => {
+      if (node.alertedDevices.length > 0) {
+        const msg = {}
+        let sRet = ''
+        let sRetLong = ''
+        let sTopic = ''
+        const item = node.alertedDevices[0] // Pick the last alerted device
+        sTopic = item.topic
+        if (item.devicename !== undefined && item.devicename !== '') sRet = item.devicename
+        if (item.longdevicename !== undefined && item.longdevicename !== '') sRetLong = item.longdevicename
+        msg.topic = sTopic
+        msg.devicename = sRet
+        msg.longdevicename = sRetLong
+        msg.count = node.alertedDevices.length
+        msg.payload = true
+        return msg
       }
+    }
 
-      node.on('input', function (msg) {
-        if (typeof msg === 'undefined') return
-        if (msg.hasOwnProperty('start')) {
-          clearTimeout(node.timerSend)
-          node.curIndexAlertedDevice = 0 // Restart form the beginning
-          if (node.alertedDevices.length > 0) {
-            node.send([null, node.getSecondPinMSG(), node.getThirdPinMSG()])
-            node.startTimer()
-          } else {
-            // Nothing more to output
-            node.sendNoMoreDevices()
+    // 24/04/2021 perform a read on all GA in the rule list. Called both from node.on("input") and knxUltimate-config
+    node.initialReadAllDevicesInRules = () => {
+      if (node.server) {
+        let grpaddr = ''
+        for (let i = 0; i < node.rules.length; i++) {
+          // rule is { topic: rowRuleTopic, devicename: rowRuleDeviceName, longdevicename: rowRuleLongDeviceName}
+          const rule = node.rules[i]
+          // READ: Send a Read request to the bus
+          grpaddr = rule.topic
+          try {
+            // Check if it's a group address
+            // const ret = Address.KNXAddress.createFromString(grpaddr, Address.KNXAddress.TYPE_GROUP)
+            node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'Read', payload: '', GA: grpaddr, dpt: '', devicename: rule.devicename })
+            node.server.writeQueueAdd({ grpaddr, payload: '', dpt: '', outputtype: 'read', nodecallerid: node.id })
+          } catch (error) {
+            node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'Not a KNX GA ' + error.message, payload: '', GA: grpaddr, dpt: '', devicename: rule.devicename })
           }
-          return
-        }
-
-        // 24/04/2021 if payload is read or the output type is set to "read", do a read
-        if ((msg.hasOwnProperty('readstatus') && msg.readstatus === true)) {
-          node.initialReadAllDevicesInRules()
-          return
-        }
-
-        if (msg.topic === undefined) {
-          node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'ERROR: You must provide a msg.topic', payload: '', GA: '', dpt: '', devicename: '' })
-          return
         }
-        if (msg.payload === undefined) {
-          node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'ERROR: You must provide payload (true/false)', payload: '', GA: '', dpt: '', devicename: '' })
-          return
-        }
-        msg.knx = { dpt: '1.001' }
-        node.handleSend(msg)
-      })
+      } else {
+        node.setLocalStatus({ fill: 'red', shape: 'ring', text: 'No gateway selected. Unable to read from KNX bus', payload: '', GA: '', dpt: '', devicename: '' })
+      }
+    }
 
-      node.on('close', function (done) {
+    node.on('input', function (msg) {
+      if (typeof msg === 'undefined') return
+      if (msg.hasOwnProperty('start')) {
         clearTimeout(node.timerSend)
-        if (node.server) {
-          node.server.removeClient(node)
-        }
-        done()
-      })
-
-      node.handleTimer = () => {
+        node.curIndexAlertedDevice = 0 // Restart form the beginning
         if (node.alertedDevices.length > 0) {
-          const count = node.alertedDevices.length
-          if (node.curIndexAlertedDevice > count - 1) {
-            node.curIndexAlertedDevice = 0
-            if (node.whentostart === 'manualstart') {
-              node.curIndexAlertedDevice = 0 // Restart form the beginning
-              return
-            }
-          }
-          // Create output message
-          try {
-            const curDev = node.alertedDevices[node.curIndexAlertedDevice] // is { topic: rule.topic, devicename: rule.devicename }
-            const msg = {}
-            msg.topic = curDev.topic
-            msg.count = count
-            msg.devicename = curDev.devicename
-            msg.longdevicename = curDev.longdevicename
-            msg.payload = true
-            node.send([msg, null, null])
-          } catch (error) {
-          }
-          node.curIndexAlertedDevice += 1
-          // Restart timer
+          node.send([null, node.getSecondPinMSG(), node.getThirdPinMSG()])
           node.startTimer()
         } else {
           // Nothing more to output
           node.sendNoMoreDevices()
         }
+        return
       }
 
-      // Start timer
-      node.startTimer = () => {
-        clearTimeout(node.timerSend)
-        node.timerSend = setTimeout(() => {
-          node.handleTimer()
-        }, node.timerinterval * 1000)
+      // 24/04/2021 if payload is read or the Telegram type is set to "read", do a read
+      if ((msg.hasOwnProperty('readstatus') && msg.readstatus === true)) {
+        node.initialReadAllDevicesInRules()
+        return
       }
 
-      // As soon as there no more devices..
-      node.sendNoMoreDevices = () => {
-        const msg = {}
-        msg.topic = ''
-        msg.count = 0
-        msg.devicename = ''
-        msg.longdevicename = ''
-        msg.payload = false
-        node.send([msg, msg, msg])
+      if (msg.topic === undefined) {
+        node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'ERROR: You must provide a msg.topic', payload: '', GA: '', dpt: '', devicename: '' })
+        return
       }
+      if (msg.payload === undefined) {
+        node.setLocalStatus({ fill: 'grey', shape: 'dot', text: 'ERROR: You must provide payload (true/false)', payload: '', GA: '', dpt: '', devicename: '' })
+        return
+      }
+      msg.knx = { dpt: '1.001' }
+      node.handleSend(msg)
+    })
 
-      // Init
-      node.sendNoMoreDevices()
-
-      // On each deploy, unsubscribe+resubscribe
+    node.on('close', function (done) {
+      clearTimeout(node.timerSend)
       if (node.server) {
         node.server.removeClient(node)
-        if (node.topic !== '' || node.topicSave !== '') {
-          node.server.addClient(node)
+      }
+      done()
+    })
+
+    node.handleTimer = () => {
+      if (node.alertedDevices.length > 0) {
+        const count = node.alertedDevices.length
+        if (node.curIndexAlertedDevice > count - 1) {
+          node.curIndexAlertedDevice = 0
+          if (node.whentostart === 'manualstart') {
+            node.curIndexAlertedDevice = 0 // Restart form the beginning
+            return
+          }
+        }
+        // Create output message
+        try {
+          const curDev = node.alertedDevices[node.curIndexAlertedDevice] // is { topic: rule.topic, devicename: rule.devicename }
+          const msg = {}
+          msg.topic = curDev.topic
+          msg.count = count
+          msg.devicename = curDev.devicename
+          msg.longdevicename = curDev.longdevicename
+          msg.payload = true
+          node.send([msg, null, null])
+        } catch (error) {
         }
+        node.curIndexAlertedDevice += 1
+        // Restart timer
+        node.startTimer()
+      } else {
+        // Nothing more to output
+        node.sendNoMoreDevices()
+      }
+    }
+
+    // Start timer
+    node.startTimer = () => {
+      clearTimeout(node.timerSend)
+      node.timerSend = setTimeout(() => {
+        node.handleTimer()
+      }, node.timerinterval * 1000)
+    }
+
+    // As soon as there no more devices..
+    node.sendNoMoreDevices = () => {
+      const msg = {}
+      msg.topic = ''
+      msg.count = 0
+      msg.devicename = ''
+      msg.longdevicename = ''
+      msg.payload = false
+      node.send([msg, msg, msg])
+    }
+
+    // Init
+    node.sendNoMoreDevices()
+
+    // On each deploy, unsubscribe+resubscribe
+    if (node.server) {
+      node.server.removeClient(node)
+      if (node.topic !== '' || node.topicSave !== '') {
+        node.server.addClient(node)
       }
     }
-    RED.nodes.registerType('knxUltimateAlerter', knxUltimateAlerter)
   }
+  RED.nodes.registerType('knxUltimateAlerter', knxUltimateAlerter)
+}

package/nodes/knxUltimateHueBattery.js

@@ -22,6 +22,7 @@ module.exports = function (RED) {
     node.formatmultiplyvalue = 1;
     node.formatnegativevalue = 'leave';
     node.formatdecimalsvalue = 2;
+    node.hueDevice = config.hueDevice;
 
     // Used to call the status update from the config node.
     node.setNodeStatus = ({
@@ -33,7 +34,7 @@ module.exports = function (RED) {
     node.setNodeStatusHue = ({
       fill, shape, text, payload,
     }) => {
-      if (payload === undefined) return;
+      if (payload === undefined) payload = '';
       const dDate = new Date();
       payload = typeof payload === 'object' ? JSON.stringify(payload) : payload.toString();
       node.status({ fill, shape, text: `${text} ${payload} (${dDate.getDate()}, ${dDate.toLocaleTimeString()})` });
@@ -83,11 +84,7 @@ module.exports = function (RED) {
     }
     if (node.serverHue) {
       node.serverHue.removeClient(node);
-      // I must get the object, to store read the battery status
-      // I queue the state request, by passing the callback to call whenever the HUE bridge send me the light status async
-      if (node.serverHue !== null && node.serverHue.hueManager !== null) {
-        node.serverHue.addClient(node);
-      }
+      node.serverHue.addClient(node);
     }
 
     node.on('input', (msg) => {

package/nodes/knxUltimateHueButton.js

@@ -26,6 +26,7 @@ module.exports = function (RED) {
     node.formatdecimalsvalue = 2;
     node.short_releaseValue = false;
     node.isTimerDimStopRunning = false;
+    node.hueDevice = config.hueDevice;
 
     // Used to call the status update from the config node.
     node.setNodeStatus = ({
@@ -37,7 +38,7 @@ module.exports = function (RED) {
     node.setNodeStatusHue = ({
       fill, shape, text, payload,
     }) => {
-      if (payload === undefined) return;
+      if (payload === undefined) payload = '';
       const dDate = new Date();
       payload = typeof payload === 'object' ? JSON.stringify(payload) : payload.toString();
       node.status({ fill, shape, text: `${text} ${payload} (${dDate.getDate()}, ${dDate.toLocaleTimeString()})` });

package/nodes/knxUltimateHueLight.html

@@ -1,4 +1,24 @@
 <script type="text/javascript">
+  RED.events.on('nodes:add', function (node) {
+    if (node.type === 'uibuilder') {
+      // Keep a list of uib nodes in the editor
+      // may be different to the deployed list
+      editorInstances[node.id] = node.url
+      // -- IF uibuilderInstances <> editorInstances THEN there are undeployed instances. --
+    }
+  })
+  RED.events.on('nodes:change', function (node) {
+    if (node.type === 'uibuilder') {
+      mylog('nodes:change:', node)
+      editorInstances[node.id] = node.url
+    }
+  })
+  RED.events.on('nodes:remove', function (node) {
+    if (node.type === 'uibuilder') {
+      mylog('>> nodes:remove >>', node)
+      delete editorInstances[node.id]
+    }
+  })
   RED.nodes.registerType("knxUltimateHueLight", {
     category: "KNX Ultimate",
     color: "#C0C7E9",
@@ -486,15 +506,15 @@
           $("#getColorAtSwitchOnNightTimeButton").text("Get current");
         });
       });
-      
+
       // Fill options for minDimLevel and maxDimLevel
       for (let index = 0; index <= 90; index++) {
-        if (index === 0){
+        if (index === 0) {
           $("#node-input-minDimLevelLight").append($("<option>").val(index).text(index.toString() + "% (Switch Off)"));
-        }else{
+        } else {
           $("#node-input-minDimLevelLight").append($("<option>").val(index).text(index.toString() + "%"));
         }
-        
+
       }
       $("#node-input-minDimLevelLight").val(node.minDimLevelLight);
       for (let index = 100; index >= 10; index--) {

package/nodes/knxUltimateHueLight.js

@@ -41,22 +41,13 @@ module.exports = function (RED) {
       fill, shape, text, payload,
     }) => { };
     // Used to call the status update from the HUE config node.
-    node.setNodeStatusHue = ({
-      fill, shape, text, payload,
-    }) => {
-      if (payload === undefined) return;
+    node.setNodeStatusHue = ({ fill, shape, text, payload }) => {
+      if (payload === undefined) payload = '';
       const dDate = new Date();
       payload = typeof payload === "object" ? JSON.stringify(payload) : payload.toString();
       node.status({ fill, shape, text: `${text} ${payload} (${dDate.getDate()}, ${dDate.toLocaleTimeString()})` });
     };
 
-    node.setNodeStatusHue({
-      fill: "grey",
-      shape: "ring",
-      text: "Connecting to the Bridge...",
-      payload: "",
-    });
-
     function getRandomIntInclusive(min, max) {
       min = Math.ceil(min);
       max = Math.floor(max);
@@ -69,7 +60,7 @@ module.exports = function (RED) {
         node.setNodeStatusHue({
           fill: "red",
           shape: "ring",
-          text: "Rejected KNX message. I'm connecting to the Bridge...",
+          text: "Currently not ready.",
           payload: "",
         });
         return;
@@ -448,26 +439,32 @@ module.exports = function (RED) {
             node.currentHUEDevice.on.on = _event.on.on;
           }
           if (_event.hasOwnProperty("color")) {
-            node.updateKNXLightColorState(_event.color);
-            node.currentHUEDevice.color = _event.color;
+            if (_event.type !== 'grouped_light') {
+              // In grouped lights, there is group color, but each light has it's own color.
+              node.updateKNXLightColorState(_event.color);
+              node.currentHUEDevice.color = _event.color;
+            }
           }
           if (_event.hasOwnProperty("dimming") && _event.dimming.brightness !== undefined) {
             // Every once on a time, the light transmit the brightness value of 0.39.
             // To avoid wrongly turn light state on, exit
             if (_event.dimming.brightness < 1) _event.dimming.brightness = 0;
-            if (node.currentHUEDevice.hasOwnProperty("on") && node.currentHUEDevice.on.on === false && _event.dimming.brightness === 0) return;
-            if (node.currentHUEDevice.on.on === false) node.updateKNXLightState(_event.dimming.brightness > 0);
-            node.updateKNXBrightnessState(_event.dimming.brightness);
-            // If the brightness reaches zero, the hue lamp "on" property must be set to zero as well
-            if (_event.dimming.brightness === 0) {
-              node.serverHue.hueManager.writeHueQueueAdd(
-                node.hueDevice,
-                { on: { on: false } },
-                node.isGrouped_light === false ? "setLight" : "setGroupedLight",
-              );
-              node.currentHUEDevice.on.on = false;
+            if (node.currentHUEDevice.hasOwnProperty("on") && node.currentHUEDevice.on.on === false && _event.dimming.brightness === 0) {
+              // Do nothing, because the light is off and the dimming also is 0
+            } else {
+              if (node.currentHUEDevice.on.on === false) node.updateKNXLightState(_event.dimming.brightness > 0);
+              node.updateKNXBrightnessState(_event.dimming.brightness);
+              // If the brightness reaches zero, the hue lamp "on" property must be set to zero as well
+              if (_event.dimming.brightness === 0) {
+                node.serverHue.hueManager.writeHueQueueAdd(
+                  node.hueDevice,
+                  { on: { on: false } },
+                  node.isGrouped_light === false ? "setLight" : "setGroupedLight",
+                );
+                node.currentHUEDevice.on.on = false;
+              }
+              node.currentHUEDevice.dimming.brightness = _event.dimming.brightness;
             }
-            node.currentHUEDevice.dimming.brightness = _event.dimming.brightness;
           }
           if (_event.hasOwnProperty("color_temperature") && _event.color_temperature.mirek !== undefined) {
             node.updateKNXLightHSVState(_event.color_temperature.mirek);
@@ -615,6 +612,8 @@ module.exports = function (RED) {
       }
     };
 
+
+
     // On each deploy, unsubscribe+resubscribe
     if (node.server) {
       node.server.removeClient(node);
@@ -622,13 +621,7 @@ module.exports = function (RED) {
     }
     if (node.serverHue) {
       node.serverHue.removeClient(node);
-      if (node.serverHue !== null && node.serverHue.hueManager !== null) {
-        try {
-          node.serverHue.addClient(node);
-        } catch (err) {
-          RED.log.error(`Errore knxUltimateHueLight node.currentHUEDevice ${err.message}`);
-        }
-      }
+      node.serverHue.addClient(node);
     }
 
     node.on("input", (msg) => { });

package/nodes/knxUltimateHueLightSensor.js

@@ -22,6 +22,7 @@ module.exports = function (RED) {
     node.formatmultiplyvalue = 1;
     node.formatnegativevalue = 'leave';
     node.formatdecimalsvalue = 2;
+    node.hueDevice = config.hueDevice;
 
     // Used to call the status update from the config node.
     node.setNodeStatus = ({ fill, shape, text, payload }) => {
@@ -29,7 +30,7 @@ module.exports = function (RED) {
     };
     // Used to call the status update from the HUE config node.
     node.setNodeStatusHue = ({ fill, shape, text, payload }) => {
-      if (payload === undefined) return;
+      if (payload === undefined) payload = '';
       const dDate = new Date();
       payload = typeof payload === 'object' ? JSON.stringify(payload) : payload.toString();
       node.status({ fill, shape, text: text + ' ' + payload + ' (' + dDate.getDate() + ', ' + dDate.toLocaleTimeString() + ')' });
@@ -76,11 +77,7 @@ module.exports = function (RED) {
     }
     if (node.serverHue) {
       node.serverHue.removeClient(node);
-      // I must get the object, to store read the status
-      // I queue the state request, by passing the callback to call whenever the HUE bridge send me the light status async
-      if (node.serverHue !== null && node.serverHue.hueManager !== null) {
-        node.serverHue.addClient(node);
-      }
+      node.serverHue.addClient(node);
     }
 
     node.on('input', function (msg) {