node-red-contrib-knx-ultimate 2.2.27 → 2.2.29

package/CHANGELOG.md

@@ -6,6 +6,17 @@
 
 # CHANGELOG
 
+**Version 2.2.29** - November 2023<br/>
+This is an interim version, to quick fix some issues. Please report any issue with HUE Nodes, on gitHub.<br/>
+- HUE Light: fixed an issue causing the node status to signal an error. Filtered the groupvalue_read from imbound KNX messages.<br/>
+- WARNING: the new HUE Light options are to be considered **BETA (= in testing with user feedback)**.<br/>
+
+**Version 2.2.28** - November 2023<br/>
+This is an interim version, to quick fix some issues. Please report any issue with HUE Nodes, on gitHub.<br/>
+- HUE Light: fixed an issue where dimming down with the light switched off, causes the brightness status to jump to 100%, thus the light remains off.<br/>
+- HUE Light: Fixed some errors, if all devices belonging to a group, have only the dimming capability.<br/>
+- WARNING: the new HUE Light options are to be considered **BETA (= in testing with user feedback)**.<br/>
+
 **Version 2.2.27** - November 2023<br/>
 This is an interim version, to quick fix some issues. Please report any issue with HUE Nodes, on gitHub.<br/>
 - HUE Light: the UI now changes, to adapt to lamp type.<br/>

package/nodes/hue-config.js

@@ -258,6 +258,7 @@ module.exports = (RED) => {
         } else {
           allResources = node.hueAllResources.filter((a) => a.type === _rtype);
         }
+        if (allResources === null) return;
         for (let index = 0; index < allResources.length; index++) {
           const resource = allResources[index];
           // Get the owner
@@ -267,15 +268,17 @@ module.exports = (RED) => {
             if (_rtype === "light" || _rtype === "grouped_light") {
               // It's a service, having a owner
               const owners = node.hueAllResources.filter((a) => a.id === resource.owner.rid);
-              for (let index = 0; index < owners.length; index++) {
-                const owner = owners[index];
-                if (owner.type === "bridge_home") {
-                  resourceName += "ALL GROUPS and ";
-                } else {
-                  resourceName += `${owner.metadata.name} and `;
-                  // const room = node.hueAllRooms.find((child) => child.children.find((a) => a.rid === owner.id));
-                  // sRoom += room !== undefined ? `${room.metadata.name} + ` : " + ";
-                  sType += `${capStr(owner.type)} + `;
+              if (owners !== null) {
+                for (let index = 0; index < owners.length; index++) {
+                  const owner = owners[index];
+                  if (owner.type === "bridge_home") {
+                    resourceName += "ALL GROUPS and ";
+                  } else {
+                    resourceName += `${owner.metadata.name} and `;
+                    // const room = node.hueAllRooms.find((child) => child.children.find((a) => a.rid === owner.id));
+                    // sRoom += room !== undefined ? `${room.metadata.name} + ` : " + ";
+                    sType += `${capStr(owner.type)} + `;
+                  }
                 }
               }
               sType = sType.slice(0, -" + ".length);
@@ -497,7 +500,7 @@ module.exports = (RED) => {
         }
         res.json(oLight);
       } catch (error) {
-        if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error(`KNXUltimateHue: hueEngine: knxUltimateGetLightObject: error ${error.message}`);
+        if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error(`KNXUltimateHue: hueEngine: knxUltimateGetLightObject: error ${error.message}. Resources still loading. Try later.`);
         res.json({});
       }
     });

package/nodes/knxUltimateHueLight.js

@@ -93,251 +93,212 @@ module.exports = function (RED) {
         });
         return;
       }
-      let state = {};
-      try {
-        switch (msg.knx.destination) {
-          case config.GALightSwitch:
-            msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightSwitch));
-            if (msg.payload === true) {
-              let colorChoosen;
-              let temperatureChoosen;
-              let brightnessChoosen;
-              // The light must support the temperature (in this case, colorAtSwitchOnNightTime is an object {kelvin:xx, brightness:yy})
-              if (node.currentHUEDevice.color_temperature !== undefined) {
-                if (node.DayTime === true && config.specifySwitchOnBrightness === "temperature") {
-                  temperatureChoosen = config.colorAtSwitchOnDayTime.kelvin;
-                } else if (node.DayTime === false && config.enableDayNightLighting === "temperature") {
-                  temperatureChoosen = config.colorAtSwitchOnNightTime.kelvin;
+      if (msg.knx.event !== "GroupValue_Read" && node.currentHUEDevice !== undefined) {
+        let state = {};
+        try {
+          switch (msg.knx.destination) {
+            case config.GALightSwitch:
+              msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightSwitch));
+              if (msg.payload === true) {
+                let colorChoosen;
+                let temperatureChoosen;
+                let brightnessChoosen;
+                // The light must support the temperature (in this case, colorAtSwitchOnNightTime is an object {kelvin:xx, brightness:yy})
+                if (node.currentHUEDevice.color_temperature !== undefined) {
+                  if (node.DayTime === true && config.specifySwitchOnBrightness === "temperature") {
+                    temperatureChoosen = config.colorAtSwitchOnDayTime.kelvin;
+                  } else if (node.DayTime === false && config.enableDayNightLighting === "temperature") {
+                    temperatureChoosen = config.colorAtSwitchOnNightTime.kelvin;
+                  }
                 }
-              }
-              if (node.currentHUEDevice.dimming !== undefined) {
-                // Check wether the user selected specific brightness at switch on (in this case, colorAtSwitchOnNightTime is an object {kelvin:xx, brightness:yy})
-                if (node.DayTime === true && config.specifySwitchOnBrightness === "temperature") {
-                  brightnessChoosen = config.colorAtSwitchOnDayTime.brightness;
-                } else if (node.DayTime === false && config.enableDayNightLighting === "temperature") {
-                  brightnessChoosen = config.colorAtSwitchOnNightTime.brightness;
+                if (node.currentHUEDevice.dimming !== undefined) {
+                  // Check wether the user selected specific brightness at switch on (in this case, colorAtSwitchOnNightTime is an object {kelvin:xx, brightness:yy})
+                  if (node.DayTime === true && config.specifySwitchOnBrightness === "temperature") {
+                    brightnessChoosen = config.colorAtSwitchOnDayTime.brightness;
+                  } else if (node.DayTime === false && config.enableDayNightLighting === "temperature") {
+                    brightnessChoosen = config.colorAtSwitchOnNightTime.brightness;
+                  }
                 }
-              }
-              if (node.currentHUEDevice.color !== undefined) {
-                // Check wether the user selected specific color at switch on (in this case, colorAtSwitchOnDayTime is a text with HTML web color)
-                if (node.DayTime === true && config.specifySwitchOnBrightness === "yes") {
-                  colorChoosen = config.colorAtSwitchOnDayTime;
-                } else if (node.DayTime === false && config.enableDayNightLighting === "yes") {
-                  colorChoosen = config.colorAtSwitchOnNightTime;
+                if (node.currentHUEDevice.color !== undefined) {
+                  // Check wether the user selected specific color at switch on (in this case, colorAtSwitchOnDayTime is a text with HTML web color)
+                  if (node.DayTime === true && config.specifySwitchOnBrightness === "yes") {
+                    colorChoosen = config.colorAtSwitchOnDayTime;
+                  } else if (node.DayTime === false && config.enableDayNightLighting === "yes") {
+                    colorChoosen = config.colorAtSwitchOnNightTime;
+                  }
                 }
-              }
 
-              if (colorChoosen !== undefined) {
-                // Now we have a jColorChoosen. Proceed illuminating the light
-                let gamut = null;
-                if (node.currentHUEDevice.color.gamut_type !== undefined) {
-                  gamut = node.currentHUEDevice.color.gamut_type;
+                if (colorChoosen !== undefined) {
+                  // Now we have a jColorChoosen. Proceed illuminating the light
+                  let gamut = null;
+                  if (node.currentHUEDevice.color.gamut_type !== undefined) {
+                    gamut = node.currentHUEDevice.color.gamut_type;
+                  }
+                  const dretXY = hueColorConverter.ColorConverter.rgbToXy(colorChoosen.red, colorChoosen.green, colorChoosen.blue, gamut);
+                  const dbright = hueColorConverter.ColorConverter.getBrightnessFromRGBOrHex(colorChoosen.red, colorChoosen.green, colorChoosen.blue);
+                  node.currentHUEDevice.dimming.brightness = Math.round(dbright, 0);
+                  node.updateKNXBrightnessState(node.currentHUEDevice.dimming.brightness);
+                  state = dbright > 0 ? { on: { on: true }, dimming: { brightness: dbright }, color: { xy: dretXY } } : { on: { on: false } };
+                } else if (temperatureChoosen !== undefined) {
+                  // Kelvin
+                  const mirek = hueColorConverter.ColorConverter.kelvinToMirek(temperatureChoosen);
+                  node.currentHUEDevice.color_temperature.mirek = mirek;
+                  node.currentHUEDevice.dimming.brightness = brightnessChoosen;
+                  node.updateKNXBrightnessState(node.currentHUEDevice.dimming.brightness);
+                  // Kelvin temp
+                  state = brightnessChoosen > 0 ? { on: { on: true }, dimming: { brightness: brightnessChoosen }, color_temperature: { mirek: mirek } } : { on: { on: false } };
+                } else if (brightnessChoosen !== undefined) {
+                  state = brightnessChoosen > 0 ? { on: { on: true }, dimming: { brightness: brightnessChoosen } } : { on: { on: false } };
+                } else {
+                  state = { on: { on: true } };
                 }
-                const dretXY = hueColorConverter.ColorConverter.rgbToXy(colorChoosen.red, colorChoosen.green, colorChoosen.blue, gamut);
-                const dbright = hueColorConverter.ColorConverter.getBrightnessFromRGBOrHex(colorChoosen.red, colorChoosen.green, colorChoosen.blue);
-                node.currentHUEDevice.dimming.brightness = Math.round(dbright, 0);
-                node.updateKNXBrightnessState(node.currentHUEDevice.dimming.brightness);
-                state = dbright > 0 ? { on: { on: true }, dimming: { brightness: dbright }, color: { xy: dretXY } } : { on: { on: false } };
-              } else if (temperatureChoosen !== undefined) {
-                // Kelvin
-                const mirek = hueColorConverter.ColorConverter.kelvinToMirek(temperatureChoosen);
-                node.currentHUEDevice.color_temperature.mirek = mirek;
-                node.currentHUEDevice.dimming.brightness = brightnessChoosen;
-                node.updateKNXBrightnessState(node.currentHUEDevice.dimming.brightness);
-                // Kelvin temp
-                state = brightnessChoosen > 0 ? { on: { on: true }, dimming: { brightness: brightnessChoosen }, color_temperature: { mirek: mirek } } : { on: { on: false } };
-              } else if (brightnessChoosen !== undefined) {
-                state = brightnessChoosen > 0 ? { on: { on: true }, dimming: { brightness: brightnessChoosen } } : { on: { on: false } };
               } else {
-                state = { on: { on: true } };
+                state = { on: { on: false } };
               }
-            } else {
-              state = { on: { on: false } };
-            }
 
-            node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-            node.setNodeStatusHue({
-              fill: "green",
-              shape: "dot",
-              text: "KNX->HUE",
-              payload: state,
-            });
-            break;
-          case config.GALightDIM:
-            // { decr_incr: 1, data: 1 } : Start increasing until { decr_incr: 0, data: 0 } is received.
-            // { decr_incr: 0, data: 1 } : Start decreasing until { decr_incr: 0, data: 0 } is received.
-            msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightDIM));
-            node.hueDimming(msg.payload.decr_incr, msg.payload.data, config.dimSpeed);
-            node.setNodeStatusHue({
-              fill: "green", shape: "dot", text: "KNX->HUE", payload: JSON.stringify(msg.payload),
-            });
-            break;
-          case config.GALightKelvin:
-            let retMirek;
-            msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightKelvin));
-            if (config.dptLightKelvin === "7.600") {
-              if (msg.payload > 65535) msg.payload = 65535;
-              if (msg.payload < 0) msg.payload = 0;
-              retMirek = hueColorConverter.ColorConverter.scale(msg.payload, [0, 65535], [500, 153]);
-            } else if (config.dptLightKelvin === "9.002") {
-              // Relative temperature in Kelvin. Use HUE scale.
-              if (msg.payload > 6535) msg.payload = 6535;
-              if (msg.payload < 2000) msg.payload = 2000;
-              retMirek = hueColorConverter.ColorConverter.scale(msg.payload, [2000, 6535], [500, 153]);
-            }
-            state = { color_temperature: { mirek: retMirek } };
-            node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-            node.setNodeStatusHue({
-              fill: "green",
-              shape: "dot",
-              text: "KNX->HUE",
-              payload: msg.payload,
-            });
-            break;
-          case config.GADaylightSensor:
-            node.DayTime = Boolean(dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptDaylightSensor)));
-            if (config.invertDayNight !== undefined && config.invertDayNight === true) node.DayTime = !node.DayTime;
-            node.setNodeStatusHue({
-              fill: "green",
-              shape: "dot",
-              text: "KNX->HUE Daytime",
-              payload: node.DayTime,
-            });
-
-            break;
-          case config.GALightHSV:
-            if (config.dptLightHSV === "3.007") {
-              // MDT smartbutton will dim the color temperature
+              node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
+              node.setNodeStatusHue({
+                fill: "green",
+                shape: "dot",
+                text: "KNX->HUE",
+                payload: state,
+              });
+              break;
+            case config.GALightDIM:
               // { decr_incr: 1, data: 1 } : Start increasing until { decr_incr: 0, data: 0 } is received.
               // { decr_incr: 0, data: 1 } : Start decreasing until { decr_incr: 0, data: 0 } is received.
-              msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightHSV));
-              node.hueDimmingTunableWhite(msg.payload.decr_incr, msg.payload.data, config.dimSpeed);
+              msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightDIM));
+              node.hueDimming(msg.payload.decr_incr, msg.payload.data, config.dimSpeed);
               node.setNodeStatusHue({
                 fill: "green", shape: "dot", text: "KNX->HUE", payload: JSON.stringify(msg.payload),
               });
-            }
-            break;
-          case config.GALightHSVPercentage:
-            if (config.dptLightHSVPercentage === "5.001") {
-              // 0-100% tunable white
-              msg.payload = 100 - dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightHSVPercentage));
-              // msg.payload = msg.payload <= 0 ? 1 : msg.payload
-              const retMirek = hueColorConverter.ColorConverter.scale(msg.payload, [0, 100], [153, 500]);
-              msg.payload = retMirek;
-              state = { color_temperature: { mirek: msg.payload } };
+              break;
+            case config.GALightKelvin:
+              let retMirek;
+              msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightKelvin));
+              if (config.dptLightKelvin === "7.600") {
+                if (msg.payload > 65535) msg.payload = 65535;
+                if (msg.payload < 0) msg.payload = 0;
+                retMirek = hueColorConverter.ColorConverter.scale(msg.payload, [0, 65535], [500, 153]);
+              } else if (config.dptLightKelvin === "9.002") {
+                // Relative temperature in Kelvin. Use HUE scale.
+                if (msg.payload > 6535) msg.payload = 6535;
+                if (msg.payload < 2000) msg.payload = 2000;
+                retMirek = hueColorConverter.ColorConverter.scale(msg.payload, [2000, 6535], [500, 153]);
+              }
+              state = { color_temperature: { mirek: retMirek } };
               node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
               node.setNodeStatusHue({
                 fill: "green",
                 shape: "dot",
                 text: "KNX->HUE",
-                payload: state,
+                payload: msg.payload,
               });
-            }
-            break;
-          case config.GALightBrightness:
-            msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightBrightness));
-            state = { dimming: { brightness: msg.payload } };
-            if (node.currentHUEDevice === undefined) {
-              // Grouped light
-              state.on = { on: msg.payload > 0 };
-            } else {
-              // Light
-              if (node.currentHUEDevice.on.on === false && msg.payload > 0) state.on = { on: true };
-              if (node.currentHUEDevice.on.on === true && msg.payload === 0) state.on = { on: false };
-            }
-            node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-            node.setNodeStatusHue({
-              fill: "green",
-              shape: "dot",
-              text: "KNX->HUE",
-              payload: state,
-            });
-            break;
-          case config.GALightColor:
-            msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightColor));
-            let gamut = null;
-            if (
-              node.currentHUEDevice !== undefined
-              && node.currentHUEDevice.hasOwnProperty("color")
-              && node.currentHUEDevice.color.hasOwnProperty("gamut_type")
-            ) {
-              gamut = node.currentHUEDevice.color.gamut_type;
-            }
-            const retXY = hueColorConverter.ColorConverter.rgbToXy(msg.payload.red, msg.payload.green, msg.payload.blue, gamut);
-            const bright = hueColorConverter.ColorConverter.getBrightnessFromRGBOrHex(msg.payload.red, msg.payload.green, msg.payload.blue);
-            // state = bright > 0 ? { on: { on: true }, dimming: { brightness: bright }, color: { xy: retXY } } : { on: { on: false } }
-            state = { dimming: { brightness: bright }, color: { xy: retXY } };
-            if (node.currentHUEDevice === undefined) {
-              // Grouped light
-              state.on = { on: bright > 0 };
-            } else {
-              // Light
-              if (node.currentHUEDevice.on.on === false && bright > 0) state.on = { on: true };
-              if (node.currentHUEDevice.on.on === true && bright === 0) state = { on: { on: false }, dimming: { brightness: bright } };
-            }
-            node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-            node.setNodeStatusHue({
-              fill: "green",
-              shape: "dot",
-              text: "KNX->HUE",
-              payload: state,
-            });
-            break;
-          case config.GALightBlink:
-            const gaVal = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightBlink));
-            if (gaVal) {
-              node.timerBlink = setInterval(() => {
-                if (node.blinkValue === undefined) node.blinkValue = true;
-                node.blinkValue = !node.blinkValue;
-                msg.payload = node.blinkValue;
-                // state = msg.payload === true ? { on: { on: true } } : { on: { on: false } }
-                state = msg.payload === true
-                  ? { on: { on: true }, dimming: { brightness: 100 }, dynamics: { duration: 0 } }
-                  : { on: { on: false }, dimming: { brightness: 0 }, dynamics: { duration: 0 } };
+              break;
+            case config.GADaylightSensor:
+              node.DayTime = Boolean(dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptDaylightSensor)));
+              if (config.invertDayNight !== undefined && config.invertDayNight === true) node.DayTime = !node.DayTime;
+              node.setNodeStatusHue({
+                fill: "green",
+                shape: "dot",
+                text: "KNX->HUE Daytime",
+                payload: node.DayTime,
+              });
+
+              break;
+            case config.GALightHSV:
+              if (config.dptLightHSV === "3.007") {
+                // MDT smartbutton will dim the color temperature
+                // { decr_incr: 1, data: 1 } : Start increasing until { decr_incr: 0, data: 0 } is received.
+                // { decr_incr: 0, data: 1 } : Start decreasing until { decr_incr: 0, data: 0 } is received.
+                msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightHSV));
+                node.hueDimmingTunableWhite(msg.payload.decr_incr, msg.payload.data, config.dimSpeed);
+                node.setNodeStatusHue({
+                  fill: "green", shape: "dot", text: "KNX->HUE", payload: JSON.stringify(msg.payload),
+                });
+              }
+              break;
+            case config.GALightHSVPercentage:
+              if (config.dptLightHSVPercentage === "5.001") {
+                // 0-100% tunable white
+                msg.payload = 100 - dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightHSVPercentage));
+                // msg.payload = msg.payload <= 0 ? 1 : msg.payload
+                const retMirek = hueColorConverter.ColorConverter.scale(msg.payload, [0, 100], [153, 500]);
+                msg.payload = retMirek;
+                state = { color_temperature: { mirek: msg.payload } };
                 node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-              }, 1000);
-            } else {
-              if (node.timerBlink !== undefined) clearInterval(node.timerBlink);
-              node.serverHue.hueManager.writeHueQueueAdd(
-                node.hueDevice,
-                { on: { on: false } },
-                node.isGrouped_light === false ? "setLight" : "setGroupedLight",
-              );
-            }
-            node.setNodeStatusHue({
-              fill: "green",
-              shape: "dot",
-              text: "KNX->HUE",
-              payload: gaVal,
-            });
-            break;
-          case config.GALightColorCycle:
-            {
-              if (node.timerColorCycle !== undefined) clearInterval(node.timerColorCycle);
-              const gaValColorCycle = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightColorCycle));
-              if (gaValColorCycle === true) {
-                node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, { on: { on: true } }, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-                node.timerColorCycle = setInterval(() => {
-                  try {
-                    const red = getRandomIntInclusive(0, 255);
-                    const green = getRandomIntInclusive(0, 255);
-                    const blue = getRandomIntInclusive(0, 255);
-                    let gamut = null;
-                    if (
-                      node.currentHUEDevice !== undefined
-                      && node.currentHUEDevice.hasOwnProperty("color")
-                      && node.currentHUEDevice.color.hasOwnProperty("gamut_type")
-                    ) {
-                      gamut = node.currentHUEDevice.color.gamut_type;
-                    }
-                    const retXY = hueColorConverter.ColorConverter.rgbToXy(red, green, blue, gamut);
-                    const bright = hueColorConverter.ColorConverter.getBrightnessFromRGBOrHex(red, green, blue);
-                    state = bright > 0 ? { on: { on: true }, dimming: { brightness: bright }, color: { xy: retXY } } : { on: { on: false } };
-                    node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
-                  } catch (error) { }
-                }, 10000);
+                node.setNodeStatusHue({
+                  fill: "green",
+                  shape: "dot",
+                  text: "KNX->HUE",
+                  payload: state,
+                });
+              }
+              break;
+            case config.GALightBrightness:
+              msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightBrightness));
+              state = { dimming: { brightness: msg.payload } };
+              if (node.currentHUEDevice === undefined) {
+                // Grouped light
+                state.on = { on: msg.payload > 0 };
               } else {
-                if (node.timerColorCycle !== undefined) clearInterval(node.timerColorCycle);
+                // Light
+                if (node.currentHUEDevice.on.on === false && msg.payload > 0) state.on = { on: true };
+                if (node.currentHUEDevice.on.on === true && msg.payload === 0) state.on = { on: false };
+              }
+              node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
+              node.setNodeStatusHue({
+                fill: "green",
+                shape: "dot",
+                text: "KNX->HUE",
+                payload: state,
+              });
+              break;
+            case config.GALightColor:
+              msg.payload = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightColor));
+              let gamut = null;
+              if (
+                node.currentHUEDevice !== undefined
+                && node.currentHUEDevice.color !== undefined
+                && node.currentHUEDevice.color.gamut_type !== undefined
+              ) {
+                gamut = node.currentHUEDevice.color.gamut_type;
+              }
+              const retXY = hueColorConverter.ColorConverter.rgbToXy(msg.payload.red, msg.payload.green, msg.payload.blue, gamut);
+              const bright = hueColorConverter.ColorConverter.getBrightnessFromRGBOrHex(msg.payload.red, msg.payload.green, msg.payload.blue);
+              // state = bright > 0 ? { on: { on: true }, dimming: { brightness: bright }, color: { xy: retXY } } : { on: { on: false } }
+              state = { dimming: { brightness: bright }, color: { xy: retXY } };
+              if (node.currentHUEDevice === undefined) {
+                // Grouped light
+                state.on = { on: bright > 0 };
+              } else {
+                // Light
+                if (node.currentHUEDevice.on.on === false && bright > 0) state.on = { on: true };
+                if (node.currentHUEDevice.on.on === true && bright === 0) state = { on: { on: false }, dimming: { brightness: bright } };
+              }
+              node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
+              node.setNodeStatusHue({
+                fill: "green",
+                shape: "dot",
+                text: "KNX->HUE",
+                payload: state,
+              });
+              break;
+            case config.GALightBlink:
+              const gaVal = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightBlink));
+              if (gaVal) {
+                node.timerBlink = setInterval(() => {
+                  if (node.blinkValue === undefined) node.blinkValue = true;
+                  node.blinkValue = !node.blinkValue;
+                  msg.payload = node.blinkValue;
+                  // state = msg.payload === true ? { on: { on: true } } : { on: { on: false } }
+                  state = msg.payload === true
+                    ? { on: { on: true }, dimming: { brightness: 100 }, dynamics: { duration: 0 } }
+                    : { on: { on: false }, dimming: { brightness: 0 }, dynamics: { duration: 0 } };
+                  node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
+                }, 1000);
+              } else {
+                if (node.timerBlink !== undefined) clearInterval(node.timerBlink);
                 node.serverHue.hueManager.writeHueQueueAdd(
                   node.hueDevice,
                   { on: { on: false } },
@@ -348,16 +309,65 @@ module.exports = function (RED) {
                 fill: "green",
                 shape: "dot",
                 text: "KNX->HUE",
-                payload: gaValColorCycle,
+                payload: gaVal,
               });
-            }
-            break;
-          default:
-            break;
+              break;
+            case config.GALightColorCycle:
+              {
+                if (node.timerColorCycle !== undefined) clearInterval(node.timerColorCycle);
+                const gaValColorCycle = dptlib.fromBuffer(msg.knx.rawValue, dptlib.resolve(config.dptLightColorCycle));
+                if (gaValColorCycle === true) {
+                  node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, { on: { on: true } }, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
+                  node.timerColorCycle = setInterval(() => {
+                    try {
+                      const red = getRandomIntInclusive(0, 255);
+                      const green = getRandomIntInclusive(0, 255);
+                      const blue = getRandomIntInclusive(0, 255);
+                      let gamut = null;
+                      if (
+                        node.currentHUEDevice !== undefined
+                        && node.currentHUEDevice.color !== undefined
+                        && node.currentHUEDevice.color.gamut_type !== undefined
+                      ) {
+                        gamut = node.currentHUEDevice.color.gamut_type;
+                      }
+                      const retXY = hueColorConverter.ColorConverter.rgbToXy(red, green, blue, gamut);
+                      const bright = hueColorConverter.ColorConverter.getBrightnessFromRGBOrHex(red, green, blue);
+                      state = bright > 0 ? { on: { on: true }, dimming: { brightness: bright }, color: { xy: retXY } } : { on: { on: false } };
+                      node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, state, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
+                    } catch (error) { }
+                  }, 10000);
+                } else {
+                  if (node.timerColorCycle !== undefined) clearInterval(node.timerColorCycle);
+                  node.serverHue.hueManager.writeHueQueueAdd(
+                    node.hueDevice,
+                    { on: { on: false } },
+                    node.isGrouped_light === false ? "setLight" : "setGroupedLight",
+                  );
+                }
+                node.setNodeStatusHue({
+                  fill: "green",
+                  shape: "dot",
+                  text: "KNX->HUE",
+                  payload: gaValColorCycle,
+                });
+              }
+              break;
+            default:
+              break;
+          }
+        } catch (error) {
+          node.status({
+            fill: "red",
+            shape: "dot",
+            text: `KNX->HUE errorRead ${error.message} (${new Date().getDate()}, ${new Date().toLocaleTimeString()})`,
+          });
+          RED.log.error(`knxUltimateHueLight: node.handleSend:  if (msg.knx.event !== "GroupValue_Read"): ${error.message} : ${error.stack || ""} `);
         }
+      }
 
-        // I must respond to query requests (read request) sent from the KNX BUS
-
+      // I must respond to query requests (read request) sent from the KNX BUS
+      try {
         if (msg.knx.event === "GroupValue_Read" && node.currentHUEDevice !== undefined) {
           let ret;
           switch (msg.knx.destination) {
@@ -389,8 +399,9 @@ module.exports = function (RED) {
         node.status({
           fill: "red",
           shape: "dot",
-          text: `KNX->HUE error ${error.message || error} (${new Date().getDate()}, ${new Date().toLocaleTimeString()})`,
+          text: `KNX->HUE error :-( ${error.message} (${new Date().getDate()}, ${new Date().toLocaleTimeString()})`,
         });
+        RED.log.error(`knxUltimateHueLight: node.handleSend: if (msg.knx.event === "GroupValue_Read" && node.currentHUEDevice !== undefined): ${error.message} : ${error.stack || ""} `);
       }
     };
 
@@ -431,7 +442,7 @@ module.exports = function (RED) {
           if (node.brightnessStep > maxDimLevelLight) node.brightnessStep = maxDimLevelLight;
           hueTelegram = { dimming: { brightness: node.brightnessStep }, dynamics: { duration: _dimSpeedInMillisecs } };
           // Switch on the light if off
-          if (node.currentHUEDevice.hasOwnProperty("on") !== undefined && node.currentHUEDevice.on.on === false) {
+          if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false) {
             hueTelegram.on = { on: true };
           }
           node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, hueTelegram, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
@@ -439,6 +450,7 @@ module.exports = function (RED) {
         }, _dimSpeedInMillisecs);
       }
       if (_KNXbrightness_delta > 0 && _KNXaction === 0) {
+        if (node.currentHUEDevice.on.on === false) return; // Don't dim down, if the light is already off.
         // DIM DOWN
         if (node.timerStepDim !== undefined) clearInterval(node.timerStepDim);
         node.timerStepDim = setInterval(() => {
@@ -447,7 +459,7 @@ module.exports = function (RED) {
           if (node.brightnessStep < minDimLevelLight) node.brightnessStep = minDimLevelLight;
           hueTelegram = { dimming: { brightness: node.brightnessStep }, dynamics: { duration: _dimSpeedInMillisecs } };
           // Switch off the light if on
-          if (node.currentHUEDevice.hasOwnProperty("on") !== undefined && node.currentHUEDevice.on.on === true && node.brightnessStep === 0) {
+          if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === true && node.brightnessStep === 0) {
             hueTelegram.on = { on: false };
           }
           node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, hueTelegram, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
@@ -465,7 +477,7 @@ module.exports = function (RED) {
       let hueTelegram = {};
       _dimSpeedInMillisecs = _dimSpeedInMillisecs === undefined || _dimSpeedInMillisecs === "" ? 5000 : _dimSpeedInMillisecs;
       let delta = 0;
-      if (!node.currentHUEDevice.color_temperature.hasOwnProperty("mirek")) delta = 347 - Math.round(173, 0); // Unable to read the mirek, set medium as default
+      if (node.currentHUEDevice.color_temperature.mirek === undefined) delta = 347 - Math.round(173, 0); // Unable to read the mirek, set medium as default
       // We have also minDimLevelLight and maxDimLevelLight to take care of.
       // Mirek limits are not taken in consideration.
       // Maximum mirek is 347
@@ -476,12 +488,12 @@ module.exports = function (RED) {
         return;
       }
       if (_KNXbrightness_delta > 0 && _KNXaction === 1) {
-        if (node.currentHUEDevice.color_temperature.hasOwnProperty("mirek")) delta = 347 - Math.round(node.currentHUEDevice.color_temperature.mirek, 0);
+        if (node.currentHUEDevice.color_temperature.mirek !== undefined) delta = 347 - Math.round(node.currentHUEDevice.color_temperature.mirek, 0);
         dimDirection = "up";
       }
       if (_KNXbrightness_delta > 0 && _KNXaction === 0) {
         // Set the minumum delta, taking care of the minimum brightness specified either in the HUE lamp itself, or specified by the user (parameter node.minDimLevelLight)
-        if (node.currentHUEDevice.color_temperature.hasOwnProperty("mirek")) delta = Math.round(node.currentHUEDevice.color_temperature.mirek, 0);
+        if (node.currentHUEDevice.color_temperature.mirek !== undefined) delta = Math.round(node.currentHUEDevice.color_temperature.mirek, 0);
         dimDirection = "down";
       }
       // Calculate the dimming time based on delta
@@ -491,7 +503,7 @@ module.exports = function (RED) {
 
       hueTelegram = { color_temperature_delta: { action: dimDirection, mirek_delta: delta }, dynamics: { duration: _dimSpeedInMillisecs } };
       // Switch on the light if off
-      if (node.currentHUEDevice.hasOwnProperty("on") !== undefined && node.currentHUEDevice.on.on === false && dimDirection === "up") {
+      if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && dimDirection === "up") {
         hueTelegram.on = { on: true };
       }
       node.serverHue.hueManager.writeHueQueueAdd(node.hueDevice, hueTelegram, node.isGrouped_light === false ? "setLight" : "setGroupedLight");
@@ -536,7 +548,7 @@ module.exports = function (RED) {
             } catch (error) { }
           }
 
-          if (_event.hasOwnProperty("on")) {
+          if (_event.on !== undefined) {
             node.updateKNXLightState(_event.on.on);
             // In case of switch off, set the dim to zero
             if (_event.on.on === false && (config.updateKNXBrightnessStatusOnHUEOnOff === undefined || config.updateKNXBrightnessStatusOnHUEOnOff === "onhueoff")) {
@@ -544,7 +556,7 @@ module.exports = function (RED) {
               //node.currentHUEDevice.dimming.brightness = 0;
             } else if (_event.on.on === true && node.currentHUEDevice.on.on === false) {
               // Turn on always update the dimming KNX Status value as well.
-              let brightVal = 100;
+              let brightVal = 50;
               if (node.currentHUEDevice.dimming !== undefined && node.currentHUEDevice.dimming.brightness !== undefined) brightVal = node.currentHUEDevice.dimming.brightness;
               node.updateKNXBrightnessState(brightVal);
             }
@@ -556,17 +568,17 @@ module.exports = function (RED) {
             node.currentHUEDevice.color = _event.color;
           }
 
-          if (_event.hasOwnProperty("dimming") && _event.dimming.brightness !== undefined) {
+          if (_event.dimming !== undefined && _event.dimming.brightness !== undefined) {
             // Once upon n a time, the light transmit the brightness value of 0.39.
             // To avoid wrongly turn light state on, exit
             if (_event.dimming.brightness < 1) _event.dimming.brightness = 0;
-            if (node.currentHUEDevice.hasOwnProperty("on") && node.currentHUEDevice.on.on === false && _event.dimming.brightness === 0) {
+            if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && _event.dimming.brightness === 0) {
               // Do nothing, because the light is off and the dimming also is 0
             } else {
-              if (node.currentHUEDevice.hasOwnProperty("on") && node.currentHUEDevice.on.on === false && (!_event.hasOwnProperty("on") || (_event.hasOwnProperty("on") && _event.on.on === true))) node.updateKNXLightState(_event.dimming.brightness > 0);
+              if (node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === false && (!_event.on !== undefined || (_event.on !== undefined && _event.on.on === true))) node.updateKNXLightState(_event.dimming.brightness > 0);
               node.updateKNXBrightnessState(_event.dimming.brightness);
               // If the brightness reaches zero, the hue lamp "on" property must be set to zero as well
-              if (_event.dimming.brightness === 0 && node.currentHUEDevice.hasOwnProperty("on") && node.currentHUEDevice.on.on === true) {
+              if (_event.dimming.brightness === 0 && node.currentHUEDevice.on !== undefined && node.currentHUEDevice.on.on === true) {
                 node.serverHue.hueManager.writeHueQueueAdd(
                   node.hueDevice,
                   { on: { on: false } },
@@ -577,7 +589,7 @@ module.exports = function (RED) {
               node.currentHUEDevice.dimming.brightness = _event.dimming.brightness;
             }
           }
-          if (_event.hasOwnProperty("color_temperature") && _event.color_temperature.mirek !== undefined) {
+          if (_event.color_temperature !== undefined && _event.color_temperature.mirek !== undefined) {
             node.updateKNXLightHSVState(_event.color_temperature.mirek);
             node.updateKNXLightKelvinState(_event.color_temperature.mirek);
             node.currentHUEDevice.color_temperature.mirek = _event.color_temperature.mirek;
@@ -587,7 +599,7 @@ module.exports = function (RED) {
         node.status({
           fill: "red",
           shape: "dot",
-          text: `HUE->KNX error ${node.id} ${error.message}`,
+          text: `HUE->KNX error ${node.id} ${error.message}. Seee Log`,
         });
         RED.log.error(`knxUltimateHueLight: node.handleSendHUE = (_event): ${error.message}`);
       }
@@ -686,7 +698,7 @@ module.exports = function (RED) {
 
     node.updateKNXLightColorState = function updateKNXLightColorState(_value, _outputtype = "write") {
       if (config.GALightColorState !== undefined && config.GALightColorState !== "") {
-        if (!_value.hasOwnProperty('xy') || _value.xy.x === undefined) return;
+        if (_value.xy === undefined || _value.xy.x === undefined) return;
         const knxMsgPayload = {};
         knxMsgPayload.topic = config.GALightColorState;
         knxMsgPayload.dpt = config.dptLightColorState;
@@ -800,6 +812,6 @@ module.exports = function (RED) {
       }
       done();
     });
-  }
+  };
   RED.nodes.registerType("knxUltimateHueLight", knxUltimateHueLight);
 };

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "2.2.27",
+  "version": "2.2.29",
   "description": "Control your KNX intallation via Node-Red! Single Node KNX IN/OUT with optional ETS group address importer. Easy to use and highly configurable. With integrated Philips HUE devices control.",
   "dependencies": {
     "binary-parser": "2.2.1",