node-red-contrib-knx-ultimate 1.4.6 → 1.4.7

package/.prettierignore

@@ -0,0 +1,8 @@
+# Ignore artifacts:
+build
+coverage
+dist
+out
+
+# Ignore all JavaScript files:
+*.js

package/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 # CHANGELOG
 
+<p>
+<b>Version 1.4.7</b> - November 2022<br/>
+- NEW: added "Griesser Object" Custom Datapoint 6001.001. Thanks @croghostrider<br/>
+</p>
 <p>
 <b>Version 1.4.6</b> - November 2022<br/>
 - NEW: added Airflow Datapoint 9.009.<br/>

package/KNXEngine/KNXClient.js

@@ -40,7 +40,7 @@ const SocketEvents = {
   data: 'data',
   close: 'close'
 }
-var KNXClientEvents;
+let KNXClientEvents;
 (function (KNXClientEvents) {
   KNXClientEvents.error = 'error'
   KNXClientEvents.disconnected = 'disconnected'
@@ -84,7 +84,7 @@ const optionsDefaults = {
 }
 
 class KNXClient extends EventEmitter {
-  constructor(options) {
+  constructor (options) {
     if (options === undefined) {
       options = optionsDefaults
     }
@@ -188,7 +188,7 @@ class KNXClient extends EventEmitter {
     this._numFailedTelegramACK = 0 // 25/12/2021 Keep count of the failed tunnelig ACK telegrams
   }
 
-  get channelID() {
+  get channelID () {
     return this._channelID
   }
 
@@ -215,7 +215,7 @@ class KNXClient extends EventEmitter {
   //     DPT19: null,
   //     DPT20: null
   // };
-  getKNXDataBuffer(_data, _dptid) {
+  getKNXDataBuffer (_data, _dptid) {
     const adpu = {}
     DPTLib.populateAPDU(_data, adpu, _dptid)
     const iDatapointType = parseInt(_dptid.substr(0, _dptid.indexOf('.')))
@@ -253,7 +253,7 @@ class KNXClient extends EventEmitter {
   //         }
   //     });
   // }
-  send(knxPacket) {
+  send (knxPacket) {
     // Logging
     if (this.sysLogger !== undefined && this.sysLogger !== null) {
       try {
@@ -320,7 +320,7 @@ class KNXClient extends EventEmitter {
     * @param {KNXDataBuffer} data
     */
   // sendWriteRequest(dstAddress, data) {
-  write(dstAddress, data, dptid) {
+  write (dstAddress, data, dptid) {
     if (this._connectionState !== STATE.CONNECTED) throw new Error('The socket is not connected. Unable to access the KNX BUS')
 
     // Get the Data Buffer from the plain value
@@ -363,7 +363,7 @@ class KNXClient extends EventEmitter {
   }
 
   // sendResponseRequest
-  respond(dstAddress, data, dptid) {
+  respond (dstAddress, data, dptid) {
     if (this._connectionState !== STATE.CONNECTED) throw new Error('The socket is not connected. Unable to access the KNX BUS')
 
     // Get the Data Buffer from the plain value
@@ -405,7 +405,7 @@ class KNXClient extends EventEmitter {
   }
 
   // sendReadRequest
-  read(dstAddress) {
+  read (dstAddress) {
     if (this._connectionState !== STATE.CONNECTED) throw new Error('The socket is not connected. Unable to access the KNX BUS')
 
     if (typeof dstAddress === 'string') dstAddress = KNXAddress.createFromString(dstAddress, KNXAddress.TYPE_GROUP)
@@ -443,7 +443,7 @@ class KNXClient extends EventEmitter {
     }
   }
 
-  writeRaw(dstAddress, _rawDataBuffer, bitlength) {
+  writeRaw (dstAddress, _rawDataBuffer, bitlength) {
     // bitlength is unused and only for backward compatibility
 
     if (this._connectionState !== STATE.CONNECTED) throw new Error('The socket is not connected. Unable to access the KNX BUS')
@@ -500,14 +500,14 @@ class KNXClient extends EventEmitter {
     }
   }
 
-  startHeartBeat() {
+  startHeartBeat () {
     this.stopHeartBeat()
     this._heartbeatFailures = 0
     this._heartbeatRunning = true
     this._runHeartbeat()
   }
 
-  stopHeartBeat() {
+  stopHeartBeat () {
     if (this._heartbeatTimer !== null) {
       this._heartbeatRunning = false
       clearTimeout(this._heartbeatTimer)
@@ -543,7 +543,7 @@ class KNXClient extends EventEmitter {
   //     this._awaitingResponseType = KNXConstants.KNX_CONSTANTS.DESCRIPTION_RESPONSE;
   //     this._sendDescriptionRequestMessage(host, port);
   // }
-  Connect(knxLayer = TunnelCRI.TunnelTypes.TUNNEL_LINKLAYER) {
+  Connect (knxLayer = TunnelCRI.TunnelTypes.TUNNEL_LINKLAYER) {
     if (this._clientSocket == null) {
       throw new Error('No client socket defined')
     }
@@ -611,7 +611,7 @@ class KNXClient extends EventEmitter {
     }
   }
 
-  getConnectionStatus() {
+  getConnectionStatus () {
     if (this._clientSocket == null) {
       throw new Error('No client socket defined')
     }
@@ -641,7 +641,7 @@ class KNXClient extends EventEmitter {
     } catch (error) { }
   }
 
-  Disconnect() {
+  Disconnect () {
     if (this._clientSocket === null) {
       throw new Error('No client socket defined')
     }
@@ -669,11 +669,11 @@ class KNXClient extends EventEmitter {
     }, 2000)
   }
 
-  isConnected() {
+  isConnected () {
     return this._connectionState === STATE.CONNECTED
   }
 
-  _setDisconnected(_sReason = '') {
+  _setDisconnected (_sReason = '') {
     try {
       if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug('KNXClient: called _setDisconnected ' + this._options.ipAddr + ':' + this._options.ipPort + ' ' + _sReason)
     } catch (error) {
@@ -698,7 +698,7 @@ class KNXClient extends EventEmitter {
     this._clearToSend = true // 26/12/2021 allow to send
   }
 
-  _runHeartbeat() {
+  _runHeartbeat () {
     if (this._heartbeatRunning) {
       this.getConnectionStatus()
       const t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
@@ -707,16 +707,16 @@ class KNXClient extends EventEmitter {
     }
   }
 
-  _getSeqNumber() {
+  _getSeqNumber () {
     return this._clientTunnelSeqNumber
   }
 
   // 26/12/2021 Handle the busy state, for example while waiting for ACK
-  _getClearToSend() {
+  _getClearToSend () {
     return (this._clearToSend !== undefined ? this._clearToSend : true)
   }
 
-  _incSeqNumber() {
+  _incSeqNumber () {
     this._clientTunnelSeqNumber++
     if (this._clientTunnelSeqNumber > 255) {
       this._clientTunnelSeqNumber = 0
@@ -727,7 +727,7 @@ class KNXClient extends EventEmitter {
   // _keyFromCEMIMessage(cEMIMessage) {
   //     return cEMIMessage.dstAddress.toString();
   // }
-  _setTimerWaitingForACK(knxTunnelingRequest) {
+  _setTimerWaitingForACK (knxTunnelingRequest) {
     this._clearToSend = false // 26/12/2021 stop sending until ACK received
     const timeoutErr = new errors.RequestTimeoutError(`RequestTimeoutError seqCounter:${knxTunnelingRequest.seqCounter}, DestAddr:${knxTunnelingRequest.cEMIMessage.dstAddress.toString() || 'Non definito'},  AckRequested:${knxTunnelingRequest.cEMIMessage.control.ack}, timed out waiting telegram acknowledge by ${this._options.ipAddr || 'No Peer host detected'}`)
     if (this._timerWaitingForACK !== null) clearTimeout(this._timerWaitingForACK)
@@ -754,7 +754,7 @@ class KNXClient extends EventEmitter {
     }, KNXConstants.KNX_CONSTANTS.TUNNELING_REQUEST_TIMEOUT * 1000)
   }
 
-  _processInboundMessage(msg, rinfo) {
+  _processInboundMessage (msg, rinfo) {
     try {
       // Composing debug string
       try {
@@ -998,31 +998,31 @@ class KNXClient extends EventEmitter {
     }
   }
 
-  _sendDescriptionRequestMessage() {
+  _sendDescriptionRequestMessage () {
     this.send(KNXProtocol.KNXProtocol.newKNXDescriptionRequest(new HPAI.HPAI(this._options.localIPAddress)))
   }
 
-  _sendSearchRequestMessage() {
+  _sendSearchRequestMessage () {
     // this.send(KNXProtocol.KNXProtocol.newKNXSearchRequest(new HPAI.HPAI(this._options.localIPAddress, this._localPort)), KNXConstants.KNX_CONSTANTS.KNX_PORT, KNXConstants.KNX_CONSTANTS.KNX_IP);
   }
 
-  _sendConnectRequestMessage(cri) {
+  _sendConnectRequestMessage (cri) {
     this.send(KNXProtocol.KNXProtocol.newKNXConnectRequest(cri))
   }
 
-  _sendConnectionStateRequestMessage(channelID) {
+  _sendConnectionStateRequestMessage (channelID) {
     this.send(KNXProtocol.KNXProtocol.newKNXConnectionStateRequest(channelID))
   }
 
-  _sendDisconnectRequestMessage(channelID) {
+  _sendDisconnectRequestMessage (channelID) {
     this.send(KNXProtocol.KNXProtocol.newKNXDisconnectRequest(channelID))
   }
 
-  _sendDisconnectResponseMessage(channelID, status = KNXConstants.ConnectionStatus.E_NO_ERROR) {
+  _sendDisconnectResponseMessage (channelID, status = KNXConstants.ConnectionStatus.E_NO_ERROR) {
     this.send(KNXProtocol.KNXProtocol.newKNXDisconnectResponse(channelID, status))
   }
 
-  _sendSecureSessionRequestMessage(cri) {
+  _sendSecureSessionRequestMessage (cri) {
     const oHPAI = new HPAI.HPAI('0.0.0.0', 0, this._options.hostProtocol === 'TunnelTCP' ? KNXConstants.KNX_CONSTANTS.IPV4_TCP : KNXConstants.KNX_CONSTANTS.IPV4_UDP)
     this.send(KNXProtocol.KNXProtocol.newKNXSecureSessionRequest(cri, oHPAI))
   }

package/KNXEngine/dptlib/dpt21.js

@@ -38,8 +38,8 @@ exports.fromBuffer = function (buf) {
     knxLog.get().error('DPT21: Buffer should be 8 bit long, got', buf.length)
     return null
   }
-  const sBit =Array.from((parseInt(buf.toString('hex').toUpperCase(), 16).toString(2)).padStart(8, '0')) // Get bit from hex
-  const ret = { outOfService: sBit[7] ==='1' ? true : false, fault: sBit[6]==='1' ? true : false, overridden: sBit[5]==='1' ? true : false, inAlarm: sBit[4]==='1' ? true : false, alarmUnAck: sBit[3] ==='1' ? true : false }
+  const sBit = Array.from((parseInt(buf.toString('hex').toUpperCase(), 16).toString(2)).padStart(8, '0')) // Get bit from hex
+  const ret = { outOfService: sBit[7] === '1', fault: sBit[6] === '1', overridden: sBit[5] === '1', inAlarm: sBit[4] === '1', alarmUnAck: sBit[3] === '1' }
   return ret
 }
 

package/KNXEngine/dptlib/dpt60001.js

@@ -0,0 +1,276 @@
+const knxLog = require('./../KnxLog')
+
+function toRadix (value, radix) {
+  if (!Number.isSafeInteger(value)) {
+    knxLog.get().error('value must be a safe integer')
+  }
+
+  const digits = Math.ceil(64 / Math.log2(radix))
+  const twosComplement = value < 0
+    ? BigInt(radix) ** BigInt(digits) + BigInt(value)
+    : value
+
+  return twosComplement.toString(radix).padStart(digits, '0')
+}
+
+function griesserSectorCode (Byte0, Byte1) {
+  const SectorCode = Byte0 + (Byte1 & 3) * 256
+  return SectorCode
+}
+
+function griesserCommandCode (Byte1) {
+  const command = (Byte1 / 4) >> 0
+  return command
+}
+
+function griesserParameter (command, Byte2, Byte3, Byte4, Byte5) {
+  let commandOperation
+  switch (command) {
+    case 1: // drive command
+      switch (Byte2 & 31) {
+        case 0: return 'no driving movement'
+        case 1: return 'upper end position'
+        case 2: return 'lower end position'
+        case 3:
+          if ((Byte3 >= 1) & (Byte3 <= 4)) {
+            return 'fixed position P' + Byte3 + ' approach'
+          } else {
+            return 'Unknown value for Pn ' + Byte3
+          }
+        default:
+          return 'Unknown drive command' + Byte2 & 31
+      }
+    case 4: // set/delete lock
+      if (Byte2 === 0) {
+        return 'no lock'
+      } else {
+        switch (Byte2 & 3) {
+          case 1: return 'driving command'
+          case 2: return 'button lock'
+          case 3: return 'driving command- and button lock'
+        }
+        if (Byte3 === 0) {
+          return 'delete lock'
+        } else {
+          return 'set lock'
+        }
+      }
+    case 5: // operation code
+      if (Byte2 <= 6) {
+        commandOperation = 'groupoperation'
+      } else if (Byte2 >= 128 && Byte2 <= 134) {
+        commandOperation = 'localoperation'
+      } else {
+        commandOperation = 'unknown command Byte3 for ' + Byte2
+      }
+      if ((Byte2 & 127) === 0) {
+        return [commandOperation, 'long up']
+      } else if ((Byte2 & 127) === 1) {
+        return [commandOperation, 'long down']
+      } else if ((Byte2 & 127) === 2) {
+        return [commandOperation, 'short up']
+      } else if ((Byte2 & 127) === 3) {
+        return [commandOperation, 'short down']
+      } else if ((Byte2 & 127) === 4) {
+        return [commandOperation, 'stop']
+      } else if ((Byte2 & 127) === 5) {
+        return [commandOperation, 'long-short up']
+      } else if ((Byte2 & 127) === 6) {
+        return [commandOperation, 'long-short down']
+      } else {
+        return [commandOperation, 'unknown command Byte3 for ' + Byte2]
+      }
+    case 22: // driving range limits for automatic button commands
+      return ['min. angle: ' + Byte2, 'max. angle: ' + Byte3, 'min. height: ' + Byte4, 'max. height: ' + Byte5]
+    default: return 'unknown value for command: ' + command
+  }
+}
+
+function griesserSectors (SectorCode) {
+  let SectorMin, SectorMax, dA, a, SectorCodeMin, SectorCodeMax
+  dA = 1
+  a = SectorCode
+  if (a > 0) {
+    while ((a & 1) === 0) {
+      a = (a / 2) >> 0
+      dA = dA * 2
+    }
+    dA = dA - 1
+    SectorMin = SectorCode - dA
+    SectorMax = SectorCode + dA
+  } else {
+    SectorMin = 0
+    SectorMax = 0
+  }
+  if (SectorMin === 0) {
+    SectorCodeMin = 0
+  } else {
+    SectorCodeMin = (((SectorMin - 1) / 2) >> 0) + 1
+  }
+  if (SectorMax === 0) {
+    SectorCodeMax = 0
+  } else {
+    SectorCodeMax = (((SectorMax - 1) / 2) >> 0) + 1
+  }
+  if (SectorCodeMax === SectorCodeMin) {
+    return [SectorCodeMin]
+  } else {
+    const Sectors = []
+    for (let i = SectorCodeMin; i <= SectorCodeMax; i++) {
+      Sectors.push(i)
+    }
+    return Sectors
+  }
+}
+
+function griesserSectorToSectorCode (sectors) {
+  if (sectors.length === 1) {
+    return sectors[0] + sectors[0] - 1
+  } else {
+    return Math.min(...sectors) + Math.max(...sectors) - 1
+  }
+}
+
+function griesserCommandToCommandCode (command) {
+  switch (command) {
+    case 'operation code': return 5
+    default: knxLog.get().error('not implemented yet: ' + command)
+  }
+}
+
+function griesserCommandToCommandCodeP1 (command) {
+  switch (command) {
+    case 'long up': return 128
+    case 'long down': return 129
+    case 'short up': return 130
+    case 'short down': return 131
+    case 'stop': return 132
+    case 'long-short up': return 133
+    case 'long-short down': return 134
+    default: knxLog.get().error('unknown command: ' + command)
+  }
+}
+
+function griesserCommand (command) {
+  switch (command) {
+    case 1: return 'drive command'
+    case 2: return 'value correction'
+    case 3: return 'automatic state'
+    case 4: return 'set/delete lock'
+    case 5: return 'operation code'
+    case 6: return 'set scene'
+    case 7: return 'special command'
+    case 8: return 'date'
+    case 9: return 'sync time'
+    case 10: return 'sensor reading notification'
+    case 11: return 'bus monitoring'
+    case 16: return 'driving range limits for safety drive commands'
+    case 17: return 'driving range limits for safety drive commands'
+    case 19: return 'driving range limits for safety drive commands'
+    case 20: return 'driving range limits for safety drive commands'
+    case 22: return 'driving range limits for automatic drive commands'
+    case 23: return 'driving range limits for automatic drive commands'
+    case 24: return 'driving range limits for automatic drive commands'
+    default: return 'unknown value for function: ' + command
+  }
+}
+
+function griesserPrio (prio, command) {
+  const prioCommand = ((command & 224) / 32) >> 0
+  if ((((prio & 252) / 4) >> 0) === 0) {
+    switch (prioCommand) {
+      case 0: return 'border command'
+      case 1: return 'automatic command'
+      case 3: return 'priority command'
+      case 4: return 'warning command'
+      case 5: return 'security command'
+      case 6: return 'danger command'
+      default: return 'unknown priority' + prioCommand
+    }
+  } else {
+    return '-'
+  }
+}
+
+// Send to BUS
+exports.formatAPDU = function (value) {
+  if (!value) {
+    knxLog.get().error('DPT60001: cannot write null value')
+  } else {
+    if (typeof value === 'object' &&
+    Object.prototype.hasOwnProperty.call(value, 'command') &&
+    Object.prototype.hasOwnProperty.call(value, 'data') &&
+    Object.prototype.hasOwnProperty.call(value, 'sectors') &&
+    value.data[0] === 'localoperation'
+    ) {
+      const sectorCode = griesserSectorToSectorCode(value.sectors)
+      const commandCode = griesserCommandToCommandCode(value.command)
+      const p1 = griesserCommandToCommandCodeP1(value.data[1])
+      const bufferTotal = Buffer.alloc(6)
+      bufferTotal[0] = parseInt(toRadix(sectorCode, 2).slice(-8), 2)
+      bufferTotal[1] = parseInt(toRadix(commandCode, 2).slice(-6) + toRadix(sectorCode, 2).slice(-10, -8), 2)
+      bufferTotal[2] = parseInt(toRadix(p1, 2).slice(-8), 2)
+      return bufferTotal
+    } else {
+      knxLog.get().error('DPT60001: Must supply an value {command:"operation code", data:["localoperation", "long up"], sectors:[159]}')
+    }
+  }
+}
+
+// RX from BUS
+exports.fromBuffer = function (buf) {
+  if (buf.length !== 6) {
+    knxLog
+      .get()
+      .warn(
+        'DPTGriesser.fromBuffer: buf should be 6 bytes long (got %d bytes)',
+        buf.length
+      )
+    return null
+  } else {
+    const hexToDecimal = (hex) => parseInt(hex, 16)
+    const bufTotale = buf.toString('hex')
+    const Byte0 = hexToDecimal(bufTotale.slice(0, 2))
+    const Byte1 = hexToDecimal(bufTotale.slice(2, 4))
+    const Byte2 = hexToDecimal(bufTotale.slice(4, 6))
+    const Byte3 = hexToDecimal(bufTotale.slice(6, 8))
+    const Byte4 = hexToDecimal(bufTotale.slice(8, 10))
+    const Byte5 = hexToDecimal(bufTotale.slice(10, 12))
+    const sectorCode = griesserSectorCode(Byte0, Byte1)
+    const commandCode = griesserCommandCode(Byte1, Byte2)
+
+    return {
+      Byte0,
+      Byte1,
+      Byte2,
+      Byte3,
+      Byte4,
+      Byte5,
+      sectorCode,
+      commandCode,
+      sectors: griesserSectors(sectorCode),
+      prio: griesserPrio(Byte1, Byte2),
+      command: griesserCommand(commandCode),
+      data: griesserParameter(commandCode, Byte2, Byte3, Byte4, Byte5)
+    }
+  }
+}
+
+// DPT Griesser Object basetype info
+exports.basetype = {
+  bitlength: 4 * 8 + 2 * 6 + 1 * 10,
+  valuetype: 'composite',
+  desc: 'Commands for solar shading actors',
+  help: `// Sample of 60001.
+  // Now are only  the local operation implemented.
+  // For example, for 60001, set the sector 42 localy up.  
+  msg.payload = { command: "operation code", data: ["localoperation", "long up"], sectors: [42] };
+  return msg;`
+}
+
+exports.subtypes = {
+  '001': {
+    desc: 'DPT_Griesser_Object',
+    name: 'Griesser Object'
+  }
+}

package/KNXEngine/dptlib/dpt9.js

@@ -11,7 +11,7 @@ const knxLog = require('./../KnxLog')
 
 const util = require('util')
 // kudos to http://croquetweak.blogspot.gr/2014/08/deconstructing-floats-frexp-and-ldexp.html
-function ldexp(mantissa, exponent) {
+function ldexp (mantissa, exponent) {
   return exponent > 1023 // avoid multiplying by infinity
     ? mantissa * Math.pow(2, 1023) * Math.pow(2, exponent - 1023)
     : exponent < -1074 // avoid multiplying by zero
@@ -19,7 +19,7 @@ function ldexp(mantissa, exponent) {
       : mantissa * Math.pow(2, exponent)
 }
 
-function frexp(value) {
+function frexp (value) {
   if (value === 0) return [value, 0]
   const data = new DataView(new ArrayBuffer(8))
   data.setFloat64(0, value)

package/KNXEngine/dptlib/index.js

@@ -148,7 +148,7 @@ dpts.fromBuffer = function (buf, dpt) {
   return value
 }
 
-function cloneDpt(d) {
+function cloneDpt (d) {
   let result = {}
   result = JSON.parse(JSON.stringify(d))
   result.fromBuffer = d.fromBuffer

package/nodes/knxUltimate-config.js

@@ -108,7 +108,7 @@ return msg;`,
     res.json(jRet)
   })
 
-  function knxUltimateConfigNode(config) {
+  function knxUltimateConfigNode (config) {
     RED.nodes.createNode(this, config)
     const node = this
     node.host = config.host
@@ -179,7 +179,7 @@ return msg;`,
     }
 
     node.setAllClientsStatus = (_status, _color, _text) => {
-      function nextStatus(_oClient) {
+      function nextStatus (_oClient) {
         let oClient = RED.nodes.getNode(_oClient.id)
         oClient.setNodeStatus({ fill: _color, shape: 'dot', text: _status + ' ' + _text, payload: '', GA: oClient.topic, dpt: '', devicename: '' })
         oClient = null
@@ -225,7 +225,7 @@ return msg;`,
     // 04/04/2021 Supergiovane, creates the service paths where the persistent files are created.
     // The values file is stored only upon disconnection/close
     // ************************
-    function setupDirectory(_aPath) {
+    function setupDirectory (_aPath) {
       if (!fs.existsSync(_aPath)) {
         // Create the path
         try {
@@ -245,7 +245,7 @@ return msg;`,
       if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info('KNXUltimate-config: payload cache set to ' + path.join(node.userDir, 'knxpersistvalues'))
     }
 
-    function saveExposedGAs() {
+    function saveExposedGAs () {
       const sFile = path.join(node.userDir, 'knxpersistvalues', 'knxpersist' + node.id + '.json')
       try {
         if (node.exposedGAs.length > 0) {
@@ -256,7 +256,7 @@ return msg;`,
         if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error('KNXUltimate-config: unable to write peristent values to the file ' + sFile + ' ' + err.message)
       }
     }
-    function loadExposedGAs() {
+    function loadExposedGAs () {
       const sFile = path.join(node.userDir, 'knxpersistvalues', 'knxpersist' + node.id + '.json')
       try {
         node.exposedGAs = JSON.parse(fs.readFileSync(sFile, 'utf8'))
@@ -479,7 +479,7 @@ return msg;`,
     }
 
     // 17/02/2020 Do initial read (called by node.timerDoInitialRead timer)
-    function DoInitialReadFromKNXBusOrFile() {
+    function DoInitialReadFromKNXBusOrFile () {
       if (node.linkStatus !== 'connected') return // 29/08/2019 If not connected, exit
       loadExposedGAs() // 04/04/2021 load the current values of GA payload
       try {
@@ -586,14 +586,14 @@ return msg;`,
       if (typeof _Protocol !== 'undefined') node.hostProtocol = _Protocol
       if (typeof _CSV !== 'undefined' && _CSV !== '') {
         try {
-          const sTemp = readCSV(_CSV) // 27/09/2022 Set the new CSV  
+          const sTemp = readCSV(_CSV) // 27/09/2022 Set the new CSV
           node.csv = sTemp
         } catch (error) {
           if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info('Node\'s main config setting error. ' + error.message || '')
         }
       }
-      
-      if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info("Node's main config setting has been changed. New config: IP " + node.host + ' Port ' + node.port + ' PhysicalAddress ' + node.physAddr + ' BindToInterface ' + node.KNXEthInterface + ((typeof _CSV !== 'undefined' && _CSV !== '') ? '. A new group address CSV has been imported.':''))
+
+      if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info("Node's main config setting has been changed. New config: IP " + node.host + ' Port ' + node.port + ' PhysicalAddress ' + node.physAddr + ' BindToInterface ' + node.KNXEthInterface + ((typeof _CSV !== 'undefined' && _CSV !== '') ? '. A new group address CSV has been imported.' : ''))
 
       try {
         node.Disconnect()
@@ -839,7 +839,7 @@ return msg;`,
 
     // Handle BUS events
     // ---------------------------------------------------------------------------------------
-    function handleBusEvents(_datagram, _echoed) {
+    function handleBusEvents (_datagram, _echoed) {
       // console.time('handleBusEvents');
 
       let _rawValue = null
@@ -1107,7 +1107,7 @@ return msg;`,
       node.telegramsQueue.unshift(_clonedMessage) // Add _clonedMessage as first in the queue pile
     }
 
-    function handleTelegramQueue() {
+    function handleTelegramQueue () {
       if (node.knxConnection !== null || node.host.toUpperCase() === 'EMULATE') {
         if (node.lockHandleTelegramQueue === true) return // Exits if the funtion is busy
         node.lockHandleTelegramQueue = true // Lock the function. It cannot be called again until finished.
@@ -1250,14 +1250,14 @@ return msg;`,
     }
 
     // 14/08/2019 If the node has payload same as the received telegram, return false
-    function checkRBEInputFromKNXBusAllowSend(_node, _KNXTelegramPayload) {
+    function checkRBEInputFromKNXBusAllowSend (_node, _KNXTelegramPayload) {
       if (_node.inputRBE !== true) return true
 
       return !_.isEqual(_node.currentPayload, _KNXTelegramPayload)
     }
 
     // 26/10/2019 Try to figure out the datapoint type from raw value
-    function tryToFigureOutDataPointFromRawValue(_rawValue) {
+    function tryToFigureOutDataPointFromRawValue (_rawValue) {
       // 25/10/2019 Try some Datapoints
       if (_rawValue === null) return '1.001'
       if (_rawValue.length === 1) {
@@ -1303,7 +1303,7 @@ return msg;`,
       }
     }
 
-    function buildInputMessage({ _srcGA, _destGA, _event, _Rawvalue, _inputDpt, _devicename, _outputtopic, _oNode }) {
+    function buildInputMessage ({ _srcGA, _destGA, _event, _Rawvalue, _inputDpt, _devicename, _outputtopic, _oNode }) {
       let sPayloadmeasureunit = 'unknown'
       let sDptdesc = 'unknown'
       let sPayloadsubtypevalue = 'unknown'
@@ -1430,7 +1430,7 @@ return msg;`,
       }
     };
 
-    function readCSV(_csvText) {
+    function readCSV (_csvText) {
       // 24/02/2020, in the middle of Coronavirus emergency in Italy. Check if it a CSV ETS Export of group addresses, or if it's an EFS
       if (_csvText.split('\n')[0].toUpperCase().indexOf('"') == -1) return readESF(_csvText)
 
@@ -1511,7 +1511,7 @@ return msg;`,
       }
     }
 
-    function readESF(_esfText) {
+    function readESF (_esfText) {
       // 24/02/2020 must do an EIS to DPT conversion.
       // https://www.loxone.com/dede/kb/eibknx-datentypen/
       // Format: Attuatori luci.Luci primo piano.0/0/1	Luce camera da letto	EIS 1 'Switching' (1 Bit)	Low
@@ -1607,7 +1607,7 @@ return msg;`,
     }
 
     // 23/08/2019 Delete unwanted CRLF in the GA description
-    function correctCRLFInCSV(_csv) {
+    function correctCRLFInCSV (_csv) {
       let sOut = '' // fixed output text to return
       let sChar = ''
       let bStart = false
@@ -1640,7 +1640,7 @@ return msg;`,
     }
 
     // 26/02/2021 Used to send the messages if the node gateway is in EMULATION mode
-    function sendEmulatedTelegram(_msg) {
+    function sendEmulatedTelegram (_msg) {
       // INPUT IS
       // _msg = {
       //     grpaddr: '5/0/1',

package/nodes/knxUltimateViewer.js

@@ -1,7 +1,7 @@
 const KNXAddress = require('./../KNXEngine/protocol/KNXAddress').KNXAddress
 
 module.exports = function (RED) {
-  function knxUltimateViewer(config) {
+  function knxUltimateViewer (config) {
     RED.nodes.createNode(this, config)
     const node = this
     node.server = RED.nodes.getNode(config.server)
@@ -96,7 +96,7 @@ module.exports = function (RED) {
           } else if (typeof element.payload === 'object') {
             // Is maybe a JSON?
             try {
-              //sPayload += '<td>' + JSON.stringify(element.payload) + '</td>'
+              // sPayload += '<td>' + JSON.stringify(element.payload) + '</td>'
               sPayload += '<td><i>' + element.rawPayload + '</i></td>'
             } catch (error) {
               sPayload += '<td>' + element.payload + '</td>'

package/nodes/knxUltimateWatchDog.js

@@ -1,7 +1,7 @@
 const ping = require('ping')
 
 module.exports = function (RED) {
-  function knxUltimateWatchDog(config) {
+  function knxUltimateWatchDog (config) {
     RED.nodes.createNode(this, config)
     const node = this
     node.server = RED.nodes.getNode(config.server)
@@ -26,7 +26,7 @@ module.exports = function (RED) {
     node.isWatchDog = true
     node.checkLevel = config.checkLevel !== undefined ? config.checkLevel : 'Ethernet'
     node.icountMessageInWindow = 0
-    node.alreadyNotifiedArray = new Array // 20/10/2022 array of already notified errors generated by every single KNX-Ultimate node. This prevents floading with repeated errors, in case of disconnection
+    node.alreadyNotifiedArray = new Array() // 20/10/2022 array of already notified errors generated by every single KNX-Ultimate node. This prevents floading with repeated errors, in case of disconnection
 
     // Used to call the status update from the config node.
     node.setNodeStatus = ({ fill, shape, text, payload, GA, dpt, devicename }) => {
@@ -42,7 +42,7 @@ module.exports = function (RED) {
 
     if (!node.server) return
 
-    function handleTheDog() {
+    function handleTheDog () {
       node.beatNumber += 1
       if (node.beatNumber > node.maxRetry) {
         // Confirmed connection error
@@ -110,7 +110,7 @@ module.exports = function (RED) {
 
       // 22/10/2022 Find in the array of notified nodes. If found and equal, don't send.
       // Warning: to be optimized: the watchdog will not emit any "red" message anymore, unless the error's description changes.
-      let oMsg = node.alreadyNotifiedArray.find(a => a.nodeid === msg.nodeid)
+      const oMsg = node.alreadyNotifiedArray.find(a => a.nodeid === msg.nodeid)
       if (oMsg === undefined) {
         node.alreadyNotifiedArray.push({ nodeid: msg.nodeid, description: msg.description })
         node.send(msg)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-knx-ultimate",
-  "version": "1.4.6",
+  "version": "1.4.7",
   "description": "Control your KNX intallation via Node-Red! Single Node KNX IN/OUT with optional ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "mkdirp": "1.0.4",