node-red-contrib-knx-ultimate 1.3.33 → 1.3.34

package/CHANGELOG.md

@@ -7,11 +7,19 @@
 # CHANGELOG
 
 <p>
-<b>Version 1.3.33</b> - March 2022<br/>
+<b>Version 1.3.34</b> - March 2022<br/>
 - Reset handlers by removing/adding every time the connection is set by "new" directive.<br/>
 - Fixed an issue causing glitches, when the disconnection is requested by the KNX interface instead of KNX-Ultimate.<br/>
 - Fixed an issue occurring when the disconnection is started from KNX-Ultimate by the DISCONNECT_REQUEST, but the KNX Interface fails to send the DISCONNECT_RESPONSE to confirm the disconnection.<br/>
 - Updated knxUltimate-config.js to actively disconnect and close the socket when the disconnection is requested by the KNX Interface. All other cases (disconnection by ethernet cable, disconnection by unreachable KNX Interface, disconnection by temporary out of access, disconnection by means of user intervention, disconnection by Watchdog node etc...) are not affected by this issue.<br/>
+- Optimized memory allocation to allow the garbage collector to get rid of unref variables.<br/>
+- Scene controller: fixed node status issues.<br/>
+- Load control: code revision.<br/>
+- Logger: code revision.<br/>
+- Watchdog: code revision.<br/>
+- Device node: code revision.<br/>
+- Global Context: code revision.<br/>
+- Wiki: merged Global Context node sample, into one single page for better readability.<br/>
 </p>
 <p>
 <b>Version 1.3.32</b> - February 2022<br/>

package/KNXEngine/KNXClient.js

@@ -94,8 +94,8 @@ class KNXClient extends EventEmitter {
         super();
         this._clientTunnelSeqNumber = -1;
         this._options = options;//Object.assign(optionsDefaults, options);
-        this._options.connectionKeepAliveTimeout = KNXConstants.KNX_CONSTANTS.CONNECTION_ALIVE_TIME,
-            this._localPort = null;
+        this._options.connectionKeepAliveTimeout = KNXConstants.KNX_CONSTANTS.CONNECTION_ALIVE_TIME;
+        //this._localPort = null;
         this._peerHost = this._options.ipAddr;
         this._peerPort = this._options.ipPort;
         this._connectionTimeoutTimer = null;
@@ -125,8 +125,6 @@ class KNXClient extends EventEmitter {
 
         // 12/03/2022 Remove all listeners
         this.removeAllListeners();
-
-        let conn = this;
         // 07/12/2021 Based on protocol instantiate the right socket
         if (this._options.hostProtocol === "TunnelUDP") {
             this._clientSocket = dgram.createSocket({ type: 'udp4', reuseAddr: false });
@@ -134,11 +132,12 @@ class KNXClient extends EventEmitter {
             this._clientSocket.on(SocketEvents.message, this._processInboundMessage);
             this._clientSocket.on(SocketEvents.error, error => this.emit(KNXClientEvents.error, error));
             this._clientSocket.on(SocketEvents.close, info => this.emit(KNXClientEvents.close, info));
-            this._clientSocket.bind({ address: this._options.localIPAddress, port: this._options._peerPort }, () => {
+            let conn = this;
+            this._clientSocket.bind({ address: this._options.localIPAddress, port: this._options._peerPort }, function () {
                 try {
                     conn._clientSocket.setTTL(128);
                 } catch (error) {
-                    if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("UDP:  Error setting SetTTL " + error.message || "");
+                    if (conn.sysLogger !== undefined && conn.sysLogger !== null) conn.sysLogger.error("UDP:  Error setting SetTTL " + error.message || "");
                 }
             });
 
@@ -154,38 +153,39 @@ class KNXClient extends EventEmitter {
             this._clientSocket.on(SocketEvents.close, info => this.emit(KNXClientEvents.close, info));
 
         } else if (this._options.hostProtocol === "Multicast") {
-            let conn = this;
             this._clientSocket = dgram.createSocket({ type: 'udp4', reuseAddr: true });
             this._clientSocket.removeAllListeners();  // 12/03/2022 Remove all listeners
             this._clientSocket.on(SocketEvents.listening, function () {
-                try {
-                    conn._clientSocket.addMembership(conn._peerHost, conn._options.localIPAddress);
-                } catch (err) {
-                    if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Multicast: cannot add membership (%s)", err);
-                    try {
-                        this.emit(KNXClientEvents.error, err);
-                    } catch (error) { }
-                    return;
-                }
+               
             });
+            let conn = this;
             this._clientSocket.on(SocketEvents.message, this._processInboundMessage);
             this._clientSocket.on(SocketEvents.error, error => this.emit(KNXClientEvents.error, error));
             this._clientSocket.on(SocketEvents.close, info => this.emit(KNXClientEvents.close, info));
-            this._clientSocket.bind(this._peerPort, () => {
+            this._clientSocket.bind(this._peerPort, function () {
                 try {
                     conn._clientSocket.setMulticastTTL(128);
-                    conn._clientSocket.setMulticastInterface(this._options.localIPAddress);
+                    conn._clientSocket.setMulticastInterface(conn._options.localIPAddress);
                 } catch (error) {
-                    if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Multicast: Error setting SetTTL " + error.message || "");
+                    if (conn.sysLogger !== undefined && conn.sysLogger !== null) conn.sysLogger.error("Multicast: Error setting SetTTL " + error.message || "");
                 }
-                this._localPort = this._clientSocket.address().port;// 07/12/2021 Get the local port used bu the socket
+                try {
+                    conn._clientSocket.addMembership(conn._peerHost, conn._options.localIPAddress);
+                } catch (err) {
+                    if (conn.sysLogger !== undefined && conn.sysLogger !== null) conn.sysLogger.error("Multicast: cannot add membership (%s)", err);
+                    try {
+                        conn.emit(KNXClientEvents.error, err);
+                    } catch (error) { }
+                    return;
+                }
+                //this._localPort = this._clientSocket.address().port;// 07/12/2021 Get the local port used bu the socket
             });
         }
 
         this._clientTunnelSeqNumber = -1;
         this._channelID = null;
         this._connectionState = STATE.DISCONNECTED;
-        this._tunnelReqTimer = null;
+        this._timerWaitingForACK = null;
         this._numFailedTelegramACK = 0; // 25/12/2021 Keep count of the failed tunnelig ACK telegrams
 
     }
@@ -237,21 +237,21 @@ class KNXClient extends EventEmitter {
         }
         return new KNXDataBuffer(adpu.data, IDataPoint);
     }
-    bindSocketPortAsync(port = KNXConstants.KNX_CONSTANTS.KNX_PORT, host = '0.0.0.0') {
-        return new Promise((resolve, reject) => {
-            try {
-                this._clientSocket.bind(port, host, () => {
-                    this._clientSocket.setMulticastInterface(host);
-                    this._clientSocket.setMulticastTTL(128);
-                    this._options.localIPAddress = host;
-                    resolve();
-                });
-            }
-            catch (err) {
-                reject(err);
-            }
-        });
-    }
+    // bindSocketPortAsync(port = KNXConstants.KNX_CONSTANTS.KNX_PORT, host = '0.0.0.0') {
+    //     return new Promise((resolve, reject) => {
+    //         try {
+    //             this._clientSocket.bind(port, host, () => {
+    //                 this._clientSocket.setMulticastInterface(host);
+    //                 this._clientSocket.setMulticastTTL(128);
+    //                 this._options.localIPAddress = host;
+    //                 resolve();
+    //             });
+    //         }
+    //         catch (err) {
+    //             reject(err);
+    //         }
+    //     });
+    // }
     send(knxPacket) {
 
         // Logging
@@ -318,10 +318,8 @@ class KNXClient extends EventEmitter {
 
     /**
     *
-    * @param {KNXAddress} srcAddress
     * @param {KNXAddress} dstAddress
     * @param {KNXDataBuffer} data
-    * @param {function} cb
     */
     // sendWriteRequest(dstAddress, data) {
     write(dstAddress, data, dptid) {
@@ -525,35 +523,35 @@ class KNXClient extends EventEmitter {
             clearTimeout(this._heartbeatTimer);
         }
     }
-    isDiscoveryRunning() {
-        return this._discovery_timer != null;
-    }
-    startDiscovery() {
-        if (this.isDiscoveryRunning()) {
-            throw new Error('Discovery already running');
-        }
-        this._discovery_timer = setTimeout(() => {
-            this._discovery_timer = null;
-        }, 1000 * KNXConstants.KNX_CONSTANTS.SEARCH_TIMEOUT);
-        this._sendSearchRequestMessage();
-    }
-    stopDiscovery() {
-        if (!this.isDiscoveryRunning()) {
-            return;
-        }
-        if (this._discovery_timer !== null) clearTimeout(this._discovery_timer);
-        this._discovery_timer = null;
-    }
-    getDescription(host, port) {
-        if (this._clientSocket == null) {
-            throw new Error('No client socket defined');
-        }
-        this._connectionTimeoutTimer = setTimeout(() => {
-            this._connectionTimeoutTimer = null;
-        }, 1000 * KNXConstants.KNX_CONSTANTS.DEVICE_CONFIGURATION_REQUEST_TIMEOUT);
-        this._awaitingResponseType = KNXConstants.KNX_CONSTANTS.DESCRIPTION_RESPONSE;
-        this._sendDescriptionRequestMessage(host, port);
-    }
+    // isDiscoveryRunning() {
+    //     return this._discovery_timer != null;
+    // }
+    // startDiscovery() {
+    //     if (this.isDiscoveryRunning()) {
+    //         throw new Error('Discovery already running');
+    //     }
+    //     this._discovery_timer = setTimeout(() => {
+    //         this._discovery_timer = null;
+    //     }, 1000 * KNXConstants.KNX_CONSTANTS.SEARCH_TIMEOUT);
+    //     this._sendSearchRequestMessage();
+    // }
+    // stopDiscovery() {
+    //     if (!this.isDiscoveryRunning()) {
+    //         return;
+    //     }
+    //     if (this._discovery_timer !== null) clearTimeout(this._discovery_timer);
+    //     this._discovery_timer = null;
+    // }
+    // getDescription(host, port) {
+    //     if (this._clientSocket == null) {
+    //         throw new Error('No client socket defined');
+    //     }
+    //     this._connectionTimeoutTimer = setTimeout(() => {
+    //         this._connectionTimeoutTimer = null;
+    //     }, 1000 * KNXConstants.KNX_CONSTANTS.DEVICE_CONFIGURATION_REQUEST_TIMEOUT);
+    //     this._awaitingResponseType = KNXConstants.KNX_CONSTANTS.DESCRIPTION_RESPONSE;
+    //     this._sendDescriptionRequestMessage(host, port);
+    // }
     Connect(knxLayer = TunnelCRI.TunnelTypes.TUNNEL_LINKLAYER) {
 
         if (this._clientSocket == null) {
@@ -600,7 +598,7 @@ class KNXClient extends EventEmitter {
             // TCP
             const timeoutError = new Error(`Connection timeout to ${this._peerHost}:${this._peerPort}`);
             let conn = this;
-            this._clientSocket.connect({ port: this._peerPort, host: this._peerHost, localAddress: this._options.localAddress }, function () {
+            this._clientSocket.connect( this._peerPort, this._peerHost, function () {
                 // conn._timer = setTimeout(() => {
                 //     conn._timer = null;
                 //     conn.emit(KNXClientEvents.error, timeoutError);
@@ -614,6 +612,11 @@ class KNXClient extends EventEmitter {
 
             // Multicast
             this._connectionState = STATE.CONNECTED;
+
+            // 16/03/2022 These two are referring to tunneling connection, but i set it here as well. Non si sa mai.
+            this._numFailedTelegramACK = 0; // 25/12/2021 Reset the failed ACK counter
+            this._clearToSend = true; // 26/12/2021 allow to send
+
             this._clientTunnelSeqNumber = -1;
             try {
                 this.emit(KNXClientEvents.connected, this._options);
@@ -659,7 +662,7 @@ class KNXClient extends EventEmitter {
         this._awaitingResponseType = KNXConstants.KNX_CONSTANTS.DISCONNECT_RESPONSE;
         this._sendDisconnectRequestMessage(this._channelID);
         // 12/03/2021 Set disconnected if not already set by DISCONNECT_RESPONSE sent from the IP Interface
-        setTimeout(() => {
+        let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
             if (this._connectionState !== STATE.DISCONNECTED) this._setDisconnected("Forced call from KNXClient Disconnect() function, because the KNX Interface hasn't sent the DISCONNECT_RESPONSE in time.");
         }, 2000);
     }
@@ -673,10 +676,9 @@ class KNXClient extends EventEmitter {
         }
         this._connectionState = STATE.DISCONNECTED;
         this.stopHeartBeat();
-        if (this._timerTimeoutSendDisconnectRequestMessagetimer !== null) clearTimeout(this._timerTimeoutSendDisconnectRequestMessagetimer);
         this._timerTimeoutSendDisconnectRequestMessage = null;
         if (this._connectionTimeoutTimer !== null) clearTimeout(this._connectionTimeoutTimer);
-        if (this._tunnelReqTimer !== null) clearTimeout(this._tunnelReqTimer);
+        if (this._timerWaitingForACK !== null) clearTimeout(this._timerWaitingForACK);
         this._clientTunnelSeqNumber = -1;
         this._channelID = null;
 
@@ -689,13 +691,12 @@ class KNXClient extends EventEmitter {
             this.emit(KNXClientEvents.disconnected, this._options.ipAddr + ":" + this._options.ipPort + " " + _sReason);
         } catch (error) {
         }
-        this._clearToSend = true; // 26/12/2021 allow to send
-
+        this._clearToSend = true; // 26/12/2021 allow to send                
     }
     _runHeartbeat() {
         if (this._heartbeatRunning) {
             this.getConnectionStatus();
-            setTimeout(() => {
+            let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                 this._runHeartbeat();
             }, 1000 * this._options.connectionKeepAliveTimeout);
         }
@@ -719,10 +720,10 @@ class KNXClient extends EventEmitter {
     //     return cEMIMessage.dstAddress.toString();
     // }
     _setTimerWaitingForACK(knxTunnelingRequest) {
-        const timeoutErr = new errors.RequestTimeoutError(`RequestTimeoutError seqCounter:${knxTunnelingRequest.seqCounter}, DestAddr:${knxTunnelingRequest.cEMIMessage.dstAddress.toString() || "Non definito"},  AckRequested:${knxTunnelingRequest.cEMIMessage.control.ack}, timed out waiting telegram acknowledge by ${this._options.ipAddr || "No Peer host detected"}`);
-        if (this._tunnelReqTimer !== null) clearTimeout(this._tunnelReqTimer);
         this._clearToSend = false; // 26/12/2021 stop sending until ACK received
-        this._tunnelReqTimer = setTimeout(() => {
+        const timeoutErr = new errors.RequestTimeoutError(`RequestTimeoutError seqCounter:${knxTunnelingRequest.seqCounter}, DestAddr:${knxTunnelingRequest.cEMIMessage.dstAddress.toString() || "Non definito"},  AckRequested:${knxTunnelingRequest.cEMIMessage.control.ack}, timed out waiting telegram acknowledge by ${this._options.ipAddr || "No Peer host detected"}`);
+        if (this._timerWaitingForACK !== null) clearTimeout(this._timerWaitingForACK);
+        this._timerWaitingForACK = setTimeout(() => {
             try {
                 this._numFailedTelegramACK += 1;
                 if (this._numFailedTelegramACK > 2) {
@@ -797,6 +798,12 @@ class KNXClient extends EventEmitter {
                         this._setDisconnected("Connect response error " + knxConnectResponse.status);
                         return;
                     }
+
+                    // 16/03/2022
+                    if (this._timerWaitingForACK !== null) clearTimeout(this._timerWaitingForACK);
+                    this._numFailedTelegramACK = 0; // 16/03/2022 Reset the failed ACK counter
+                    this._clearToSend = true; // 16/03/2022 allow to send
+
                     this._connectionState = STATE.CONNECTED;
                     this._channelID = knxConnectResponse.channelID;
                     try {
@@ -837,7 +844,7 @@ class KNXClient extends EventEmitter {
                 this._connectionState = STATE.DISCONNECTING;
                 this._sendDisconnectResponseMessage(knxDisconnectRequest.channelID);
                 // 12/03/2021 Added 1 sec delay.
-                setTimeout(() => {
+                let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                     this._setDisconnected("Received KNX packet: DISCONNECT_REQUEST, ChannelID:" + this._channelID + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
                 }, 1000);
             }
@@ -896,7 +903,7 @@ class KNXClient extends EventEmitter {
                 // Check the received ACK sequence number
                 if (!this._options.suppress_ack_ldatareq) {
                     if (knxTunnelingAck.seqCounter === this._getSeqNumber()) {
-                        if (this._tunnelReqTimer !== null) clearTimeout(this._tunnelReqTimer);
+                        if (this._timerWaitingForACK !== null) clearTimeout(this._timerWaitingForACK);
                         this._numFailedTelegramACK = 0; // 25/12/2021 clear the current ACK failed telegram number
                         this._clearToSend = true; // I'm ready to send a new datagram now
                         try {
@@ -996,7 +1003,7 @@ class KNXClient extends EventEmitter {
         this.send(KNXProtocol.KNXProtocol.newKNXDescriptionRequest(new HPAI.HPAI(this._options.localIPAddress)));
     }
     _sendSearchRequestMessage() {
-        this.send(KNXProtocol.KNXProtocol.newKNXSearchRequest(new HPAI.HPAI(this._options.localIPAddress, this._localPort)), KNXConstants.KNX_CONSTANTS.KNX_PORT, KNXConstants.KNX_CONSTANTS.KNX_IP);
+        //this.send(KNXProtocol.KNXProtocol.newKNXSearchRequest(new HPAI.HPAI(this._options.localIPAddress, this._localPort)), KNXConstants.KNX_CONSTANTS.KNX_PORT, KNXConstants.KNX_CONSTANTS.KNX_IP);
     }
     _sendConnectRequestMessage(cri) {
         this.send(KNXProtocol.KNXProtocol.newKNXConnectRequest(cri));

package/KNXEngine/KnxLog.js

@@ -1,6 +1,8 @@
 /**
 * (C) 2021 Supergiovane
 */
+"use strict";
+
 const util = require('util')
 const possibleLEvels = ['silent', 'error', 'warn', 'info', 'debug', 'trace'];
 let logger

package/nodes/knxUltimate-config.js

@@ -1,3 +1,5 @@
+
+
 // const knx = require('./../knxultimate-api2');
 // const dptlib = require('./../knxultimate-api2/src/dptlib');
 const knx = require("./../KNXEngine");
@@ -11,23 +13,23 @@ var fs = require('fs');
 
 
 //Helpers
-sortBy = (field) => (a, b) => {
+let sortBy = (field) => (a, b) => {
     if (a[field] > b[field]) { return 1 } else { return -1 }
 };
 
 
-onlyDptKeys = (kv) => {
+let onlyDptKeys = (kv) => {
     return kv[0].startsWith("DPT")
 };
 
-extractBaseNo = (kv) => {
+let extractBaseNo = (kv) => {
     return {
         subtypes: kv[1].subtypes,
         base: parseInt(kv[1].id.replace("DPT", ""))
     }
 };
 
-convertSubtype = (baseType) => (kv) => {
+let convertSubtype = (baseType) => (kv) => {
     let value = `${baseType.base}.${kv[0]}`;
     //let sRet = value + " " + kv[1].name + (kv[1].unit === undefined ? "" : " (" + kv[1].unit + ")");
     let sRet = value + " " + kv[1].name;
@@ -47,7 +49,7 @@ convertSubtype = (baseType) => (kv) => {
 // }
 
 
-toConcattedSubtypes = (acc, baseType) => {
+let toConcattedSubtypes = (acc, baseType) => {
     let subtypes =
         Object.entries(baseType.subtypes)
             .sort(sortBy(0))
@@ -59,6 +61,8 @@ toConcattedSubtypes = (acc, baseType) => {
 
 module.exports = (RED) => {
 
+    "use strict";
+
     RED.httpAdmin.get("/knxUltimateDpts", RED.auth.needsPermission('knxUltimate-config.read'), function (req, res) {
         const dpts =
             Object.entries(dptlib)
@@ -135,11 +139,12 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
         node.userDir = path.join(RED.settings.userDir, "knxultimatestorage"); // 04/04/2021 Supergiovane: Storage for service files
         node.exposedGAs = [];
         node.loglevel = config.loglevel !== undefined ? config.loglevel : "error"; // 18/02/2020 Loglevel default error
+        node.sysLogger = null; // 20/03/2022 Default
         try {
-            node.sysLogger = null;
             node.sysLogger = require("./utils/sysLogger.js").get({ loglevel: node.loglevel }); // 08/04/2021 new logger to adhere to the loglevel selected in the config-window            
         } catch (error) { }
         // 12/11/2021 Connect at start delay
+        node.autoReconnect = true; // 20/03/2022 Default
         if (config.autoReconnect === "no" || config.autoReconnect === false) {
             node.autoReconnect = false;
         } else {
@@ -155,7 +160,8 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
         node.knxConnectionProperties = null; // Retains the connection properties
         node.allowLauch_initKNXConnection = true; // See the node.timerKNXUltimateCheckState function
         node.timerClearTelegramQueue = null; // Timer to clear the telegram's queue after long disconnection
-
+        node.hostProtocol = "TunnelUDP"; // 20/03/2022 Default
+        node.knxConnection = null; // 20/03/2022 Default
         // 15/12/2021
         node.adaptProtocolBasedOnIP = () => {
             // Auto set protocol based on IP            
@@ -192,7 +198,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
         node.startTimerClearTelegramQueue = () => {
             if (node.timerClearTelegramQueue === null) {
                 node.timerClearTelegramQueue = setTimeout(() => {
-                    setTimeout(() => {
+                    let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                         node.setAllClientsStatus("Queue", "grey", "Deleted TX");
                     }, 200);
                     node.telegramsQueue = [];
@@ -207,6 +213,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
         // 15/11/2021 Function to load the keyring file exported from ETS
         //
         //
+        node.jKNXSecureKeyring = null;
         try {
             (async () => {
                 if (node.knxSecureSelected) {
@@ -220,7 +227,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
             if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error("KNXUltimate-config: KNX Secure: error parsing the keyring XML: " + error.message);
             node.jKNXSecureKeyring = null;
             node.knxSecureSelected = false;
-            setTimeout(() => node.setAllClientsStatus("Error", "red", "KNX Secure " + error.message), 2000);
+            let t = setTimeout(() => node.setAllClientsStatus("Error", "red", "KNX Secure " + error.message), 2000); // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
         }
 
 
@@ -323,7 +330,6 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
             var sGA = "";
             var sDPT = "";
             var sName = "";
-            var sNodeID = "";
             let sOptions = "";
             try {
                 if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info("KNXUltimate-config: Total knx-ultimate nodes: " + _node.nodeClients.length || 0);
@@ -506,7 +512,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                                     if (oExposedGA !== undefined) {
 
                                         // Retrieve the value from exposedGAs
-                                        let msg = buildInputMessage({ _srcGA: "", _destGA: oClient.topic, _event: "GroupValue_Response", _Rawvalue: new Buffer.from(oExposedGA.rawValue.data), _inputDpt: oClient.dpt, _devicename: oClient.name ? oClient.name : "", _outputtopic: oClient.outputtopic, _oNode: oClient })
+                                        let msg = buildInputMessage({ _srcGA: "", _destGA: oClient.topic, _event: "GroupValue_Response", _Rawvalue: Buffer.from(oExposedGA.rawValue.data), _inputDpt: oClient.dpt, _devicename: oClient.name ? oClient.name : "", _outputtopic: oClient.outputtopic, _oNode: oClient })
                                         oClient.previouspayload = ""; // 05/04/2021 Added previous payload
                                         oClient.currentPayload = msg.payload;
                                         oClient.setNodeStatus({ fill: "grey", shape: "dot", text: "Update value from persist file", payload: oClient.currentPayload, GA: oClient.topic, dpt: oClient.dpt, devicename: oClient.name || "" });
@@ -596,7 +602,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                 node.Disconnect();
                 // node.setKnxConnectionProperties(); // 28/12/2021 Commented 
                 node.setAllClientsStatus("CONFIG", "yellow", "KNXUltimage-config:setGatewayConfig: disconnected by new setting...");
-                if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.debug("KNXUltimage-config:setGatewayConfig: disconnected by setGatewayConfig. AutoReconnect = " + oldReconnect);
+                if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.debug("KNXUltimage-config:setGatewayConfig: disconnected by setGatewayConfig.");
             } catch (error) { }
 
         };
@@ -619,7 +625,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                 try {
                     node.autoReconnect = false;
                     node.Disconnect();
-                    setTimeout(() => {
+                    let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                         node.setAllClientsStatus("CONFIG", "yellow", "Forced GW disconnection and stop reconnection attempts, from watchdog.");
                     }, 2000);
                 } catch (error) { }
@@ -759,10 +765,10 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                     if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error("knxUltimate-config: Disconnected by: " + (err.message === undefined ? err : err.message));
                 });
                 // Call discoverCB when a knx gateway has been discovered.
-                node.knxConnection.on(knx.KNXClient.KNXClientEvents.discover, info => {
-                    const [ip, port] = info.split(":");
-                    discoverCB(ip, port);
-                });
+                // node.knxConnection.on(knx.KNXClient.KNXClientEvents.discover, info => {
+                //     const [ip, port] = info.split(":");
+                //     discoverCB(ip, port);
+                // });
                 node.knxConnection.on(knx.KNXClient.KNXClientEvents.disconnected, info => {
                     saveExposedGAs(); // 13/12/2021 save the current values of GA payload
                     node.startTimerClearTelegramQueue(); // 21/01/2022 Clear the telegram queue after a while
@@ -785,7 +791,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                     // Start the timer to do initial read.
                     if (node.timerDoInitialRead !== null) clearTimeout(node.timerDoInitialRead);
                     node.timerDoInitialRead = setTimeout(DoInitialReadFromKNXBusOrFile, 6000); // 17/02/2020 Do initial read of all nodes requesting initial read
-                    setTimeout(() => {
+                    let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                         node.setAllClientsStatus("Connected.", "green", "On duty.")
                     }, 500);
                     if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.info("knxUltimate-config: Connected to %o", info);
@@ -813,7 +819,8 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
             } catch (error) {
                 if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error("KNXUltimate-config: Error in instantiating knxConnection " + error.message + ". Node " + node.name);
                 node.linkStatus = "disconnected";
-                setTimeout(() => node.setAllClientsStatus("Error in instantiating knxConnection " + error, "red", "Error"), 200);
+                // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
+                let t = setTimeout(() => node.setAllClientsStatus("Error in instantiating knxConnection " + error, "red", "Error"), 200);
             }
 
         };
@@ -824,7 +831,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
         function handleBusEvents(_datagram, _echoed) {
 
 
-            // _rawValue
+            let _rawValue = null;
             try {
                 _rawValue = _datagram.cEMIMessage.npdu.dataValue;
             } catch (error) {
@@ -832,15 +839,15 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
             }
 
 
-            // _evt
+            let _evt = null;
             if (_datagram.cEMIMessage.npdu.isGroupRead) _evt = "GroupValue_Read";
             if (_datagram.cEMIMessage.npdu.isGroupResponse) _evt = "GroupValue_Response";
             if (_datagram.cEMIMessage.npdu.isGroupWrite) _evt = "GroupValue_Write";
 
-            // _src
+            let _src = null;
             _src = _datagram.cEMIMessage.srcAddress.toString();
 
-            // _dest
+            let _dest = null;
             _dest = _datagram.cEMIMessage.dstAddress.toString();
 
             let isRepeated = _datagram.cEMIMessage.control.repeat === 1 ? false : true;
@@ -945,10 +952,12 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                             } else if (input.listenallga == true) {
 
                                 // Get the GA from CVS
-                                let oGA;
-                                try {
-                                    oGA = node.csv.filter(sga => sga.ga == _dest)[0];
-                                } catch (error) { }
+                                let oGA = undefined;
+                                if (node.csv !== undefined) {
+                                    try {
+                                        oGA = node.csv.filter(sga => sga.ga == _dest)[0];
+                                    } catch (error) { }
+                                }
 
                                 // 25/10/2019 TRY TO AUTO DECODE IF Group address not found in the CSV
                                 let msg = buildInputMessage({ _srcGA: _src, _destGA: _dest, _event: _evt, _Rawvalue: _rawValue, _inputDpt: (typeof oGA === "undefined") ? null : oGA.dpt, _devicename: (typeof oGA === "undefined") ? input.name || "" : oGA.devicename, _outputtopic: _dest, _oNode: input });
@@ -1251,7 +1260,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
         }
 
         // 14/08/2019 If the node has payload same as the received telegram, return false
-        checkRBEInputFromKNXBusAllowSend = (_node, _KNXTelegramPayload) => {
+        function checkRBEInputFromKNXBusAllowSend(_node, _KNXTelegramPayload) {
             if (_node.inputRBE !== true) return true;
 
             return !_.isEqual(_node.currentPayload, _KNXTelegramPayload);
@@ -1350,7 +1359,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
 
                 if (dpt !== null && _Rawvalue !== null) {
                     try {
-                        var jsValue = dptlib.fromBuffer(_Rawvalue, dpt)
+                        jsValue = dptlib.fromBuffer(_Rawvalue, dpt)
                         if (jsValue === null) {
                             if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.error("knxUltimate-config: buildInputMessage: received a wrong datagram form KNX BUS, from device " + _srcGA + " Destination " + _destGA + " Event " + _event + " GA's Datapoint " + (_inputDpt === null ? "THE ETS FILE HAS NOT BEEN IMPORTED, SO I'M TRYING TO FIGURE OUT WHAT DATAPOINT BELONGS THIS GROUP ADDRESS. DON'T BLAME ME IF I'M WRONG, INSTEAD, IMPORT THE ETS FILE!" : _inputDpt) + " Devicename " + _devicename + " Topic " + _outputtopic + " NodeID " + _oNode.id || "");
                         }
@@ -1720,7 +1729,6 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
 
                         let msg = {
                             topic: _msg.grpaddr,//input.topic,
-                            payload: _msg.payload,
                             devicename: (typeof oGA === "undefined") ? input.name || "" : oGA.devicename,
                             payload: _msg.payload,
                             knx: { event: sEvent, dpt: _msg.dpt, destination: _msg.grpaddr },
@@ -1739,7 +1747,6 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
 
                             let msg = {
                                 topic: input.outputtopic,
-                                payload: _msg.payload,
                                 devicename: input.name ? input.name : "",
                                 payload: _msg.payload,
                                 knx: { event: sEvent, dpt: _msg.dpt, destination: _msg.grpaddr },
@@ -1774,7 +1781,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
             // If the node is disconnected, wait another cycle, then reconnects
             if (node.allowLauch_initKNXConnection && node.autoReconnect) {
                 node.allowLauch_initKNXConnection = false;
-                setTimeout(() => {
+                let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                     node.setAllClientsStatus("Auto reconnect in progress...", "grey", "");
                 }, 100);
                 if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.debug("knxUltimate-config: Auto Reconect by timerKNXUltimateCheckState in progress. node.LinkStatus:" + node.linkStatus + ", node.autoReconnect:" + node.autoReconnect);
@@ -1783,7 +1790,7 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
             }
             if (node.linkStatus === "disconnected" && node.autoReconnect) {
                 node.allowLauch_initKNXConnection = true; // Next cycle, launch initKNXConnection, so it pauses more and leave more time
-                setTimeout(() => {
+                let t = setTimeout(() => { // 21/03/2022 fixed possible memory leak. Previously was setTimeout without "let t = ".
                     node.setAllClientsStatus("Next cycle will reconnect...", "grey", "");
                 }, 1000);
                 if (node.sysLogger !== undefined && node.sysLogger !== null) node.sysLogger.debug("knxUltimate-config: Waiting next cycle to reconect. node.LinkStatus:" + node.linkStatus + ", node.autoReconnect:" + node.autoReconnect);