node-red-contrib-knx-ultimate 1.3.2 → 1.3.7

package/CHANGELOG.md

@@ -4,6 +4,19 @@
 
 <br/>
 <p>
+<b>Version 1.3.7</b> - December 2021<br/>
+- FIX: fixed a stupid "Disconnected by Message length mismatch 8/16" error due to a dumb find/replace error in the code.<br/>
+- Added some more log to help resolving issues.<br/>
+</p>
+<p>
+<b>Version 1.3.5 - REMOVED FROM REPO due to "Disconnected by Message length mismatch 8/16" error</b> - December 2021<br/>
+- New KNX Engine has been enabled again, after fixing some glitches.<br/>
+</p>
+<p>
+<b>Version 1.3.4</b> - December 2021<br/>
+- Temporary reverted to old API, due to some little glitches.<br/>
+</p>
+<p>
 <b>Version 1.3.2</b> - December 2021<br/>
 - NEW: config node: you can now gather debug info (there is a button for that) to be sent to the developer to help resolving your issue. Then, please paste the debug infos in your gitHub issue.<br/>
 </p>

package/KNXEngine/KNXClient.js

@@ -178,14 +178,45 @@ class KNXClient extends EventEmitter {
     get channelID() {
         return this._channelID;
     }
-    // Transform the plain value "data" into a KNXDataBuffer
+    // Transform the plain value "data" into a KNXDataBuffer. The datapoints without "null" are SixBits
+    // dataPointsSixBits = {
+    //     DPT1,
+    //     DPT2,
+    //     DPT3,
+    //     DPT4: null,
+    //     DPT5,
+    //     DPT6: null,
+    //     DPT7: null,
+    //     DPT8: null,
+    //     DPT9,
+    //     DPT10,
+    //     DPT11,
+    //     DPT12: null,
+    //     DPT13: null,
+    //     DPT14,
+    //     DPT15: null,
+    //     DPT16: null,
+    //     DPT17: null,
+    //     DPT18,
+    //     DPT19: null,
+    //     DPT20: null
+    // };
     getKNXDataBuffer(_data, _dptid) {
         let adpu = {};
         DPTLib.populateAPDU(_data, adpu, _dptid);
+        let iDatapointType = parseInt(_dptid.substr(0, _dptid.indexOf(".")));
+        let isSixBits = adpu.bitlength <= 6;
+        //let isSixBits = [1,2,3,5,9,10,11,14,18].includes(iDatapointType);
+        //console.log("isSixBits", isSixBits, "Includes (should be = isSixBits)", [1, 2, 3, 5, 9, 10, 11, 14, 18].includes(iDatapointType), "ADPU BitLenght", adpu.bitlength);
+        try {
+            if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.trace("isSixBits:" + isSixBits + " Includes (should be = isSixBits):" + [1, 2, 3, 5, 9, 10, 11, 14, 18].includes(iDatapointType) + " ADPU BitLenght:" + adpu.bitlength);
+        } catch (error) { }
+
         let IDataPoint = {
             id: "",
             value: "any",
-            type: { type: adpu.bitlength.toString() || null },
+            //type: { type: adpu.bitlength.toString() || null },
+            type: { type: isSixBits },
             bind: null,
             read: () => null,
             write: null
@@ -212,15 +243,21 @@ class KNXClient extends EventEmitter {
         if (this.sysLogger !== undefined && this.sysLogger !== null) {
             try {
                 if (knxPacket.constructor.name !== undefined && knxPacket.constructor.name.toLowerCase() === "knxconnectrequest") this.sysLogger.debug("Sending KNX packet: " + knxPacket.constructor.name + " Host:" + this._peerHost + ":" + this._peerPort);
-                if (knxPacket.constructor.name !== undefined && knxPacket.constructor.name.toLowerCase() === "knxtunnelingrequest") {
+                if (knxPacket.constructor.name !== undefined && (knxPacket.constructor.name.toLowerCase() === "knxtunnelingrequest" || knxPacket.constructor.name.toLowerCase() === "knxroutingindication")) {
                     let sTPCI = ""
                     if (knxPacket.cEMIMessage.npdu.isGroupRead) sTPCI = "Read";
                     if (knxPacket.cEMIMessage.npdu.isGroupResponse) sTPCI = "Response";
                     if (knxPacket.cEMIMessage.npdu.isGroupWrite) sTPCI = "Write";
-                    this.sysLogger.debug("Sending KNX packet: " + knxPacket.constructor.name + " Host:" + this._peerHost + ":" + this._peerPort + " channelID:" + knxPacket.channelID + " seqCounter:" + knxPacket.seqCounter + " Dest:" + knxPacket.cEMIMessage.dstAddress.toString(), " Data:" + knxPacket.cEMIMessage.npdu.dataValue.toString("hex") + " TPCI:" + sTPCI);
+                    // Composing debug string
+                    let sDebugString = "???";
+                    try {
+                        sDebugString = "Data: " + JSON.stringify(knxPacket.cEMIMessage.npdu);
+                        sDebugString += " srcAddress: " + knxPacket.cEMIMessage.srcAddress.toString();
+                        sDebugString += " dstAddress: " + knxPacket.cEMIMessage.dstAddress.toString();
+                    } catch (error) { }
+                    this.sysLogger.debug("Sending KNX packet: " + knxPacket.constructor.name + " " + sDebugString + " Host:" + this._peerHost + ":" + this._peerPort + " channelID:" + knxPacket.channelID + " seqCounter:" + knxPacket.seqCounter + " Dest:" + knxPacket.cEMIMessage.dstAddress.toString(), " Data:" + knxPacket.cEMIMessage.npdu.dataValue.toString("hex") + " TPCI:" + sTPCI);
                 }
             } catch (error) {
-                this.sysLogger.debug("Sending KNX packet error " + error.message || "");
             }
         }
 
@@ -230,16 +267,16 @@ class KNXClient extends EventEmitter {
             try {
                 this._clientSocket.send(knxPacket.toBuffer(), this._peerPort, this._peerHost, err => {
                     if (err) {
-                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("KNXClient: Send UDP: " + err.message || "Undef error");
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Sending KNX packet: Send UDP sending error: " + err.message || "Undef error");
                         try {
                             this.emit(KNXClientEvents.error, err);
                         } catch (error) {
                         }
                     }
-                   
+
                 });
             } catch (error) {
-                if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Sending KNX packet via TCP: " + typeof (knxPacket) + " seqCounter:" + knxPacket.seqCounter);
+                if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Sending KNX packet: Send UDP Catch error: " + error.message + " " + typeof (knxPacket) + " seqCounter:" + knxPacket.seqCounter);
                 try {
                     //this.emit(KNXClientEvents.error, error);
                 } catch (error) {
@@ -251,13 +288,13 @@ class KNXClient extends EventEmitter {
             try {
                 this._clientSocket.write(knxPacket.toBuffer(), err => {
                     if (err) {
-                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("KNXClient: Send TCP: " + err.message || "Undef error");
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Sending KNX packet: Send TCP sending error: " + err.message || "Undef error");
                         this.emit(KNXClientEvents.error, err);
                     }
-                  
+
                 });
             } catch (error) {
-                if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("KNXClient: Send TCP Catch: " + error.message || "Undef error");
+                if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Sending KNX packet: Send TCP Catch error: " + error.message || "Undef error");
                 try {
                     //this.emit(KNXClientEvents.error, error);
                 } catch (error) {
@@ -287,7 +324,7 @@ class KNXClient extends EventEmitter {
 
         if (this._options.hostProtocol === "Multicast") {
             // Multicast
-            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataRequestMessage("write", srcAddress, dstAddress, data);
+            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataIndicationMessage("write", srcAddress, dstAddress, data);
             cEMIMessage.control.ack = 0;
             cEMIMessage.control.broadcast = 1;
             cEMIMessage.control.priority = 3;
@@ -295,12 +332,7 @@ class KNXClient extends EventEmitter {
             cEMIMessage.control.hopCount = 6;
             const knxPacketRequest = KNXProtocol.KNXProtocol.newKNXRoutingIndication(cEMIMessage);
             this.send(knxPacketRequest);
-            // 06/12/2021 Echo the sent telegram.
-            try {
-                this.emit(KNXClientEvents.indication, knxPacketRequest, true, null);
-            } catch (error) {
-            }
-
+            // 06/12/2021 Multivast automaticalli echoes telegrams
         } else {
             // Tunneling
             const cEMIMessage = CEMIFactory.CEMIFactory.newLDataRequestMessage("write", srcAddress, dstAddress, data);
@@ -335,7 +367,7 @@ class KNXClient extends EventEmitter {
 
         if (this._options.hostProtocol === "Multicast") {
             // Multicast
-            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataRequestMessage("response", srcAddress, dstAddress, data);
+            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataIndicationMessage("response", srcAddress, dstAddress, data);
             cEMIMessage.control.ack = 0;
             cEMIMessage.control.broadcast = 1;
             cEMIMessage.control.priority = 3;
@@ -343,11 +375,7 @@ class KNXClient extends EventEmitter {
             cEMIMessage.control.hopCount = 6;
             const knxPacketRequest = KNXProtocol.KNXProtocol.newKNXRoutingIndication(cEMIMessage);
             this.send(knxPacketRequest);
-            // 06/12/2021 Echo the sent telegram. Last parameter is the echo true/false
-            try {
-                if (this._options.localEchoInTunneling) this.emit(KNXClientEvents.indication, knxPacketRequest, true, null);
-            } catch (error) {
-            }
+            // 06/12/2021 Multivast automaticalli echoes telegrams
 
         } else {
             // Tunneling
@@ -380,7 +408,7 @@ class KNXClient extends EventEmitter {
 
         if (this._options.hostProtocol === "Multicast") {
             // Multicast
-            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataRequestMessage("read", srcAddress, dstAddress, null);
+            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataIndicationMessage("read", srcAddress, dstAddress, null);
             cEMIMessage.control.ack = 0;
             cEMIMessage.control.broadcast = 1;
             cEMIMessage.control.priority = 3;
@@ -388,11 +416,7 @@ class KNXClient extends EventEmitter {
             cEMIMessage.control.hopCount = 6;
             const knxPacketRequest = KNXProtocol.KNXProtocol.newKNXRoutingIndication(cEMIMessage);
             this.send(knxPacketRequest);
-            // 06/12/2021 Echo the sent telegram. Last parameter is the echo true/false
-            try {
-                if (this._options.localEchoInTunneling) this.emit(KNXClientEvents.indication, knxPacketRequest, true, null);
-            } catch (error) {
-            }
+            // 06/12/2021 Multivast automaticalli echoes telegrams
 
         } else {
             // Tunneling
@@ -432,7 +456,7 @@ class KNXClient extends EventEmitter {
         let srcAddress = this._options.physAddr;
         if (this._options.hostProtocol === "Multicast") {
             // Multicast
-            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataRequestMessage("write", srcAddress, dstAddress, data);
+            const cEMIMessage = CEMIFactory.CEMIFactory.newLDataIndicationMessage("write", srcAddress, dstAddress, data);
             cEMIMessage.control.ack = 0;
             cEMIMessage.control.broadcast = 1;
             cEMIMessage.control.priority = 3;
@@ -440,11 +464,7 @@ class KNXClient extends EventEmitter {
             cEMIMessage.control.hopCount = 6;
             const knxPacketRequest = KNXProtocol.KNXProtocol.newKNXRoutingIndication(cEMIMessage);
             this.send(knxPacketRequest);
-            // 06/12/2021 Echo the sent telegram. Last parameter is the echo true/false
-            try {
-                this.emit(KNXClientEvents.indication, knxPacketRequest, true, null);
-            } catch (error) {
-            }
+            // 06/12/2021 Multivast automaticalli echoes telegrams
 
         } else {
             // Tunneling
@@ -676,6 +696,7 @@ class KNXClient extends EventEmitter {
         }, KNXConstants.KNX_CONSTANTS.TUNNELING_REQUEST_TIMEOUT * 1000));
     }
     _processInboundMessage(msg, rinfo) {
+
         try {
             const { knxHeader, knxMessage } = KNXProtocol.KNXProtocol.parseMessage(msg);
 
@@ -752,8 +773,16 @@ class KNXClient extends EventEmitter {
 
                 if (knxTunnelingRequest.cEMIMessage.msgCode === CEMIConstants.CEMIConstants.L_DATA_IND) {
 
+                    // Composing debug string
+                    let sDebugString = "???";
+                    try {
+                        sDebugString = "Data: " + JSON.stringify(knxTunnelingRequest.cEMIMessage.npdu);
+                        sDebugString += " srcAddress: " + knxTunnelingRequest.cEMIMessage.srcAddress.toString();
+                        sDebugString += " dstAddress: " + knxTunnelingRequest.cEMIMessage.dstAddress.toString();
+                    } catch (error) { }
+
                     try {
-                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING_REQUEST L_DATA_IND, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingRequest.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING: L_DATA_IND, " + sDebugString + " ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingRequest.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
                     } catch (error) { }
 
                     try {
@@ -765,7 +794,7 @@ class KNXClient extends EventEmitter {
                 else if (knxTunnelingRequest.cEMIMessage.msgCode === CEMIConstants.CEMIConstants.L_DATA_CON) {
 
                     try {
-                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING_REQUEST L_DATA_CON, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingRequest.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING: L_DATA_CON, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingRequest.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
                     } catch (error) { }
 
                 }
@@ -780,7 +809,7 @@ class KNXClient extends EventEmitter {
                 }
 
                 try {
-                    if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING_ACK, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingAck.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
+                    if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING: TUNNELING_ACK, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingAck.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
                 } catch (error) { }
 
                 this._incSeqNumber(knxTunnelingAck.seqCounter);
@@ -789,7 +818,7 @@ class KNXClient extends EventEmitter {
                     if (this._tunnelReqTimer.get(knxTunnelingAck.seqCounter) !== null) clearTimeout(this._tunnelReqTimer.get(knxTunnelingAck.seqCounter));
                     this._tunnelReqTimer.delete(knxTunnelingAck.seqCounter);
                     try {
-                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("_processInboundMessage: DELETED_TUNNELING_ACK FROM PENDING ACK's, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingAck.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: TUNNELING: DELETED_TUNNELING_ACK FROM PENDING ACK's, ChannelID:" + this._channelID + " seqCounter:" + knxTunnelingAck.seqCounter + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
                     } catch (error) { }
                 }
                 else {
@@ -797,23 +826,41 @@ class KNXClient extends EventEmitter {
                     // Avoid warning if the KNXEngine is set to ignore ACK's telegrams
                     if (!this._options.suppress_ack_ldatareq) {
                         try {
-                            if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("_processInboundMessage: Unexpected Tunnel Ack with seqCounter = " + knxTunnelingAck.seqCounter);
+                            if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.error("Received KNX packet: TUNNELING: Unexpected Tunnel Ack with seqCounter = " + knxTunnelingAck.seqCounter);
                         } catch (error) { }
                         //this.emit(KNXClientEvents.error, `Unexpected Tunnel Ack ${knxTunnelingAck.seqCounter}`);
                     }
                 }
 
             } else if (knxHeader.service_type === KNXConstants.KNX_CONSTANTS.ROUTING_INDICATION) {
+
                 // 07/12/2021 Multicast routing indication
                 const knxRoutingInd = knxMessage;
                 if (knxRoutingInd.cEMIMessage.msgCode === CEMIConstants.CEMIConstants.L_DATA_IND) {
+
+                    // Composing debug string
+                    let sDebugString = "???";
+                    try {
+                        sDebugString = "Data: " + JSON.stringify(knxRoutingInd.cEMIMessage.npdu);
+                        sDebugString += " srcAddress: " + knxRoutingInd.cEMIMessage.srcAddress.toString();
+                        sDebugString += " dstAddress: " + knxRoutingInd.cEMIMessage.dstAddress.toString();
+                    } catch (error) { }
+
                     try {
-                        this.emit(KNXClientEvents.indication, knxRoutingInd, false, msg.toString("hex"));                        
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: ROUTING: L_DATA_IND, " + sDebugString + " Host:" + this._options.ipAddr + ":" + this._options.ipPort);
+                    } catch (error) { }
+
+                    try {
+                        this.emit(KNXClientEvents.indication, knxRoutingInd, false, msg.toString("hex"));
                     } catch (error) {
                     }
                 }
                 else if (knxRoutingInd.cEMIMessage.msgCode === CEMIConstants.CEMIConstants.L_DATA_CON) {
 
+                    try {
+                        if (this.sysLogger !== undefined && this.sysLogger !== null) this.sysLogger.debug("Received KNX packet: ROUTING: L_DATA_CON, Host:" + this._options.ipAddr + ":" + this._options.ipPort);
+                    } catch (error) { }
+
                 }
 
             } else if (knxHeader.service_type === KNXConstants.KNX_CONSTANTS.ROUTING_LOST_MESSAGE) {

package/KNXEngine/protocol/KNXDataBuffer.js

@@ -17,7 +17,8 @@ class KNXDataBuffer {
         if (this.info == null) {
             return true;
         }
-        return this.info.type.type === '1';
+        //return !(this.info.type.type === '1');
+        return this.info.type.type;
     }
 }
 exports.KNXDataBuffer = KNXDataBuffer;

package/KNXEngine/protocol/KNXHeader.js

@@ -1,13 +1,13 @@
 'use strict';
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.KNXHeader = void 0;
-const KNXConstants_1 = require("./KNXConstants");
+const KNXConstants = require("./KNXConstants");
 class KNXHeader {
     constructor(type, length) {
-        this._headerLength = KNXConstants_1.KNX_CONSTANTS.HEADER_SIZE_10;
-        this._version = KNXConstants_1.KNX_CONSTANTS.KNXNETIP_VERSION_10;
+        this._headerLength = KNXConstants.KNX_CONSTANTS.HEADER_SIZE_10;
+        this._version = KNXConstants.KNX_CONSTANTS.KNXNETIP_VERSION_10;
         this.service_type = type;
-        this.length = KNXConstants_1.KNX_CONSTANTS.HEADER_SIZE_10 + length;
+        this.length = KNXConstants.KNX_CONSTANTS.HEADER_SIZE_10 + length;
     }
     get headerLength() {
         return this._headerLength;
@@ -16,16 +16,16 @@ class KNXHeader {
         return this._version;
     }
     static createFromBuffer(buffer, offset = 0) {
-        if (buffer.length < KNXConstants_1.KNX_CONSTANTS.HEADER_SIZE_10) {
+        if (buffer.length < KNXConstants.KNX_CONSTANTS.HEADER_SIZE_10) {
             throw new Error('Incomplete buffer');
         }
         const header_length = buffer.readUInt8(offset);
-        if (header_length !== KNXConstants_1.KNX_CONSTANTS.HEADER_SIZE_10) {
+        if (header_length !== KNXConstants.KNX_CONSTANTS.HEADER_SIZE_10) {
             throw new Error(`Invalid buffer length ${header_length}`);
         }
         offset += 1;
         const version = buffer.readUInt8(offset);
-        if (version !== KNXConstants_1.KNX_CONSTANTS.KNXNETIP_VERSION_10) {
+        if (version !== KNXConstants.KNX_CONSTANTS.KNXNETIP_VERSION_10) {
             throw new Error(`Unknown version ${version}`);
         }
         offset += 1;

package/KNXEngine/protocol/KNXProtocol.js

@@ -94,7 +94,7 @@ class KNXProtocol {
     static newKNXTunnelingRequest(channelID, seqCounter, cEMIMessage) {
         return new KNXTunnelingRequest.KNXTunnelingRequest(channelID, seqCounter, cEMIMessage);
     }
-    static newKNXRoutingIndication(cEMIMessage) {
+    static newKNXRoutingIndication(cEMIMessage) { // 18/12/2021
         return new KNXRoutingIndication.KNXRoutingIndication(cEMIMessage);
     }
     static newKNXSecureSessionRequest(cri, hpaiData = HPAI.HPAI.NULLHPAI) {

package/KNXEngine/protocol/KNXRoutingIndication.js

@@ -24,11 +24,6 @@ class KNXRoutingIndication extends KNXPacket.KNXPacket {
         return new KNXRoutingIndication(cEMIMessage);
     }
     toBuffer() {
-        const buffer = Buffer.alloc(4);
-        buffer.writeUInt8(4, 0);
-        buffer.writeUInt8(0, 1);
-        buffer.writeUInt8(0, 2);
-        buffer.writeUInt8(0, 3);
         return Buffer.concat([this.header.toBuffer(),  this.cEMIMessage.toBuffer()]);
     }
 }

package/KNXEngine/protocol/cEMI/CEMIFactory.js

@@ -21,9 +21,9 @@ class CEMIFactory {
         }
     }
     static newLDataRequestMessage(requestType, srcAddress, dstAddress, data) {
- 
+
         const controlField = new ControlField.ControlField();
-       
+
         const npdu = new NPDU.NPDU();
         npdu.tpci = NPDU.NPDU.TPCI_UNUMBERED_PACKET;
 
@@ -36,6 +36,24 @@ class CEMIFactory {
         return new LDataReq.LDataReq(null, controlField, srcAddress, dstAddress, npdu);
     }
 
+    // 18/12/2021 New
+    static newLDataIndicationMessage(requestType, srcAddress, dstAddress, data) {
+
+        const controlField = new ControlField.ControlField();
+
+        const npdu = new NPDU.NPDU();
+        npdu.tpci = NPDU.NPDU.TPCI_UNUMBERED_PACKET;
+
+        // 06/12/2021
+        if (requestType === "write") npdu.action = NPDU.NPDU.GROUP_WRITE; // 2
+        if (requestType === "response") npdu.action = NPDU.NPDU.GROUP_RESPONSE; // 1
+        if (requestType === "read") npdu.action = NPDU.NPDU.GROUP_READ; // 0
+
+        npdu.data = data;
+        return new LDataInd.LDataInd(null, controlField, srcAddress, dstAddress, npdu);
+
+    }
+
 }
 exports.CEMIFactory = CEMIFactory;
 //# sourceMappingURL=CEMIFactory.js.map

package/KNXEngine/protocol/cEMI/CEMIMessage.js

@@ -22,7 +22,7 @@ class CEMIMessage {
         return buffer;
     }
     static GetLength(additionalInfo, control, srcAddress, dstAddress, npdu) {
-        const length = additionalInfo == null ? 1 : additionalInfo.length;
+        const length = additionalInfo === null ? 1 : additionalInfo.length;
         const npduLength = npdu == null ? 0 : npdu.length;
         return 1 + length + control.length + srcAddress.length + dstAddress.length + npduLength;
     }

package/KNXEngine/protocol/cEMI/LDataInd.js

@@ -31,7 +31,7 @@ class LDataInd extends CEMIMessage.CEMIMessage {
         return new LDataInd(additionalInfo, controlField, srcAddress, dstAddress, npdu);
     }
     toBuffer() {
-        const buffer = Buffer.alloc(1);
+        const buffer = Buffer.alloc(2);
         const msgBuffer = [buffer];
         let offset = 0;
         buffer.writeUInt8(this.msgCode, offset++);

package/KNXEngine/protocol/cEMI/NPDU.js

@@ -45,12 +45,13 @@ class NPDU {
         if (!(data instanceof KNXDataBuffer.KNXDataBuffer)) {
             throw new Error('Invalid data Buffer');
         }
+        
         if (data.sixBits() && data.length === 1 && data.value.readUInt8(0) < 0x3F) {
             this.apci = (this.apci & 0xC0) | data.value.readUInt8(0);
             this._data = null;
             return;
         }
-        
+
         this._data = data;
     }
     get length() {

package/knxultimate-api2/src/Connection.js

@@ -27,6 +27,7 @@ const onUdpSocketMessage = function (msg /*, rinfo, callback */) {
   //   var pera =true;
   // }
 
+
   try {
     let reader = KnxNetProtocol.createReader(msg)
     let dg

package/nodes/knxUltimate-config API2.js

@@ -1109,24 +1109,15 @@ return msg;`, "helplink": "https://github.com/Supergiovane/node-red-contrib-knx-
                                     // 24/09/2019 Autorespond to BUS
                                     if (input.notifyreadrequestalsorespondtobus === true) {
                                         if (typeof input.currentPayload === "undefined" || input.currentPayload === "" || input.currentPayload === null) { // 14/08/2021 Added || input.currentPayload === null
-                                            setTimeout(() => {
-                                                try {
-                                                    node.knxConnection.respond(_dest, input.notifyreadrequestalsorespondtobusdefaultvalueifnotinitialized, input.dpt);
-                                                    input.setNodeStatus({ fill: "blue", shape: "ring", text: "Read & Autorespond with default", payload: input.notifyreadrequestalsorespondtobusdefaultvalueifnotinitialized, GA: input.topic, dpt: msg.knx.dpt, devicename: "" });
-                                                } catch (error) {
-                                                    console.log("BANANA ERRORE RESPOND", error.message);
-                                                }
-
-                                            }, 200);
+                                            node.writeQueueAdd({ grpaddr: _dest, payload: input.notifyreadrequestalsorespondtobusdefaultvalueifnotinitialized, dpt: input.dpt, outputtype: "response", nodecallerid: input.id });
+
+                                            input.setNodeStatus({ fill: "blue", shape: "ring", text: "Read & Autorespond with default", payload: input.notifyreadrequestalsorespondtobusdefaultvalueifnotinitialized, GA: input.topic, dpt: msg.knx.dpt, devicename: "" });
+
                                         } else {
-                                            setTimeout(() => {
-                                                try {
-                                                    node.knxConnection.respond(_dest, input.currentPayload, input.dpt);
-                                                    input.setNodeStatus({ fill: "blue", shape: "ring", text: "Read & Autorespond", payload: input.currentPayload, GA: input.topic, dpt: msg.knx.dpt, devicename: "" });
-                                                } catch (error) {
-                                                    console.log("BANANA ERRORE RESPOND2", error.message);
-                                                }
-                                            }, 200);
+                                            node.writeQueueAdd({ grpaddr: _dest, payload: input.currentPayload, dpt: input.dpt, outputtype: "response", nodecallerid: input.id });
+
+                                            input.setNodeStatus({ fill: "blue", shape: "ring", text: "Read & Autorespond", payload: input.currentPayload, GA: input.topic, dpt: msg.knx.dpt, devicename: "" });
+
                                         };
                                     } else {
                                         input.setNodeStatus({ fill: "grey", shape: "dot", text: "Read", payload: msg.payload, GA: input.topic, dpt: msg.knx.dpt, devicename: "" });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-knx-ultimate",
-  "version": "1.3.2",
+  "version": "1.3.7",
   "description": "Control your KNX intallation via Node-Red! Single Node KNX IN/OUT with optional ETS group address importer. Easy to use and highly configurable.",
   "dependencies": {
     "fs": "0.0.1-security",