node-red-contrib-homebridge-automation 0.1.5 → 0.1.7

package/HAP-NodeRed.js

@@ -510,12 +510,8 @@ module.exports = function (RED) {
         payload[key] = msg.payload[key];
       });
       _control.call(this, node, msg.payload, function (err, data) {
-        if (!err && data) {
-          // debug('hbControl', err, data); // Images produce alot of noise
-          const msg = {};
-          msg.payload = data;
-          node.send(msg);
-        } else {
+        // debug('hbControl [%s] - [%s]', err, data); // Images produce alot of noise
+        if (err) {
           node.error(err, this.msg);
         }
       }.bind(this));
@@ -728,7 +724,7 @@ module.exports = function (RED) {
 
       // characteristics = Object.assign(characteristics, characteristic.characteristic);
       if (device) {
-        hbMessage.forEach(function(characteristic) {
+        hbMessage.forEach(function (characteristic) {
           // debug("Exists", (device.characteristics[characteristic.aid + '.' + characteristic.iid]));
           if (device.characteristics[characteristic.aid + '.' + characteristic.iid]) {
             payload = Object.assign(payload, {
@@ -806,7 +802,7 @@ module.exports = function (RED) {
               "image-height": 1080
             };
             debug("Control %s:%s ->", device.host, device.port, JSON.stringify(message));
-            homebridge.HAPresource(device.host, device.port, JSON.stringify(message), function(err, status) {
+            homebridge.HAPresource(device.host, device.port, JSON.stringify(message), function (err, status) {
               // debug("status", btoa(status));
               if (!err) {
                 debug("Controlled %s:%s ->", device.host, device.port);
@@ -816,7 +812,7 @@ module.exports = function (RED) {
                   fill: 'green'
                 });
                 clearTimeout(node.timeout);
-                node.timeout = setTimeout(function() {
+                node.timeout = setTimeout(function () {
                   node.status({});
                 }, 30 * 1000);
                 // {"characteristics":[{"aid":19,"iid":10,"value":false},{"aid":19,"iid":11,"value":0}]}

package/README.md

@@ -31,6 +31,8 @@ The above Node-RED Flow, turns on my 'Outside Office' light when the powder room
       * [Mar 9, 2021 - Version 0.0.80](#mar-9-2021---version-0080)
       * [April 23, 2021 - Version 0.0.82](#april-23-2021---version-0082)
       * [Dec 31, 2022 - Version 0.1.3](#dec-31-2022---version-013)
+      * [Jan 6, 2023 - Version 0.1.5](#jan-6-2023---version-015)
+      * [Jan 11, 2023 - Version 0.1.7](#jan-11-2023---version-017)
 * [Backlog / Roadmap](#backlog--roadmap)
    * [Dropped items](#dropped-items)
 * [Installation Steps](#installation-steps)
@@ -56,7 +58,7 @@ The above Node-RED Flow, turns on my 'Outside Office' light when the powder room
    * [To start Node-RED in DEBUG mode, and output Homebridge-Automation debug logs start Node-RED like this.](#to-start-node-red-in-debug-mode-and-output-homebridge-automation-debug-logs-start-node-red-like-this)
 
 <!-- Created by https://github.com/ekalinin/github-markdown-toc -->
-<!-- Added by: sgracey, at: Fri  6 Jan 2023 09:40:24 EST -->
+<!-- Added by: sgracey, at: Wed 11 Jan 2023 11:21:22 EST -->
 
 <!--te-->
 
@@ -167,6 +169,14 @@ With a plugin, you can see if it supports Real Time events, by opening the Home
 
 - Removal of request dependency from hap-node-client
 
+### Jan 6, 2023 - Version 0.1.5
+
+- Remove support for ipv6
+
+### Jan 11, 2023 - Version 0.1.7
+
+- Fix for #110 and homebridge-alexa #564
+
 # Backlog / Roadmap
 
 * [x] - Update Node Information with Homebridge Accessory Details ( hapEndpoint, deviceType, description )

package/lib/Service.js

@@ -74,7 +74,7 @@ function Service(devices, context) {
   this.id = context.id;
   this.characteristics = [];
   // Fix for homebridge 1.3.0
-  devices.characteristics.forEach(function(element) {
+  devices.characteristics.forEach(function (element) {
     // var service = new Characteristic(element, this);
     if (element.type.substring(0, 8) === '00000023' && element.description === "Name") {
       this.name = element.value;
@@ -84,7 +84,7 @@ function Service(devices, context) {
       // this.characteristics.push(service);
     }
   }.bind(this));
-  devices.characteristics.forEach(function(element) {
+  devices.characteristics.forEach(function (element) {
     var service = new Characteristic(element, this);
     if (element.type.substring(0, 8) === '00000023' && element.description === "Name") {
       this.name = element.value;
@@ -97,13 +97,13 @@ function Service(devices, context) {
   if (this.configuredName) {
     this.name = this.configuredName;
   }
-// Uncomment to display services not defined
-//  if (!this.service) {
-//    console.log('Missing', devices);
-//  }
+  // Uncomment to display services not defined
+  //  if (!this.service) {
+  //    console.log('Missing', devices);
+  //  }
 }
 
-Service.prototype.toList = function(context) {
+Service.prototype.toList = function (context) {
   var descriptions;
   var getCharacteristics;
   var putCharacteristics = [];
@@ -115,6 +115,8 @@ Service.prototype.toList = function(context) {
     // Fix for #30
     if (context.manufacturer === "Nest" && (this.name === "Fan" || this.name === "Eco Mode")) {
       fullName = context.name + " - " + this.name;
+    } else if (context.manufacturer === "Mitsubishi" && !fullName.includes(this.name)) {
+      fullName = context.name + " - " + this.name;
     } else {
       context.name = this.name;
       fullName = context.name;
@@ -292,7 +294,7 @@ function _normalizeName(id) {
       return ("Transfer Transport Management");
     case "00000012":
       return ("Heartrate");
-      // Eve types
+    // Eve types
     case "B77831FD":
       return ("Air Pressure Service");
     case "E863F007":

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-homebridge-automation",
-  "version": "0.1.5",
+  "version": "0.1.7",
   "description": "NodeRED Automation for HomeBridge",
   "main": "HAP-NodeRed.js",
   "scripts": {
@@ -27,7 +27,7 @@
   "dependencies": {
     "better-queue": ">=3.8.12",
     "debug": "^4.3.4",
-    "hap-node-client": ">=0.2.2"
+    "hap-node-client": ">=0.2.4"
   },
   "author": "NorthernMan54",
   "license": "ISC",