node-red-contrib-homebridge-automation 0.1.12-beta.0 → 0.1.12-beta.2

package/.eslintrc.js

@@ -0,0 +1,24 @@
+module.exports = {
+  env: {
+    es6: true,
+    node: true,
+    mocha: true,
+  },
+  extends: ['eslint:recommended', 'plugin:mocha/recommended'],
+  globals: {
+    Atomics: 'readonly',
+    SharedArrayBuffer: 'readonly',
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: 'module',
+  },
+  plugins: ['mocha'],
+  rules: {
+    indent: ['error', 2, { SwitchCase: 1 }],
+    'linebreak-style': ['error', 'unix'],
+    quotes: ['error', 'single'],
+    semi: ['error', 'always'],
+    'no-console': 'off',
+  },
+};

package/.nycrc.json

@@ -0,0 +1,11 @@
+{
+  "reporter": [
+    "lcov",
+    "text-summary"
+  ],
+  "lines": 100,
+  "statements": 100,
+  "functions": 100,
+  "branches": 100,
+  "check-coverage": true
+}

package/.prettierrc

@@ -0,0 +1,6 @@
+{
+  "printWidth": 120,
+  "tabWidth": 2,
+  "trailingComma": "all",
+  "singleQuote": true
+}

package/README.md

@@ -60,7 +60,7 @@ The above Node-RED Flow, turns on my 'Outside Office' light when the powder room
    * [To start Node-RED in DEBUG mode, and output Homebridge-Automation debug logs start Node-RED like this.](#to-start-node-red-in-debug-mode-and-output-homebridge-automation-debug-logs-start-node-red-like-this)
 
 <!-- Created by https://github.com/ekalinin/github-markdown-toc -->
-<!-- Added by: runner, at: Fri Jul  5 02:40:07 UTC 2024 -->
+<!-- Added by: runner, at: Fri Jul  5 22:24:05 UTC 2024 -->
 
 <!--te-->
 

package/package.json

@@ -1,13 +1,16 @@
 {
   "name": "node-red-contrib-homebridge-automation",
-  "version": "0.1.12-beta.0",
+  "version": "0.1.12-beta.2",
   "description": "NodeRED Automation for HomeBridge",
   "main": "src/HAP-NodeRed.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
     "api": "documentation build HAP-NodeRed.js -f md --config docs/documentation.yml > docs/API.md",
     "document": "./gh-md-toc --insert README.md; rm README.md.orig.* README.md.toc.*",
-    "watch": "nodemon"
+    "watch": "nodemon",
+    "coverage": "nyc npm t",
+    "format": "prettier --write {.,test}/*.js *.html *.md",
+    "lint": "eslint {.,test}/*.js",
+    "test": "mocha \"test/**/*_spec.js\""
   },
   "keywords": [
     "node-red",
@@ -23,8 +26,22 @@
     "url": "git+https://github.com/NorthernMan54/node-red-contrib-homebridge-automation.git"
   },
   "devDependencies": {
-    "documentation": "^14.0.3",
+    "@types/node-red": "^0.20.7",
+    "@types/jest": "^29.5.12",
+    "documentation": "14.0.3",
+    "eslint": "^8.57.0",
+    "eslint-config-airbnb-typescript": "^18.0.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-import-newlines": "^1.4.0",
+    "eslint-plugin-jest": "^28.6.0",
+    "eslint-plugin-sort-exports": "^0.9.1",
+    "mocha": "^10.6.0",
+    "node-red": "^4.0.2",
+    "node-red-node-test-helper": "^0.3.4",
     "nodemon": "^3.1.4",
+    "nyc": "^17.0.0",
+    "prettier": "^3.3.2",
+    "rimraf": "^5.0.7",
     "semver": "^7.6.2"
   },
   "dependencies": {

package/src/HAP-NodeRed.js

@@ -233,7 +233,7 @@ module.exports = function (RED) {
         }, function (err, message) {
           if (!err) {
             node.state = _convertHBcharactericToNode(message.characteristics, node);
-            debug("hbEvent received: %s = %s", node.fullName, JSON.stringify(message.characteristics), node.state);
+            debug("hbEvent received: %s = %s", node.fullName, JSON.stringify(message.characteristics).slice(0, 80)+'...');
             if (node.sendInitialState) {
               var msg = {
                 name: node.name,

package/src/lib/Accessory.js

@@ -17,14 +17,21 @@ function Accessory(devices, context) {
   this.homebridge = context.homebridge;
   this.id = context.id;
   this.services = [];
-  devices.services.forEach(function(element) {
+  devices.services.forEach(function (element) {
     // debug("Service", element);
     switch (element.type.substring(0, 8)) {
       case "0000003E": // Accessory Information
         this.info = information(element.characteristics);
         break;
- //     case "00000110": // Camera RTPStream Management generates duplicates
- //       break;
+      case "00000110": // Camera RTPStream Management generates duplicates
+        var service = new Service(element, this);
+        console.log('services', this.services);
+        if (this.services.some(e => e.type === '00000110')) {
+
+        } else {
+          this.services.push(service);
+        }
+        break;
       case "000000D9": // Input Source from webosTV has a dummy input source
         var service = new Service(element, this);
         if (service.name !== "dummy") {
@@ -39,7 +46,7 @@ function Accessory(devices, context) {
   // debug("Info", this.info);
 }
 
-Accessory.prototype.toList = function(context) {
+Accessory.prototype.toList = function (context) {
   var list = [];
   // debug("toList", context);
   context.aid = this.aid;
@@ -109,7 +116,7 @@ Accessory.prototype.toList = function(context) {
 
 function information(characteristics) {
   var result = {};
-  characteristics.forEach(function(characteristic) {
+  characteristics.forEach(function (characteristic) {
     if (characteristic.description) {
       var key = characteristic.description.replace(/ /g, '').replace(/\./g, '_');
       result[key] = characteristic.value;

package/test/flows.js

@@ -0,0 +1,42 @@
+const Flows = {
+  getDefault: function (options) {
+    let defaultFlow = [
+      {
+        id: 'status1',
+        type: 'hb-status',
+        name: 'StatusNode1',
+        Homebridge: 'homebridge',
+        Manufacturer: 'TestModule',
+        Service: 'Switch',
+        device: 'homebridgeAA:BB:CC:DD:EE:FF0StatusNode100000049',
+        conf: 'conf1',
+        wires: [['n2']],
+      },
+      {
+        id: 'control1',
+        type: 'hb-control',
+        name: 'ControlNode1',
+        Homebridge: 'homebridge',
+        Manufacturer: 'TestModule',
+        Service: 'Outlet',
+        device: 'homebridgeAA:BB:CC:DD:EE:FF0ControlNode1h00000047',
+        conf: 'conf1',
+        outputs: 0,
+        wires: [],
+      },
+      {
+        id: 'conf1',
+        type: 'hb-conf',
+        username: '031-45-154',
+        macAddress: 'AA:BB:CC:DD:EE:FF',
+      },
+      { id: 'n2', type: 'helper' },
+      { id: 'n3', type: 'helper' },
+    ];
+
+    defaultFlow[0] = Object.assign(defaultFlow[0], options);
+    return defaultFlow;
+  },
+};
+
+module.exports = Flows;

package/test/test_spec.js

@@ -0,0 +1,40 @@
+// var should = require('should');
+var os = require('os');
+var path = require('path');
+var helper = require('node-red-node-test-helper');
+helper.init(require.resolve('node-red'), { userDir: os.tmpdir() });
+
+var flows = require('./flows');
+var hapNode = require('../src/HAP-NodeRed.js');
+
+describe('HAP node', function () {
+  before(function (done) {
+    helper.startServer(done);
+  });
+
+  after(function (done) {
+    helper.stopServer(done);
+  });
+
+  afterEach(function () {
+    helper.unload();
+  });
+
+  it('should be loaded', function (done) {
+    var flow = flows.getDefault();
+
+    helper.load(hapNode, flow, function () {
+      var conf1 = helper.getNode('conf1');
+      conf1.should.have.property('macAddress', 'AA:BB:CC:DD:EE:FF');
+      var stat1 = helper.getNode('status1');
+      stat1.should.have.property('name', 'StatusNode1');
+      var ctl1 = helper.getNode('control1');
+      ctl1.should.have.property('name', 'ControlNode1');
+      var logEvents = helper.log().args.filter(function (evt) {
+        return evt[0].type == 'hb-conf' || evt[0].type == 'hb-status';
+      });
+      logEvents.should.have.length(0);
+      done();
+    });
+  });
+});