node-red-contrib-dmx-for-ha 0.4.9 → 0.6.1

package/LICENSE

@@ -0,0 +1,28 @@
+GNU GENERAL PUBLIC LICENSE
+Version 3, 29 June 2007
+
+node-red-contrib-dmx-for-ha
+Copyright (C) 2024-2026 DeSwaggy
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+---
+
+Full licence text: https://www.gnu.org/licenses/gpl-3.0.txt
+
+ADDITIONAL NOTE:
+This package was built from 6+ years of real-world professional 
+installation experience. If you use it, improve it, or build on it —
+please contribute your changes back to the community. That's the spirit
+of this licence and the spirit in which it was written.

package/README.md

@@ -64,6 +64,16 @@ Most DMX implementations require either expensive proprietary hardware or comple
 - Configurable DMX floor value — prevents low-value flicker on hardware that needs it
 - Debug mode per node — 12hr auto-disable, safe to leave in production flows
 
+## Licence
+
+This package is licensed under **[GPL v3](https://www.gnu.org/licenses/gpl-3.0.txt)**.
+
+You are free to use, modify, and distribute this package. Any derivative works must be distributed under the same GPL v3 licence. This package may not be taken proprietary, rebranded as closed source, or distributed without crediting the original author.
+
+This package was built from 6+ years of real-world professional installation experience. If you use it, improve it, or build on it — please contribute your changes back to the community.
+
+---
+
 > **Note:** This is building automation DMX — fixtures, decoders, dimmers, relay switching. Not entertainment industry DMX (no movers, gobos, or fixture profiles). DMX is an open standard and this package works with any DMX controller that accepts MQTT payloads.
 
 ---
@@ -290,6 +300,45 @@ Entity IDs in HA are locked to the fixture ID and survive friendly name changes.
 
 ---
 
+## Retain discovery — why the default is false
+
+If you search "MQTT discovery retain" you will find HA community posts and documentation recommending `retain=true` for discovery messages. **This advice is correct for ESP and battery-powered IoT devices — but not for Node-RED.**
+
+### Why ESP devices need retain=true
+
+An ESP sensor runs independently of HA. When HA restarts or updates, the ESP device has no way of knowing — it thinks it already discovered itself and won't re-send the discovery payload. Without `retain=true`, the device disappears from HA permanently until the ESP reboots.
+
+```
+ESP device                    Home Assistant
+──────────                    ──────────────
+Sends discovery once    →     HA restarts
+Doesn't know HA restarted     Retained message restores device ✓
+```
+
+### Why Node-RED is different
+
+Node-RED sits on the same server stack as HA. They are tightly coupled — if one goes down the other knows immediately via the websocket connection. When HA restarts, NR reconnects and re-discovers every device automatically. If NR goes down, HA *should* show nothing — because nothing is working.
+
+```
+Node-RED + Home Assistant (same server):
+  NR down  → no devices in HA  → client sees fault immediately ✓
+  HA restart → NR reconnects   → re-discovers everything      ✓
+  retain=true → ghost devices  → client confused, support call ✗
+```
+
+### The config node setting
+
+The `Retain discovery` setting on the config node controls this behaviour:
+
+| Setting | Behaviour | Recommended for |
+|---|---|---|
+| `false` (default) | Devices disappear if NR stops | Professional installs — clear fault indication |
+| `true` | Devices persist if NR stops | Standalone IoT, voice assistant integrations where entity persistence matters |
+
+**Default is `false`** — if a client opens their HA dashboard and sees no lights, they know something is wrong with Node-RED. This is the correct behaviour for a professionally installed system where NR and HA live on the same hardware.
+
+---
+
 ## MQTT topic formats
 
 | Node | Topic |

package/nodes/ha-mqtt-button.html

@@ -41,8 +41,9 @@
             subLocation:    { value: '' },
             // Button specifics
             buttonPosition: { value: '' },
-            buttonPayload:  { value: '', required: true },
-            subscribeTopic: { value: '', required: true },
+            buttonPayload:      { value: '', required: true },
+            subscribeTopic:     { value: '', required: true },
+            controllerProfile:  { value: 'mw3d_v1' },
             // Options
             haIcon:         { value: 'mdi:gesture-tap-button' },
             ledColor:       { value: 'Blue' },
@@ -239,12 +240,35 @@
     </div>
 
     <div class="form-row">
+        <label for="node-input-controllerProfile"><i class="fa fa-microchip"></i> Profile</label>
+        <select id="node-input-controllerProfile" style="width:65%" onchange="
+            var v = this.value;
+            document.getElementById('btn-payload-row').style.display = (v === 'mw3d_v1' || v === 'custom') ? '' : 'none';
+            document.getElementById('btn-topic-row').style.display   = (v === 'mw3d_v1' || v === 'custom') ? '' : 'none';
+            document.getElementById('btn-v2-note').style.display     = (v === 'mw3d_v2') ? '' : 'none';
+        ">
+            <option value="mw3d_v1">MW3D v1 — Legacy (panelId-GPIO payload)</option>
+            <option value="mw3d_v2">MW3D v2 — JSON (fixture ID payload)</option>
+            <option value="custom">Custom</option>
+        </select>
+    </div>
+
+    <div class="form-row" id="btn-v2-note" style="display:none">
+        <label></label>
+        <span style="color:#999; font-size:0.85em;">
+            <i class="fa fa-info-circle"></i>
+            v2 firmware — topic and payload auto-configured from zone + fixture ID.
+            No manual payload or topic needed.
+        </span>
+    </div>
+
+    <div class="form-row" id="btn-payload-row">
         <label for="node-input-buttonPayload"><i class="fa fa-hand-pointer-o"></i> Payload</label>
         <input type="text" id="node-input-buttonPayload" placeholder="Required — e.g. 10-54" style="width:120px" />
         <span style="margin-left:8px; color:#999; font-size:0.85em;">panelId-GPIOpin</span>
     </div>
 
-    <div class="form-row">
+    <div class="form-row" id="btn-topic-row">
         <label for="node-input-subscribeTopic"><i class="fa fa-exchange"></i> Subscribe topic</label>
         <input type="text" id="node-input-subscribeTopic" placeholder="Required — e.g. buttons or home/zone/buttons" style="width:55%" />
     </div>
@@ -289,7 +313,7 @@
     </div>
 
     <div style="margin-top:16px; padding-top:8px; border-top:1px solid #444; color:#666; font-size:0.8em; text-align:right;">
-        node-red-contrib-dmx-for-ha &nbsp;v0.4.8
+        node-red-contrib-dmx-for-ha &nbsp;v0.6.1
     </div>
 
 </script>

package/nodes/ha-mqtt-button.js

@@ -28,6 +28,13 @@ module.exports = function (RED) {
 
         function autoDiscover() {
             if (discoveryMode === 'disabled') {
+                const fixtureIdD = `S-${config.uid}${config.uidPostfix || ''}`;
+                const fixTopicD  = cfg.buildTopic(cfg.discoveryPrefix, 'binary_sensor', fixtureIdD);
+                const cfgTopicD = `${fixTopicD}/${cfg.configTopic}`;
+                broker.publish({ topic: cfgTopicD, payload: '', qos: cfg.qos, retain: true });
+                const uiBtnTopicD = cfg.buildTopic(cfg.discoveryPrefix, 'button', fixtureIdD + '-BTN');
+                const uiBtnCfgTopicD = `${uiBtnTopicD}/${cfg.configTopic}`;
+                broker.publish({ topic: uiBtnCfgTopicD, payload: '', qos: cfg.qos, retain: true });
                 setStatus('grey', 'ring', 'Disabled — not discovered');
                 return;
             }
@@ -99,8 +106,9 @@ module.exports = function (RED) {
             situation:      config.situation         || 'in',
             subLocation:    config.subLocation       || '',
             buttonPosition: config.buttonPosition    || 'Single',
-            buttonPayload:  String(config.buttonPayload || ''),
-            subscribeTopic: config.subscribeTopic    || 'buttons',
+            buttonPayload:     String(config.buttonPayload || ''),
+            subscribeTopic:   config.subscribeTopic    || 'buttons',
+            controllerProfile: config.controllerProfile || 'mw3d_v1',
             haIcon:         config.haIcon            || 'mdi:gesture-tap-button',
             ledColor:       config.ledColor          || 'Blue',
             holdTime:       parseFloat(config.holdTime) || 0.5,
@@ -122,8 +130,49 @@ module.exports = function (RED) {
         }
 
 
+        // ── Controller profile ────────────────────────────────────────────
+        let _btnProfile;
+        try {
+            const _profiles = require('../profiles/index');
+            _btnProfile = (_profiles.button || []).find(p => p.id === S.controllerProfile)
+                       || _profiles.button[0];
+        } catch(e) {
+            _btnProfile = {
+                id: 'mw3d_v1',
+                buildTopic: () => null,
+                parsePayload: (raw, fid, exp) => raw === exp ? { match: true, state: 'on' } : null,
+                hasOffEvent: false
+            };
+        }
+        const btnProfile = _btnProfile;
+
         // ── Fixture identity and topics ───────────────────────────────────────
         const fixtureId     = `S-${S.uid}${S.uidPostfix}`;
+        // ── Fixture ID duplicate detection ──────────────────────────────────
+        function registerFixtureId() {
+            const globalCtx = node.context().global;
+            const regKey = `dmx_fixture_ids_${cfg.siteId}`;
+            let reg = {};
+            try { reg = globalCtx.get(regKey) || {}; } catch(e) {}
+            if (reg[fixtureId] && reg[fixtureId] !== node.id) {
+                node.warn(`${fixtureId} ⚠ DUPLICATE FIXTURE ID — already registered by node ${reg[fixtureId]}`);
+                setStatus('red', 'dot', `DUPLICATE ID: ${fixtureId}`);
+            } else {
+                reg[fixtureId] = node.id;
+                try { globalCtx.set(regKey, reg); } catch(e) {}
+            }
+        }
+        function unregisterFixtureId() {
+            const globalCtx = node.context().global;
+            const regKey = `dmx_fixture_ids_${cfg.siteId}`;
+            let reg = {};
+            try { reg = globalCtx.get(regKey) || {}; } catch(e) {}
+            if (reg[fixtureId] === node.id) {
+                delete reg[fixtureId];
+                try { globalCtx.set(regKey, reg); } catch(e) {}
+            }
+        }
+
         const objectId      = `s_${S.uid}${S.uidPostfix}`.toLowerCase().replace(/[^a-z0-9_]/g, '_');
         const fixtureTopic  = cfg.buildTopic(cfg.discoveryPrefix, 'binary_sensor', fixtureId);
         const uiBtnTopic    = cfg.buildTopic(cfg.discoveryPrefix, 'button', fixtureId + '-BTN');
@@ -157,6 +206,7 @@ module.exports = function (RED) {
 
         // ── Device add ────────────────────────────────────────────
         function handleDeviceAdd() {
+            registerFixtureId();
             // Binary sensor discovery
             const bsDiscovery = {
                 unique_id:          fixtureId,
@@ -192,11 +242,18 @@ module.exports = function (RED) {
             };
 
             pub(cfgTopic,     bsDiscovery, true);
-            pub(uiBtnCfgTopic, uiDiscovery, true);
-
-            // Subscribe to controller topic (physical presses)
-            broker.subscribe(S.subscribeTopic, cfg.qos, function (topic, payload) {
-                if (String(payload) === S.buttonPayload) handlePress('physical');
+            pub(uiBtnCfgTopic, uiDiscovery, cfg.retainDiscovery);
+
+            // Subscribe to controller topic — topic and matching via profile
+            const _btnSubTopic = btnProfile.buildTopic ? btnProfile.buildTopic(cfg) : null;
+            const activeBtnTopic = _btnSubTopic || S.subscribeTopic;
+            S._activeBtnTopic = activeBtnTopic;
+
+            broker.subscribe(activeBtnTopic, cfg.qos, function (topic, payload) {
+                const result = btnProfile.parsePayload(
+                    String(payload), fixtureId, S.buttonPayload
+                );
+                if (result && result.match && result.state === 'on') handlePress('physical');
             }, node.id);
 
             // Subscribe to HA UI button cmd topic
@@ -211,9 +268,10 @@ module.exports = function (RED) {
 
         // ── Device remove ─────────────────────────────────────────
         function handleDeviceRemove() {
+            unregisterFixtureId();
             pub(cfgTopic,      '', true);
             pub(uiBtnCfgTopic, '', true);
-            broker.unsubscribe(S.subscribeTopic, node.id);
+            broker.unsubscribe(S._activeBtnTopic || S.subscribeTopic, node.id);
             broker.unsubscribe(uiBtnCmdTopic,    node.id);
             setStatus('red', 'ring', `${fixtureId} removed`);
             node.log(`${fixtureId} device removed`);
@@ -239,7 +297,7 @@ module.exports = function (RED) {
 
         // ── Cleanup ───────────────────────────────────────────────
         node.on('close', function (done) {
-            broker.unsubscribe(S.subscribeTopic, node.id);
+            broker.unsubscribe(S._activeBtnTopic || S.subscribeTopic, node.id);
             broker.unsubscribe(uiBtnCmdTopic,    node.id);
             broker.deregister(node, done);
         });

package/nodes/ha-mqtt-config.html

@@ -13,8 +13,9 @@
             zone:            { value: '' },
             broker:          { value: '',             type: 'mqtt-broker', required: true },
             discoveryPrefix: { value: 'homeassistant' },
-            qos:             { value: '0' },
-            retain:          { value: 'false' },
+            qos:              { value: '0' },
+            retain:           { value: 'false' },
+            retainDiscovery:  { value: 'false' },
             configTopic:     { value: 'config' },
             stateTopic:      { value: 'state' },
             commandTopic:    { value: 'cmd' },
@@ -142,6 +143,19 @@
         </select>
     </div>
 
+    <div class="form-row">
+        <label for="node-config-input-retainDiscovery" style="width:auto">
+            <i class="fa fa-thumb-tack"></i> Retain discovery
+        </label>
+        <select id="node-config-input-retainDiscovery" style="width:80px">
+            <option value="false">false</option>
+            <option value="true">true</option>
+        </select>
+        <span style="color:#999; font-size:0.85em; margin-left:8px">
+            false = devices disappear from HA if NR stops (recommended)
+        </span>
+    </div>
+
     <hr/>
 
     <!-- DEFAULTS -->

package/nodes/ha-mqtt-config.js

@@ -48,8 +48,9 @@ module.exports = function (RED) {
         this.availTopic      = config.availTopic      || 'avty';
 
         // MQTT settings
-        this.qos    = parseInt(config.qos)    || 0;
-        this.retain = config.retain === 'true';
+        this.qos             = parseInt(config.qos)    || 0;
+        this.retain          = config.retain === 'true';
+        this.retainDiscovery = config.retainDiscovery === 'true';
 
         // HA defaults
         this.enabledDefault = config.enabledDefault !== 'false';
@@ -83,6 +84,7 @@ module.exports = function (RED) {
             availTopic:      this.availTopic,
             qos:             this.qos,
             retain:          this.retain,
+            retainDiscovery: this.retainDiscovery,
             enabledDefault:  this.enabledDefault,
             diskDelay:       this.diskDelay,
             flashShort:      this.flashShort,

package/nodes/ha-mqtt-dmx-group.html

@@ -317,7 +317,7 @@
     </div>
 
     <div style="margin-top:16px; padding-top:8px; border-top:1px solid #444; color:#666; font-size:0.8em; text-align:right;">
-        node-red-contrib-dmx-for-ha &nbsp;v0.4.8
+        node-red-contrib-dmx-for-ha &nbsp;v0.6.1
     </div>
 
 </script>

package/nodes/ha-mqtt-dmx-group.js

@@ -31,6 +31,10 @@ module.exports = function (RED) {
 
         function autoDiscover() {
             if (discoveryMode === 'disabled') {
+                const fixtureIdD = `LG-${config.uid}${config.uidPostfix || ''}`;
+                const fixTopicD  = cfg.buildTopic(cfg.discoveryPrefix, 'light', fixtureIdD);
+                const cfgTopicD = `${fixTopicD}/${cfg.configTopic}`;
+                broker.publish({ topic: cfgTopicD, payload: '', qos: cfg.qos, retain: true });
                 setStatus('grey', 'ring', 'Disabled — not discovered');
                 return;
             }
@@ -132,6 +136,31 @@ module.exports = function (RED) {
 
         // ── Group identity and topics ─────────────────────────────────────────
         const groupId    = `LG-${S.uid}${S.uidPostfix}`;
+        // ── Fixture ID duplicate detection ──────────────────────────────────
+        function registerFixtureId() {
+            const globalCtx = node.context().global;
+            const regKey = `dmx_fixture_ids_${cfg.siteId}`;
+            let reg = {};
+            try { reg = globalCtx.get(regKey) || {}; } catch(e) {}
+            if (reg[groupId] && reg[groupId] !== node.id) {
+                node.warn(`${groupId} ⚠ DUPLICATE FIXTURE ID — already registered by node ${reg[groupId]}`);
+                setStatus('red', 'dot', `DUPLICATE ID: ${groupId}`);
+            } else {
+                reg[groupId] = node.id;
+                try { globalCtx.set(regKey, reg); } catch(e) {}
+            }
+        }
+        function unregisterFixtureId() {
+            const globalCtx = node.context().global;
+            const regKey = `dmx_fixture_ids_${cfg.siteId}`;
+            let reg = {};
+            try { reg = globalCtx.get(regKey) || {}; } catch(e) {}
+            if (reg[groupId] === node.id) {
+                delete reg[groupId];
+                try { globalCtx.set(regKey, reg); } catch(e) {}
+            }
+        }
+
         const objectId   = `lg_${S.uid}${S.uidPostfix}`.toLowerCase().replace(/[^a-z0-9_]/g, '_');
         const groupTopic = cfg.buildTopic(cfg.discoveryPrefix, 'light', groupId);
         const cfgTopic   = `${groupTopic}/${cfg.configTopic}`;
@@ -248,6 +277,7 @@ module.exports = function (RED) {
 
         // ── Device add ────────────────────────────────────────────
         function handleDeviceAdd(incomingTrace) {
+            registerFixtureId();
             if (!ctxGet('state') && !ctxGet('state', 'disk_values')) {
                 ctxSet('state', S.defaultState);
             }
@@ -283,7 +313,7 @@ module.exports = function (RED) {
                 },
             };
 
-            pub(cfgTopic, discovery, true);
+            pub(cfgTopic, discovery, cfg.retainDiscovery);
 
             broker.subscribe(cmdTopic, cfg.qos, function (topic, rawPayload) {
                 let payload;

package/nodes/ha-mqtt-dmx.html

@@ -158,8 +158,9 @@
             chWhite:        { value: '' },
             chWarmWhite:    { value: '' },
             // DMX controller
-            controllerNum:  { value: '1' },
-            universe:       { value: '1' },
+            controllerNum:     { value: '1' },
+            universe:          { value: '1' },
+            controllerProfile: { value: 'etherten_v1' },
             // Options
             haIcon:         { value: 'mdi:lightbulb' },
             showEffects:    { value: true },
@@ -378,6 +379,36 @@
         </label>
     </div>
 
+    <div class="form-row">
+        <label for="node-input-controllerProfile"><i class="fa fa-microchip"></i> Profile</label>
+        <select id="node-input-controllerProfile" style="width:65%" onchange="
+            var v = this.value;
+            document.getElementById('dmx-v2-note').style.display = (v === 'etherten_v2') ? '' : 'none';
+            document.getElementById('dmx-custom-row').style.display = (v === 'custom') ? '' : 'none';
+        ">
+            <option value="etherten_v1">EtherTen v1 — Legacy "212255" (one msg per channel)</option>
+            <option value="etherten_v2">EtherTen v2 — Batched [[212,255],...] (one msg per tick)</option>
+            <option value="mqtt_json">MQTT JSON — {"channel":212,"value":255}</option>
+            <option value="custom">Custom payload</option>
+        </select>
+    </div>
+
+    <div class="form-row" id="dmx-v2-note" style="display:none">
+        <label></label>
+        <span style="color:#999; font-size:0.85em;">
+            <i class="fa fa-info-circle"></i>
+            v2 batches all channel changes into one MQTT message per tick.
+            Requires MW3D DMXController firmware v3.0+.
+            Significantly reduces MQTT traffic during effects and transitions.
+        </span>
+    </div>
+
+    <div class="form-row" id="dmx-custom-row" style="display:none">
+        <label for="node-input-customTopic"><i class="fa fa-exchange"></i> Custom topic</label>
+        <input type="text" id="node-input-customTopic"
+               placeholder="{siteId}/{zone}/dmx/{universe}" style="width:55%" />
+    </div>
+
     <div class="form-row">
         <label for="node-input-controllerNum">
             <i class="fa fa-sort-numeric-asc"></i> Controller
@@ -553,7 +584,7 @@
     </div>
 
     <div style="margin-top:16px; padding-top:8px; border-top:1px solid #444; color:#666; font-size:0.8em; text-align:right;">
-        node-red-contrib-dmx-for-ha &nbsp;v0.4.8
+        node-red-contrib-dmx-for-ha &nbsp;v0.6.1
     </div>
 
 </script>

package/nodes/ha-mqtt-dmx.js

@@ -38,6 +38,11 @@ module.exports = function (RED) {
 
         function autoDiscover() {
             if (discoveryMode === 'disabled') {
+                // Clear any previously retained discovery message so HA removes the device
+                const fixtureIdD   = `${S.uidPrefix}-${S.uid}${S.uidPostfix}`;
+                const fixTopicD    = cfg.buildTopic(cfg.discoveryPrefix, 'light', fixtureIdD);
+                const cfgTopicD    = `${fixTopicD}/${cfg.configTopic}`;
+                broker.publish({ topic: cfgTopicD, payload: '', qos: cfg.qos, retain: true });
                 setStatus('grey', 'ring', 'Disabled — not discovered');
                 return;
             }
@@ -119,7 +124,8 @@ module.exports = function (RED) {
                 warmWhite:parseInt(config.chWarmWhite)|| 0,
             },
             controllerNum: config.controllerNum  || '1',
-            universe:      config.universe        || '1',
+            universe:          config.universe           || '1',
+            controllerProfile: config.controllerProfile  || 'etherten_v1',
             haIcon:        config.haIcon          || 'mdi:lightbulb',
             showEffects:   config.showEffects     !== false,
             transitions:   config.transitions     !== false,
@@ -219,18 +225,41 @@ module.exports = function (RED) {
         const _lastSent = {};
 
         function sendDmxChannels(channels) {
-            channels.forEach(function ([ch, val]) {
-                const payload = buildDmxPayload(ch, val);
-                if (payload === null) return;
-                // Skip if value unchanged since last publish
-                if (_lastSent[ch] === val) {
-                    if (S.debugMode) node.warn(`[DEBUG] ${fixtureId} → SKIP ch${ch}=${val} (unchanged)`);
-                    return;
+            if (dmxProfile.batched) {
+                // ── Batched mode (etherten_v2) ─────────────────────────────
+                // Collect all changed channels → publish ONE message per tick
+                const batch = [];
+                channels.forEach(function ([ch, val]) {
+                    if (!ch || ch <= 0 || val == null) return;
+                    if (_lastSent[ch] === val) {
+                        if (S.debugMode) node.warn(`[DEBUG] ${fixtureId} → SKIP ch${ch}=${val} (unchanged)`);
+                        return;
+                    }
+                    _lastSent[ch] = val;
+                    batch.push([ch, val]);
+                });
+                if (batch.length > 0) {
+                    const payload = dmxProfile.buildPayload(null, null, batch);
+                    broker.publish({ topic: dmxTopic, payload, qos: cfg.qos, retain: false });
+                    if (S.debugMode) node.warn(`[DEBUG] ${fixtureId} → ${dmxTopic} batch[${batch.length}] ${payload}`);
                 }
-                _lastSent[ch] = val;
-                broker.publish({ topic: dmxTopic, payload, qos: cfg.qos, retain: false });
-                if (S.debugMode) node.warn(`[DEBUG] ${fixtureId} → ${dmxTopic}  "${payload}"`);
-            });
+            } else {
+                // ── Single message per channel (etherten_v1 legacy) ────────
+                channels.forEach(function ([ch, val]) {
+                    if (!ch || ch <= 0 || val == null) return;
+                    if (_lastSent[ch] === val) {
+                        if (S.debugMode) node.warn(`[DEBUG] ${fixtureId} → SKIP ch${ch}=${val} (unchanged)`);
+                        return;
+                    }
+                    _lastSent[ch] = val;
+                    const payload = dmxProfile.buildPayload
+                        ? dmxProfile.buildPayload(ch, val, null)
+                        : buildDmxPayload(ch, val);
+                    if (payload === null) return;
+                    broker.publish({ topic: dmxTopic, payload, qos: cfg.qos, retain: false });
+                    if (S.debugMode) node.warn(`[DEBUG] ${fixtureId} → ${dmxTopic}  "${payload}"`);
+                });
+            }
         }
 
         function resetLastSent() {
@@ -556,14 +585,61 @@ module.exports = function (RED) {
 
 
 
-        // ── Fixture identity and topics ───────────────────────────────────────
+
+        // ── DMX Controller profile ────────────────────────────────────────
+        let _dmxProfile;
+        try {
+            const _profiles = require('../profiles/index');
+            _dmxProfile = (_profiles.dmx || []).find(p => p.id === S.controllerProfile)
+                       || _profiles.dmx[0];
+        } catch(e) {
+            // Fallback to etherten_v1 if profiles not found
+            _dmxProfile = {
+                id:      'etherten_v1',
+                batched: false,
+                buildPayload: (ch, val) =>
+                    String(ch).padStart(3,'0') + String(val).padStart(3,'0'),
+                buildTopic: (cfg, universe) =>
+                    cfg.buildTopic(cfg.siteId, cfg.zone, 'dmx', universe)
+            };
+        }
+        const dmxProfile = _dmxProfile;
+
+                // ── Fixture identity and topics ───────────────────────────────────────
         const fixtureId    = `${S.uidPrefix}-${S.uid}${S.uidPostfix}`;
+
+        // ── Fixture ID duplicate detection ──────────────────────────────────
+        function registerFixtureId() {
+            const globalCtx = node.context().global;
+            const regKey = `dmx_fixture_ids_${cfg.siteId}`;
+            let reg = {};
+            try { reg = globalCtx.get(regKey) || {}; } catch(e) {}
+            if (reg[fixtureId] && reg[fixtureId] !== node.id) {
+                node.warn(`${fixtureId} ⚠ DUPLICATE FIXTURE ID — already registered by node ${reg[fixtureId]}`);
+                setStatus('red', 'dot', `DUPLICATE ID: ${fixtureId}`);
+            } else {
+                reg[fixtureId] = node.id;
+                try { globalCtx.set(regKey, reg); } catch(e) {}
+            }
+        }
+        function unregisterFixtureId() {
+            const globalCtx = node.context().global;
+            const regKey = `dmx_fixture_ids_${cfg.siteId}`;
+            let reg = {};
+            try { reg = globalCtx.get(regKey) || {}; } catch(e) {}
+            if (reg[fixtureId] === node.id) {
+                delete reg[fixtureId];
+                try { globalCtx.set(regKey, reg); } catch(e) {}
+            }
+        }
         const objectId     = `${S.uidPrefix}_${S.uid}${S.uidPostfix}`.toLowerCase().replace(/[^a-z0-9_]/g, '_');
         const fixtureTopic = cfg.buildTopic(cfg.discoveryPrefix, 'light', fixtureId);
         const cfgTopic     = `${fixtureTopic}/${cfg.configTopic}`;
         const statTopic    = `${fixtureTopic}/${cfg.stateTopic}`;
         const cmdTopic     = `${fixtureTopic}/${cfg.commandTopic}`;
-        const dmxTopic     = cfg.buildTopic(cfg.siteId, cfg.zone, 'dmx', S.universe);
+        const dmxTopic     = dmxProfile.buildTopic
+            ? dmxProfile.buildTopic(cfg, S.universe)
+            : cfg.buildTopic(cfg.siteId, cfg.zone, 'dmx', S.universe);
 
         // ── DMX channel conflict detection ───────────────────────────────────
         function checkChannelConflicts() {
@@ -608,6 +684,7 @@ module.exports = function (RED) {
 
         // ── Device add ────────────────────────────────────────────
         function handleDeviceAdd() {
+            registerFixtureId();
             if (ctxGet('state') === undefined && ctxGet('state', 'disk_values') === undefined) {
                 ctxSet('state', S.defaultState);
             }
@@ -649,7 +726,7 @@ module.exports = function (RED) {
                 },
             };
 
-            pub(cfgTopic, discovery, true);
+            pub(cfgTopic, discovery, cfg.retainDiscovery);
             // Check for DMX channel conflicts before discovery
             if (!checkChannelConflicts()) return;
             resetLastSent(); // Force full state re-publish after discovery
@@ -698,6 +775,7 @@ module.exports = function (RED) {
 
         // ── Device remove ─────────────────────────────────────────
         function handleDeviceRemove() {
+            unregisterFixtureId();
             clearChannelRegistry();
             stopEffect();
             if (diskTimer) {