node-red-contrib-ccu 4.4.2 → 4.4.3

package/CHANGELOG.md

@@ -5,6 +5,29 @@ Notable changes to node-red-contrib-ccu. Format follows
 user-visible symptom and the cause, not the commit list (the release notes
 append commits automatically).
 
+## 4.4.3 (2026-09-09)
+
+### Fixed
+
+- **Node-RED at 100 % CPU and unresponsive on openccu-lite** (B-27, found on
+  the maintainer's Pi 4 with RedMatic 9.4.2). openccu-lite has no ReGaHSS, so
+  nothing listens on port 31999 — but the connection node still created the
+  ReGaHSS binrpc client in metadata mode, and binrpc up to 4.2.0 armed a new
+  reconnect timer for both the `error` and the `close` event of every refused
+  connect, so the number of attempts doubled every 2.5 s without bound: about
+  7,000 refused connects per second, 30,000 pending timers and 68 million
+  connects in under three hours. The same explosion hit a CCU whenever its
+  ReGaHSS was down for a while (restart, backup restore); it just ended when
+  the port came back. Two changes: the ReGaHSS client is not created at all
+  while the box is an openccu-lite (and is closed when a box becomes one, or
+  created when it stops being one), and this release requires
+  [binrpc 4.3.0](https://github.com/hobbyquaker/binrpc/blob/master/CHANGELOG.md),
+  which keeps a single reconnect timer per client with exponential backoff
+  (2.5 s doubling to 30 s) and has `close()`. The connection node now closes
+  its rpc clients when it is removed or redeployed, and when it replaces a
+  client after a failed call — a replaced binrpc client used to keep
+  reconnecting in the background for the life of the process.
+
 ## 4.4.2 (2026-09-09)
 
 ### Fixed

package/nodes/ccu-connection.js

@@ -1151,6 +1151,13 @@ module.exports = function (RED) {
             this.metaMode = true;
             this.lastMetaProbe = now();
             clearTimeout(this.regaPollTimeout);
+            if (this.clients.ReGaHSS) {
+                // the box became an openccu-lite while Node-RED was running
+                // (recheckMeta): no ReGaHSS to talk to any more (B-27)
+                this.logger.info('rpc client ReGaHSS closed: openccu-lite has no ReGaHSS');
+                this.closeClient('ReGaHSS');
+            }
+
             this.logger.info(
                 'openccu-lite detected (' +
                     (info.implementation || 'meta api') +
@@ -1205,6 +1212,10 @@ module.exports = function (RED) {
                                 return this.startMeta(again);
                             }
 
+                            if (this.ifaceTypes.ReGaHSS.enabled && !this.clients.ReGaHSS) {
+                                this.createClient('ReGaHSS').then(() => this.setIfaceStatus('ReGaHSS', true));
+                            }
+
                             return this.getRegaData().then(() => this.regaPoll());
                         });
                     },
@@ -1868,6 +1879,16 @@ module.exports = function (RED) {
             Object.keys(this.ifaceTypes).forEach((iface) => {
                 const enabled = config[this.ifaceTypes[iface].conf + 'Enabled'];
                 this.ifaceTypes[iface].enabled = enabled;
+                if (enabled && iface === 'ReGaHSS' && this.metaMode) {
+                    // B-27: openccu-lite has no ReGaHSS, nothing listens on 31999.
+                    // A client would only reconnect forever (with binrpc < 4.3.0
+                    // exponentially, at 100 % CPU). The metadata api reports the
+                    // interface status instead; the client is created if the box
+                    // stops being an openccu-lite (onGone).
+                    this.logger.info('rpc client ReGaHSS not created: openccu-lite has no ReGaHSS');
+                    return;
+                }
+
                 if (enabled) {
                     this.createClient(iface)
                         .then(() => {
@@ -1896,6 +1917,28 @@ module.exports = function (RED) {
          * @param iface
          * @returns {Promise<any>}
          */
+        /**
+         * Drop an rpc client and stop its reconnect timer (binrpc >= 4.3.0 has
+         * close(); the xmlrpc client holds no timer). Without this a replaced
+         * client kept reconnecting in the background for the life of the process.
+         * @param iface
+         */
+        closeClient(iface) {
+            const client = this.clients[iface];
+            if (!client) {
+                return;
+            }
+
+            delete this.clients[iface];
+            if (typeof client.close === 'function') {
+                try {
+                    client.close();
+                } catch (error) {
+                    this.logger.debug('close rpc client ' + iface + ': ' + error.message);
+                }
+            }
+        }
+
         createClient(iface) {
             return new Promise((resolve) => {
                 const {rpc, port, path, protocol, auth, user, pass, tls, inSecure} = this.ifaceTypes[iface];
@@ -2166,6 +2209,15 @@ module.exports = function (RED) {
                 });
             });
 
+            // last: the clients themselves, so their reconnect timers die with the
+            // node (a redeploy used to leave every binrpc client reconnecting)
+            calls.push(() => {
+                Object.keys(this.clients).forEach((iface) => {
+                    this.closeClient(iface);
+                });
+                return Promise.resolve();
+            });
+
             this.logger.debug('shutdown tasks: ' + calls.length);
             return calls.reduce((p, task) => p.then(task), Promise.resolve());
         }
@@ -3159,7 +3211,7 @@ module.exports = function (RED) {
                     this.clients[iface].methodCall(method, parameters, (err, res) => {
                         if (err) {
                             this.logger.error('    <', iface, method, err);
-                            delete this.clients[iface];
+                            this.closeClient(iface);
                             this.createClient(iface);
                             reject(err);
                         } else if (res && res.faultCode) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-ccu",
-  "version": "4.4.2",
+  "version": "4.4.3",
   "license": "MIT",
   "main": "none",
   "keywords": [
@@ -50,7 +50,7 @@
     }
   ],
   "dependencies": {
-    "binrpc": "^4.2.0",
+    "binrpc": "^4.3.0",
     "homematic-rega": "^2.0.1",
     "homematic-xmlrpc": "^2.0.0",
     "mqtt-wildcard": "^3.0.9"
@@ -75,7 +75,7 @@
   "overrides": {
     "hm-simulator": {
       "homematic-xmlrpc": "^2.0.0",
-      "binrpc": "^4.2.0"
+      "binrpc": "^4.3.0"
     }
   },
   "engines": {