node-pty 1.0.0 → 1.1.0-beta10

package/src/windowsTerminal.test.ts

@@ -88,125 +88,127 @@ function pollForProcessTreeSize(pid: number, size: number, intervalMs: number =
 }
 
 if (process.platform === 'win32') {
-  describe('WindowsTerminal', () => {
-    describe('kill', () => {
-      it('should not crash parent process', (done) => {
-        const term = new WindowsTerminal('cmd.exe', [], {});
-        term.kill();
-        // Add done call to deferred function queue to ensure the kill call has completed
-        (<any>term)._defer(done);
-      });
-      it('should kill the process tree', function (done: Mocha.Done): void {
-        this.timeout(5000);
-        const term = new WindowsTerminal('cmd.exe', [], {});
-        // Start sub-processes
-        term.write('powershell.exe\r');
-        term.write('notepad.exe\r');
-        term.write('node.exe\r');
-        pollForProcessTreeSize(term.pid, 4, 500, 5000).then(list => {
-          assert.strictEqual(list[0].name.toLowerCase(), 'cmd.exe');
-          assert.strictEqual(list[1].name.toLowerCase(), 'powershell.exe');
-          assert.strictEqual(list[2].name.toLowerCase(), 'notepad.exe');
-          assert.strictEqual(list[3].name.toLowerCase(), 'node.exe');
+  [true, false].forEach((useConpty) => {
+    describe(`WindowsTerminal (useConpty = ${useConpty})`, () => {
+      describe('kill', () => {
+        it('should not crash parent process', (done) => {
+          const term = new WindowsTerminal('cmd.exe', [], { useConpty });
           term.kill();
-          const desiredState: IProcessState = {};
-          desiredState[list[0].pid] = false;
-          desiredState[list[1].pid] = false;
-          desiredState[list[2].pid] = true;
-          desiredState[list[3].pid] = false;
-          pollForProcessState(desiredState).then(() => {
-            // Kill notepad before done
-            process.kill(list[2].pid);
-            done();
+          // Add done call to deferred function queue to ensure the kill call has completed
+          (<any>term)._defer(done);
+        });
+        it('should kill the process tree', function (done: Mocha.Done): void {
+          this.timeout(5000);
+          const term = new WindowsTerminal('cmd.exe', [], { useConpty });
+          // Start sub-processes
+          term.write('powershell.exe\r');
+          term.write('notepad.exe\r');
+          term.write('node.exe\r');
+          pollForProcessTreeSize(term.pid, 4, 500, 5000).then(list => {
+            assert.strictEqual(list[0].name.toLowerCase(), 'cmd.exe');
+            assert.strictEqual(list[1].name.toLowerCase(), 'powershell.exe');
+            assert.strictEqual(list[2].name.toLowerCase(), 'notepad.exe');
+            assert.strictEqual(list[3].name.toLowerCase(), 'node.exe');
+            term.kill();
+            const desiredState: IProcessState = {};
+            desiredState[list[0].pid] = false;
+            desiredState[list[1].pid] = false;
+            desiredState[list[2].pid] = true;
+            desiredState[list[3].pid] = false;
+            pollForProcessState(desiredState).then(() => {
+              // Kill notepad before done
+              process.kill(list[2].pid);
+              done();
+            });
           });
         });
       });
-    });
 
-    describe('resize', () => {
-      it('should throw a non-native exception when resizing an invalid value', () => {
-        const term = new WindowsTerminal('cmd.exe', [], {});
-        assert.throws(() => term.resize(-1, -1));
-        assert.throws(() => term.resize(0, 0));
-        assert.doesNotThrow(() => term.resize(1, 1));
-      });
-      it('should throw an non-native exception when resizing a killed terminal', (done) => {
-        const term = new WindowsTerminal('cmd.exe', [], {});
-        (<any>term)._defer(() => {
-          term.on('exit', () => {
-            assert.throws(() => term.resize(1, 1));
-            done();
+      describe('resize', () => {
+        it('should throw a non-native exception when resizing an invalid value', () => {
+          const term = new WindowsTerminal('cmd.exe', [], { useConpty });
+          assert.throws(() => term.resize(-1, -1));
+          assert.throws(() => term.resize(0, 0));
+          assert.doesNotThrow(() => term.resize(1, 1));
+        });
+        it('should throw a non-native exception when resizing a killed terminal', (done) => {
+          const term = new WindowsTerminal('cmd.exe', [], { useConpty });
+          (<any>term)._defer(() => {
+            term.on('exit', () => {
+              assert.throws(() => term.resize(1, 1));
+              done();
+            });
+            term.destroy();
           });
-          term.destroy();
         });
       });
-    });
 
-    describe('Args as CommandLine', () => {
-      it('should not fail running a file containing a space in the path', (done) => {
-        const spaceFolder = path.resolve(__dirname, '..', 'fixtures', 'space folder');
-        if (!fs.existsSync(spaceFolder)) {
-          fs.mkdirSync(spaceFolder);
-        }
+      describe('Args as CommandLine', () => {
+        it('should not fail running a file containing a space in the path', (done) => {
+          const spaceFolder = path.resolve(__dirname, '..', 'fixtures', 'space folder');
+          if (!fs.existsSync(spaceFolder)) {
+            fs.mkdirSync(spaceFolder);
+          }
 
-        const cmdCopiedPath = path.resolve(spaceFolder, 'cmd.exe');
-        const data = fs.readFileSync(`${process.env.windir}\\System32\\cmd.exe`);
-        fs.writeFileSync(cmdCopiedPath, data);
+          const cmdCopiedPath = path.resolve(spaceFolder, 'cmd.exe');
+          const data = fs.readFileSync(`${process.env.windir}\\System32\\cmd.exe`);
+          fs.writeFileSync(cmdCopiedPath, data);
 
-        if (!fs.existsSync(cmdCopiedPath)) {
-          // Skip test if git bash isn't installed
-          return;
-        }
-        const term = new WindowsTerminal(cmdCopiedPath, '/c echo "hello world"', {});
-        let result = '';
-        term.on('data', (data) => {
-          result += data;
-        });
-        term.on('exit', () => {
-          assert.ok(result.indexOf('hello world') >= 1);
-          done();
+          if (!fs.existsSync(cmdCopiedPath)) {
+            // Skip test if git bash isn't installed
+            return;
+          }
+          const term = new WindowsTerminal(cmdCopiedPath, '/c echo "hello world"', { useConpty });
+          let result = '';
+          term.on('data', (data) => {
+            result += data;
+          });
+          term.on('exit', () => {
+            assert.ok(result.indexOf('hello world') >= 1);
+            done();
+          });
         });
       });
-    });
 
-    describe('env', () => {
-      it('should set environment variables of the shell', (done) => {
-        const term = new WindowsTerminal('cmd.exe', '/C echo %FOO%', { env: { FOO: 'BAR' }});
-        let result = '';
-        term.on('data', (data) => {
-          result += data;
-        });
-        term.on('exit', () => {
-          assert.ok(result.indexOf('BAR') >= 0);
-          done();
+      describe('env', () => {
+        it('should set environment variables of the shell', (done) => {
+          const term = new WindowsTerminal('cmd.exe', '/C echo %FOO%', { env: { FOO: 'BAR' }});
+          let result = '';
+          term.on('data', (data) => {
+            result += data;
+          });
+          term.on('exit', () => {
+            assert.ok(result.indexOf('BAR') >= 0);
+            done();
+          });
         });
       });
-    });
 
-    describe('On close', () => {
-      it('should return process zero exit codes', (done) => {
-        const term = new WindowsTerminal('cmd.exe', '/C exit');
-        term.on('exit', (code) => {
-          assert.equal(code, 0);
-          done();
+      describe('On close', () => {
+        it('should return process zero exit codes', (done) => {
+          const term = new WindowsTerminal('cmd.exe', '/C exit', { useConpty });
+          term.on('exit', (code) => {
+            assert.strictEqual(code, 0);
+            done();
+          });
         });
-      });
 
-      it('should return process non-zero exit codes', (done) => {
-        const term = new WindowsTerminal('cmd.exe', '/C exit 2');
-        term.on('exit', (code) => {
-          assert.equal(code, 2);
-          done();
+        it('should return process non-zero exit codes', (done) => {
+          const term = new WindowsTerminal('cmd.exe', '/C exit 2', { useConpty });
+          term.on('exit', (code) => {
+            assert.strictEqual(code, 2);
+            done();
+          });
         });
       });
-    });
 
-    describe('winpty', () => {
-      it('should accept input', (done) => {
-        const term = new WindowsTerminal('cmd.exe', '', { useConpty: false });
-        term.write('exit\r');
-        term.on('exit', () => {
-          done();
+      describe('Write', () => {
+        it('should accept input', (done) => {
+          const term = new WindowsTerminal('cmd.exe', '', { useConpty });
+          term.write('exit\r');
+          term.on('exit', () => {
+            done();
+          });
         });
       });
     });