node-pptx-templater 1.1.10 → 2.0.0-alpha.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-pptx-templater",
-  "version": "1.1.10",
+  "version": "2.0.0-alpha.0",
   "description": "High-performance, low-level PowerPoint (PPTX) OpenXML template engine for Node.js. Dynamically replace text, insert images, update charts (with Excel workbook data caching), and merge table cells without PowerPoint corruption or Repair Mode prompts.",
   "main": "./src/index.js",
   "module": "./src/index.mjs",
@@ -15,7 +15,7 @@
     }
   },
   "bin": {
-    "node-pptx-templater": "./src/cli/index.js"
+    "node-pptx-templater": "src/cli/index.js"
   },
   "scripts": {
     "test": "vitest run",
@@ -167,7 +167,7 @@
   "license": "MIT",
   "repository": {
     "type": "git",
-    "url": "https://github.com/jsuyog2/node-pptx-templater.git"
+    "url": "git+https://github.com/jsuyog2/node-pptx-templater.git"
   },
   "bugs": {
     "url": "https://github.com/jsuyog2/node-pptx-templater/issues"
@@ -209,4 +209,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}

package/src/managers/ChartManager.js

@@ -303,14 +303,14 @@ class ChartManager {
         const xlsxPath = relationshipManager.resolveTarget(chartZipPath, rel.target)
         const buffer = await this.#zipManager.readBinaryFile(xlsxPath)
         if (buffer) {
-          console.log(`Found embedded workbook: ${xlsxPath}`)
+          logger.debug(`Found embedded workbook: ${xlsxPath}`)
           const updatedXlsx = await ChartWorkbookUpdater.updateWorkbook(buffer, cleanNumericData)
           if (updatedXlsx) {
-            console.log(`Writing updated workbook to: ${xlsxPath}, size: ${updatedXlsx.length}`)
+            logger.debug(`Writing updated workbook to: ${xlsxPath}, size: ${updatedXlsx.length}`)
             this.#zipManager.writeBinaryFile(xlsxPath, updatedXlsx)
           }
         } else {
-          console.log(`Could not find workbook at: ${xlsxPath}`)
+          logger.debug(`Could not find workbook at: ${xlsxPath}`)
         }
       }
     }

package/src/managers/RelationshipManager.js

@@ -244,6 +244,16 @@ class RelationshipManager {
     this.#flushRels(key, partPath)
   }
 
+  /**
+   * Completely removes all relationships for a part from the cache.
+   *
+   * @param {string} partPath - ZIP path of the part.
+   */
+  deleteRelationships(partPath) {
+    const key = this.#getNormalizedKey(partPath)
+    this.#relationships.delete(key)
+  }
+
   /**
    * Updates the target of an existing relationship.
    *

package/src/managers/ShapeManager.js

@@ -863,6 +863,10 @@ class ShapeManager {
       normalized.rotation !== undefined ? ` rot="${Math.round(normalized.rotation * 60000)}"` : ''
 
     // Text box body properties
+    // NOTE: p:txBody is REQUIRED on every p:sp element per the OOXML spec.
+    // PowerPoint will trigger a repair dialog if it is missing, even for purely
+    // graphical shapes (circles, rectangles used as visual indicators, etc.).
+    // When no text is provided we emit an empty body with an end-paragraph run.
     let txBodyXml = ''
     if (normalized.text !== undefined && normalized.text !== null) {
       const textStyle = normalized.textStyle || {}
@@ -886,46 +890,18 @@ class ShapeManager {
       const lines = String(normalized.text).split(/\r?\n/)
       const paragraphsXml = lines
         .map(line => {
-          return `<a:p>
-          ${alignAttr}
-          <a:r>
-            <a:rPr lang="en-US" sz="${fontSizeVal}"${boldAttr}${italicAttr}>
-              ${colorFill}
-            </a:rPr>
-            <a:t>${escapeXml(line)}</a:t>
-          </a:r>
-        </a:p>`
+          return `<a:p>${alignAttr}<a:r><a:rPr lang="en-US" sz="${fontSizeVal}"${boldAttr}${italicAttr}>${colorFill}</a:rPr><a:t>${escapeXml(line)}</a:t></a:r></a:p>`
         })
         .join('')
 
-      txBodyXml = `<p:txBody>
-        <a:bodyPr wrap="square" rtlCol="0">
-          <a:normAutofit/>
-        </a:bodyPr>
-        <a:lstStyle/>
-        ${paragraphsXml}
-      </p:txBody>`
+      txBodyXml = `<p:txBody><a:bodyPr wrap="square" rtlCol="0"><a:normAutofit/></a:bodyPr><a:lstStyle/>${paragraphsXml}</p:txBody>`
+    } else {
+      // Graphical-only shape: emit a minimal empty txBody to satisfy the OOXML schema
+      txBodyXml = `<p:txBody><a:bodyPr rtlCol="0"/><a:lstStyle/><a:p><a:endParaRPr lang="en-US" dirty="0"/></a:p></p:txBody>`
     }
 
     // Build shape XML block
-    const shapeXml = `<p:sp>
-      <p:nvSpPr>
-        <p:cNvPr id="${newId}" name="${escapeXml(name)}"/>
-        <p:cNvSpPr/>
-        <p:nvPr/>
-      </p:nvSpPr>
-      <p:spPr>
-        <a:xfrm${rotAttr}>
-          <a:off x="${xEmu}" y="${yEmu}"/>
-          <a:ext cx="${wEmu}" cy="${hEmu}"/>
-        </a:xfrm>
-        <a:prstGeom prst="${preset}">${avLstXml}</a:prstGeom>
-        ${fillXml}
-        ${borderXml}
-        ${shadowXml}
-      </p:spPr>
-      ${txBodyXml}
-    </p:sp>`
+    const shapeXml = `<p:sp><p:nvSpPr><p:cNvPr id="${newId}" name="${escapeXml(name)}"/><p:cNvSpPr/><p:nvPr/></p:nvSpPr><p:spPr><a:xfrm${rotAttr}><a:off x="${xEmu}" y="${yEmu}"/><a:ext cx="${wEmu}" cy="${hEmu}"/></a:xfrm><a:prstGeom prst="${preset}">${avLstXml}</a:prstGeom>${fillXml}${borderXml}${shadowXml}</p:spPr>${txBodyXml}</p:sp>`
 
     const parsed = this.#xmlParser.parse(shapeXml, 'shape.xml')['p:sp']
     const shapeObj = Array.isArray(parsed) ? parsed[0] : parsed

package/src/managers/SlideManager.js

@@ -433,7 +433,7 @@ class SlideManager {
   cloneSlide(sourceIndex, atPosition, relationshipManager) {
     this.#assertSlideExists(sourceIndex)
     const sourceInfo = this.#slides.get(sourceIndex)
-    console.log('[DEBUG] Source Slide Info:', sourceInfo)
+    logger.debug('Source Slide Info:', sourceInfo)
 
     const newIndex = this.#slides.size + 1
     let nextFileIndex = 1
@@ -445,21 +445,18 @@ class SlideManager {
 
     // Copy the source XML
     let sourceXml = this.getSlideXml(sourceIndex)
-    console.log('[DEBUG] Source XML length:', sourceXml ? sourceXml.length : 0)
+    logger.debug('Source XML length:', sourceXml ? sourceXml.length : 0)
 
     // Copy relationships
     const sourceRels = relationshipManager.getRelationships(sourceInfo.zipPath)
-    console.log(
-      '[DEBUG] Source Rels Path searched:',
-      relationshipManager.getRelsPath(sourceInfo.zipPath)
-    )
-    console.log('[DEBUG] Source Rels found:', sourceRels)
+    logger.debug('Source Rels Path searched:', relationshipManager.getRelsPath(sourceInfo.zipPath))
+    logger.debug('Source Rels found:', sourceRels)
 
     // Copy relationships from source slide (excluding notes, which are slide-specific)
     const idMap = relationshipManager.copyRelationships(sourceInfo.zipPath, slideZipPath, [
       REL_TYPES.NOTES_SLIDE,
     ])
-    console.log('[DEBUG] Copied relationship ID map:', Array.from(idMap.entries()))
+    logger.debug('Copied relationship ID map:', Array.from(idMap.entries()))
 
     // Remap relationship IDs in the cloned XML to match the new targets
     sourceXml = remapRelationshipIds(sourceXml, idMap)
@@ -498,7 +495,7 @@ class SlideManager {
       tableMap: new Map(),
       chartMap: new Map(),
     })
-    this.#addSlideToPresentation(rId, newSlideId)
+    this.#addSlideToPresentation(rId, newSlideId, sourceInfo.slideId)
     this.#registerSlideContentType(slideFileName)
 
     logger.debug(`Cloned slide ${sourceIndex} to new slide ${newIndex}`)
@@ -527,6 +524,9 @@ class SlideManager {
     // Remove relationship from presentation.xml
     this.#relationshipManager.removeRelationship('ppt/presentation.xml', info.relationshipId)
 
+    // Remove relationships cache
+    this.#relationshipManager.deleteRelationships(info.zipPath)
+
     // Remove content type from [Content_Types].xml
     this.#contentTypesManager.removeOverride(info.zipPath)
 
@@ -909,11 +909,61 @@ class SlideManager {
     await Promise.all(this.getAllSlideIndices().map(i => this.getSlideXmlAsync(i)))
   }
 
+  /**
+   * Adds a slide ID to sections in presentation.xml.
+   * @private
+   */
+  #addSlideToSections(slideId, sourceSlideId = null) {
+    if (!this.#presentationObj) return
+    const extLst = this.#xmlParser.getNode(this.#presentationObj, 'p:presentation.p:extLst')
+    if (!extLst?.['p:ext']) return
+
+    const exts = Array.isArray(extLst['p:ext']) ? extLst['p:ext'] : [extLst['p:ext']]
+    for (const ext of exts) {
+      const sectionLst = ext['p14:sectionLst']
+      if (!sectionLst?.['p14:section']) continue
+
+      const sections = sectionLst['p14:section']
+      const targetIdStr = String(slideId)
+      const sourceIdStr = sourceSlideId ? String(sourceSlideId) : null
+
+      if (sourceIdStr) {
+        for (const section of sections) {
+          const sldIdLst = section['p14:sldIdLst']
+          if (!sldIdLst?.['p14:sldId']) continue
+
+          const sldIds = sldIdLst['p14:sldId']
+          const idx = sldIds.findIndex(s => String(s['@_id']) === sourceIdStr)
+          if (idx !== -1) {
+            logger.debug(
+              `Inserting slide ${targetIdStr} after slide ${sourceIdStr} in section "${section['@_name']}"`
+            )
+            sldIds.splice(idx + 1, 0, { '@_id': targetIdStr })
+            return
+          }
+        }
+      }
+
+      if (sections.length > 0) {
+        const lastSection = sections[sections.length - 1]
+        if (!lastSection['p14:sldIdLst']) {
+          lastSection['p14:sldIdLst'] = { 'p14:sldId': [] }
+        }
+        if (!lastSection['p14:sldIdLst']['p14:sldId']) {
+          lastSection['p14:sldIdLst']['p14:sldId'] = []
+        }
+        const sldIds = lastSection['p14:sldIdLst']['p14:sldId']
+        logger.debug(`Appending slide ${targetIdStr} to last section "${lastSection['@_name']}"`)
+        sldIds.push({ '@_id': targetIdStr })
+      }
+    }
+  }
+
   /**
    * Updates the presentation.xml sldIdLst with a new slide entry.
    * @private
    */
-  #addSlideToPresentation(rId, slideId) {
+  #addSlideToPresentation(rId, slideId, sourceSlideId = null) {
     if (!this.#presentationObj) return
 
     let sldIdLst = this.#xmlParser.getNode(this.#presentationObj, 'p:presentation.p:sldIdLst')
@@ -928,6 +978,7 @@ class SlideManager {
     }
 
     sldIdLst['p:sldId'].push({ '@_id': slideId, '@_r:id': rId })
+    this.#addSlideToSections(slideId, sourceSlideId)
     this.#flushPresentation()
   }
 

package/src/managers/TableManager.js

@@ -1166,8 +1166,8 @@ class TableManager {
     const tableX = xfrm?.['a:off']?.['@_x'] ? parseInt(xfrm['a:off']['@_x'], 10) : 0
     const tableY = xfrm?.['a:off']?.['@_y'] ? parseInt(xfrm['a:off']['@_y'], 10) : 0
 
-    const colWidths = this.#calculateColumnWidths(slideIndex, tableId, slideManager, tblObj, true)
-    const rowHeights = this.#calculateRowHeights(slideIndex, tableId, slideManager, tblObj, true)
+    const colWidths = this.#calculateColumnWidths(slideIndex, tableId, slideManager, tblObj, false)
+    const rowHeights = this.#calculateRowHeights(slideIndex, tableId, slideManager, tblObj, false)
 
     const R = this.getMergeRegion(slideIndex, tableId, rowIndex, colIndex, slideManager)
     let pr = rowIndex

package/src/managers/charts/ChartWorkbookUpdater.js

@@ -58,7 +58,6 @@ class ChartWorkbookUpdater {
         compressionOptions: { level: 6 },
       })
     } catch (err) {
-      console.error('Failed to update embedded workbook', err)
       logger.error('Failed to update embedded workbook', err)
       return workbookData // Return original if failed
     }

package/src/utils/relationshipUtils.js

@@ -67,24 +67,15 @@ function isValidRelationshipId(str) {
  * remapRelationshipIds(xml, new Map([['rId1', 'rId5'], ['rId2', 'rId6']]));
  */
 function remapRelationshipIds(xml, idMap) {
-  let updated = xml
+  if (!idMap || idMap.size === 0) return xml
 
-  // Sort by length descending to avoid partial replacements (e.g., rId1 replacing part of rId10)
-  const sortedEntries = Array.from(idMap.entries()).sort(([a], [b]) => b.length - a.length)
-
-  for (const [oldId, newId] of sortedEntries) {
-    // Replace rId references in attribute values: r:id="rId1", r:embed="rId1"
-    const pattern = new RegExp(`(r:[a-zA-Z]+=")${oldId}(")|rId="${oldId}(")`, 'g')
-    updated = updated.replace(pattern, (match, pre, post) => {
-      if (pre) return `${pre}${newId}${post}`
-      return match.replace(oldId, newId)
-    })
-
-    // Simple global replace as fallback
-    updated = updated.split(`"${oldId}"`).join(`"${newId}"`)
-  }
-
-  return updated
+  // Perform single-pass replacement of relationship IDs inside quotes to prevent clobbering
+  return xml.replace(/([\'"])(rId\d+)([\'"])/g, (match, openQuote, id, closeQuote) => {
+    if (idMap.has(id)) {
+      return `${openQuote}${idMap.get(id)}${closeQuote}`
+    }
+    return match
+  })
 }
 
 module.exports = {