node-pptx-templater 1.0.12 → 1.0.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-pptx-templater",
-  "version": "1.0.12",
+  "version": "1.0.13",
   "description": "High-performance, low-level PowerPoint (PPTX) OpenXML template engine for Node.js. Dynamically replace text, insert images, update charts (with Excel workbook data caching), and merge table cells without PowerPoint corruption or Repair Mode prompts.",
   "main": "./src/index.js",
   "type": "commonjs",

package/src/core/OutputWriter.js

@@ -107,8 +107,6 @@ class OutputWriter {
    * @returns {Promise<void>}
    */
   async #flushAllSlides(slideManager, zipManager) {
-    // SlideManager already writes to zipManager via setSlideXml,
-    // so this is mostly a no-op with a validation step.
     const info = slideManager.getAllSlideInfo()
 
     for (const slide of info) {
@@ -117,64 +115,58 @@ class OutputWriter {
       }
     }
 
-    // Update the slide count and titles in docProps/app.xml to prevent repair mode issues
+    // Change this block to await the process completely
     if (zipManager.hasFile('docProps/app.xml')) {
-      zipManager.addPendingPromise(
-        zipManager.rawZip
-          .file('docProps/app.xml')
-          .async('text')
-          .then(content => {
-            const parser = new XMLParser()
-            const appObj = parser.parse(content, 'app.xml')
-            const properties = appObj.Properties
-
-            if (properties) {
-              // 1. Update Slides count
-              properties.Slides = info.length
-
-              // 2. Find old slide titles count and update HeadingPairs
-              let oldSlideTitlesCount = 0
-              const variants = properties.HeadingPairs?.['vt:vector']?.['vt:variant']
-              if (Array.isArray(variants)) {
-                for (let i = 0; i < variants.length; i++) {
-                  if (variants[i]['vt:lpstr'] === 'Slide Titles') {
-                    const countVar = variants[i + 1]
-                    if (countVar) {
-                      oldSlideTitlesCount = parseInt(countVar['vt:i4'], 10) || 0
-                      countVar['vt:i4'] = info.length
-                    }
-                    break
+      // AWAIT this process entirely before exiting the function!
+      await zipManager.rawZip
+        .file('docProps/app.xml')
+        .async('text')
+        .then(content => {
+          const parser = new XMLParser()
+          const appObj = parser.parse(content, 'app.xml')
+          const properties = appObj.Properties
+
+          if (properties) {
+            properties.Slides = info.length
+
+            let oldSlideTitlesCount = 0
+            const variants = properties.HeadingPairs?.['vt:vector']?.['vt:variant']
+            if (Array.isArray(variants)) {
+              for (let i = 0; i < variants.length; i++) {
+                if (variants[i]['vt:lpstr'] === 'Slide Titles') {
+                  const countVar = variants[i + 1]
+                  if (countVar) {
+                    oldSlideTitlesCount = parseInt(countVar['vt:i4'], 10) || 0
+                    countVar['vt:i4'] = info.length
                   }
+                  break
                 }
               }
+            }
 
-              // 3. Update TitlesOfParts
-              const titlesVector = properties.TitlesOfParts?.['vt:vector']
-              if (titlesVector) {
-                let lpstrs = titlesVector['vt:lpstr']
-                if (lpstrs) {
-                  if (!Array.isArray(lpstrs)) lpstrs = [lpstrs]
-
-                  // Remove the old slide titles (which are at the end)
-                  if (oldSlideTitlesCount > 0 && lpstrs.length >= oldSlideTitlesCount) {
-                    lpstrs = lpstrs.slice(0, lpstrs.length - oldSlideTitlesCount)
-                  }
-
-                  // Append new slide titles
-                  const newSlideTitles = info.map(slide => slide.title || `Slide ${slide.index}`)
-                  lpstrs.push(...newSlideTitles)
-
-                  titlesVector['vt:lpstr'] = lpstrs
-                  titlesVector['@_size'] = String(lpstrs.length)
+            const titlesVector = properties.TitlesOfParts?.['vt:vector']
+            if (titlesVector) {
+              let lpstrs = titlesVector['vt:lpstr']
+              if (lpstrs) {
+                if (!Array.isArray(lpstrs)) lpstrs = [lpstrs]
+                if (oldSlideTitlesCount > 0 && lpstrs.length >= oldSlideTitlesCount) {
+                  lpstrs = lpstrs.slice(0, lpstrs.length - oldSlideTitlesCount)
                 }
-              }
+                const newSlideTitles = info.map(slide => slide.title || `Slide ${slide.index}`)
+                lpstrs.push(...newSlideTitles)
 
-              const declaration = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>'
-              const updatedXml = parser.build(appObj, declaration)
-              zipManager.writeFile('docProps/app.xml', updatedXml)
+                titlesVector['vt:lpstr'] = lpstrs
+                titlesVector['@_size'] = String(lpstrs.length)
+              }
             }
-          })
-      )
+
+            const declaration = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>'
+            const updatedXml = parser.build(appObj, declaration)
+
+            // Writing it safely here now that the function block is strictly sequential
+            zipManager.writeFile('docProps/app.xml', updatedXml)
+          }
+        })
     }
 
     logger.debug(`Flushed ${info.length} slide(s) to ZIP`)