node-poppler 6.1.2 → 6.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-poppler",
-	"version": "6.1.2",
+	"version": "6.2.1",
 	"description": "Asynchronous node.js wrapper for the Poppler PDF rendering library",
 	"keywords": [
 		"async",
@@ -33,6 +33,7 @@
 		"unite"
 	],
 	"main": "src/index.js",
+	"types": "types/index.d.ts",
 	"repository": "git+https://github.com/Fdawgs/node-poppler.git",
 	"homepage": "https://github.com/Fdawgs/node-poppler",
 	"bugs": {
@@ -40,6 +41,7 @@
 	},
 	"license": "MIT",
 	"author": "Frazer Smith <frazer.dev@outlook.com>",
+	"funding": "https://github.com/sponsors/Fdawgs",
 	"engines": {
 		"node": ">=14.0.0"
 	},

package/src/index.js

@@ -1,4 +1,3 @@
-/* eslint-disable security/detect-child-process */
 const camelCase = require("camelcase");
 const path = require("upath");
 const { execFile, spawn } = require("child_process");
@@ -11,6 +10,7 @@ const errorMessages = {
 	1: "Error opening a PDF file",
 	2: "Error opening an output file",
 	3: "Error related to PDF permissions",
+	4: "Error related to ICC profile",
 	99: "Other error",
 	3221226505: "Internal process error",
 };
@@ -19,10 +19,12 @@ const errorMessages = {
  * @author Frazer Smith
  * @description Check each option provided is valid, of the correct type, and can be used by specified
  * version of binary.
+ * @ignore
  * @param {object} acceptedOptions - Object containing options that a binary accepts.
  * @param {object} options - Object containing options to pass to binary.
  * @param {string=} version - Version of binary.
- * @returns {Array|Error} Array of CLI arguments or Error object if invalid arguments provided.
+ * @returns {Array<string>} Array of CLI arguments.
+ * @throws If invalid arguments provided.
  */
 function parseOptions(acceptedOptions, options, version) {
 	const args = [];
@@ -233,19 +235,19 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async () => {
+				child.on("close", () => {
 					if (stdOut !== "") {
 						resolve(stdOut.trim());
 					} else {
-						reject(new Error(stdErr.trim()));
+						reject(new Error(stdErr ? stdErr.trim() : undefined));
 					}
 				});
 			});
@@ -329,15 +331,15 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async (code) => {
+				child.on("close", (code) => {
 					if (stdOut !== "") {
 						resolve(stdOut.trim());
 					} else if (code === 0) {
@@ -447,15 +449,15 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async () => {
+				child.on("close", () => {
 					if (stdOut !== "") {
 						if (fileSize) {
 							stdOut = stdOut.replace(
@@ -481,7 +483,7 @@ class Poppler {
 							resolve(stdOut.trim());
 						}
 					} else {
-						reject(new Error(stdErr.trim()));
+						reject(new Error(stdErr ? stdErr.trim() : undefined));
 					}
 				});
 			});
@@ -734,15 +736,15 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async (code) => {
+				child.on("close", (code) => {
 					if (stdOut !== "") {
 						resolve(stdOut.trim());
 					} else if (code === 0) {
@@ -865,24 +867,23 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async (code) => {
+				/**
+				 * pdfToHtml does not return an exit code so check output to see if it was successful.
+				 * See https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/utils/pdftohtml.1
+				 */
+				child.on("close", () => {
 					if (stdOut !== "") {
 						resolve(stdOut.trim());
-					} else if (code === 0) {
-						resolve(errorMessages[code]);
-					} else if (stdErr !== "") {
-						reject(new Error(stdErr.trim()));
 					} else {
-						/* istanbul ignore next */
-						reject(new Error(errorMessages[code]));
+						reject(new Error(stdErr ? stdErr.trim() : undefined));
 					}
 				});
 			});
@@ -1067,11 +1068,11 @@ class Poppler {
 
 				let stdErr = "";
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async (code) => {
+				child.on("close", (code) => {
 					if (stdErr !== "") {
 						reject(new Error(stdErr.trim()));
 					} else if (code === 0) {
@@ -1302,15 +1303,15 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async (code) => {
+				child.on("close", (code) => {
 					if (stdOut !== "") {
 						resolve(stdOut.trim());
 					} else if (code === 0) {
@@ -1451,15 +1452,15 @@ class Poppler {
 				let stdOut = "";
 				let stdErr = "";
 
-				child.stdout.on("data", async (data) => {
+				child.stdout.on("data", (data) => {
 					stdOut += data;
 				});
 
-				child.stderr.on("data", async (data) => {
+				child.stderr.on("data", (data) => {
 					stdErr += data;
 				});
 
-				child.on("close", async (code) => {
+				child.on("close", (code) => {
 					if (stdOut !== "") {
 						resolve(stdOut.trim());
 					} else if (code === 0) {
@@ -1518,6 +1519,5 @@ class Poppler {
 	}
 }
 
-module.exports = {
-	Poppler,
-};
+module.exports.Poppler = Poppler;
+module.exports.default = Poppler;

package/{src → types}/index.d.ts

@@ -1,3 +1,4 @@
+export default Poppler;
 export class Poppler {
 	/**
 	 * @param {string=} binPath - Path of poppler-utils binaries.