node-pluginsmanager 3.6.0 → 3.6.1

package/lib/cjs/PluginsManager.d.ts

@@ -31,7 +31,7 @@ export default class PluginsManager extends EventEmitter {
     beforeInitAll(callback: tBeforeAllMethodCallback): Promise<void>;
     initAll(...data: unknown[]): Promise<void>;
     releaseAll(...data: unknown[]): Promise<void>;
-    getLatestGithubTag(user: string, repo: string): Promise<string>;
+    getLatestGithubTag(plugin: Orchestrator): Promise<string>;
     installViaGithub(user: string, repo: string, ...data: unknown[]): Promise<Orchestrator>;
     updateViaGithub(plugin: Orchestrator, ...data: unknown[]): Promise<Orchestrator>;
     uninstall(plugin: Orchestrator, ...data: unknown[]): Promise<string>;

package/lib/cjs/PluginsManager.js

@@ -270,9 +270,15 @@ class PluginsManager extends node_events_1.default {
             this.emit("allreleased", ...data);
         });
     }
-    getLatestGithubTag(user, repo) {
-        return (0, getLatestGithubTag_1.default)(user, repo).then((tag) => {
-            return tag.name;
+    getLatestGithubTag(plugin) {
+        return (0, checkOrchestrator_1.default)("getLatestGithubTag/plugin", plugin).then(() => {
+            const githubUserRepo = (0, parseGithubUserRepo_1.default)((0, extractGithub_1.default)(plugin));
+            if (!githubUserRepo) {
+                throw new Error("Plugin \"" + plugin.name + "\" has an invalid github project link");
+            }
+            return (0, getLatestGithubTag_1.default)(githubUserRepo.user, githubUserRepo.repo).then((tag) => {
+                return tag.name;
+            });
         });
     }
     // install a plugin via github repo, using "data" in arguments for "install" and "init" plugin's Orchestrator methods
@@ -408,17 +414,8 @@ class PluginsManager extends node_events_1.default {
     updateViaGithub(plugin, ...data) {
         let directory = "";
         let key = -1;
-        let githubUrl = "";
-        let latestTag = "";
         // check plugin
         return (0, checkOrchestrator_1.default)("updateViaGithub/plugin", plugin).then(() => {
-            const github = (0, extractGithub_1.default)(plugin);
-            return (0, checkNonEmptyString_1.default)("updateViaGithub/github", github).catch(() => {
-                return Promise.reject(new ReferenceError("Plugin \"" + plugin.name + "\" must be linked in the package to a github project to be updated"));
-            }).then(() => {
-                githubUrl = github;
-            });
-        }).then(() => {
             key = this.getPluginsNames().findIndex((pluginName) => {
                 return pluginName === plugin.name;
             });
@@ -433,17 +430,13 @@ class PluginsManager extends node_events_1.default {
             });
             // check remote version
         }).then(() => {
-            const githubUserRepo = (0, parseGithubUserRepo_1.default)(githubUrl);
-            if (!githubUserRepo) {
-                throw new Error("Plugin \"" + plugin.name + "\" has an invalid github project link");
-            }
             const currentVersion = semver_1.default.coerce(plugin.version);
             if (!currentVersion) {
                 throw new Error("Plugin \"" + plugin.name + "\" has no valid version (\"" + plugin.version + "\")");
             }
             this._logger?.("debug", "Get github latest tag", false, plugin.name);
-            return (0, getLatestGithubTag_1.default)(githubUserRepo.user, githubUserRepo.repo).then((tag) => {
-                const latestVersion = semver_1.default.coerce(tag.name);
+            return this.getLatestGithubTag(plugin).then((tag) => {
+                const latestVersion = semver_1.default.coerce(tag);
                 if (!latestVersion) {
                     throw new Error("No valid version found for plugin \"" + plugin.name + "\" on github");
                 }
@@ -451,11 +444,11 @@ class PluginsManager extends node_events_1.default {
                 if (!semver_1.default.gt(latestVersion, currentVersion)) {
                     throw new Error("Plugin \"" + plugin.name + "\" is already up to date (v" + plugin.version + ")");
                 }
-                latestTag = tag.name;
                 this._logger?.("success", "New version available", false, plugin.name);
+                return tag;
             });
             // release plugin
-        }).then(() => {
+        }).then((latestTag) => {
             const pluginName = plugin.name;
             return plugin.release(...data).then(() => {
                 this.emit("released", plugin, ...data);
@@ -463,9 +456,10 @@ class PluginsManager extends node_events_1.default {
             }).then(() => {
                 this.emit("destroyed", pluginName, ...data);
                 this.plugins.splice(key, 1);
+                return latestTag;
             });
             // update plugin
-        }).then(() => {
+        }).then((latestTag) => {
             this._logger?.("debug", "Update with new plugin version", false, plugin.name);
             return (0, gitUpdate_1.default)(directory, latestTag).then(() => {
                 return (0, createPluginByDirectory_1.default)(directory, this.externalResourcesDirectory, this._logger, ...data);

package/package.json

@@ -1,7 +1,7 @@
 {
 
   "name": "node-pluginsmanager",
-  "version": "3.6.0",
+  "version": "3.6.1",
   "description": "A plugins manager.",
 
   "type": "commonjs",