node-pluginsmanager 3.2.0 → 3.4.0

package/lib/cjs/PluginsManager.js

@@ -11,6 +11,7 @@ const node_os_1 = require("node:os");
 const promises_1 = require("node:fs/promises");
 // externals
 const check_version_modules_1 = __importDefault(require("check-version-modules"));
+const check_node_engine_1 = __importDefault(require("check-node-engine"));
 // locals
 const rmdirp_1 = __importDefault(require("./utils/rmdirp"));
 const checkAbsoluteDirectory_1 = __importDefault(require("./checkers/checkAbsoluteDirectory"));
@@ -18,6 +19,8 @@ const checkFunction_1 = __importDefault(require("./checkers/checkFunction"));
 const checkNonEmptyArray_1 = __importDefault(require("./checkers/checkNonEmptyArray"));
 const checkNonEmptyString_1 = __importDefault(require("./checkers/checkNonEmptyString"));
 const checkOrchestrator_1 = __importDefault(require("./checkers/checkOrchestrator"));
+const isDirectory_1 = __importDefault(require("./utils/isDirectory"));
+const isFile_1 = __importDefault(require("./utils/isFile"));
 const createPluginByDirectory_1 = __importDefault(require("./createPluginByDirectory"));
 const loadSortedPlugins_1 = __importDefault(require("./loadSortedPlugins"));
 const initSortedPlugins_1 = __importDefault(require("./initSortedPlugins"));
@@ -102,11 +105,16 @@ class PluginsManager extends node_events_1.default {
         return (0, checkAbsoluteDirectory_1.default)("checkModules/directory", this.directory).then(() => {
             return (0, checkOrchestrator_1.default)("checkModules/plugin", plugin);
         }).then(() => {
-            return (0, check_version_modules_1.default)((0, node_path_1.join)(this.directory, plugin.name, "package.json"), {
-                "failAtMajor": true,
-                "failAtMinor": true,
-                "failAtPatch": false,
-                "dev": false
+            const packageFile = (0, node_path_1.join)(this.directory, plugin.name, "package.json");
+            // start with node engine checker to compare minimal node version used
+            return (0, check_node_engine_1.default)(packageFile).then(() => {
+                // then check used packages versions
+                return (0, check_version_modules_1.default)(packageFile, {
+                    "failAtMajor": false, // can break and be a huge source of dev
+                    "failAtMinor": true, // mandatory, most important updates
+                    "failAtPatch": false, // not critical
+                    "dev": false
+                });
             }).then((analyze) => {
                 return analyze.result ? Promise.resolve() : Promise.reject(new Error("\"" + plugin.name + "\" plugin has obsoletes modules"));
             });
@@ -274,8 +282,30 @@ class PluginsManager extends node_events_1.default {
                 });
             });
         }).then((directory) => {
-            return (0, gitInstall_1.default)(directory, user, repo).then(() => {
-                // install dependencies & execute install script
+            // download plugin
+            return Promise.resolve().then(() => {
+                return (0, gitInstall_1.default)(directory, user, repo);
+                // check if plugin directory is created
+            }).then(() => {
+                return (0, isDirectory_1.default)(directory).then((isPluginADirectory) => {
+                    return !isPluginADirectory ? Promise.reject(new Error("\"" + repo + "\" plugin directory is not created")) : Promise.resolve();
+                });
+                // check if plugin has a valid package.json
+            }).then(() => {
+                return (0, isFile_1.default)((0, node_path_1.join)(directory, "package.json")).then((isPluginAPackageFile) => {
+                    return !isPluginAPackageFile ? Promise.reject(new Error("\"" + repo + "\" plugin has no valid package.json")) : Promise.resolve();
+                });
+                // install dependencies if needed
+            }).then(() => {
+                return (0, promises_1.readFile)((0, node_path_1.join)(directory, "package.json"), "utf-8").then((content) => {
+                    return JSON.parse(content);
+                }).then(({ dependencies }) => {
+                    return "object" !== typeof dependencies || null === dependencies || 0 >= Object.keys(dependencies).length
+                        ? Promise.resolve()
+                        : (0, npmInstall_1.default)(directory);
+                });
+                // create plugin
+            }).then(() => {
                 return (0, createPluginByDirectory_1.default)(directory, this.externalResourcesDirectory, this._logger, ...data);
                 // check plugin modules versions
             }).then((plugin) => {
@@ -283,17 +313,19 @@ class PluginsManager extends node_events_1.default {
                     return Promise.resolve(plugin);
                 });
             }).then((plugin) => {
+                // execute plugin install script
                 return Promise.resolve().then(() => {
-                    return !plugin.dependencies ? Promise.resolve() : (0, npmInstall_1.default)(directory);
-                }).then(() => {
-                    return plugin.install(...data);
-                    // execute init script
+                    return plugin.install(...data).then(() => {
+                        this.emit("installed", plugin, ...data);
+                    });
+                    // execute init plugin script
                 }).then(() => {
-                    this.emit("installed", plugin, ...data);
-                    return plugin.init(...data);
+                    return plugin.init(...data).then(() => {
+                        this.emit("initialized", plugin, ...data);
+                        this.plugins.push(plugin);
+                    });
+                    // return installed plugin
                 }).then(() => {
-                    this.emit("initialized", plugin, ...data);
-                    this.plugins.push(plugin);
                     return Promise.resolve(plugin);
                 }).catch((err) => {
                     return this.uninstall(plugin, ...data).then(() => {

package/lib/cjs/checkers/checkDirectory.js

@@ -5,18 +5,13 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = checkDirectory;
-// natives
-const node_fs_1 = require("node:fs");
 // locals
 const checkNonEmptyString_1 = __importDefault(require("./checkNonEmptyString"));
+const isDirectory_1 = __importDefault(require("../utils/isDirectory"));
 // module
 function checkDirectory(dataName, directory) {
     return (0, checkNonEmptyString_1.default)(dataName, directory).then(() => {
-        return new Promise((resolve) => {
-            (0, node_fs_1.lstat)(directory, (err, stats) => {
-                return resolve(Boolean(!err && stats.isDirectory()));
-            });
-        });
+        return (0, isDirectory_1.default)(directory);
     }).then((exists) => {
         return exists ? Promise.resolve() : Promise.reject(new Error("\"" + dataName + "\" (" + directory + ") is not a valid directory"));
     });

package/lib/cjs/utils/isDirectory.js

@@ -14,7 +14,7 @@ function isDirectory(directory) {
             reject(new TypeError("\"directory\" argument is not a string"));
         }
         else if ("" === directory.trim()) {
-            reject(new Error("\"directory\" argument is empty"));
+            reject(new RangeError("\"directory\" argument is empty"));
         }
         else {
             (0, node_fs_1.lstat)(directory, (err, stats) => {

package/lib/cjs/utils/isFile.d.ts

@@ -0,0 +1 @@
+export default function isFile(directory: string): Promise<boolean>;

package/lib/cjs/utils/isFile.js

@@ -0,0 +1,25 @@
+"use strict";
+// deps
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = isFile;
+// natives
+const node_fs_1 = require("node:fs");
+// module
+function isFile(directory) {
+    return new Promise((resolve, reject) => {
+        if ("undefined" === typeof directory) {
+            reject(new ReferenceError("missing \"directory\" argument"));
+        }
+        else if ("string" !== typeof directory) {
+            reject(new TypeError("\"directory\" argument is not a string"));
+        }
+        else if ("" === directory.trim()) {
+            reject(new RangeError("\"directory\" argument is empty"));
+        }
+        else {
+            (0, node_fs_1.lstat)(directory, (err, stats) => {
+                return resolve(Boolean(!err && stats.isFile()));
+            });
+        }
+    });
+}

package/package.json

@@ -1,7 +1,7 @@
 {
 
   "name": "node-pluginsmanager",
-  "version": "3.2.0",
+  "version": "3.4.0",
   "description": "A plugins manager.",
 
   "type": "commonjs",
@@ -19,8 +19,6 @@
 
   "scripts": {
 
-    "prepare": "npx husky || true",
-
     "lint-back": "npx eslint --config .eslintrc-back.js --ext .ts,.cts,.mts ./lib/src/**/*",
     "lint-tests": "npx eslint --config .eslintrc-tests.js --ext .js,.cjs,.mjs ./test/**/*.js",
     "lint": "npm run lint-back && npm run lint-tests",
@@ -31,12 +29,13 @@
     "build-back": "npm run clean-back && npx tsc --project ./tsconfig.json",
     "build": "npm run build-back",
 
+    "check-node-engine": "npx check-node-engine",
     "check-requires": "npx used-deps-analyzer ./package.json ./lib/src --no-dev",
     "check-updates": "npx check-version-modules --no-fail-at-major --fail-at-minor --fail-at-patch",
     "unit-tests": "npx mocha",
     "unit-tests-local": "npx nyc --reporter=html --reporter=text mocha",
 
-    "tests": "npm run lint && npm run check-requires && npm run check-updates && npm run build && npm run unit-tests-local"
+    "tests": "npm run lint && npm run check-node-engine && npm run check-requires && npm run check-updates && npm run build && npm run unit-tests-local"
 
   },
 
@@ -44,36 +43,30 @@
     "/lib/cjs"
   ],
   "engines": {
-    "node": ">=22.22.0"
+    "node": ">=22.22.3"
   },
 
   "dependencies": {
-    "check-version-modules": "2.3.0"
+    "check-node-engine": "1.1.0",
+    "check-version-modules": "2.5.0"
   },
   "devDependencies": {
     "@types/express": "5.0.6",
-    "@types/node": "25.6.0",
+    "@types/node": "25.9.1",
     "@types/socket.io": "3.0.2",
     "@types/ws": "8.18.1",
     "eslint-plugin-personnallinter": "git+ssh://git@github.com/Psychopoulet/eslint-plugin-personnallinter",
     "express": "5.2.1",
     "husky": "9.1.7",
-    "mocha": "11.7.5",
-    "node-pluginsmanager-plugin": "7.1.0",
+    "mocha": "11.7.6",
+    "node-pluginsmanager-plugin": "7.3.0",
     "nyc": "18.0.0",
     "proxyquire": "2.1.3",
     "rimraf": "6.1.3",
     "socket.io": "4.8.3",
     "typescript": "5.9.3",
-    "used-deps-analyzer": "0.3.0",
-    "ws": "8.20.0"
-  },
-
-  "husky": {
-    "hooks": {
-      "pre-commit": "npm run lint",
-      "pre-push": "npm run build && npm run unit-tests-local"
-    }
+    "used-deps-analyzer": "0.4.0",
+    "ws": "8.21.0"
   },
 
   "keywords": [