node-pluginsmanager 2.5.1 → 3.0.0

package/LICENSE

@@ -1,13 +1,13 @@
-Copyright (c) 2023, Sébastien Vidal
-
-Permission to use, copy, modify, and/or distribute this software for any
-purpose with or without fee is hereby granted, provided that the above
-copyright notice and this permission notice appear in all copies.
-
-THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
-WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
-MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
-ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
-WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
-ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
-OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+Copyright (c) 2023, Sébastien Vidal
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

package/README.md

@@ -1,79 +1,84 @@
-# node-pluginsmanager
-A plugins manager
-
-[![Build status](https://api.travis-ci.org/Psychopoulet/node-pluginsmanager.svg?branch=master)](https://travis-ci.org/Psychopoulet/node-pluginsmanager)
-[![Coverage status](https://coveralls.io/repos/github/Psychopoulet/node-pluginsmanager/badge.svg?branch=master)](https://coveralls.io/github/Psychopoulet/node-pluginsmanager)
-[![Dependency status](https://david-dm.org/Psychopoulet/node-pluginsmanager/status.svg)](https://david-dm.org/Psychopoulet/node-pluginsmanager)
-[![Dev dependency status](https://david-dm.org/Psychopoulet/node-pluginsmanager/dev-status.svg)](https://david-dm.org/Psychopoulet/node-pluginsmanager?type=dev)
-[![Issues](https://img.shields.io/github/issues/Psychopoulet/node-pluginsmanager.svg)](https://github.com/Psychopoulet/node-pluginsmanager/issues)
-[![Pull requests](https://img.shields.io/github/issues-pr/Psychopoulet/node-pluginsmanager.svg)](https://github.com/Psychopoulet/node-pluginsmanager/pulls)
-
-> please note that this version is only usable with node-pluginsmanager-plugin 3.x.x &&  4.x.x
-
-## Installation
-
-```bash
-$ npm install node-pluginsmanager
-```
-
-## Features
-
-  * simply manage plugins (extended from [node-pluginsmanager-plugin](https://github.com/Psychopoulet/node-pluginsmanager-plugin)) to interact with specifics hardwares / API / whatever
-  * install plugins manually or via github & initialize them
-  * update plugins via github
-  * uninstall plugins and release there resources
-  * run plugins' middlewares for server, to create specifics rules
-  * check plugins' modules' versions
-
-## Architecture
-
-### Plugin
-
-![Plugin](https://raw.githubusercontent.com/Psychopoulet/node-pluginsmanager-plugin/master/documentation/pictures/functional.jpg)
-
-### Routes
-
-![Routes](./documentation/routes.jpg)
-
-## Content
-
-[check the TypeScript definition file](https://github.com/Psychopoulet/node-pluginsmanager/blob/master/lib/index.d.ts)
-
-## Events
-
-  * ``` on("error", (err: Error) => void) : this ``` fires if an error occurs
-
-  * ``` on("loading", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin starts load
-  * ``` on("loaded", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin ends load
-  * ``` on("allloaded", (data?: any) => void) : this ``` fires if all the plugins are loaded
-
-  * ``` on("initializing", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin starts init
-  * ``` on("initialized", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin ends init
-  * ``` on("allinitialized", (data?: any) => void) : this ``` fires if all the plugins are initialized
-
-  * ``` on("released", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin is released
-  * ``` on("allreleased", (data?: any) => void) : this ``` fires if all the plugins are released
-
-  * ``` on("destroyed", (pluginName: string, data?: any) => void) : this ``` fires if a plugin is destroyed
-  * ``` on("alldestroyed", (data?: any) => void) : this ``` fires if all the plugins are destroyed
-
-  * ``` on("installed", (pluginName: string, data?: any) => void) : this ``` fires if a plugin is installed
-  * ``` on("updated", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin is updated
-  * ``` on("uninstalled", (pluginName: string, data?: any) => void) : this ``` fires if a plugin is uninstalled
-
-## Examples
-
-[check the TypeScript compilation tests](https://github.com/Psychopoulet/node-pluginsmanager/blob/master/test/typescript/compilation.ts)
-
-## Tests
-
-```bash
-$ git clone git://github.com/Psychopoulet/node-pluginsmanager.git
-$ cd ./node-pluginsmanager
-$ npm install
-$ npm run-script tests
-```
-
-## License
-
-  [ISC](LICENSE)
+# node-pluginsmanager
+A plugins manager
+
+[![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=Psychopoulet_node-pluginsmanager&metric=ncloc)](https://sonarcloud.io/summary/new_code?id=Psychopoulet_node-pluginsmanager)
+[![Issues](https://img.shields.io/github/issues/Psychopoulet/node-pluginsmanager.svg)](https://github.com/Psychopoulet/node-pluginsmanager/issues)
+[![Pull requests](https://img.shields.io/github/issues-pr/Psychopoulet/node-pluginsmanager.svg)](https://github.com/Psychopoulet/node-pluginsmanager/pulls)
+
+[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=Psychopoulet_node-pluginsmanager&metric=reliability_rating)](https://sonarcloud.io/summary/new_code?id=Psychopoulet_node-pluginsmanager)
+[![Security Rating](https://sonarcloud.io/api/project_badges/measure?project=Psychopoulet_node-pluginsmanager&metric=security_rating)](https://sonarcloud.io/summary/new_code?id=Psychopoulet_node-pluginsmanager)
+[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=Psychopoulet_node-pluginsmanager&metric=sqale_rating)](https://sonarcloud.io/summary/new_code?id=Psychopoulet_node-pluginsmanager)
+[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=Psychopoulet_node-pluginsmanager&metric=vulnerabilities)](https://sonarcloud.io/summary/new_code?id=Psychopoulet_node-pluginsmanager)
+[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=Psychopoulet_node-pluginsmanager&metric=bugs)](https://sonarcloud.io/summary/new_code?id=Psychopoulet_node-pluginsmanager)
+
+[![Known Vulnerabilities](https://snyk.io/test/github/Psychopoulet/node-pluginsmanager/badge.svg)](https://snyk.io/test/github/Psychopoulet/node-pluginsmanager)
+
+> please note that this version is only usable with node-pluginsmanager-plugin 3.x.x &&  4.x.x
+
+## Installation
+
+```bash
+$ npm install node-pluginsmanager
+```
+
+## Features
+
+  * simply manage plugins (extended from [node-pluginsmanager-plugin](https://github.com/Psychopoulet/node-pluginsmanager-plugin)) to interact with specifics hardwares / API / whatever
+  * install plugins manually or via github & initialize them
+  * update plugins via github
+  * uninstall plugins and release there resources
+  * run plugins' middlewares for server, to create specifics rules
+  * check plugins' modules' versions
+
+## Architecture
+
+### Plugin
+
+![Plugin](https://raw.githubusercontent.com/Psychopoulet/node-pluginsmanager-plugin/master/documentation/pictures/functional.jpg)
+
+### Routes
+
+![Routes](./documentation/routes.jpg)
+
+## Content
+
+[check the TypeScript definition file](https://github.com/Psychopoulet/node-pluginsmanager/blob/master/lib/index.d.ts)
+
+## Events
+
+  * ``` on("error", (err: Error) => void) : this ``` fires if an error occurs
+
+  * ``` on("loading", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin starts load
+  * ``` on("loaded", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin ends load
+  * ``` on("allloaded", (data?: any) => void) : this ``` fires if all the plugins are loaded
+
+  * ``` on("initializing", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin starts init
+  * ``` on("initialized", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin ends init
+  * ``` on("allinitialized", (data?: any) => void) : this ``` fires if all the plugins are initialized
+
+  * ``` on("released", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin is released
+  * ``` on("allreleased", (data?: any) => void) : this ``` fires if all the plugins are released
+
+  * ``` on("destroyed", (pluginName: string, data?: any) => void) : this ``` fires if a plugin is destroyed
+  * ``` on("alldestroyed", (data?: any) => void) : this ``` fires if all the plugins are destroyed
+
+  * ``` on("installed", (pluginName: string, data?: any) => void) : this ``` fires if a plugin is installed
+  * ``` on("updated", (plugin: Orchestrator, data?: any) => void) : this ``` fires if a plugin is updated
+  * ``` on("uninstalled", (pluginName: string, data?: any) => void) : this ``` fires if a plugin is uninstalled
+
+## Examples
+
+[check the TypeScript compilation tests](https://github.com/Psychopoulet/node-pluginsmanager/blob/master/test/typescript/compilation.ts)
+
+## Tests
+
+```bash
+$ git clone git://github.com/Psychopoulet/node-pluginsmanager.git
+$ cd ./node-pluginsmanager
+$ npm install
+$ npm run-script tests
+```
+
+## License
+
+  [ISC](LICENSE)

package/lib/cjs/PluginsManager.d.ts

@@ -5,19 +5,19 @@ import type { Server as WebSocketServer } from "ws";
 import type { Server as SocketIOServer } from "socket.io";
 interface iPluginManagerOptions {
     "directory"?: string;
-    "externalRessourcesDirectory"?: string;
+    "externalResourcesDirectory"?: string;
     "logger"?: tLogger | null;
 }
-type tBeforeAllMethodCallback = (...data: any) => Promise<void> | void;
+type tBeforeAllMethodCallback = (...data: unknown[]) => Promise<void> | void;
 export default class PluginsManager extends EventEmitter {
     protected _beforeLoadAll: tBeforeAllMethodCallback | null;
     protected _beforeInitAll: tBeforeAllMethodCallback | null;
     protected _logger: tLogger | null;
     protected _orderedPluginsNames: string[];
     directory: string;
-    externalRessourcesDirectory: string;
+    externalResourcesDirectory: string;
     plugins: Orchestrator[];
-    constructor(options: iPluginManagerOptions);
+    constructor(options?: iPluginManagerOptions);
     getPluginsNames(): string[];
     setOrder(pluginsNames: string[]): Promise<void>;
     getOrder(): string[];
@@ -26,13 +26,13 @@ export default class PluginsManager extends EventEmitter {
     appMiddleware(req: IncomingMessage, res: ServerResponse, next: () => void): void;
     socketMiddleware(server: WebSocketServer | SocketIOServer): void;
     beforeLoadAll(callback: tBeforeAllMethodCallback): Promise<void>;
-    loadAll(...data: any): Promise<void>;
-    destroyAll(...data: any): Promise<void>;
+    loadAll(...data: unknown[]): Promise<void>;
+    destroyAll(...data: unknown[]): Promise<void>;
     beforeInitAll(callback: tBeforeAllMethodCallback): Promise<void>;
-    initAll(...data: any): Promise<void>;
-    releaseAll(...data: any): Promise<void>;
-    installViaGithub(user: string, repo: string, ...data: any): Promise<Orchestrator>;
-    updateViaGithub(plugin: Orchestrator, ...data: any): Promise<Orchestrator>;
-    uninstall(plugin: Orchestrator, ...data: any): Promise<string>;
+    initAll(...data: unknown[]): Promise<void>;
+    releaseAll(...data: unknown[]): Promise<void>;
+    installViaGithub(user: string, repo: string, ...data: unknown[]): Promise<Orchestrator>;
+    updateViaGithub(plugin: Orchestrator, ...data: unknown[]): Promise<Orchestrator>;
+    uninstall(plugin: Orchestrator, ...data: unknown[]): Promise<string>;
 }
 export {};

package/lib/cjs/PluginsManager.js

@@ -30,31 +30,39 @@ const npmInstall_1 = __importDefault(require("./cmd/npm/npmInstall"));
 const npmUpdate_1 = __importDefault(require("./cmd/npm/npmUpdate"));
 // consts
 const DEFAULT_PLUGINS_DIRECTORY = (0, node_path_1.join)((0, node_os_1.homedir)(), "node-pluginsmanager-plugins");
-const DEFAULT_RESSOURCES_DIRECTORY = (0, node_path_1.join)((0, node_os_1.homedir)(), "node-pluginsmanager-resources");
+const DEFAULT_RESOURCES_DIRECTORY = (0, node_path_1.join)((0, node_os_1.homedir)(), "node-pluginsmanager-resources");
 // module
 class PluginsManager extends node_events_1.default {
+    // attributes
+    // protected
+    _beforeLoadAll;
+    _beforeInitAll;
+    _logger;
+    _orderedPluginsNames;
+    // public
+    directory; // plugins location (must be writable). default : join(homedir(), "node-pluginsmanager-plugins")
+    externalResourcesDirectory; // external resources locations (sqlite, files, cache, etc...) (must be writable). default : join(homedir(), "node-pluginsmanager-resources")
+    plugins; // plugins' Orchestrators
     // constructor
-    constructor(options) {
+    constructor(options = {}) {
         super();
+        // mandatory props
+        if ("object" !== typeof options) {
+            throw new ReferenceError("\"options\" must be a non-null object");
+        }
         // protected
         this._beforeLoadAll = null;
         this._beforeInitAll = null;
         this._orderedPluginsNames = [];
-        this._logger = options && "function" === typeof options.logger
-            ? options.logger
-            : null;
+        this._logger = "function" === typeof options.logger ? options.logger : null;
         // public
         this.plugins = [];
-        this.directory = options && "undefined" !== typeof options.directory
-            ? options.directory
-            : DEFAULT_PLUGINS_DIRECTORY;
-        this.externalRessourcesDirectory = options && "undefined" !== typeof options.externalRessourcesDirectory
-            ? options.externalRessourcesDirectory
-            : DEFAULT_RESSOURCES_DIRECTORY;
+        this.directory = options.directory ?? DEFAULT_PLUGINS_DIRECTORY;
+        this.externalResourcesDirectory = options.externalResourcesDirectory ?? DEFAULT_RESOURCES_DIRECTORY;
     }
     // public
     getPluginsNames() {
-        return [...this.plugins].map((plugin) => {
+        return this.plugins.map((plugin) => {
             return plugin.name;
         });
     }
@@ -78,19 +86,17 @@ class PluginsManager extends node_events_1.default {
             return !errors.length ? Promise.resolve() : Promise.reject(new Error(errors.join("\r\n")));
         }).then(() => {
             this._orderedPluginsNames = pluginsNames;
-            return Promise.resolve();
         });
     }
     getOrder() {
         return [...this._orderedPluginsNames];
     }
     checkAllModules() {
-        const _checkPluginsModules = (i = 0) => {
-            return i < this.plugins.length ? this.checkModules(this.plugins[i]).then(() => {
-                return _checkPluginsModules(i + 1);
-            }) : Promise.resolve();
-        };
-        return _checkPluginsModules();
+        return Promise.all(this.plugins.map((plugin) => {
+            return this.checkModules(plugin);
+        })).then(() => {
+            return Promise.resolve();
+        });
     }
     checkModules(plugin) {
         return (0, checkAbsoluteDirectory_1.default)("checkModules/directory", this.directory).then(() => {
@@ -116,7 +122,7 @@ class PluginsManager extends node_events_1.default {
             return next();
         }
         else {
-            const _recursiveNext = (i) => {
+            function _recursiveNext(i) {
                 if (i < plugins.length) {
                     return () => {
                         return plugins[i].appMiddleware(req, res, _recursiveNext(i + 1));
@@ -126,8 +132,8 @@ class PluginsManager extends node_events_1.default {
                 else {
                     return next;
                 }
-            };
-            return plugins[0].appMiddleware(req, res, _recursiveNext(0));
+            }
+            return plugins[0].appMiddleware(req, res, _recursiveNext(1)); // must start at index "1", cause the "0" is executed here
         }
     }
     // middleware for socket to add bilateral push events
@@ -142,7 +148,6 @@ class PluginsManager extends node_events_1.default {
     beforeLoadAll(callback) {
         return (0, checkFunction_1.default)("beforeLoadAll/callback", callback).then(() => {
             this._beforeLoadAll = callback;
-            return Promise.resolve();
         });
     }
     // load all plugins asynchronously, using "data" in arguments for "load" plugin's Orchestrator method
@@ -156,11 +161,11 @@ class PluginsManager extends node_events_1.default {
             });
             // create dir if not exist
         }).then(() => {
-            return (0, checkNonEmptyString_1.default)("initAll/externalRessourcesDirectory", this.externalRessourcesDirectory).then(() => {
-                return (0, promises_1.mkdir)(this.externalRessourcesDirectory, {
+            return (0, checkNonEmptyString_1.default)("initAll/externalResourcesDirectory", this.externalResourcesDirectory).then(() => {
+                return (0, promises_1.mkdir)(this.externalResourcesDirectory, {
                     "recursive": true
                 }).then(() => {
-                    return (0, checkAbsoluteDirectory_1.default)("initAll/externalRessourcesDirectory", this.externalRessourcesDirectory);
+                    return (0, checkAbsoluteDirectory_1.default)("initAll/externalResourcesDirectory", this.externalResourcesDirectory);
                 });
             });
             // ensure loop
@@ -184,7 +189,7 @@ class PluginsManager extends node_events_1.default {
             return (0, promises_1.readdir)(this.directory);
             // load all
         }).then((files) => {
-            return (0, loadSortedPlugins_1.default)(this.directory, this.externalRessourcesDirectory, files, this.plugins, this._orderedPluginsNames, this.emit.bind(this), this._logger, ...data);
+            return (0, loadSortedPlugins_1.default)(this.directory, this.externalResourcesDirectory, files, this.plugins, this._orderedPluginsNames, this.emit.bind(this), this._logger, ...data);
             // sort plugins
         }).then(() => {
             this.plugins.sort((a, b) => {
@@ -198,51 +203,35 @@ class PluginsManager extends node_events_1.default {
                     return 0;
                 }
             });
-            return Promise.resolve();
             // end
         }).then(() => {
             this.emit("allloaded", ...data);
-            return Promise.resolve();
         });
     }
     // after releasing, destroy packages data & free "plugins" list, using "data" in arguments for "destroy" plugin's Orchestrator method
     destroyAll(...data) {
-        return Promise.resolve().then(() => {
-            const _destroyPlugin = (i = this.plugins.length - 1) => {
-                return -1 < i ? Promise.resolve().then(() => {
-                    const pluginName = this.plugins[i].name;
-                    // emit event
-                    return this.plugins[i].destroy().then(() => {
-                        this.emit("destroyed", pluginName, ...data);
-                        return Promise.resolve();
-                        // loop
-                    }).then(() => {
-                        return _destroyPlugin(i - 1);
-                    });
-                }) : Promise.resolve();
-            };
-            return _destroyPlugin();
-            // end
-        }).then(() => {
+        return Promise.all(this.plugins.map((plugin) => {
+            return plugin.destroy().then(() => {
+                this.emit("destroyed", plugin.name, ...data);
+            });
+        })).then(() => {
             this.plugins = [];
             this.emit("alldestroyed", ...data);
-            return Promise.resolve();
             // remove all external resources
         }).then(() => {
-            return (0, rmdirp_1.default)(this.externalRessourcesDirectory);
+            return (0, rmdirp_1.default)(this.externalResourcesDirectory);
         });
     }
     // add a function executed before initializing all plugins
     beforeInitAll(callback) {
         return (0, checkFunction_1.default)("beforeInitAll/callback", callback).then(() => {
             this._beforeInitAll = callback;
-            return Promise.resolve();
         });
     }
     // initialize all plugins asynchronously, using "data" in arguments for "init" plugin's Orchestrator method
     initAll(...data) {
         return (0, checkAbsoluteDirectory_1.default)("initAll/directory", this.directory).then(() => {
-            return (0, checkAbsoluteDirectory_1.default)("initAll/externalRessourcesDirectory", this.externalRessourcesDirectory);
+            return (0, checkAbsoluteDirectory_1.default)("initAll/externalResourcesDirectory", this.externalResourcesDirectory);
         }).then(() => {
             // execute _beforeInitAll
             return "function" !== typeof this._beforeInitAll ? Promise.resolve() : new Promise((resolve, reject) => {
@@ -260,29 +249,16 @@ class PluginsManager extends node_events_1.default {
             // end
         }).then(() => {
             this.emit("allinitialized", ...data);
-            return Promise.resolve();
         });
     }
     // release a plugin (keep package but destroy Mediator & Server), using "data" in arguments for "release" plugin's Orchestrator method
     releaseAll(...data) {
-        return Promise.resolve().then(() => {
-            const _releasePlugin = (i = this.plugins.length - 1) => {
-                return -1 < i ? Promise.resolve().then(() => {
-                    return this.plugins[i].release(data);
-                    // emit event
-                }).then(() => {
-                    this.emit("released", this.plugins[i], ...data);
-                    return Promise.resolve();
-                    // loop
-                }).then(() => {
-                    return _releasePlugin(i - 1);
-                }) : Promise.resolve();
-            };
-            return _releasePlugin();
-            // end
-        }).then(() => {
+        return Promise.all(this.plugins.map((plugin) => {
+            return plugin.release(...data).then(() => {
+                this.emit("released", plugin, ...data);
+            });
+        })).then(() => {
             this.emit("allreleased", ...data);
-            return Promise.resolve();
         });
     }
     // install a plugin via github repo, using "data" in arguments for "install" and "init" plugin's Orchestrator methods
@@ -301,11 +277,9 @@ class PluginsManager extends node_events_1.default {
                 });
             });
         }).then((directory) => {
-            return Promise.resolve().then(() => {
-                return (0, gitInstall_1.default)(directory, user, repo);
-            }).then(() => {
+            return (0, gitInstall_1.default)(directory, user, repo).then(() => {
                 // install dependencies & execute install script
-                return (0, createPluginByDirectory_1.default)(directory, this.externalRessourcesDirectory, this._logger, ...data);
+                return (0, createPluginByDirectory_1.default)(directory, this.externalResourcesDirectory, this._logger, ...data);
                 // check plugin modules versions
             }).then((plugin) => {
                 return this.checkModules(plugin).then(() => {
@@ -330,14 +304,12 @@ class PluginsManager extends node_events_1.default {
                     });
                 });
             }).catch((err) => {
-                return new Promise((resolve, reject) => {
-                    (0, checkAbsoluteDirectory_1.default)("installViaGithub/plugindirectory", directory).then(() => {
-                        return (0, rmdirp_1.default)(directory).then(() => {
-                            return err ? reject(err) : resolve();
-                        });
-                    }).catch(() => {
-                        return err ? reject(err) : resolve();
-                    });
+                return (0, checkAbsoluteDirectory_1.default)("installViaGithub/plugindirectory", directory).then(() => {
+                    return (0, rmdirp_1.default)(directory);
+                }).then(() => {
+                    return Promise.reject(err);
+                }).catch(() => {
+                    return Promise.reject(err);
                 });
             });
         });
@@ -373,12 +345,11 @@ class PluginsManager extends node_events_1.default {
             }).then(() => {
                 this.emit("destroyed", pluginName, ...data);
                 this.plugins.splice(key, 1);
-                return Promise.resolve();
             });
             // download plugin
         }).then(() => {
             return (0, gitUpdate_1.default)(directory).then(() => {
-                return (0, createPluginByDirectory_1.default)(directory, this.externalRessourcesDirectory, this._logger, ...data);
+                return (0, createPluginByDirectory_1.default)(directory, this.externalResourcesDirectory, this._logger, ...data);
             });
             // check plugin modules versions
         }).then((_plugin) => {
@@ -425,20 +396,17 @@ class PluginsManager extends node_events_1.default {
             // release plugin
         }).then(() => {
             return plugin.release(...data).then(() => {
-                return (0, rmdirp_1.default)((0, node_path_1.join)(this.externalRessourcesDirectory));
+                return (0, rmdirp_1.default)((0, node_path_1.join)(this.externalResourcesDirectory, pluginName));
             }).then(() => {
                 this.emit("released", plugin, ...data);
                 return plugin.destroy(...data);
             }).then(() => {
                 this.emit("destroyed", pluginName, ...data);
                 this.plugins.splice(key, 1);
-                return Promise.resolve();
             });
             // update dependencies & execute update script
         }).then(() => {
-            return Promise.resolve().then(() => {
-                return plugin.uninstall(...data);
-            }).then(() => {
+            return plugin.uninstall(...data).then(() => {
                 this.emit("uninstalled", pluginName, ...data);
                 return (0, rmdirp_1.default)(directory);
             });
@@ -448,4 +416,3 @@ class PluginsManager extends node_events_1.default {
     }
 }
 exports.default = PluginsManager;
-;

package/lib/cjs/checkers/checkFunction.d.ts

@@ -1 +1 @@
-export default function isFunction(dataName: string, data: any): Promise<void>;
+export default function isFunction(dataName: string, data: unknown): Promise<void>;

package/lib/cjs/checkers/checkNonEmptyArray.d.ts

@@ -1 +1 @@
-export default function isNonEmptyArray(dataName: string, data: any): Promise<void>;
+export default function isNonEmptyArray(dataName: string, data: unknown): Promise<void>;

package/lib/cjs/checkers/checkNonEmptyString.d.ts

@@ -1 +1 @@
-export default function isNonEmptyString(dataName: string, data: any): Promise<void>;
+export default function isNonEmptyString(dataName: string, data: unknown): Promise<void>;

package/lib/cjs/checkers/checkOrchestrator.js

@@ -1,10 +1,14 @@
 "use strict";
-// deps
+/*
+    eslint-disable @typescript-eslint/unbound-method
+*/
+// => @typescript-eslint/unbound-method is disabled to allow check on data (no need for js context)
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = checkOrchestrator;
+// deps
 // natives
 const node_events_1 = __importDefault(require("node:events"));
 // locals

package/lib/cjs/cmd/cmd.js

@@ -20,18 +20,27 @@ function cmd(directory, command, params) {
         return (0, checkNonEmptyArray_1.default)("cmd/params", params);
     }).then(() => {
         return new Promise((resolve, reject) => {
-            let result = "";
+            let errMsg = "";
+            let outMsg = "";
             const mySpawn = (0, node_child_process_1.spawn)(command, params, {
                 "cwd": directory,
                 "windowsHide": true,
                 "shell": true
             }).on("error", (err) => {
-                result += (0, stdToString_1.default)(err);
+                errMsg += (0, stdToString_1.default)(err);
             }).on("close", (code) => {
-                return code ? reject(new Error(result)) : resolve();
+                if (0 < errMsg.length) {
+                    return code ? reject(new Error(errMsg)) : resolve();
+                }
+                return code ? reject(new Error(outMsg)) : resolve();
             });
+            mySpawn.stdout.setEncoding("utf8");
+            mySpawn.stdout.on("data", (msg) => {
+                outMsg += (0, stdToString_1.default)(msg);
+            });
+            mySpawn.stderr.setEncoding("utf8");
             mySpawn.stderr.on("data", (msg) => {
-                result += (0, stdToString_1.default)(msg);
+                errMsg += (0, stdToString_1.default)(msg);
             });
         });
     });

package/lib/cjs/cmd/git/gitInstall.js

@@ -16,7 +16,7 @@ function gitInstall(directory, user, repo) {
     return (0, checkNonEmptyString_1.default)("cmd/git/install/directory", directory).then(() => {
         return new Promise((resolve, reject) => {
             (0, checkDirectory_1.default)("cmd/git/install/directory", directory).then(() => {
-                reject(new Error("\"" + directory + "\" aldready exists"));
+                reject(new Error("\"" + directory + "\" already exists"));
             }).catch(() => {
                 resolve();
             });

package/lib/cjs/cmd/stdToString.d.ts

@@ -1 +1 @@
-export default function stdToString(msg: any): string;
+export default function stdToString(msg: unknown): string;

package/lib/cjs/cmd/stdToString.js

@@ -1,7 +1,11 @@
 "use strict";
-// module
+/*
+    eslint-disable @typescript-eslint/no-base-to-string
+*/
+// => @typescript-eslint/no-base-to-string is disabled to force stringifying a potential object
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = stdToString;
+// module
 function stdToString(msg) {
     if ("object" !== typeof msg) {
         return String(msg);
@@ -9,7 +13,10 @@ function stdToString(msg) {
     else if (msg instanceof Buffer) {
         return msg.toString("utf8");
     }
+    else if (msg.message) {
+        return msg.message;
+    }
     else {
-        return msg.message ? msg.message : String(msg);
+        return String(msg);
     }
 }

package/lib/cjs/createPluginByDirectory.d.ts

@@ -1,2 +1,2 @@
 import type { Orchestrator, tLogger } from "node-pluginsmanager-plugin";
-export default function createPluginByDirectory(directory: string, externalRessourcesDirectory: string, logger: tLogger | null, ...data: any): Promise<Orchestrator>;
+export default function createPluginByDirectory(directory: string, externalResourcesDirectory: string, logger: tLogger | null, ...data: unknown[]): Promise<Orchestrator>;

package/lib/cjs/createPluginByDirectory.js

@@ -1,10 +1,14 @@
 "use strict";
-// deps
+/*
+    eslint-disable @typescript-eslint/no-var-requires
+*/
+// => @typescript-eslint/no-var-requires is disabled to allow plugin load
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = createPluginByDirectory;
+// deps
 // natives
 const node_path_1 = require("node:path");
 // locals
@@ -12,22 +16,22 @@ const checkAbsoluteDirectory_1 = __importDefault(require("./checkers/checkAbsolu
 const checkOrchestrator_1 = __importDefault(require("./checkers/checkOrchestrator"));
 const checkFunction_1 = __importDefault(require("./checkers/checkFunction"));
 // module
-function createPluginByDirectory(directory, externalRessourcesDirectory, logger, ...data) {
+function createPluginByDirectory(directory, externalResourcesDirectory, logger, ...data) {
     return (0, checkAbsoluteDirectory_1.default)("createPluginByDirectory/directory", directory).then(() => {
-        return (0, checkAbsoluteDirectory_1.default)("createPluginByDirectory/externalRessourcesDirectory", externalRessourcesDirectory);
+        return (0, checkAbsoluteDirectory_1.default)("createPluginByDirectory/externalResourcesDirectory", externalResourcesDirectory);
     }).then(() => {
         return new Promise((resolve, reject) => {
             try {
                 resolve(require(directory));
             }
             catch (e) {
-                reject(e);
+                reject(e instanceof Error ? e : new Error(String(e)));
             }
         }).then((Plugin) => {
-            if (Plugin.Orchestrator) {
+            if (["function", "object"].includes(typeof Plugin.Orchestrator)) {
                 return Promise.resolve(Plugin.Orchestrator);
             }
-            else if (Plugin.default) {
+            else if (["function", "object"].includes(typeof Plugin.default)) {
                 return Promise.resolve(Plugin.default);
             }
             else {
@@ -38,7 +42,7 @@ function createPluginByDirectory(directory, externalRessourcesDirectory, logger,
                 const pluginBaseNameDirectory = (0, node_path_1.basename)(directory);
                 const plugin = new Plugin({
                     // usefull for inherited Orchestrators
-                    "externalRessourcesDirectory": (0, node_path_1.join)(externalRessourcesDirectory, pluginBaseNameDirectory),
+                    "externalResourcesDirectory": (0, node_path_1.join)(externalResourcesDirectory, pluginBaseNameDirectory),
                     "logger": logger,
                     // useless, setted in inherited Orchestrators
                     "packageFile": "",

package/lib/cjs/extractGithub.d.ts

@@ -3,5 +3,5 @@ interface OrchestratorExtended extends Orchestrator {
     "github"?: string;
     "repository"?: string | Record<string, string>;
 }
-export default function extractGithub(plugin: OrchestratorExtended): string;
+export default function extractGithub(plugin: OrchestratorExtended): string | null;
 export {};

package/lib/cjs/extractGithub.js

@@ -4,7 +4,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = extractGithub;
 // module
 function extractGithub(plugin) {
-    let github = "";
+    let github = null;
     if ("object" === typeof plugin) {
         if ("string" === typeof plugin.github) {
             github = plugin.github;
@@ -16,5 +16,5 @@ function extractGithub(plugin) {
             github = plugin.repository.url;
         }
     }
-    return github;
+    return github ?? null;
 }

package/lib/cjs/initSortedPlugins.d.ts

@@ -1,2 +1,2 @@
 import type { Orchestrator } from "node-pluginsmanager-plugin";
-export default function initSortedPlugins(plugins: Orchestrator[], orderedPluginsNames: string[], emit: (eventName: string, ...subdata: any) => void, ...data: any): Promise<void>;
+export default function initSortedPlugins(plugins: Orchestrator[], orderedPluginsNames: string[], emit: (eventName: string, ...subdata: unknown[]) => void, ...data: unknown[]): Promise<void>;

package/lib/cjs/loadSortedPlugins.d.ts

@@ -1,2 +1,2 @@
 import type { Orchestrator, tLogger } from "node-pluginsmanager-plugin";
-export default function loadSortedPlugins(globalDirectory: string, externalRessourcesDirectory: string, files: string[], loadedPlugins: Orchestrator[], orderedPluginsNames: string[], emit: (eventName: string, ...subdata: any) => void, logger: tLogger | null, ...data: any): Promise<void>;
+export default function loadSortedPlugins(globalDirectory: string, externalResourcesDirectory: string, files: string[], loadedPlugins: Orchestrator[], orderedPluginsNames: string[], emit: (eventName: string, ...subdata: unknown[]) => void, logger: tLogger | null, ...data: unknown[]): Promise<void>;

package/lib/cjs/loadSortedPlugins.js

@@ -11,7 +11,7 @@ const node_path_1 = require("node:path");
 const createPluginByDirectory_1 = __importDefault(require("./createPluginByDirectory"));
 // private
 // methods
-function _loadPlugin(globalDirectory, externalRessourcesDirectory, pluginFileName, loadedPlugins, emit, logger, ...data) {
+function _loadPlugin(globalDirectory, externalResourcesDirectory, pluginFileName, loadedPlugins, emit, logger, ...data) {
     // is already loaded ?
     const plugin = loadedPlugins.find((p) => {
         return pluginFileName === p.name;
@@ -20,7 +20,7 @@ function _loadPlugin(globalDirectory, externalRessourcesDirectory, pluginFileNam
     return plugin ? Promise.resolve() : Promise.resolve().then(() => {
         emit("loading", pluginFileName, ...data);
         const directory = (0, node_path_1.join)(globalDirectory, pluginFileName);
-        return (0, createPluginByDirectory_1.default)(directory, externalRessourcesDirectory, logger, ...data);
+        return (0, createPluginByDirectory_1.default)(directory, externalResourcesDirectory, logger, ...data);
         // emit event
     }).then((createdPlugin) => {
         emit("loaded", createdPlugin, ...data);
@@ -28,16 +28,16 @@ function _loadPlugin(globalDirectory, externalRessourcesDirectory, pluginFileNam
         return Promise.resolve();
     });
 }
-function _loadPlugins(globalDirectory, externalRessourcesDirectory, pluginsToLoad, loadedPlugins, emit, logger, data, i = 0) {
+function _loadPlugins(globalDirectory, externalResourcesDirectory, pluginsToLoad, loadedPlugins, emit, logger, i, ...data) {
     return i < pluginsToLoad.length ? Promise.resolve().then(() => {
-        return _loadPlugin(globalDirectory, externalRessourcesDirectory, pluginsToLoad[i], loadedPlugins, emit, logger, ...data);
+        return _loadPlugin(globalDirectory, externalResourcesDirectory, pluginsToLoad[i], loadedPlugins, emit, logger, ...data);
         // loop
     }).then(() => {
-        return _loadPlugins(globalDirectory, externalRessourcesDirectory, pluginsToLoad, loadedPlugins, emit, logger, data, i + 1);
+        return _loadPlugins(globalDirectory, externalResourcesDirectory, pluginsToLoad, loadedPlugins, emit, logger, i + 1, ...data);
     }) : Promise.resolve();
 }
 // module
-function loadSortedPlugins(globalDirectory, externalRessourcesDirectory, files, loadedPlugins, orderedPluginsNames, emit, logger, ...data) {
+function loadSortedPlugins(globalDirectory, externalResourcesDirectory, files, loadedPlugins, orderedPluginsNames, emit, logger, ...data) {
     // if no files, does not run
     return !files.length ? Promise.resolve() : Promise.resolve().then(() => {
         const sortedPluginsNames = [];
@@ -45,13 +45,13 @@ function loadSortedPlugins(globalDirectory, externalRessourcesDirectory, files,
             const plugin = files.find((p) => {
                 return p === pluginName;
             });
-            if (plugin) {
+            if ("string" === typeof plugin) {
                 sortedPluginsNames.push(pluginName);
             }
         });
         // first, sorted plugins
         return sortedPluginsNames.length
-            ? _loadPlugins(globalDirectory, externalRessourcesDirectory, sortedPluginsNames, loadedPlugins, emit, logger, data)
+            ? _loadPlugins(globalDirectory, externalResourcesDirectory, sortedPluginsNames, loadedPlugins, emit, logger, 0, ...data)
             : Promise.resolve();
     }).then(() => {
         const unsortedPluginsNames = [
@@ -71,7 +71,7 @@ function loadSortedPlugins(globalDirectory, externalRessourcesDirectory, files,
         ];
         // then, all other plugins, asynchronously
         return unsortedPluginsNames.length
-            ? _loadPlugins(globalDirectory, externalRessourcesDirectory, unsortedPluginsNames, loadedPlugins, emit, logger, data)
+            ? _loadPlugins(globalDirectory, externalResourcesDirectory, unsortedPluginsNames, loadedPlugins, emit, logger, 0, ...data)
             : Promise.resolve();
     });
 }

package/package.json

@@ -1,89 +1,95 @@
-{
-
-  "name": "node-pluginsmanager",
-  "version": "2.5.1",
-  "description": "A plugins manager",
-
-  "type": "commonjs",
-  "typings": "./lib/cjs/main.d.cts",
-  "main": "./lib/cjs/main.cjs",
-
-  "exports": {
-    ".": {
-      "require": {
-        "types": "./lib/cjs/main.d.cts",
-        "default": "./lib/cjs/main.cjs"
-      }
-    }
-  },
-
-  "scripts": {
-
-    "prepare": "npx husky",
-
-    "clean": "npx rimraf ./lib/cjs",
-    "build": "npm run-script clean && npx tsc --project \"./tsconfig.json\"",
-
-    "lint": "npx eslint --config .eslintrc-src.js --ext .cts,.ts ./lib/src/**/* && npx eslint --config .eslintrc-tests.js ./bin/*.js ./test/**/*.js",
-    "check-requires": "npx used-deps-analyzer \"./package.json\" \"./lib/src\" --no-dev --overkill \"fs-extra\" \"node-promfs\"",
-    "check-updates": "npx check-version-modules",
-    "unit-tests": "npm run-script build && npx nyc --reporter=html --reporter=text mocha",
-
-    "tests": "npm run-script lint && npm run-script check-requires && npm run-script check-updates && npm run-script unit-tests"
-
-  },
-
-  "files": [
-    "/bin",
-    "/lib/cjs",
-    "/public"
-  ],
-  "engines": {
-    "node": ">=16.0.0"
-  },
-
-  "dependencies": {
-    "check-version-modules": "2.1.3"
-  },
-  "devDependencies": {
-    "@types/express": "5.0.3",
-    "@types/node": "24.3.0",
-    "@types/socket.io": "3.0.2",
-    "@types/ws": "8.18.1",
-    "eslint-plugin-personnallinter": "git+ssh://git@github.com/Psychopoulet/eslint-plugin-personnallinter",
-    "express": "5.1.0",
-    "husky": "9.1.7",
-    "mocha": "11.7.1",
-    "node-pluginsmanager-plugin": "6.4.5",
-    "nyc": "17.1.0",
-    "rimraf": "6.0.1",
-    "socket.io": "4.8.1",
-    "typescript": "5.9.2",
-    "used-deps-analyzer": "0.1.8",
-    "ws": "8.18.3"
-  },
-  "optionalDependencies": {},
-
-  "husky": {
-    "hooks": {
-      "pre-push": "npm run-script tests"
-    }
-  },
-  "keywords": [
-    "plugin",
-    "manage",
-    "gestion"
-  ],
-  "author": "Sébastien VIDAL",
-  "license": "ISC",
-
-  "homepage": "https://github.com/Psychopoulet/node-pluginsmanager#readme",
-  "repository": {
-    "type": "git",
-    "url": "git://github.com/Psychopoulet/node-pluginsmanager"
-  },
-  "bugs": {
-    "url": "https://github.com/Psychopoulet/node-pluginsmanager/issues"
-  }
-
-}
+{
+
+  "name": "node-pluginsmanager",
+  "version": "3.0.0",
+  "description": "A plugins manager.",
+
+  "type": "commonjs",
+  "typings": "./lib/cjs/main.d.cts",
+  "main": "./lib/cjs/main.cjs",
+
+  "exports": {
+    ".": {
+      "require": {
+        "types": "./lib/cjs/main.d.cts",
+        "default": "./lib/cjs/main.cjs"
+      }
+    }
+  },
+
+  "scripts": {
+
+    "prepare": "npx husky || true",
+
+    "lint-back": "npx eslint --config .eslintrc-back.js --ext .ts,.cts,.mts ./lib/src/**/*",
+    "lint-tests": "npx eslint --config .eslintrc-tests.js --ext .js,.cjs,.mjs ./test/**/*.js",
+    "lint": "npm run lint-back && npm run lint-tests",
+
+    "clean-back": "npx rimraf ./lib/cjs",
+    "clean": "npm run clean-back",
+
+    "build-back": "npm run clean-back && npx tsc --project ./tsconfig.json",
+    "build": "npm run build-back",
+
+    "check-requires": "npx used-deps-analyzer ./package.json ./lib/src --no-dev",
+    "check-updates": "npx check-version-modules",
+    "unit-tests": "npm run build && npx nyc --reporter=html --reporter=text mocha",
+
+    "tests": "npm run lint && npm run check-requires && npm run check-updates && npm run unit-tests"
+
+  },
+
+  "files": [
+    "/lib/cjs"
+  ],
+  "engines": {
+    "node": ">=22.22.0"
+  },
+
+  "dependencies": {
+    "check-version-modules": "2.2.2"
+  },
+  "devDependencies": {
+    "@types/express": "5.0.6",
+    "@types/node": "25.5.0",
+    "@types/socket.io": "3.0.2",
+    "@types/ws": "8.18.1",
+    "eslint-plugin-personnallinter": "git+ssh://git@github.com/Psychopoulet/eslint-plugin-personnallinter",
+    "express": "5.2.1",
+    "husky": "9.1.7",
+    "mocha": "11.7.5",
+    "node-pluginsmanager-plugin": "6.5.0",
+    "nyc": "18.0.0",
+    "proxyquire": "2.1.3",
+    "rimraf": "6.1.3",
+    "socket.io": "4.8.3",
+    "typescript": "5.9.3",
+    "used-deps-analyzer": "0.2.0",
+    "ws": "8.19.0"
+  },
+
+  "husky": {
+    "hooks": {
+      "pre-commit": "npm run lint",
+      "pre-push": "npm run unit-tests"
+    }
+  },
+
+  "keywords": [
+    "plugin",
+    "manage",
+    "gestion"
+  ],
+  "author": "Sébastien VIDAL",
+  "license": "ISC",
+
+  "homepage": "https://github.com/Psychopoulet/node-pluginsmanager#readme",
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/Psychopoulet/node-pluginsmanager.git"
+  },
+  "bugs": {
+    "url": "https://github.com/Psychopoulet/node-pluginsmanager/issues"
+  }
+
+}