node-opcua-server 2.77.0 → 2.79.0

package/source/opcua_server.ts

@@ -173,6 +173,7 @@ import { ISocketData } from "./i_socket_data";
 import { IChannelData } from "./i_channel_data";
 import { UAUserManagerBase, makeUserManager, UserManagerOptions } from "./user_manager";
 import { bindRoleSet } from "./user_manager_ua";
+import { SamplingFunc } from "./sampling_func";
 
 function isSubscriptionIdInvalid(subscriptionId: number): boolean {
     return subscriptionId < 0 || subscriptionId >= 0xffffffff;
@@ -403,7 +404,7 @@ function thumbprint(certificate?: Certificate): string {
  */
 function monitoredItem_read_and_record_value(
     self: MonitoredItem,
-    context: ISessionContext | null,
+    context: ISessionContext,
     oldValue: DataValue,
     node: UAVariable,
     itemToMonitor: any,
@@ -447,13 +448,7 @@ function monitoredItem_read_and_record_value_async(
     });
 }
 
-function build_scanning_node_function(
-    context: ISessionContext,
-    addressSpace: AddressSpace,
-    monitoredItem: MonitoredItem,
-    itemToMonitor: any
-): (dataValue: DataValue, callback: (err: Error | null, dataValue?: DataValue) => void) => void {
-    assert(context instanceof SessionContext);
+function build_scanning_node_function(addressSpace: AddressSpace, itemToMonitor: any): SamplingFunc {
     assert(itemToMonitor instanceof ReadValueId);
 
     const node = addressSpace.findNode(itemToMonitor.nodeId) as UAVariable;
@@ -462,7 +457,11 @@ function build_scanning_node_function(
     if (!node) {
         errorLog(" INVALID NODE ID  , ", itemToMonitor.nodeId.toString());
         dump(itemToMonitor);
-        return (oldData: DataValue, callback: (err: Error | null, dataValue?: DataValue) => void) => {
+        return (
+            _sessionContext: ISessionContext,
+            _oldData: DataValue,
+            callback: (err: Error | null, dataValue?: DataValue) => void
+        ) => {
             callback(
                 null,
                 new DataValue({
@@ -483,13 +482,14 @@ function build_scanning_node_function(
 
         return function func(
             this: MonitoredItem,
+            sessionContext: ISessionContext,
             oldDataValue: DataValue,
             callback: (err: Error | null, dataValue?: DataValue) => void
         ) {
             assert(this instanceof MonitoredItem);
             assert(oldDataValue instanceof DataValue);
             assert(typeof callback === "function");
-            monitoredItem_read_and_record_value_func(this, context, oldDataValue, node, itemToMonitor, callback);
+            monitoredItem_read_and_record_value_func(this, sessionContext, oldDataValue, node, itemToMonitor, callback);
         };
     } else {
         // Attributes, other than the  Value  Attribute, are only monitored for a change in value.
@@ -499,13 +499,14 @@ function build_scanning_node_function(
         // only record value when it has changed
         return function func(
             this: MonitoredItem,
+            sessionContext: ISessionContext,
             oldDataValue: DataValue,
             callback: (err: Error | null, dataValue?: DataValue) => void
         ) {
             assert(this instanceof MonitoredItem);
             assert(oldDataValue instanceof DataValue);
             assert(typeof callback === "function");
-            const newDataValue = node.readAttribute(null, itemToMonitor.attributeId);
+            const newDataValue = node.readAttribute(sessionContext, itemToMonitor.attributeId);
             callback(null, newDataValue);
         };
     }
@@ -513,7 +514,7 @@ function build_scanning_node_function(
 
 function prepareMonitoredItem(context: ISessionContext, addressSpace: AddressSpace, monitoredItem: MonitoredItem) {
     const itemToMonitor = monitoredItem.itemToMonitor;
-    const readNodeFunc = build_scanning_node_function(context, addressSpace, monitoredItem, itemToMonitor);
+    const readNodeFunc = build_scanning_node_function(addressSpace, itemToMonitor);
     monitoredItem.samplingFunc = readNodeFunc;
 }
 
@@ -1574,7 +1575,6 @@ export class OPCUAServer extends OPCUABaseServer {
                             comment: { dataType: DataType.String, value: certificateStatus.toString() }
                         });
                         break;
-                    
                 }
             }
             if (
@@ -1651,7 +1651,7 @@ export class OPCUAServer extends OPCUABaseServer {
             }
 
             const length = buff.readUInt32LE(0) - serverNonce.length;
-            password = buff.slice(4, 4 + length).toString("utf-8");
+            password = buff.subarray(4, 4 + length).toString("utf-8");
         }
 
         this.userManager
@@ -1833,7 +1833,8 @@ export class OPCUAServer extends OPCUABaseServer {
         // see Release 1.02  27  OPC Unified Architecture, Part 4
         const session = this.createSession({
             clientDescription: request.clientDescription,
-            sessionTimeout: revisedSessionTimeout
+            sessionTimeout: revisedSessionTimeout,
+            server: this
         });
         session.endpoint = endpoint;
 
@@ -2101,8 +2102,6 @@ export class OPCUAServer extends OPCUABaseServer {
                     return rejectConnection(this, StatusCodes.BadIdentityChangeNotSupported); // not sure about this code !
                 }
             }
-
-            moveSessionToChannel(session, channel);
         } else if (session.status === "screwed") {
             // session has been used before being activated => this should be detected and session should be dismissed.
             return rejectConnection(this, StatusCodes.BadSessionClosed);
@@ -2134,7 +2133,6 @@ export class OPCUAServer extends OPCUABaseServer {
                     }
                     return rejectConnection(this, statusCode);
                 }
-                session.userIdentityToken = request.userIdentityToken as UserIdentityToken;
 
                 // check if user access is granted
                 this.isUserAuthorized(
@@ -2150,6 +2148,11 @@ export class OPCUAServer extends OPCUABaseServer {
                         if (!authorized) {
                             return rejectConnection(this, StatusCodes.BadUserAccessDenied);
                         } else {
+                            if (session.status === "active") {
+                                moveSessionToChannel(session, channel);
+                            }
+                            session.userIdentityToken = request.userIdentityToken as UserIdentityToken;
+
                             // extract : OPC UA part 4 - 5.6.3
                             // Once used, a serverNonce cannot be used again. For that reason, the Server returns a new
                             // serverNonce each time the ActivateSession Service is called.
@@ -2160,13 +2163,6 @@ export class OPCUAServer extends OPCUABaseServer {
                             response = new ActivateSessionResponse({ serverNonce: session.nonce });
                             channel.send_response("MSG", response, message);
 
-                            const userIdentityTokenPasswordRemoved = (userIdentityToken: any) => {
-                                const a = userIdentityToken.clone();
-                                // remove password
-                                a.password = "*************";
-                                return a;
-                            };
-
                             // send OPCUA Event Notification
                             // see part 5 : 6.4.3 AuditEventType
                             //              6.4.7 AuditSessionEventType
@@ -2175,49 +2171,11 @@ export class OPCUAServer extends OPCUABaseServer {
                             // xx assert(session.channel.clientCertificate instanceof Buffer);
                             assert(session.sessionTimeout > 0);
 
-                            if (this.isAuditing) {
-                                this.raiseEvent("AuditActivateSessionEventType", {
-                                    /* part 5 -  6.4.3 AuditEventType */
-                                    actionTimeStamp: { dataType: "DateTime", value: new Date() },
-                                    status: { dataType: "Boolean", value: true },
-
-                                    serverId: { dataType: "String", value: "" },
-
-                                    // ClientAuditEntryId contains the human-readable AuditEntryId defined in Part 3.
-                                    clientAuditEntryId: { dataType: "String", value: "" },
-
-                                    // The ClientUserId identifies the user of the client requesting an action.
-                                    // The ClientUserId can be obtained from the UserIdentityToken passed in the
-                                    // ActivateSession call.
-                                    clientUserId: { dataType: "String", value: "cc" },
-
-                                    sourceName: { dataType: "String", value: "Session/ActivateSession" },
-
-                                    /* part 5 - 6.4.7 AuditSessionEventType */
-                                    sessionId: { dataType: "NodeId", value: session.nodeId },
-
-                                    /* part 5 - 6.4.10 AuditActivateSessionEventType */
-                                    clientSoftwareCertificates: {
-                                        arrayType: VariantArrayType.Array,
-                                        dataType: "ExtensionObject" /* SignedSoftwareCertificate */,
-                                        value: []
-                                    },
-                                    // UserIdentityToken reflects the userIdentityToken parameter of the ActivateSession
-                                    // Service call.
-                                    // For Username/Password tokens the password should NOT be included.
-                                    userIdentityToken: {
-                                        dataType: "ExtensionObject" /*  UserIdentityToken */,
-                                        value: userIdentityTokenPasswordRemoved(session.userIdentityToken)
-                                    },
-
-                                    // SecureChannelId shall uniquely identify the SecureChannel. The application shall
-                                    // use the same identifier in all AuditEvents related to the Session Service Set
-                                    // (AuditCreateSessionEventType, AuditActivateSessionEventType and their subtypes) and
-                                    // the SecureChannel Service Set (AuditChannelEventType and its subtypes).
-                                    secureChannelId: { dataType: "String", value: session.channel!.channelId!.toString() }
-                                });
-                            }
-                            this.emit("session_activated", session, userIdentityTokenPasswordRemoved);
+                            raiseAuditActivateSessionEventType.call(this, session);
+
+                            this.emit("session_activated", session, userIdentityTokenPasswordRemoved(session.userIdentityToken));
+
+                            session.resendMonitoredItemInitialValues();
                         }
                     }
                 );
@@ -2574,7 +2532,7 @@ export class OPCUAServer extends OPCUABaseServer {
                 const requestedMaxReferencesPerNode = Math.min(9876, request.requestedMaxReferencesPerNode);
                 assert(request.nodesToBrowse[0].schema.name === "BrowseDescription");
 
-                const context = new SessionContext({ session, server: this });
+                const context = session.sessionContext;
 
                 const f = callbackify(this.engine.browseWithAutomaticExpansion).bind(this.engine);
                 (f as any)(request.nodesToBrowse, context, (err?: Error | null, results?: BrowseResult[]) => {
@@ -2676,7 +2634,7 @@ export class OPCUAServer extends OPCUABaseServer {
             message,
             channel,
             (session: ServerSession, sendResponse: (response: Response) => void, sendError: (statusCode: StatusCode) => void) => {
-                const context = new SessionContext({ session, server: this });
+                const context = session.sessionContext;
 
                 let response;
 
@@ -2778,7 +2736,7 @@ export class OPCUAServer extends OPCUABaseServer {
                     }
                 }
 
-                const context = new SessionContext({ session, server: this });
+                const context = session.sessionContext;
 
                 // ask for a refresh of asynchronous variables
                 this.engine.refreshValues(request.nodesToRead, 0, (err?: Error | null) => {
@@ -2849,7 +2807,7 @@ export class OPCUAServer extends OPCUABaseServer {
                     nodeToWrite.nodeId = session.resolveRegisteredNode(nodeToWrite.nodeId);
                 }
 
-                const context = new SessionContext({ session, server: this });
+                const context = session.sessionContext;
 
                 assert(request.nodesToWrite[0].schema.name === "WriteValue");
                 this.engine.write(context, request.nodesToWrite, (err: Error | null, results?: StatusCode[]) => {
@@ -2882,7 +2840,7 @@ export class OPCUAServer extends OPCUABaseServer {
             message,
             channel,
             (session: ServerSession, sendResponse: (response: Response) => void, sendError: (statusCode: StatusCode) => void) => {
-                const context = new SessionContext({ session, server: this });
+                const context = session.sessionContext;
 
                 if (session.currentSubscriptionCount >= this.engine.serverCapabilities.maxSubscriptionsPerSession) {
                     return sendError(StatusCodes.BadTooManySubscriptions);
@@ -3417,7 +3375,7 @@ export class OPCUAServer extends OPCUABaseServer {
                 /* jshint validthis: true */
                 const addressSpace = this.engine.addressSpace!;
 
-                const context = new SessionContext({ session, server: this });
+                const context = session.sessionContext;
 
                 async.map(
                     request.methodsToCall,
@@ -3623,6 +3581,58 @@ export class OPCUAServer extends OPCUABaseServer {
     }
 }
 
+const userIdentityTokenPasswordRemoved = (userIdentityToken: any) => {
+    const a = userIdentityToken.clone();
+    // remove password
+    a.password = "*************";
+    return a;
+};
+
+function raiseAuditActivateSessionEventType(this: OPCUAServer, session: ServerSession) {
+    if (this.isAuditing) {
+        this.raiseEvent("AuditActivateSessionEventType", {
+            /* part 5 -  6.4.3 AuditEventType */
+            actionTimeStamp: { dataType: "DateTime", value: new Date() },
+            status: { dataType: "Boolean", value: true },
+
+            serverId: { dataType: "String", value: "" },
+
+            // ClientAuditEntryId contains the human-readable AuditEntryId defined in Part 3.
+            clientAuditEntryId: { dataType: "String", value: "" },
+
+            // The ClientUserId identifies the user of the client requesting an action.
+            // The ClientUserId can be obtained from the UserIdentityToken passed in the
+            // ActivateSession call.
+            clientUserId: { dataType: "String", value: "cc" },
+
+            sourceName: { dataType: "String", value: "Session/ActivateSession" },
+
+            /* part 5 - 6.4.7 AuditSessionEventType */
+            sessionId: { dataType: "NodeId", value: session.nodeId },
+
+            /* part 5 - 6.4.10 AuditActivateSessionEventType */
+            clientSoftwareCertificates: {
+                arrayType: VariantArrayType.Array,
+                dataType: "ExtensionObject" /* SignedSoftwareCertificate */,
+                value: []
+            },
+            // UserIdentityToken reflects the userIdentityToken parameter of the ActivateSession
+            // Service call.
+            // For Username/Password tokens the password should NOT be included.
+            userIdentityToken: {
+                dataType: "ExtensionObject" /*  UserIdentityToken */,
+                value: userIdentityTokenPasswordRemoved(session.userIdentityToken)
+            },
+
+            // SecureChannelId shall uniquely identify the SecureChannel. The application shall
+            // use the same identifier in all AuditEvents related to the Session Service Set
+            // (AuditCreateSessionEventType, AuditActivateSessionEventType and their subtypes) and
+            // the SecureChannel Service Set (AuditChannelEventType and its subtypes).
+            secureChannelId: { dataType: "String", value: session.channel!.channelId!.toString() }
+        });
+    }
+}
+
 export interface RaiseEventAuditEventData extends RaiseEventData {
     actionTimeStamp: PseudoVariantDateTime;
     status: PseudoVariantBoolean;

package/source/sampling_func.ts

@@ -0,0 +1,8 @@
+import { ISessionContext } from "node-opcua-address-space-base";
+import { DataValue } from "node-opcua-data-value";
+
+export type SamplingFunc = (
+    context: ISessionContext,
+    dataValue: DataValue,
+    callback: (err: Error | null, dataValue?: DataValue) => void
+) => void;

package/source/server_engine.ts

@@ -5,7 +5,7 @@ import { EventEmitter } from "events";
 import * as async from "async";
 import * as chalk from "chalk";
 import { assert } from "node-opcua-assert";
-import { BinaryStream} from "node-opcua-binary-stream";
+import { BinaryStream } from "node-opcua-binary-stream";
 import {
     addElement,
     AddressSpace,
@@ -29,6 +29,7 @@ import {
     DTServerStatus,
     resolveOpaqueOnAddressSpace,
     ContinuationData,
+    IServerBase,
     UARole
 } from "node-opcua-address-space";
 import { generateAddressSpace } from "node-opcua-address-space/nodeJS";
@@ -81,7 +82,8 @@ import {
     ReadValueId,
     TimeZoneDataType,
     ProgramDiagnosticDataType,
-    CallMethodResultOptions
+    CallMethodResultOptions,
+    AggregateConfiguration
 } from "node-opcua-types";
 import { DataType, isValidVariant, Variant, VariantArrayType } from "node-opcua-variant";
 
@@ -94,6 +96,7 @@ import { ServerSession } from "./server_session";
 import { Subscription } from "./server_subscription";
 import { sessionsCompatibleForTransfer } from "./sessions_compatible_for_transfer";
 import { OPCUAServerOptions } from "./opcua_server";
+import { IUserManager } from "node-opcua-address-space/source";
 
 const debugLog = make_debugLog(__filename);
 const errorLog = make_errorLog(__filename);
@@ -266,6 +269,44 @@ function _get_next_subscriptionId() {
     return next_subscriptionId++;
 }
 
+function checkReadProcessedDetails(historyReadDetails: ReadProcessedDetails): StatusCode {
+    if (!historyReadDetails.aggregateConfiguration) {
+        historyReadDetails.aggregateConfiguration = new AggregateConfiguration({
+            useServerCapabilitiesDefaults: true
+        });
+    }
+    if (historyReadDetails.aggregateConfiguration.useServerCapabilitiesDefaults) {
+        return StatusCodes.Good;
+    }
+
+    // The PercentDataGood and PercentDataBad shall follow the following relationship
+    //          PercentDataGood ≥ (100 – PercentDataBad).
+    // If they are equal the result of the PercentDataGood calculation is used.
+    // If the values entered for PercentDataGood and PercentDataBad do not result in a valid calculation
+    //  (e.g. Bad = 80; Good = 0) the result will have a StatusCode of Bad_AggregateInvalidInputs.
+    if (
+        historyReadDetails.aggregateConfiguration.percentDataGood <
+        100 - historyReadDetails.aggregateConfiguration.percentDataBad
+    ) {
+        return StatusCodes.BadAggregateInvalidInputs;
+    }
+    // The StatusCode Bad_AggregateInvalidInputs will be returned if the value of PercentDataGood
+    // or PercentDataBad exceed 100.
+    if (
+        historyReadDetails.aggregateConfiguration.percentDataGood > 100 ||
+        historyReadDetails.aggregateConfiguration.percentDataGood < 0
+    ) {
+        return StatusCodes.BadAggregateInvalidInputs;
+    }
+    if (
+        historyReadDetails.aggregateConfiguration.percentDataBad > 100 ||
+        historyReadDetails.aggregateConfiguration.percentDataBad < 0
+    ) {
+        return StatusCodes.BadAggregateInvalidInputs;
+    }
+    return StatusCodes.Good;
+}
+
 export type StringGetter = () => string;
 
 export interface ServerEngineOptions {
@@ -284,6 +325,7 @@ export interface ServerEngineOptions {
 export interface CreateSessionOption {
     clientDescription?: ApplicationDescription;
     sessionTimeout?: number;
+    server: IServerBase;
 }
 
 export type ClosingReason = "Timeout" | "Terminated" | "CloseSession" | "Forcing";
@@ -400,7 +442,7 @@ export class ServerEngine extends EventEmitter {
                 counter += session.currentSubscriptionCount;
             });
             // we also need to add the orphan subscriptions
-            counter += this._orphanPublishEngine ? this._orphanPublishEngine .subscriptions.length : 0;
+            counter += this._orphanPublishEngine ? this._orphanPublishEngine.subscriptions.length : 0;
             return counter;
         });
 
@@ -1556,6 +1598,12 @@ export class ServerEngine extends EventEmitter {
             if (!historyReadDetails.aggregateType || historyReadDetails.aggregateType.length !== nodesToRead.length) {
                 return callback(null, [new HistoryReadResult({ statusCode: StatusCodes.BadInvalidArgument })]);
             }
+
+            // chkec parameters
+            const parameterStatus = checkReadProcessedDetails(historyReadDetails);
+            if (parameterStatus !== StatusCodes.Good) {
+                return callback(null, [new HistoryReadResult({ statusCode: parameterStatus })]);
+            }
             const promises: Promise<HistoryReadResult>[] = [];
             let index = 0;
             for (const nodeToRead of nodesToRead) {
@@ -1632,7 +1680,7 @@ export class ServerEngine extends EventEmitter {
      */
     public createSession(options: CreateSessionOption): ServerSession {
         options = options || {};
-
+        options.server = options.server || {};
         debugLog("createSession : increasing serverDiagnosticsSummary cumulatedSessionCount/currentSessionCount ");
         this.serverDiagnosticsSummary.cumulatedSessionCount += 1;
         this.serverDiagnosticsSummary.currentSessionCount += 1;
@@ -1642,7 +1690,7 @@ export class ServerEngine extends EventEmitter {
         const sessionTimeout = options.sessionTimeout || 1000;
         assert(typeof sessionTimeout === "number");
 
-        const session = new ServerSession(this, sessionTimeout);
+        const session = new ServerSession(this, options.server.userManager!, sessionTimeout);
 
         debugLog("createSession :sessionTimeout = ", session.sessionTimeout);
 
@@ -1851,7 +1899,7 @@ export class ServerEngine extends EventEmitter {
         if (subscription.$session) {
             subscription.$session._unexposeSubscriptionDiagnostics(subscription);
         }
-        
+
         await ServerSidePublishEngine.transferSubscription(subscription, session.publishEngine, sendInitialValues);
         subscription.$session = session;
 
@@ -1987,14 +2035,18 @@ export class ServerEngine extends EventEmitter {
     }
 
     private _exposeSubscriptionDiagnostics(subscription: Subscription): void {
-        debugLog("ServerEngine#_exposeSubscriptionDiagnostics", subscription.subscriptionId);
-        const subscriptionDiagnosticsArray = this._getServerSubscriptionDiagnosticsArrayNode();
-        const subscriptionDiagnostics = subscription.subscriptionDiagnostics;
-        assert((subscriptionDiagnostics as any).$subscription === subscription);
-        assert(subscriptionDiagnostics instanceof SubscriptionDiagnosticsDataType);
-
-        if (subscriptionDiagnostics && subscriptionDiagnosticsArray) {
-            addElement(subscriptionDiagnostics, subscriptionDiagnosticsArray);
+        try {
+            debugLog("ServerEngine#_exposeSubscriptionDiagnostics", subscription.subscriptionId);
+            const subscriptionDiagnosticsArray = this._getServerSubscriptionDiagnosticsArrayNode();
+            const subscriptionDiagnostics = subscription.subscriptionDiagnostics;
+            assert((subscriptionDiagnostics as any).$subscription === subscription);
+            assert(subscriptionDiagnostics instanceof SubscriptionDiagnosticsDataType);
+
+            if (subscriptionDiagnostics && subscriptionDiagnosticsArray) {
+                addElement(subscriptionDiagnostics, subscriptionDiagnosticsArray);
+            }
+        } catch (err) {
+            console.log("err", err);
         }
     }
 

package/source/server_session.ts

@@ -6,6 +6,7 @@
 import * as crypto from "crypto";
 import { EventEmitter } from "events";
 
+import { assert } from "node-opcua-assert";
 import {
     addElement,
     AddressSpace,
@@ -19,10 +20,11 @@ import {
     UASessionDiagnosticsVariable,
     UASessionSecurityDiagnostics,
     DTSessionDiagnostics,
-    DTSessionSecurityDiagnostics
+    DTSessionSecurityDiagnostics,
+    SessionContext,
+    IUserManager
 } from "node-opcua-address-space";
-
-import { assert } from "node-opcua-assert";
+import { ISessionContext } from "node-opcua-address-space-base";
 import { minOPCUADate, randomGuid } from "node-opcua-basic-types";
 import { SessionDiagnosticsDataType, SessionSecurityDiagnosticsDataType, SubscriptionDiagnosticsDataType } from "node-opcua-common";
 import { QualifiedName, NodeClass } from "node-opcua-data-model";
@@ -119,6 +121,7 @@ export class ServerSession extends EventEmitter implements ISubscriber, ISession
     public clientDescription?: ApplicationDescription;
     public channelId?: number | null;
     public continuationPointManager: ContinuationPointManager;
+    public sessionContext: ISessionContext;
 
     // ISubscriber
     public _watchDog?: WatchDog;
@@ -134,13 +137,18 @@ export class ServerSession extends EventEmitter implements ISubscriber, ISession
 
     private channel_abort_event_handler: any;
 
-    constructor(parent: ServerEngine, sessionTimeout: number) {
+    constructor(parent: ServerEngine, userManager: IUserManager, sessionTimeout: number) {
         super();
 
         this.parent = parent; // SessionEngine
 
         ServerSession.registry.register(this);
 
+        this.sessionContext = new SessionContext({
+            session: this,
+            server: { userManager }
+        });
+
         assert(isFinite(sessionTimeout));
         assert(sessionTimeout >= 0, " sessionTimeout");
         this.sessionTimeout = sessionTimeout;
@@ -846,6 +854,12 @@ export class ServerSession extends EventEmitter implements ISubscriber, ISession
         return this.sessionObject;
     }
 
+    public async resendMonitoredItemInitialValues(): Promise<void> {
+        for (const subscription of this.publishEngine.subscriptions) {
+            await subscription.resendInitialValues();
+        }
+    }
+
     /**
      *
      * @private

package/source/server_subscription.ts

@@ -783,7 +783,7 @@ export class Subscription extends EventEmitter {
         }
         assert(this.monitoredItemCount === 0);
 
-        if (this.$session) {
+        if (this.$session && this.$session._unexposeSubscriptionDiagnostics) {
             this.$session._unexposeSubscriptionDiagnostics(this);
         }
         this.state = SubscriptionState.CLOSED;

package/source/user_manager.ts

@@ -1,8 +1,11 @@
 import { IUserManager, UARoleSet } from "node-opcua-address-space";
 import { NodeId } from "node-opcua-nodeid";
 import { IdentityMappingRuleType } from "node-opcua-types";
+import { make_errorLog } from "node-opcua-debug";
 import { ServerSession } from "./server_session";
 
+const errorLog = make_errorLog(__filename);
+
 export type ValidUserFunc = (this: ServerSession, username: string, password: string) => boolean;
 export type ValidUserAsyncFunc = (
     this: ServerSession,
@@ -45,7 +48,18 @@ export class UAUserManager1 extends UAUserManagerBase {
         super();
     }
     getUserRoles(user: string): NodeId[] {
-        return this.options.getUserRoles != null ? this.options.getUserRoles(user) : [];
+        if (!this.options.getUserRoles) return [];
+        try {
+            return this.options.getUserRoles(user);
+        } catch (err) {
+            if (err instanceof Error) {
+                errorLog(
+                    "[NODE-OPCUA-E27] userManager provided getUserRoles method has thrown an exception, please fix your code! "
+                );
+                errorLog(err.message, "\n", (err as Error).stack?.split("\n").slice(0,2).join("\n"));
+            }
+            return [];
+        }
     }
 
     async isValidUser(session: ServerSession, username: string, password: string): Promise<boolean> {
@@ -56,9 +70,19 @@ export class UAUserManager1 extends UAUserManagerBase {
                     resolve(isAuthorized!);
                 });
             });
-        } else if(typeof this.options.isValidUser === "function") {
-            const authorized = this.options.isValidUser!.call(session, username, password);
-            return authorized;
+        } else if (typeof this.options.isValidUser === "function") {
+            try {
+                const authorized = this.options.isValidUser!.call(session, username, password);
+                return authorized;
+            } catch (err) {
+                if (err instanceof Error) {
+                    errorLog(
+                        "[NODE-OPCUA-E26] userManager provided isValidUser method has thrown an exception, please fix your code!"
+                    );
+                    errorLog(err.message, "\n", (err as Error).stack?.split("\n").slice(0,2).join("\n"));
+                }
+                return false;
+            }
         } else {
             return false;
         }