node-opcua-server 2.72.2 → 2.74.0

package/dist/sessions_compatible_for_transfer.d.ts

@@ -1,2 +1,2 @@
 import { ServerSession } from "./server_session";
-export declare function sessionsCompatibleForTransfer(sessionSrc: ServerSession, sessionDest: ServerSession): boolean;
+export declare function sessionsCompatibleForTransfer(sessionSrc: ServerSession | undefined, sessionDest: ServerSession): boolean;

package/dist/sessions_compatible_for_transfer.js

@@ -4,6 +4,9 @@ exports.sessionsCompatibleForTransfer = void 0;
 const node_opcua_assert_1 = require("node-opcua-assert");
 const node_opcua_types_1 = require("node-opcua-types");
 function sessionsCompatibleForTransfer(sessionSrc, sessionDest) {
+    if (!sessionSrc) {
+        return true;
+    }
     (0, node_opcua_assert_1.assert)(sessionDest);
     (0, node_opcua_assert_1.assert)(sessionSrc);
     if (!sessionSrc.userIdentityToken && !sessionDest.userIdentityToken) {

package/dist/sessions_compatible_for_transfer.js.map

@@ -1 +1 @@
-{"version":3,"file":"sessions_compatible_for_transfer.js","sourceRoot":"","sources":["../source/sessions_compatible_for_transfer.ts"],"names":[],"mappings":";;;AAAA,yDAA2C;AAC3C,uDAAuH;AAGvH,SAAgB,6BAA6B,CAAC,UAAyB,EAAE,WAA0B;IAC/F,IAAA,0BAAM,EAAC,WAAW,CAAC,CAAC;IACpB,IAAA,0BAAM,EAAC,UAAU,CAAC,CAAC;IACnB,IAAI,CAAC,UAAU,CAAC,iBAAiB,IAAI,CAAC,WAAW,CAAC,iBAAiB,EAAE;QACjE,OAAO,IAAI,CAAC;KACf;IACD,IAAI,UAAU,CAAC,iBAAiB,YAAY,yCAAsB,EAAE;QAChE,IAAI,CAAC,CAAC,WAAW,CAAC,iBAAiB,YAAY,yCAAsB,CAAC,EAAE;YACpE,OAAO,KAAK,CAAC;SAChB;QACD,OAAO,IAAI,CAAC;KACf;SAAM,IAAI,UAAU,CAAC,iBAAiB,YAAY,wCAAqB,EAAE;QACtE,IAAI,CAAC,CAAC,WAAW,CAAC,iBAAiB,YAAY,wCAAqB,CAAC,EAAE;YACnE,OAAO,KAAK,CAAC;SAChB;QACD,OAAO,UAAU,CAAC,iBAAiB,CAAC,QAAQ,KAAK,WAAW,CAAC,iBAAiB,CAAC,QAAQ,CAAC;KAC3F;IACD,uBAAuB;SAClB,IAAI,UAAU,CAAC,iBAAiB,YAAY,oCAAiB,EAAE;QAChE,IAAI,CAAC,CAAC,WAAW,CAAC,iBAAiB,YAAY,oCAAiB,CAAC,EAAE;YAC/D,OAAO,KAAK,CAAC;SAChB;QACD,OAAO,CACH,UAAU,CAAC,iBAAiB,CAAC,eAAe,CAAC,QAAQ,CAAC,KAAK,CAAC;YAC5D,WAAW,CAAC,iBAAiB,CAAC,eAAe,CAAC,QAAQ,CAAC,KAAK,CAAC,CAChE,CAAC;KACL;SAAM;QACH,MAAM,IAAI,KAAK,CAAC,4BAA4B,CAAC,CAAC;KACjD;AACL,CAAC;AA7BD,sEA6BC"}
+{"version":3,"file":"sessions_compatible_for_transfer.js","sourceRoot":"","sources":["../source/sessions_compatible_for_transfer.ts"],"names":[],"mappings":";;;AAAA,yDAA2C;AAC3C,uDAAuH;AAGvH,SAAgB,6BAA6B,CAAC,UAAqC,EAAE,WAA0B;IAE3G,IAAI,CAAC,UAAU,EAAE;QACb,OAAO,IAAI,CAAC;KACf;IACD,IAAA,0BAAM,EAAC,WAAW,CAAC,CAAC;IACpB,IAAA,0BAAM,EAAC,UAAU,CAAC,CAAC;IACnB,IAAI,CAAC,UAAU,CAAC,iBAAiB,IAAI,CAAC,WAAW,CAAC,iBAAiB,EAAE;QACjE,OAAO,IAAI,CAAC;KACf;IACD,IAAI,UAAU,CAAC,iBAAiB,YAAY,yCAAsB,EAAE;QAChE,IAAI,CAAC,CAAC,WAAW,CAAC,iBAAiB,YAAY,yCAAsB,CAAC,EAAE;YACpE,OAAO,KAAK,CAAC;SAChB;QACD,OAAO,IAAI,CAAC;KACf;SAAM,IAAI,UAAU,CAAC,iBAAiB,YAAY,wCAAqB,EAAE;QACtE,IAAI,CAAC,CAAC,WAAW,CAAC,iBAAiB,YAAY,wCAAqB,CAAC,EAAE;YACnE,OAAO,KAAK,CAAC;SAChB;QACD,OAAO,UAAU,CAAC,iBAAiB,CAAC,QAAQ,KAAK,WAAW,CAAC,iBAAiB,CAAC,QAAQ,CAAC;KAC3F;IACD,uBAAuB;SAClB,IAAI,UAAU,CAAC,iBAAiB,YAAY,oCAAiB,EAAE;QAChE,IAAI,CAAC,CAAC,WAAW,CAAC,iBAAiB,YAAY,oCAAiB,CAAC,EAAE;YAC/D,OAAO,KAAK,CAAC;SAChB;QACD,OAAO,CACH,UAAU,CAAC,iBAAiB,CAAC,eAAe,CAAC,QAAQ,CAAC,KAAK,CAAC;YAC5D,WAAW,CAAC,iBAAiB,CAAC,eAAe,CAAC,QAAQ,CAAC,KAAK,CAAC,CAChE,CAAC;KACL;SAAM;QACH,MAAM,IAAI,KAAK,CAAC,4BAA4B,CAAC,CAAC;KACjD;AACL,CAAC;AAjCD,sEAiCC"}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "node-opcua-server",
-    "version": "2.72.2",
+    "version": "2.74.0",
     "description": "pure nodejs OPCUA SDK - module -server",
     "scripts": {
         "build": "tsc -b",
@@ -17,55 +17,56 @@
         "async": "^3.2.4",
         "dequeue": "^1.0.5",
         "lodash": "4.17.21",
-        "node-opcua-address-space": "2.72.2",
-        "node-opcua-assert": "2.66.0",
-        "node-opcua-basic-types": "2.72.1",
-        "node-opcua-certificate-manager": "2.72.1",
-        "node-opcua-client": "2.72.2",
-        "node-opcua-client-dynamic-extension-object": "2.72.2",
-        "node-opcua-common": "2.72.2",
-        "node-opcua-constants": "2.70.0",
+        "node-opcua-address-space": "2.74.0",
+        "node-opcua-assert": "2.74.0",
+        "node-opcua-basic-types": "2.74.0",
+        "node-opcua-binary-stream": "2.74.0",
+        "node-opcua-certificate-manager": "2.74.0",
+        "node-opcua-client": "2.74.0",
+        "node-opcua-client-dynamic-extension-object": "2.74.0",
+        "node-opcua-common": "2.74.0",
+        "node-opcua-constants": "2.74.0",
         "node-opcua-crypto": "^1.11.0",
-        "node-opcua-data-access": "2.72.2",
-        "node-opcua-data-model": "2.72.1",
-        "node-opcua-data-value": "2.72.2",
-        "node-opcua-date-time": "2.71.0",
-        "node-opcua-debug": "2.71.0",
-        "node-opcua-enum": "2.71.0",
-        "node-opcua-extension-object": "2.72.1",
-        "node-opcua-factory": "2.72.1",
-        "node-opcua-hostname": "2.67.0",
-        "node-opcua-nodeid": "2.71.0",
-        "node-opcua-nodeset-ua": "2.72.2",
-        "node-opcua-nodesets": "2.71.0",
-        "node-opcua-numeric-range": "2.72.2",
-        "node-opcua-object-registry": "2.71.0",
+        "node-opcua-data-access": "2.74.0",
+        "node-opcua-data-model": "2.74.0",
+        "node-opcua-data-value": "2.74.0",
+        "node-opcua-date-time": "2.74.0",
+        "node-opcua-debug": "2.74.0",
+        "node-opcua-enum": "2.74.0",
+        "node-opcua-extension-object": "2.74.0",
+        "node-opcua-factory": "2.74.0",
+        "node-opcua-hostname": "2.74.0",
+        "node-opcua-nodeid": "2.74.0",
+        "node-opcua-nodeset-ua": "2.74.0",
+        "node-opcua-nodesets": "2.74.0",
+        "node-opcua-numeric-range": "2.74.0",
+        "node-opcua-object-registry": "2.74.0",
         "node-opcua-pki": "^2.17.0",
-        "node-opcua-secure-channel": "2.72.2",
-        "node-opcua-service-browse": "2.72.2",
-        "node-opcua-service-call": "2.72.2",
-        "node-opcua-service-discovery": "2.72.2",
-        "node-opcua-service-endpoints": "2.72.2",
-        "node-opcua-service-filter": "2.72.2",
-        "node-opcua-service-history": "2.72.2",
-        "node-opcua-service-node-management": "2.72.2",
-        "node-opcua-service-query": "2.72.2",
-        "node-opcua-service-read": "2.72.2",
-        "node-opcua-service-register-node": "2.72.2",
-        "node-opcua-service-secure-channel": "2.72.2",
-        "node-opcua-service-session": "2.72.2",
-        "node-opcua-service-subscription": "2.72.2",
-        "node-opcua-service-translate-browse-path": "2.72.2",
-        "node-opcua-service-write": "2.72.2",
-        "node-opcua-status-code": "2.71.0",
-        "node-opcua-transport": "2.72.2",
-        "node-opcua-types": "2.72.2",
-        "node-opcua-utils": "2.71.0",
-        "node-opcua-variant": "2.72.2"
+        "node-opcua-secure-channel": "2.74.0",
+        "node-opcua-service-browse": "2.74.0",
+        "node-opcua-service-call": "2.74.0",
+        "node-opcua-service-discovery": "2.74.0",
+        "node-opcua-service-endpoints": "2.74.0",
+        "node-opcua-service-filter": "2.74.0",
+        "node-opcua-service-history": "2.74.0",
+        "node-opcua-service-node-management": "2.74.0",
+        "node-opcua-service-query": "2.74.0",
+        "node-opcua-service-read": "2.74.0",
+        "node-opcua-service-register-node": "2.74.0",
+        "node-opcua-service-secure-channel": "2.74.0",
+        "node-opcua-service-session": "2.74.0",
+        "node-opcua-service-subscription": "2.74.0",
+        "node-opcua-service-translate-browse-path": "2.74.0",
+        "node-opcua-service-write": "2.74.0",
+        "node-opcua-status-code": "2.74.0",
+        "node-opcua-transport": "2.74.0",
+        "node-opcua-types": "2.74.0",
+        "node-opcua-utils": "2.74.0",
+        "node-opcua-variant": "2.74.0"
     },
     "devDependencies": {
-        "node-opcua-leak-detector": "2.71.0",
-        "node-opcua-test-helpers": "2.66.0",
+        "node-opcua-leak-detector": "2.74.0",
+        "node-opcua-test-helpers": "2.74.0",
         "should": "^13.2.3",
         "sinon": "^14.0.0"
     },
@@ -84,5 +85,5 @@
         "internet of things"
     ],
     "homepage": "http://node-opcua.github.io/",
-    "gitHead": "07dcdd8e8c7f2b55544c6e23023093e35674829c"
+    "gitHead": "003ee041795f3b737afaaef5721045ee31ea9f77"
 }

package/source/helper.ts

@@ -0,0 +1,87 @@
+import * as util from "util";
+import { OPCUAServer } from "./opcua_server";
+import { ServerEngine } from "./server_engine";
+import { ServerSession } from "./server_session";
+import { Subscription, SubscriptionState } from "./server_subscription";
+
+const consolelog = (...args: any) => {
+    const d = new Date();
+    const t = d.toTimeString().split(" ")[0] + "." + d.getMilliseconds().toString().padStart(3, "0");
+    console.log.apply(console, [t, ...args]);
+};
+const doDebug = false;
+
+/**
+ *
+ * @private
+ */
+export function installSessionLogging(server: OPCUAServer) {
+    installSessionLoggingOnEngine(server.engine);
+}
+
+const info = (subscription: Subscription) => {
+    return util.format(
+        subscription.subscriptionId,
+        SubscriptionState[subscription.state].padEnd(9),
+        subscription.state,
+        "kac=",
+        subscription.currentKeepAliveCount.toString().padStart(3)+
+        "/"+
+        subscription.maxKeepAliveCount.toString().padStart(3),
+        "ltc=",
+        subscription.currentLifetimeCount.toString().padStart(3)+
+        "/"+
+        subscription.lifeTimeCount.toString().padStart(3),
+        "prc=",
+        subscription.publishEngine?.pendingPublishRequestCount.toString().padStart(3),
+        "pi=",
+        subscription.publishingInterval
+    );
+};
+
+export function installSubscriptionMonitoring(subscription: Subscription) {
+    consolelog("new_subscription", subscription.subscriptionId, info(subscription));
+    subscription.on("lifeTimeExpired", () => {
+        consolelog("lifeTimeExpired".padEnd(45), info(subscription));
+    });
+    if (true || doDebug) {
+        subscription.on("lifeTimeCounterChanged", (ltc: number) => {
+            consolelog("subscription lifeTimeCounterChanged".padEnd(45), info(subscription));
+        });
+    }
+    subscription.on("expired", () => {
+        consolelog("subscription expired".padEnd(45), info(subscription));
+    });
+    subscription.on("stateChanged", (state: SubscriptionState) => {
+        consolelog("subscription stateChanged".padEnd(45), info(subscription));
+    });
+    subscription.on("terminate", () => {
+        consolelog("subscription terminated".padEnd(45), info(subscription));
+    });
+    subscription.on("keepalive", () => {
+        consolelog("subscription keepalive".padEnd(45), info(subscription));
+    });
+}
+export function installSessionLoggingOnEngine(serverEngine: ServerEngine) {
+    function on_create_session(session: ServerSession) {
+        try {
+            session.on("activate_session", function () {
+                consolelog("activate_session");
+            });
+
+            session.on("statusChanged", (status) => {
+                consolelog("session status changed: ", status);
+            });
+            session.on("new_subscription", function (subscription) {
+                installSubscriptionMonitoring(subscription);
+            });
+        } catch (err) {
+            consolelog((err as any).message);
+        }
+    }
+    serverEngine.on("create_session", on_create_session);
+    serverEngine.once("session_closed", function (session) {
+        consolelog("session is closed");
+        serverEngine.removeListener("create_session", on_create_session);
+    });
+}

package/source/index.ts

@@ -12,4 +12,5 @@ export * from "./server_capabilities";
 export * from "./server_engine";
 export * from "./opcua_server";
 export * from "./monitored_item";
-export * from "./user_manager";
+export * from "./user_manager";
+export * from "./helper";

package/source/monitored_item.ts

@@ -25,7 +25,7 @@ import {
     coerceTimestampsToReturn,
     sameStatusCode
 } from "node-opcua-data-value";
-import { checkDebugFlag, make_debugLog } from "node-opcua-debug";
+import { checkDebugFlag, make_debugLog, make_warningLog } from "node-opcua-debug";
 import { ExtensionObject } from "node-opcua-extension-object";
 import { NodeId } from "node-opcua-nodeid";
 import { NumericalRange0, NumericRange } from "node-opcua-numeric-range";
@@ -71,6 +71,7 @@ const defaultItemToMonitor: ReadValueIdOptions = new ReadValueId({
 
 const debugLog = make_debugLog(__filename);
 const doDebug = checkDebugFlag(__filename);
+const warningLog = make_warningLog(__filename);
 
 function _adjust_sampling_interval(samplingInterval: number, node_minimumSamplingInterval: number): number {
     assert(typeof node_minimumSamplingInterval === "number", "expecting a number");
@@ -216,7 +217,7 @@ function apply_dataChange_filter(this: MonitoredItem, newDataValue: DataValue, o
                 debugLog("timestampHasChanged ", timestampHasChanged(newDataValue.sourceTimestamp, oldDataValue.sourceTimestamp));
             }
         } catch (err) {
-            console.log(err);
+            warningLog(err);
         }
     }
     switch (trigger) {

package/source/opcua_server.ts

@@ -145,7 +145,8 @@ import {
     BuildInfoOptions,
     MonitoredItemCreateResult,
     IssuedIdentityToken,
-    BrowseResultOptions
+    BrowseResultOptions,
+    ServiceFault
 } from "node-opcua-types";
 import { DataType } from "node-opcua-variant";
 import { VariantArrayType } from "node-opcua-variant";
@@ -184,7 +185,7 @@ const warningLog = make_warningLog(__filename);
 const default_maxConnectionsPerEndpoint = 10;
 
 function g_sendError(channel: ServerSecureChannelLayer, message: Message, ResponseClass: any, statusCode: StatusCode): void {
-    const response = new ResponseClass({
+    const response = new ServiceFault({
         responseHeader: { serviceResult: statusCode }
     });
     return channel.send_response("MSG", response, message);
@@ -203,6 +204,7 @@ const default_build_info: BuildInfoOptions = {
 const minSessionTimeout = 100; // 100 milliseconds
 const defaultSessionTimeout = 1000 * 30; // 30 seconds
 const maxSessionTimeout = 1000 * 60 * 50; // 50 minutes
+let unnamed_session_count = 0;
 
 type ResponseClassType =
     | typeof BrowseResponse
@@ -252,7 +254,7 @@ function moveSessionToChannel(session: ServerSession, channel: ServerSecureChann
 }
 
 async function _attempt_to_close_some_old_unactivated_session(server: OPCUAServer) {
-    const session = server.engine!.getOldestUnactivatedSession();
+    const session = server.engine!.getOldestInactiveSession();
     if (session) {
         await server.engine!.closeSession(session.authenticationToken, false, "Forcing");
     }
@@ -1786,7 +1788,7 @@ export class OPCUAServer extends OPCUABaseServer {
         assert(session.sessionTimeout === revisedSessionTimeout);
 
         session.clientDescription = request.clientDescription;
-        session.sessionName = request.sessionName || "<unknown session name>";
+        session.sessionName = request.sessionName || `<unknown session name ${unnamed_session_count++}>`;
 
         // Depending upon on the  SecurityPolicy  and the  SecurityMode  of the  SecureChannel,  the exchange of
         // ApplicationInstanceCertificates   and  Nonces  may be optional and the signatures may be empty. See
@@ -2232,13 +2234,14 @@ export class OPCUAServer extends OPCUABaseServer {
 
         function sendResponse(response1: Response) {
             try {
-                assert(response1 instanceof ResponseClass);
+                assert(response1 instanceof ResponseClass || response1 instanceof ServiceFault);
                 if (message.session) {
                     const counterName = ResponseClass.name.replace("Response", "");
                     message.session.incrementRequestTotalCounter(counterName);
                 }
                 return channel.send_response("MSG", response1, message);
             } catch (err) {
+                warningLog(err);
                 // istanbul ignore next
                 if (err instanceof Error) {
                     // istanbul ignore next
@@ -3069,7 +3072,7 @@ export class OPCUAServer extends OPCUABaseServer {
             (session: ServerSession, sendResponse: (response: Response) => void, sendError: (statusCode: StatusCode) => void) => {
                 assert(session);
                 assert(session.publishEngine); // server.publishEngine doesn't exists, OPCUAServer has probably shut down already
-                session.publishEngine._on_PublishRequest(request, (request1: PublishRequest, response: PublishResponse) => {
+                session.publishEngine._on_PublishRequest(request, (_request1, response) => {
                     sendResponse(response);
                 });
             }
@@ -3136,7 +3139,7 @@ export class OPCUAServer extends OPCUABaseServer {
 
                     sendResponse(response);
                 } catch (err) {
-                    console.log(err);
+                    warningLog(err);
                     return sendError(StatusCodes.BadInternalError);
                 }
             }
@@ -3178,16 +3181,20 @@ export class OPCUAServer extends OPCUABaseServer {
                     linksToAdd,
                     linksToRemove
                 );
-                const response = new SetTriggeringResponse({
-                    responseHeader: { serviceResult: statusCode },
-
-                    addResults,
-                    removeResults,
-                    addDiagnosticInfos: null,
-                    removeDiagnosticInfos: null
-                });
+                if (statusCode !== StatusCodes.Good) {
+                    const response = new ServiceFault({ responseHeader: { serviceResult: statusCode } });
+                    sendResponse(response);
+                } else {
+                    const response = new SetTriggeringResponse({
+                        responseHeader: { serviceResult: statusCode },
 
-                sendResponse(response);
+                        addResults,
+                        removeResults,
+                        addDiagnosticInfos: null,
+                        removeDiagnosticInfos: null
+                    });
+                    sendResponse(response);
+                }
             }
         );
     }
@@ -3388,11 +3395,8 @@ export class OPCUAServer extends OPCUABaseServer {
             message,
             channel,
             (session: ServerSession, sendResponse: (response: Response) => void, sendError: (statusCode: StatusCode) => void) => {
-                let response;
-
                 if (!request.nodesToRegister || request.nodesToRegister.length === 0) {
-                    response = new RegisterNodesResponse({ responseHeader: { serviceResult: StatusCodes.BadNothingToDo } });
-                    return sendResponse(response);
+                    return sendError(StatusCodes.BadNothingToDo);
                 }
                 if (this.engine.serverCapabilities.operationLimits.maxNodesPerRegisterNodes > 0) {
                     if (request.nodesToRegister.length > this.engine.serverCapabilities.operationLimits.maxNodesPerRegisterNodes) {
@@ -3408,7 +3412,7 @@ export class OPCUAServer extends OPCUABaseServer {
                 // NodeId from the request.
                 const registeredNodeIds = request.nodesToRegister.map((nodeId) => session.registerNode(nodeId));
 
-                response = new RegisterNodesResponse({
+                const response = new RegisterNodesResponse({
                     registeredNodeIds
                 });
                 sendResponse(response);
@@ -3425,13 +3429,10 @@ export class OPCUAServer extends OPCUABaseServer {
             message,
             channel,
             (session: ServerSession, sendResponse: (response: Response) => void, sendError: (statusCode: StatusCode) => void) => {
-                let response;
-
                 request.nodesToUnregister = request.nodesToUnregister || [];
 
                 if (!request.nodesToUnregister || request.nodesToUnregister.length === 0) {
-                    response = new UnregisterNodesResponse({ responseHeader: { serviceResult: StatusCodes.BadNothingToDo } });
-                    return sendResponse(response);
+                    return sendError(StatusCodes.BadNothingToDo);
                 }
 
                 if (this.engine.serverCapabilities.operationLimits.maxNodesPerRegisterNodes > 0) {
@@ -3444,7 +3445,7 @@ export class OPCUAServer extends OPCUABaseServer {
 
                 request.nodesToUnregister.map((nodeId: NodeId) => session.unRegisterNode(nodeId));
 
-                response = new UnregisterNodesResponse({});
+                const response = new UnregisterNodesResponse({});
                 sendResponse(response);
             }
         );

package/source/server_capabilities.ts

@@ -154,9 +154,9 @@ export type ServerCapabilitiesOptions = Partial<IServerCapabilities>;
 export const defaultServerCapabilities: IServerCapabilities = {
     maxBrowseContinuationPoints: 0,
     maxHistoryContinuationPoints: 0,
-    maxStringLength: 65535,
-    maxArrayLength: 65535,
-    maxByteStringLength: 65535,
+    maxStringLength: 16 * 1024 * 1024,
+    maxArrayLength: 1024 * 1024,
+    maxByteStringLength: 16 * 1024 * 1024,
     maxQueryContinuationPoints: 0,
 
     minSupportedSampleRate: 100,
@@ -245,7 +245,8 @@ export class ServerCapabilities implements IServerCapabilities {
         // new in 1.05
         this.maxSessions = options.maxSessions || defaultServerCapabilities.maxSessions;
 
-        this.maxSubscriptionsPerSession = options.maxSubscriptionsPerSession || defaultServerCapabilities.maxSubscriptionsPerSession;
+        this.maxSubscriptionsPerSession =
+            options.maxSubscriptionsPerSession || defaultServerCapabilities.maxSubscriptionsPerSession;
         this.maxSubscriptions = options.maxSubscriptions || defaultServerCapabilities.maxSubscriptions;
         this.maxMonitoredItems = options.maxMonitoredItems || defaultServerCapabilities.maxMonitoredItems;
         this.maxMonitoredItemsPerSubscription =

package/source/server_engine.ts

@@ -5,7 +5,7 @@ import { EventEmitter } from "events";
 import * as async from "async";
 import * as chalk from "chalk";
 import { assert } from "node-opcua-assert";
-
+import { BinaryStream} from "node-opcua-binary-stream";
 import {
     addElement,
     AddressSpace,
@@ -399,6 +399,8 @@ export class ServerEngine extends EventEmitter {
             Object.values(this._sessions).forEach((session: ServerSession) => {
                 counter += session.currentSubscriptionCount;
             });
+            // we also need to add the orphan subscriptions
+            counter += this._orphanPublishEngine ? this._orphanPublishEngine .subscriptions.length : 0;
             return counter;
         });
 
@@ -1007,15 +1009,15 @@ export class ServerEngine extends EventEmitter {
                 );
 
                 bindStandardScalar(VariableIds.Server_ServerCapabilities_MaxArrayLength, DataType.UInt32, () => {
-                    return this.serverCapabilities.maxArrayLength;
+                    return Math.min(this.serverCapabilities.maxArrayLength, Variant.maxArrayLength);
                 });
 
                 bindStandardScalar(VariableIds.Server_ServerCapabilities_MaxStringLength, DataType.UInt32, () => {
-                    return this.serverCapabilities.maxStringLength;
+                    return Math.min(this.serverCapabilities.maxStringLength, BinaryStream.maxStringLength);
                 });
 
                 bindStandardScalar(VariableIds.Server_ServerCapabilities_MaxByteStringLength, DataType.UInt32, () => {
-                    return this.serverCapabilities.maxByteStringLength;
+                    return Math.min(this.serverCapabilities.maxByteStringLength, BinaryStream.maxByteStringLength);
                 });
 
                 const bindOperationLimits = (operationLimits: OperationLimits) => {
@@ -1598,13 +1600,17 @@ export class ServerEngine extends EventEmitter {
         });
     }
 
-    public getOldestUnactivatedSession(): ServerSession | null {
-        const tmp = Object.values(this._sessions).filter((session1: ServerSession) => {
-            return session1.status === "new";
-        });
+    public getOldestInactiveSession(): ServerSession | null {
+        // search screwed or closed session first
+        let tmp = Object.values(this._sessions).filter(
+            (session1: ServerSession) =>
+                session1.status === "screwed" || session1.status === "disposed" || session1.status === "closed"
+        );
         if (tmp.length === 0) {
-            return null;
+            // if none available, tap into the session that are not yet activated
+            tmp = Object.values(this._sessions).filter((session1: ServerSession) => session1.status === "new");
         }
+        if (tmp.length === 0) return null;
         let session = tmp[0];
         for (let i = 1; i < tmp.length; i++) {
             const c = tmp[i];
@@ -1812,10 +1818,6 @@ export class ServerEngine extends EventEmitter {
         if (!subscription) {
             return new TransferResult({ statusCode: StatusCodes.BadSubscriptionIdInvalid });
         }
-        // istanbul ignore next
-        if (!subscription.$session) {
-            return new TransferResult({ statusCode: StatusCodes.BadInternalError });
-        }
 
         // check that session have same userIdentity
         if (!sessionsCompatibleForTransfer(subscription.$session, session)) {
@@ -1846,9 +1848,11 @@ export class ServerEngine extends EventEmitter {
 
         const nbSubscriptionBefore = session.publishEngine.subscriptionCount;
 
-        subscription.$session._unexposeSubscriptionDiagnostics(subscription);
+        if (subscription.$session) {
+            subscription.$session._unexposeSubscriptionDiagnostics(subscription);
+        }
+        
         await ServerSidePublishEngine.transferSubscription(subscription, session.publishEngine, sendInitialValues);
-
         subscription.$session = session;
 
         session._exposeSubscriptionDiagnostics(subscription);
@@ -1983,7 +1987,7 @@ export class ServerEngine extends EventEmitter {
     }
 
     private _exposeSubscriptionDiagnostics(subscription: Subscription): void {
-        debugLog("ServerEngine#_exposeSubscriptionDiagnostics");
+        debugLog("ServerEngine#_exposeSubscriptionDiagnostics", subscription.subscriptionId);
         const subscriptionDiagnosticsArray = this._getServerSubscriptionDiagnosticsArrayNode();
         const subscriptionDiagnostics = subscription.subscriptionDiagnostics;
         assert((subscriptionDiagnostics as any).$subscription === subscription);
@@ -1995,19 +1999,19 @@ export class ServerEngine extends EventEmitter {
     }
 
     protected _unexposeSubscriptionDiagnostics(subscription: Subscription): void {
-        const subscriptionDiagnosticsArray = this._getServerSubscriptionDiagnosticsArrayNode();
+        const serverSubscriptionDiagnosticsArray = this._getServerSubscriptionDiagnosticsArrayNode();
         const subscriptionDiagnostics = subscription.subscriptionDiagnostics;
         assert(subscriptionDiagnostics instanceof SubscriptionDiagnosticsDataType);
-        if (subscriptionDiagnostics && subscriptionDiagnosticsArray) {
-            const node = (subscriptionDiagnosticsArray as any)[subscription.id];
-            removeElement(subscriptionDiagnosticsArray, subscriptionDiagnostics);
+        if (subscriptionDiagnostics && serverSubscriptionDiagnosticsArray) {
+            const node = (serverSubscriptionDiagnosticsArray as any)[subscription.id];
+            removeElement(serverSubscriptionDiagnosticsArray, subscriptionDiagnostics);
             /*assert(
                 !(subscriptionDiagnosticsArray as any)[subscription.id],
                 " subscription node must have been removed from subscriptionDiagnosticsArray"
             );
             */
         }
-        debugLog("ServerEngine#_unexposeSubscriptionDiagnostics");
+        debugLog("ServerEngine#_unexposeSubscriptionDiagnostics", subscription.subscriptionId);
     }
 
     /**
@@ -2200,16 +2204,14 @@ export class ServerEngine extends EventEmitter {
     private _getServerSubscriptionDiagnosticsArrayNode(): UADynamicVariableArray<SubscriptionDiagnosticsDataType> | null {
         // istanbul ignore next
         if (!this.addressSpace) {
-            if (doDebug) {
-                console.warn("ServerEngine#_getServerSubscriptionDiagnosticsArray : no addressSpace");
-            }
+            doDebug && debugLog("ServerEngine#_getServerSubscriptionDiagnosticsArray : no addressSpace");
+
             return null; // no addressSpace
         }
         const subscriptionDiagnosticsType = this.addressSpace.findVariableType("SubscriptionDiagnosticsType");
         if (!subscriptionDiagnosticsType) {
-            if (doDebug) {
-                console.warn("ServerEngine#_getServerSubscriptionDiagnosticsArray " + ": cannot find SubscriptionDiagnosticsType");
-            }
+            doDebug &&
+                debugLog("ServerEngine#_getServerSubscriptionDiagnosticsArray " + ": cannot find SubscriptionDiagnosticsType");
         }
 
         // SubscriptionDiagnosticsArray = i=2290