node-opcua-server 2.164.2 → 2.165.0

package/dist/server_engine.js

@@ -8,28 +8,29 @@ exports.setNextSubscriptionId = setNextSubscriptionId;
 /**
  * @module node-opcua-server
  */
-const events_1 = require("events");
-const util_1 = require("util");
+const node_events_1 = require("node:events");
+const node_util_1 = require("node:util");
 const async_1 = __importDefault(require("async"));
 const chalk_1 = __importDefault(require("chalk"));
-const node_opcua_assert_1 = require("node-opcua-assert");
-const node_opcua_binary_stream_1 = require("node-opcua-binary-stream");
 const node_opcua_address_space_1 = require("node-opcua-address-space");
 const nodeJS_1 = require("node-opcua-address-space/nodeJS");
+const node_opcua_assert_1 = require("node-opcua-assert");
+const node_opcua_binary_stream_1 = require("node-opcua-binary-stream");
 const node_opcua_common_1 = require("node-opcua-common");
-const node_opcua_data_model_1 = require("node-opcua-data-model");
-const node_opcua_nodeid_1 = require("node-opcua-nodeid");
 const node_opcua_constants_1 = require("node-opcua-constants");
+const node_opcua_data_model_1 = require("node-opcua-data-model");
 const node_opcua_date_time_1 = require("node-opcua-date-time");
 const node_opcua_debug_1 = require("node-opcua-debug");
+const node_opcua_nodeid_1 = require("node-opcua-nodeid");
 const node_opcua_nodesets_1 = require("node-opcua-nodesets");
 const node_opcua_object_registry_1 = require("node-opcua-object-registry");
 const node_opcua_service_call_1 = require("node-opcua-service-call");
-const node_opcua_service_subscription_1 = require("node-opcua-service-subscription");
 const node_opcua_service_endpoints_1 = require("node-opcua-service-endpoints");
+const node_opcua_service_subscription_1 = require("node-opcua-service-subscription");
 const node_opcua_status_code_1 = require("node-opcua-status-code");
 const node_opcua_types_1 = require("node-opcua-types");
 const node_opcua_variant_1 = require("node-opcua-variant");
+const addressSpace_accessor_1 = require("./addressSpace_accessor");
 const history_server_capabilities_1 = require("./history_server_capabilities");
 const monitored_item_1 = require("./monitored_item");
 const server_capabilities_1 = require("./server_capabilities");
@@ -38,7 +39,6 @@ const server_publish_engine_for_orphan_subscriptions_1 = require("./server_publi
 const server_session_1 = require("./server_session");
 const server_subscription_1 = require("./server_subscription");
 const sessions_compatible_for_transfer_1 = require("./sessions_compatible_for_transfer");
-const addressSpace_accessor_1 = require("./addressSpace_accessor");
 const debugLog = (0, node_opcua_debug_1.make_debugLog)(__filename);
 const errorLog = (0, node_opcua_debug_1.make_errorLog)(__filename);
 const warningLog = (0, node_opcua_debug_1.make_warningLog)(__filename);
@@ -50,7 +50,7 @@ async function shutdownAndDisposeAddressSpace() {
     if (this.addressSpace) {
         await this.addressSpace.shutdown();
         this.addressSpace.dispose();
-        delete this.addressSpace;
+        this.addressSpace = null;
     }
 }
 function setSubscriptionDurable(inputArguments, context, callback) {
@@ -143,8 +143,10 @@ function _getSubscription(inputArguments, context) {
 function resendData(inputArguments, context, callback) {
     (0, node_opcua_assert_1.assert)(typeof callback === "function");
     const data = _getSubscription.call(this, inputArguments, context);
-    if (data.statusCode)
-        return callback(null, { statusCode: data.statusCode });
+    if (data.statusCode) {
+        callback(null, { statusCode: data.statusCode });
+        return;
+    }
     const { subscription } = data;
     subscription
         .resendInitialValues()
@@ -174,8 +176,11 @@ function getMonitoredItemsId(inputArguments, context, callback) {
 }
 function __bindVariable(self, nodeId, options) {
     options = options || {};
+    if (!self.addressSpace) {
+        return;
+    }
     const variable = self.addressSpace.findNode(nodeId);
-    if (variable && variable.bindVariable) {
+    if (variable?.bindVariable) {
         variable.bindVariable(options, true);
         (0, node_opcua_assert_1.assert)(typeof variable.asyncRefresh === "function");
         (0, node_opcua_assert_1.assert)(typeof variable.refreshFunc === "function");
@@ -201,7 +206,7 @@ function _get_next_subscriptionId() {
 /**
  *
  */
-class ServerEngine extends events_1.EventEmitter {
+class ServerEngine extends node_events_1.EventEmitter {
     static registry = new node_opcua_object_registry_1.ObjectRegistry();
     isAuditing;
     serverDiagnosticsSummary;
@@ -257,7 +262,7 @@ class ServerEngine extends events_1.EventEmitter {
             "http://opcfoundation.org/UA-Profile/Server/StandardEventSubscription",
             "http://opcfoundation.org/UA-Profile/Transport/uatcp-uasc-uabinary",
             "http://opcfoundation.org/UA-Profile/Server/FileAccess",
-            "http://opcfoundation.org/UA-Profile/Server/StateMachine",
+            "http://opcfoundation.org/UA-Profile/Server/StateMachine"
             // "http://opcfoundation.org/UA-Profile/Transport/wss-uajson",
             // "http://opcfoundation.org/UA-Profile/Transport/wss-uasc-uabinary"
             // "http://opcfoundation.org/UA-Profile/Server/DurableSubscription"
@@ -276,8 +281,9 @@ class ServerEngine extends events_1.EventEmitter {
         // new SignedSoftwareCertificate({})
         ];
         // make sure minSupportedSampleRate matches MonitoredItem.minimumSamplingInterval
-        this.serverCapabilities.__defineGetter__("minSupportedSampleRate", () => {
-            return options.serverCapabilities?.minSupportedSampleRate || monitored_item_1.MonitoredItem.minimumSamplingInterval;
+        Object.defineProperty(this.serverCapabilities, "minSupportedSampleRate", {
+            get: () => options.serverCapabilities?.minSupportedSampleRate || monitored_item_1.MonitoredItem.minimumSamplingInterval,
+            configurable: true
         });
         this.serverConfiguration = options.serverConfiguration;
         this.historyServerCapabilities = new history_server_capabilities_1.HistoryServerCapabilities(options.historyServerCapabilities);
@@ -287,16 +293,19 @@ class ServerEngine extends events_1.EventEmitter {
         // note spelling is different for serverDiagnosticsSummary.currentSubscriptionCount
         //      and sessionDiagnostics.currentSubscriptionsCount ( with an s)
         (0, node_opcua_assert_1.assert)(Object.prototype.hasOwnProperty.call(this.serverDiagnosticsSummary, "currentSubscriptionCount"));
-        this.serverDiagnosticsSummary.__defineGetter__("currentSubscriptionCount", () => {
-            // currentSubscriptionCount returns the total number of subscriptions
-            // that are currently active on all sessions
-            let counter = 0;
-            Object.values(this._sessions).forEach((session) => {
-                counter += session.currentSubscriptionCount;
-            });
-            // we also need to add the orphan subscriptions
-            counter += this._orphanPublishEngine ? this._orphanPublishEngine.subscriptions.length : 0;
-            return counter;
+        Object.defineProperty(this.serverDiagnosticsSummary, "currentSubscriptionCount", {
+            get: () => {
+                // currentSubscriptionCount returns the total number of subscriptions
+                // that are currently active on all sessions
+                let counter = 0;
+                Object.values(this._sessions).forEach((session) => {
+                    counter += session.currentSubscriptionCount;
+                });
+                // we also need to add the orphan subscriptions
+                counter += this._orphanPublishEngine ? this._orphanPublishEngine.subscriptions.length : 0;
+                return counter;
+            },
+            configurable: true
         });
         this._internalState = "creating";
         this.setServerState(node_opcua_common_1.ServerState.NoConfiguration);
@@ -304,7 +313,10 @@ class ServerEngine extends events_1.EventEmitter {
         this._shutdownTasks = [];
         this._applicationUri = "";
         if (typeof options.applicationUri === "function") {
-            this.__defineGetter__("_applicationUri", options.applicationUri);
+            Object.defineProperty(this, "_applicationUri", {
+                get: options.applicationUri,
+                configurable: true
+            });
         }
         else {
             this._applicationUri = options.applicationUri || "<unset _applicationUri>";
@@ -312,7 +324,7 @@ class ServerEngine extends events_1.EventEmitter {
         options.serverDiagnosticsEnabled = Object.prototype.hasOwnProperty.call(options, "serverDiagnosticsEnable")
             ? options.serverDiagnosticsEnabled
             : true;
-        this.serverDiagnosticsEnabled = options.serverDiagnosticsEnabled;
+        this.serverDiagnosticsEnabled = options.serverDiagnosticsEnabled || false;
     }
     isStarted() {
         return !!this._serverStatus;
@@ -336,10 +348,10 @@ class ServerEngine extends events_1.EventEmitter {
         ServerEngine.registry.unregister(this);
     }
     get startTime() {
-        return this._serverStatus.startTime;
+        return this._serverStatus.startTime || new Date();
     }
     get currentTime() {
-        return this._serverStatus.currentTime;
+        return this._serverStatus.currentTime || new Date();
     }
     get buildInfo() {
         return this._serverStatus.buildInfo;
@@ -469,9 +481,12 @@ class ServerEngine extends events_1.EventEmitter {
         this._expectedShutdownTime = date;
     }
     setShutdownReason(reason) {
+        const localizedReason = (0, node_opcua_data_model_1.coerceLocalizedText)(reason);
+        if (!localizedReason)
+            return;
         this.addressSpace?.rootFolder.objects.server.serverStatus.shutdownReason.setValueFromSource({
             dataType: node_opcua_variant_1.DataType.LocalizedText,
-            value: (0, node_opcua_data_model_1.coerceLocalizedText)(reason)
+            value: localizedReason
         });
     }
     /**
@@ -490,7 +505,7 @@ class ServerEngine extends events_1.EventEmitter {
      * the name of the server
      */
     get serverName() {
-        return this._serverStatus.buildInfo.productName;
+        return this._serverStatus.buildInfo?.productName || "";
     }
     /**
      * the server urn
@@ -514,7 +529,69 @@ class ServerEngine extends events_1.EventEmitter {
             value: serverState
         });
     }
+    getServerState() {
+        return this._serverStatus.state;
+    }
+    /**
+     * Set the `ServerConfiguration.InApplicationSetup` property
+     * in the address space.
+     *
+     * This flag indicates whether the server is currently in
+     * its initial application setup phase (e.g. waiting for
+     * GDS provisioning).
+     */
+    setInApplicationSetup(value) {
+        const addressSpace = this.addressSpace;
+        if (!addressSpace) {
+            return;
+        }
+        const serverConfiguration = addressSpace.rootFolder?.objects?.server?.getChildByName("ServerConfiguration");
+        if (!serverConfiguration) {
+            return;
+        }
+        let prop = serverConfiguration.getPropertyByName("InApplicationSetup");
+        if (!prop) {
+            // InApplicationSetup is ModellingRule_Optional on
+            // ServerConfigurationType (i=19308) — instantiate
+            // it on the instance on first use.
+            const ns = addressSpace.getOwnNamespace();
+            prop = ns.addVariable({
+                browseName: { name: "InApplicationSetup", namespaceIndex: 0 },
+                propertyOf: serverConfiguration,
+                typeDefinition: "PropertyType",
+                dataType: node_opcua_variant_1.DataType.Boolean,
+                minimumSamplingInterval: -1,
+                value: { dataType: node_opcua_variant_1.DataType.Boolean, value }
+            });
+            return;
+        }
+        prop.setValueFromSource({
+            dataType: node_opcua_variant_1.DataType.Boolean,
+            value
+        });
+    }
+    /**
+     * Read the current value of
+     * `ServerConfiguration.InApplicationSetup`.
+     *
+     * Returns `false` if the property does not exist in
+     * the address space.
+     */
+    getInApplicationSetup() {
+        const serverConfiguration = this.addressSpace?.rootFolder?.objects?.server?.getChildByName("ServerConfiguration");
+        if (!serverConfiguration) {
+            return false;
+        }
+        const prop = serverConfiguration.getPropertyByName("InApplicationSetup");
+        if (!prop) {
+            return false;
+        }
+        return prop.readValue().value.value ?? false;
+    }
     getServerDiagnosticsEnabledFlag() {
+        if (!this.addressSpace) {
+            return false;
+        }
         const server = this.addressSpace.rootFolder.objects.server;
         const serverDiagnostics = server.getComponentByName("ServerDiagnostics");
         if (!serverDiagnostics) {
@@ -623,7 +700,7 @@ class ServerEngine extends events_1.EventEmitter {
                 /* c8 ignore next */
                 if (!(0, node_opcua_variant_1.isValidVariant)(node_opcua_variant_1.VariantArrayType.Scalar, dataType, func())) {
                     errorLog("func", func());
-                    throw new Error("bindStandardScalar : func doesn't provide an value of type " + node_opcua_variant_1.DataType[dataType]);
+                    throw new Error(`bindStandardScalar : func doesn't provide an value of type ${node_opcua_variant_1.DataType[dataType]}`);
                 }
                 return bindVariableIfPresent(nodeId, {
                     get() {
@@ -636,7 +713,7 @@ class ServerEngine extends events_1.EventEmitter {
                     set: setter_func2
                 });
             };
-            const bindStandardArray = (id, variantDataType, dataType, func) => {
+            const bindStandardArray = (id, variantDataType, _dataType, func) => {
                 (0, node_opcua_assert_1.assert)(typeof func === "function");
                 (0, node_opcua_assert_1.assert)(variantDataType !== null); // check invalid dataType
                 const nodeId = (0, node_opcua_nodeid_1.makeNodeId)(id);
@@ -658,7 +735,7 @@ class ServerEngine extends events_1.EventEmitter {
             };
             bindStandardScalar(node_opcua_constants_1.VariableIds.Server_EstimatedReturnTime, node_opcua_variant_1.DataType.DateTime, () => (0, node_opcua_date_time_1.getMinOPCUADate)());
             // TimeZoneDataType
-            const timeZoneDataType = addressSpace.findDataType((0, node_opcua_nodeid_1.resolveNodeId)(node_opcua_constants_1.DataTypeIds.TimeZoneDataType));
+            addressSpace.findDataType((0, node_opcua_nodeid_1.resolveNodeId)(node_opcua_constants_1.DataTypeIds.TimeZoneDataType));
             const timeZone = new node_opcua_types_1.TimeZoneDataType({
                 daylightSavingInOffset: /* boolean*/ false,
                 offset: /* int16 */ 0
@@ -802,7 +879,7 @@ class ServerEngine extends events_1.EventEmitter {
                     (0, node_opcua_assert_1.assert)(operationLimits !== null && typeof operationLimits === "object");
                     const keys = Object.keys(operationLimits);
                     keys.forEach((key) => {
-                        const uid = "Server_ServerCapabilities_OperationLimits_" + upperCaseFirst(key);
+                        const uid = `Server_ServerCapabilities_OperationLimits_${upperCaseFirst(key)}`;
                         const nodeId = (0, node_opcua_nodeid_1.makeNodeId)(node_opcua_constants_1.VariableIds[uid]);
                         (0, node_opcua_assert_1.assert)(!nodeId.isEmpty());
                         bindStandardScalar(node_opcua_constants_1.VariableIds[uid], node_opcua_variant_1.DataType.UInt32, () => {
@@ -938,7 +1015,7 @@ class ServerEngine extends events_1.EventEmitter {
             this.__internal_bindMethod((0, node_opcua_nodeid_1.makeNodeId)(node_opcua_constants_1.MethodIds.Server_RequestServerStateChange), requestServerStateChange.bind(this));
             // fix getMonitoredItems.outputArguments arrayDimensions
             const fixGetMonitoredItemArgs = () => {
-                const objects = this.addressSpace.rootFolder?.objects;
+                const objects = this.addressSpace?.rootFolder?.objects;
                 if (!objects || !objects.server) {
                     return;
                 }
@@ -947,6 +1024,9 @@ class ServerEngine extends events_1.EventEmitter {
                     return;
                 }
                 const outputArguments = getMonitoredItemsMethod.outputArguments;
+                if (!outputArguments) {
+                    return;
+                }
                 const dataValue = outputArguments.readValue();
                 if (!dataValue.value?.value) {
                     // value is null or undefined , meaning no arguments necessary
@@ -958,6 +1038,9 @@ class ServerEngine extends events_1.EventEmitter {
             fixGetMonitoredItemArgs();
             const prepareServerDiagnostics = () => {
                 const addressSpace1 = this.addressSpace;
+                if (!addressSpace1) {
+                    return;
+                }
                 if (!addressSpace1.rootFolder.objects) {
                     return;
                 }
@@ -982,13 +1065,15 @@ class ServerEngine extends events_1.EventEmitter {
                 const samplingIntervalDiagnosticsArray = serverDiagnosticsNode.getComponentByName("SamplingIntervalDiagnosticsArray");
                 if (samplingIntervalDiagnosticsArray) {
                     addressSpace.deleteNode(samplingIntervalDiagnosticsArray);
-                    const s = serverDiagnosticsNode.getComponents();
                 }
                 const subscriptionDiagnosticsArrayNode = serverDiagnosticsNode.getComponentByName("SubscriptionDiagnosticsArray");
                 (0, node_opcua_assert_1.assert)(subscriptionDiagnosticsArrayNode.nodeClass === node_opcua_data_model_1.NodeClass.Variable);
                 (0, node_opcua_address_space_1.bindExtObjArrayNode)(subscriptionDiagnosticsArrayNode, "SubscriptionDiagnosticsType", "subscriptionId");
                 makeNotReadableIfEnabledFlagIsFalse(subscriptionDiagnosticsArrayNode);
                 const sessionsDiagnosticsSummary = serverDiagnosticsNode.getComponentByName("SessionsDiagnosticsSummary");
+                if (!sessionsDiagnosticsSummary) {
+                    return;
+                }
                 const sessionDiagnosticsArray = sessionsDiagnosticsSummary.getComponentByName("SessionDiagnosticsArray");
                 (0, node_opcua_assert_1.assert)(sessionDiagnosticsArray.nodeClass === node_opcua_data_model_1.NodeClass.Variable);
                 (0, node_opcua_address_space_1.bindExtObjArrayNode)(sessionDiagnosticsArray, "SessionDiagnosticsVariableType", "sessionId");
@@ -1013,7 +1098,7 @@ class ServerEngine extends events_1.EventEmitter {
         // do expansion first
         for (const browseDescription of nodesToBrowse) {
             const nodeId = (0, node_opcua_nodeid_1.resolveNodeId)(browseDescription.nodeId);
-            const node = this.addressSpace.findNode(nodeId);
+            const node = this.addressSpace?.findNode(nodeId);
             if (node) {
                 if (node.onFirstBrowseAction) {
                     try {
@@ -1021,7 +1106,7 @@ class ServerEngine extends events_1.EventEmitter {
                         node.onFirstBrowseAction = undefined;
                     }
                     catch (err) {
-                        if (util_1.types.isNativeError(err)) {
+                        if (node_util_1.types.isNativeError(err)) {
                             errorLog("onFirstBrowseAction method has failed", err.message);
                         }
                         errorLog(err);
@@ -1033,18 +1118,33 @@ class ServerEngine extends events_1.EventEmitter {
         return await this.browse(context, nodesToBrowse);
     }
     async browse(context, nodesToBrowse) {
+        if (!this.addressSpaceAccessor) {
+            throw new Error("addressSpaceAccessor is not available");
+        }
         return this.addressSpaceAccessor.browse(context, nodesToBrowse);
     }
     async read(context, readRequest) {
+        if (!this.addressSpaceAccessor) {
+            throw new Error("addressSpaceAccessor is not available");
+        }
         return this.addressSpaceAccessor.read(context, readRequest);
     }
     async write(context, nodesToWrite) {
+        if (!this.addressSpaceAccessor) {
+            throw new Error("addressSpaceAccessor is not available");
+        }
         return await this.addressSpaceAccessor.write(context, nodesToWrite);
     }
     async call(context, methodsToCall) {
+        if (!this.addressSpaceAccessor) {
+            throw new Error("addressSpaceAccessor is not available");
+        }
         return await this.addressSpaceAccessor.call(context, methodsToCall);
     }
     async historyRead(context, historyReadRequest) {
+        if (!this.addressSpaceAccessor) {
+            throw new Error("addressSpaceAccessor is not available");
+        }
         return this.addressSpaceAccessor.historyRead(context, historyReadRequest);
     }
     getOldestInactiveSession() {
@@ -1077,19 +1177,19 @@ class ServerEngine extends events_1.EventEmitter {
         this.clientDescription = options.clientDescription || new node_opcua_service_endpoints_1.ApplicationDescription({});
         const sessionTimeout = options.sessionTimeout || 1000;
         (0, node_opcua_assert_1.assert)(typeof sessionTimeout === "number");
-        const session = new server_session_1.ServerSession(this, options.server.userManager, sessionTimeout);
+        const session = new server_session_1.ServerSession(this, options.server.userManager || {}, sessionTimeout);
         debugLog("createSession :sessionTimeout = ", session.sessionTimeout);
         const key = session.authenticationToken.toString();
         this._sessions[key] = session;
         // see spec OPC Unified Architecture,  Part 2 page 26 Release 1.02
         // TODO : When a Session is created, the Server adds an entry for the Client
         //        in its SessionDiagnosticsArray Variable
-        session.on("new_subscription", (subscription) => {
+        session.on("new_subscription", (_subscription) => {
             this.serverDiagnosticsSummary.cumulatedSubscriptionCount += 1;
             // add the subscription diagnostics in our subscriptions diagnostics array
             // note currentSubscriptionCount is handled directly with a special getter
         });
-        session.on("subscription_terminated", (subscription) => {
+        session.on("subscription_terminated", (_subscription) => {
             // remove the subscription diagnostics in our subscriptions diagnostics array
             // note currentSubscriptionCount is handled directly with a special getter
         });
@@ -1138,7 +1238,7 @@ class ServerEngine extends events_1.EventEmitter {
         const session = this.getSession(authenticationToken);
         // c8 ignore next
         if (!session) {
-            throw new Error("cannot find session with this authenticationToken " + authenticationToken.toString());
+            throw new Error(`cannot find session with this authenticationToken ${authenticationToken.toString()}`);
         }
         if (!deleteSubscriptions) {
             // Live Subscriptions will not be deleted, but transferred to the orphanPublishEngine
@@ -1161,7 +1261,7 @@ class ServerEngine extends events_1.EventEmitter {
     }
     findSubscription(subscriptionId) {
         const subscriptions = [];
-        Object.values(this._sessions).map((session) => {
+        Object.values(this._sessions).forEach((session) => {
             if (subscriptions.length) {
                 return;
             }
@@ -1230,7 +1330,6 @@ class ServerEngine extends events_1.EventEmitter {
         subscription.subscriptionDiagnostics.transferredToAltClientCount++;
         // The number of times the subscription has been transferred to an alternate session for the same client.
         subscription.subscriptionDiagnostics.transferredToSameClientCount++;
-        const nbSubscriptionBefore = session.publishEngine.subscriptionCount;
         if (subscription.$session) {
             subscription.$session._unexposeSubscriptionDiagnostics(subscription);
         }
@@ -1277,6 +1376,9 @@ class ServerEngine extends events_1.EventEmitter {
         return browsePathResults;
     }
     async translateBrowsePath(browsePath) {
+        if (!this.addressSpace) {
+            throw new Error("addressSpace is not available");
+        }
         return this.addressSpace.browsePath(browsePath);
     }
     /**
@@ -1308,7 +1410,7 @@ class ServerEngine extends events_1.EventEmitter {
                 continue;
             }
             // ... and that are valid object and instances of Variables ...
-            const uaNode = this.addressSpace.findNode(nodeToRefresh.nodeId);
+            const uaNode = this.addressSpace?.findNode(nodeToRefresh.nodeId);
             if (!uaNode || !(uaNode.nodeClass === node_opcua_data_model_1.NodeClass.Variable)) {
                 continue;
             }
@@ -1325,7 +1427,8 @@ class ServerEngine extends events_1.EventEmitter {
         const uaVariableArray = Object.values(nodeMap);
         if (uaVariableArray.length === 0) {
             // nothing to do
-            return callback(null, []);
+            callback(null, []);
+            return;
         }
         // perform all asyncRefresh in parallel
         async_1.default.map(uaVariableArray, (uaVariable, inner_callback) => {
@@ -1363,7 +1466,6 @@ class ServerEngine extends events_1.EventEmitter {
         const subscriptionDiagnostics = subscription.subscriptionDiagnostics;
         (0, node_opcua_assert_1.assert)(subscriptionDiagnostics instanceof node_opcua_common_1.SubscriptionDiagnosticsDataType);
         if (subscriptionDiagnostics && serverSubscriptionDiagnosticsArray) {
-            const node = serverSubscriptionDiagnosticsArray[subscription.id];
             (0, node_opcua_address_space_1.removeElement)(serverSubscriptionDiagnosticsArray, (a) => a.subscriptionId === subscription.id);
             /*assert(
                 !(subscriptionDiagnosticsArray as any)[subscription.id],
@@ -1418,15 +1520,15 @@ class ServerEngine extends events_1.EventEmitter {
     __internal_bindMethod(nodeId, func) {
         (0, node_opcua_assert_1.assert)(typeof func === "function");
         (0, node_opcua_assert_1.assert)(nodeId instanceof node_opcua_nodeid_1.NodeId);
-        const methodNode = this.addressSpace.findNode(nodeId);
+        const methodNode = this.addressSpace?.findNode(nodeId);
         if (!methodNode) {
             return;
         }
-        if (methodNode && methodNode.bindMethod) {
+        if (methodNode?.bindMethod) {
             methodNode.bindMethod(func);
         }
-        /* c8 ignore next */
         else {
+            /* c8 ignore next */
             warningLog(chalk_1.default.yellow("WARNING:  cannot bind a method with id ") +
                 chalk_1.default.cyan(nodeId.toString()) +
                 chalk_1.default.yellow(". please check your nodeset.xml file or add this node programmatically"));
@@ -1441,8 +1543,7 @@ class ServerEngine extends events_1.EventEmitter {
         }
         const subscriptionDiagnosticsType = this.addressSpace.findVariableType("SubscriptionDiagnosticsType");
         if (!subscriptionDiagnosticsType) {
-            doDebug &&
-                debugLog("ServerEngine#_getServerSubscriptionDiagnosticsArray " + ": cannot find SubscriptionDiagnosticsType");
+            doDebug && debugLog(`ServerEngine#_getServerSubscriptionDiagnosticsArray : cannot find SubscriptionDiagnosticsType`);
         }
         // SubscriptionDiagnosticsArray = i=2290
         const subscriptionDiagnosticsArrayNode = this.addressSpace.findNode((0, node_opcua_nodeid_1.makeNodeId)(node_opcua_constants_1.VariableIds.Server_ServerDiagnostics_SubscriptionDiagnosticsArray));