node-opcua-server 2.120.0 → 2.121.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "node-opcua-server",
-    "version": "2.120.0",
+    "version": "2.121.0",
     "description": "pure nodejs OPCUA SDK - module server",
     "scripts": {
         "build": "tsc -b",
@@ -17,54 +17,54 @@
         "chalk": "4.1.2",
         "dequeue": "^1.0.5",
         "lodash": "4.17.21",
-        "node-opcua-address-space": "2.120.0",
-        "node-opcua-address-space-base": "2.120.0",
+        "node-opcua-address-space": "2.121.0",
+        "node-opcua-address-space-base": "2.121.0",
         "node-opcua-assert": "2.120.0",
-        "node-opcua-basic-types": "2.120.0",
+        "node-opcua-basic-types": "2.121.0",
         "node-opcua-binary-stream": "2.120.0",
-        "node-opcua-certificate-manager": "2.120.0",
-        "node-opcua-client": "2.120.0",
-        "node-opcua-client-dynamic-extension-object": "2.120.0",
-        "node-opcua-common": "2.120.0",
-        "node-opcua-constants": "2.120.0",
-        "node-opcua-crypto": "4.7.0",
-        "node-opcua-data-model": "2.120.0",
-        "node-opcua-data-value": "2.120.0",
-        "node-opcua-date-time": "2.120.0",
-        "node-opcua-debug": "2.120.0",
-        "node-opcua-extension-object": "2.120.0",
-        "node-opcua-factory": "2.120.0",
+        "node-opcua-certificate-manager": "2.121.0",
+        "node-opcua-client": "2.121.0",
+        "node-opcua-client-dynamic-extension-object": "2.121.0",
+        "node-opcua-common": "2.121.0",
+        "node-opcua-constants": "2.121.0",
+        "node-opcua-crypto": "4.8.0",
+        "node-opcua-data-model": "2.121.0",
+        "node-opcua-data-value": "2.121.0",
+        "node-opcua-date-time": "2.121.0",
+        "node-opcua-debug": "2.121.0",
+        "node-opcua-extension-object": "2.121.0",
+        "node-opcua-factory": "2.121.0",
         "node-opcua-hostname": "2.120.0",
-        "node-opcua-nodeid": "2.120.0",
-        "node-opcua-nodesets": "2.120.0",
-        "node-opcua-numeric-range": "2.120.0",
-        "node-opcua-object-registry": "2.120.0",
-        "node-opcua-secure-channel": "2.120.0",
-        "node-opcua-service-browse": "2.120.0",
-        "node-opcua-service-call": "2.120.0",
-        "node-opcua-service-discovery": "2.120.0",
-        "node-opcua-service-endpoints": "2.120.0",
-        "node-opcua-service-filter": "2.120.0",
-        "node-opcua-service-history": "2.120.0",
-        "node-opcua-service-node-management": "2.120.0",
-        "node-opcua-service-query": "2.120.0",
-        "node-opcua-service-read": "2.120.0",
-        "node-opcua-service-register-node": "2.120.0",
-        "node-opcua-service-secure-channel": "2.120.0",
-        "node-opcua-service-session": "2.120.0",
-        "node-opcua-service-subscription": "2.120.0",
-        "node-opcua-service-translate-browse-path": "2.120.0",
-        "node-opcua-service-write": "2.120.0",
-        "node-opcua-status-code": "2.120.0",
-        "node-opcua-transport": "2.120.0",
-        "node-opcua-types": "2.120.0",
+        "node-opcua-nodeid": "2.121.0",
+        "node-opcua-nodesets": "2.121.0",
+        "node-opcua-numeric-range": "2.121.0",
+        "node-opcua-object-registry": "2.121.0",
+        "node-opcua-secure-channel": "2.121.0",
+        "node-opcua-service-browse": "2.121.0",
+        "node-opcua-service-call": "2.121.0",
+        "node-opcua-service-discovery": "2.121.0",
+        "node-opcua-service-endpoints": "2.121.0",
+        "node-opcua-service-filter": "2.121.0",
+        "node-opcua-service-history": "2.121.0",
+        "node-opcua-service-node-management": "2.121.0",
+        "node-opcua-service-query": "2.121.0",
+        "node-opcua-service-read": "2.121.0",
+        "node-opcua-service-register-node": "2.121.0",
+        "node-opcua-service-secure-channel": "2.121.0",
+        "node-opcua-service-session": "2.121.0",
+        "node-opcua-service-subscription": "2.121.0",
+        "node-opcua-service-translate-browse-path": "2.121.0",
+        "node-opcua-service-write": "2.121.0",
+        "node-opcua-status-code": "2.121.0",
+        "node-opcua-transport": "2.121.0",
+        "node-opcua-types": "2.121.0",
         "node-opcua-utils": "2.120.0",
-        "node-opcua-variant": "2.120.0",
+        "node-opcua-variant": "2.121.0",
         "thenify": "^3.3.1"
     },
     "devDependencies": {
-        "node-opcua-data-access": "2.120.0",
-        "node-opcua-leak-detector": "2.120.0",
+        "node-opcua-data-access": "2.121.0",
+        "node-opcua-leak-detector": "2.121.0",
         "node-opcua-test-helpers": "2.120.0",
         "should": "^13.2.3",
         "sinon": "^17.0.1",
@@ -85,7 +85,7 @@
         "internet of things"
     ],
     "homepage": "http://node-opcua.github.io/",
-    "gitHead": "f4ae243bb61ba7af4c019a3cfe76dfc0f6427983",
+    "gitHead": "ba93a78eda343ecc0cc20476837347f6dfa259e0",
     "files": [
         "dist",
         "source"

package/source/addressSpace_accessor.ts

@@ -185,7 +185,7 @@ export class AddressSpaceAccessor implements IAddressSpaceAccessor, IAddressSpac
             const continuationPoint = m.nodeToRead.continuationPoint;
             return await this.historyReadNode(context, m.nodeToRead, m.processDetail, timestampsToReturn, {
                 continuationPoint,
-                releaseContinuationPoints /**, index = ??? */
+                releaseContinuationPoints
             });
         };
 
@@ -217,7 +217,6 @@ export class AddressSpaceAccessor implements IAddressSpaceAccessor, IAddressSpac
             return await this.historyReadNode(context, nodeToRead, historyReadDetails, timestampsToReturn, {
                 continuationPoint,
                 releaseContinuationPoints,
-                index
             });
         };
         const promises: Promise<HistoryReadResult>[] = [];
@@ -405,7 +404,7 @@ export class AddressSpaceAccessor implements IAddressSpaceAccessor, IAddressSpac
             //    invalid attributes : BadNodeAttributesInvalid
             //    invalid range      : BadIndexRangeInvalid
             const result = await obj.historyRead(context, historyReadDetails, indexRange, dataEncoding, continuationData);
-            assert(result!.statusCode instanceof StatusCode);
+    
             assert(result!.isValid());
             return result;
         }

package/source/monitored_item.ts

@@ -255,22 +255,21 @@ function apply_dataChange_filter(this: MonitoredItem, newDataValue: DataValue, o
 
 const s = (a: any) => JSON.stringify(a, null, "  ");
 
-function safeGuardRegiter(monitoredItem: MonitoredItem) {
-
+function safeGuardRegister(monitoredItem: MonitoredItem) {
     (monitoredItem.oldDataValue as any)._$monitoredItem = monitoredItem.node?.nodeId?.toString();
     (monitoredItem as any)._$safeGuard = s((monitoredItem as any).oldDataValue);
 }
 function safeGuardVerify(monitoredItem: MonitoredItem) {
     if ((monitoredItem as any)._$safeGuard) {
-        const verif = s(monitoredItem.oldDataValue|| "");
+        const verif = s(monitoredItem.oldDataValue || "");
         if (verif !== (monitoredItem as any)._$safeGuard) {
             errorLog(verif, (monitoredItem as any)._$safeGuard);
-            throw new Error("Internal error: DataValue has been altereed !!!");
+            throw new Error("Internal error: DataValue has been altered !!!");
         }
     }
 }
 function apply_filter(this: MonitoredItem, newDataValue: DataValue) {
-    if (!this.oldDataValue) {
+    if (this.oldDataValue === badDataUnavailable) {
         return true; // keep
     }
 
@@ -365,6 +364,7 @@ function isSourceNewerThan(a: DataValue, b?: DataValue): boolean {
     return at > bt;
 }
 
+const badDataUnavailable = new DataValue({ statusCode: StatusCodes.BadDataUnavailable }); // unset initially
 /**
  * a server side monitored item
  *
@@ -391,7 +391,7 @@ export class MonitoredItem extends EventEmitter {
     public samplingInterval = -1;
     public monitoredItemId: number;
     public overflow: boolean;
-    public oldDataValue?: DataValue;
+    public oldDataValue: DataValue;
     public monitoringMode: MonitoringMode;
     public timestampsToReturn: TimestampsToReturn;
     public itemToMonitor: any;
@@ -404,7 +404,7 @@ export class MonitoredItem extends EventEmitter {
     public samplingFunc: SamplingFunc | null = null;
 
     private _node: BaseNode | null;
-    private queue: QueueItem[];
+    public queue: QueueItem[];
     private _semantic_version: number;
     private _is_sampling = false;
     private _on_opcua_event_received_callback: any;
@@ -433,7 +433,7 @@ export class MonitoredItem extends EventEmitter {
         this.queue = [];
         this.overflow = false;
 
-        this.oldDataValue = new DataValue({ statusCode: StatusCodes.BadDataUnavailable }); // unset initially
+        this.oldDataValue = badDataUnavailable;
 
         // user has to call setMonitoringMode
         this.monitoringMode = MonitoringMode.Invalid;
@@ -522,7 +522,7 @@ export class MonitoredItem extends EventEmitter {
         }
 
         // x assert(this._samplingId === null,"Sampling Id must be null");
-        this.oldDataValue = undefined;
+        this.oldDataValue = badDataUnavailable;
         this.queue = [];
         this.itemToMonitor = null;
         this.filter = null;
@@ -580,7 +580,7 @@ export class MonitoredItem extends EventEmitter {
      *
      */
     // eslint-disable-next-line complexity, max-statements
-    public recordValue(dataValue: DataValue, skipChangeTest: boolean, indexRange?: NumericRange): boolean {
+    public recordValue(dataValue: DataValue, skipChangeTest?: boolean, indexRange?: NumericRange): boolean {
         if (!this.itemToMonitor) {
             // we must have a valid itemToMonitor(have this monitoredItem been disposed already ?)
             // istanbul ignore next
@@ -588,18 +588,13 @@ export class MonitoredItem extends EventEmitter {
             return false;
         }
 
-        assert(dataValue !== this.oldDataValue, "recordValue expects different dataValue to be provided");
-
-        assert(
-            !dataValue.value || !this.oldDataValue || dataValue.value !== this.oldDataValue!.value,
-            "recordValue expects different dataValue.value to be provided"
-        );
-
-        assert(!dataValue.value || dataValue.value.isValid(), "expecting a valid variant value");
+        if (dataValue === this.oldDataValue) {
+            errorLog("recordValue expects different dataValue to be provided");
+        }
+        doDebug && assert(!dataValue.value || dataValue.value.isValid(), "expecting a valid variant value");
 
         const hasSemanticChanged = this.node && (this.node as any).semantic_version !== this._semantic_version;
 
-       
         if (!hasSemanticChanged && indexRange && this.itemToMonitor.indexRange) {
             // we just ignore changes that do not fall within our range
             // ( unless semantic bit has changed )
@@ -655,13 +650,13 @@ export class MonitoredItem extends EventEmitter {
             }
         }
 
-        if (!apply_filter.call(this, dataValue)) {
+        if (!skipChangeTest && !apply_filter.call(this, dataValue)) {
             // istanbul ignore next
             if (doDebug) {
                 debugLog("recordValue => Rejected ", this.node?.browseName.toString(), " because apply_filter");
                 debugLog("current Value =>", this.oldDataValue?.toString());
-                debugLog("propoped Value =>", dataValue?.toString());
-                debugLog("propoped Value =>", dataValue == this.oldDataValue, dataValue.value === this.oldDataValue?.value);
+                debugLog("proposed Value =>", dataValue?.toString());
+                debugLog("proposed Value =>", dataValue == this.oldDataValue, dataValue.value === this.oldDataValue?.value);
             }
             return false;
         }
@@ -672,12 +667,12 @@ export class MonitoredItem extends EventEmitter {
 
             // istanbul ignore next
             if (doDebug) {
-                debugLog("Current : ", this.oldDataValue!.toString());
+                debugLog("Current : ", this.oldDataValue?.toString());
                 debugLog("New : ", dataValue.toString());
                 debugLog("indexRange=", indexRange);
             }
 
-            if (sameVariant(dataValue.value, this.oldDataValue!.value)) {
+            if (this.oldDataValue !== badDataUnavailable && sameVariant(dataValue.value, this.oldDataValue.value)) {
                 // istanbul ignore next
                 doDebug &&
                     debugLog("recordValue => Rejected ", this.node?.browseName.toString(), " because useIndexRange && sameVariant");
@@ -791,13 +786,24 @@ export class MonitoredItem extends EventEmitter {
         return notifications;
     }
 
-    public modify(timestampsToReturn: TimestampsToReturn, monitoringParameters: MonitoringParameters): MonitoredItemModifyResult {
+    public modify(
+        timestampsToReturn: TimestampsToReturn | null,
+        monitoringParameters: MonitoringParameters | null
+    ): MonitoredItemModifyResult {
         assert(monitoringParameters instanceof MonitoringParameters);
 
         const old_samplingInterval = this.samplingInterval;
 
         this.timestampsToReturn = timestampsToReturn || this.timestampsToReturn;
 
+        if (!monitoringParameters) {
+            return new MonitoredItemModifyResult({
+                revisedQueueSize: this.queueSize,
+                revisedSamplingInterval: this.samplingInterval,
+                filterResult: null,
+                statusCode: StatusCodes.Good
+            });
+        }
         if (old_samplingInterval !== 0 && monitoringParameters.samplingInterval === 0) {
             monitoringParameters.samplingInterval = MonitoredItem.minimumSamplingInterval; // fastest possible
         }
@@ -831,13 +837,30 @@ export class MonitoredItem extends EventEmitter {
         });
     }
 
-    public async resendInitialValues(): Promise<void> {
+    public async resendInitialValue(): Promise<void> {
         // the first Publish response(s) after the TransferSubscriptions call shall contain the current values of all
         // Monitored Items in the Subscription where the Monitoring Mode is set to Reporting.
         // the first Publish response after the TransferSubscriptions call shall contain only the value changes since
         // the last Publish response was sent.
         // This parameter only applies to MonitoredItems used for monitoring Attribute changes.
-        return this._start_sampling(true);
+
+        // istanbul ignore next
+        if (!this.node) return;
+
+        const sessionContext = this.getSessionContext() || SessionContext.defaultContext;
+
+        // istanbul ignore next
+        if (!sessionContext) return;
+
+        // no need to resend if a value is already in the queue
+        if (this.queue.length > 0) return;
+
+        const theValueToResend =
+            this.oldDataValue !== badDataUnavailable
+                ? this.oldDataValue
+                : this.node.readAttribute(sessionContext, this.itemToMonitor.attributeId);
+        this.oldDataValue = badDataUnavailable;
+        this._enqueue_value(theValueToResend);
     }
 
     private getSessionContext(): ISessionContext | null {
@@ -857,8 +880,11 @@ export class MonitoredItem extends EventEmitter {
             return;
         }
 
-        const sessionContext = this.getSessionContext();
+        // Use default context if session is not available
+        const sessionContext = this.getSessionContext() || SessionContext.defaultContext;
+
         if (!sessionContext) {
+            warningLog("MonitoredItem#_on_sampling_timer : ", this.node?.nodeId.toString(), "cannot find session");
             return;
         }
         // istanbul ignore next
@@ -893,13 +919,13 @@ export class MonitoredItem extends EventEmitter {
 
             this._is_sampling = true;
 
-            this.samplingFunc.call(this, sessionContext, this.oldDataValue!, (err: Error | null, newDataValue?: DataValue) => {
+            this.samplingFunc.call(this, sessionContext, this.oldDataValue, (err: Error | null, newDataValue?: DataValue) => {
                 if (!this._samplingId) {
                     // item has been disposed. The monitored item has been disposed while the async sampling func
                     // was taking place ... just ignore this
                     return;
                 }
-                // istanbull ignore next
+                // istanbul ignore next
                 if (err) {
                     errorLog(" SAMPLING ERROR =>", err);
                 } else {
@@ -1022,13 +1048,14 @@ export class MonitoredItem extends EventEmitter {
     private _start_sampling(recordInitialValue: boolean): void {
         // istanbul ignore next
         if (!this.node) {
-            throw new Error("Internal Error");
+            return; // we just want to ignore here ...
         }
+        this.oldDataValue = badDataUnavailable;
         setImmediate(() => this.__start_sampling(recordInitialValue));
     }
 
     private __acquireInitialValue(sessionContext: ISessionContext, callback: CallbackT<DataValue>): void {
-        // aquire initial value from the variable/object not itself or from the last known value if we have
+        // acquire initial value from the variable/object not itself or from the last known value if we have
         // one already
         assert(this.itemToMonitor.attributeId === AttributeIds.Value);
         assert(this.node);
@@ -1036,16 +1063,16 @@ export class MonitoredItem extends EventEmitter {
             return callback(new Error("Invalid "));
         }
         const variable = this.node as UAVariable;
-        if (!this.oldDataValue || this.oldDataValue.statusCode.value == StatusCodes.BadDataUnavailable.value) {
+        if (this.oldDataValue == badDataUnavailable) {
             variable.readValueAsync(sessionContext, (err: Error | null, dataValue?: DataValue) => {
                 callback(err, dataValue);
             });
         } else {
             const o = this.oldDataValue;
-            this.oldDataValue = new DataValue({ statusCode: StatusCodes.BadDataUnavailable });
+            this.oldDataValue = badDataUnavailable;
             // istanbul ignore next
             if (doDebug) {
-                safeGuardRegiter(this);
+                safeGuardRegister(this);
             }
             callback(null, o);
         }
@@ -1056,7 +1083,7 @@ export class MonitoredItem extends EventEmitter {
             return; // we just want to ignore here ...
         }
 
-        const sessionContext = this.getSessionContext();
+        const sessionContext = this.getSessionContext() || SessionContext.defaultContext;
         // istanbul ignore next
         if (!sessionContext) {
             return;
@@ -1241,34 +1268,20 @@ export class MonitoredItem extends EventEmitter {
      * @param dataValue {DataValue} the dataValue to enqueue
      * @private
      */
-    private _enqueue_value(dataValue: DataValue) {
+    public _enqueue_value(dataValue: DataValue) {
         // preconditions:
-        if (doDebug) {
-            debugLog("_enqueue_value = ", dataValue.toString());
-        }
+        doDebug && debugLog("_enqueue_value = ", dataValue.toString());
 
-        assert(dataValue instanceof DataValue);
         // lets verify that, if status code is good then we have a valid Variant in the dataValue
-        assert(!dataValue.statusCode.isGoodish() || dataValue.value instanceof Variant);
-        // xx assert(isGoodish(dataValue.statusCode) || util.isNullOrUndefined(dataValue.value) );
+        doDebug && assert(!dataValue.statusCode.isGoodish() || dataValue.value instanceof Variant);
         // let's check that data Value is really a different object
         // we may end up with corrupted queue if dataValue are recycled and stored as is in notifications
-        assert(dataValue !== this.oldDataValue, "dataValue cannot be the same object twice!");
-
-        // Xx // todo ERN !!!! PLEASE CHECK this !!!
-        // Xx // let make a clone, so we have a snapshot
-        // Xx dataValue = dataValue.clone();
+        doDebug && assert(dataValue !== this.oldDataValue, "dataValue cannot be the same object twice!");
 
         // let's check that data Value is really a different object
         // we may end up with corrupted queue if dataValue are recycled and stored as is in notifications
-        assert(
-            !this.oldDataValue || !dataValue.value || dataValue.value !== this.oldDataValue.value,
-            "dataValue cannot be the same object twice!"
-        );
-
         if (
             !(
-                !this.oldDataValue ||
                 !this.oldDataValue.value ||
                 !dataValue.value ||
                 !(dataValue.value.value instanceof Object) ||
@@ -1294,7 +1307,7 @@ export class MonitoredItem extends EventEmitter {
         this.oldDataValue = dataValue.clone();
         // istanbul ignore next
         if (doDebug) {
-            safeGuardRegiter(this);
+            safeGuardRegister(this);
         }
 
         const notification = this._makeDataChangeNotification(this.oldDataValue);
@@ -1302,7 +1315,6 @@ export class MonitoredItem extends EventEmitter {
     }
 
     private _makeEventFieldList(eventFields: any[]): EventFieldList {
-        assert(Array.isArray(eventFields));
         return new EventFieldList({
             clientHandle: this.clientHandle,
             eventFields

package/source/opcua_server.ts

@@ -1479,8 +1479,9 @@ export class OPCUAServer extends OPCUABaseServer {
     /**
      * retrieve a session by authentication token
      * @internal
+     * @private
      */
-    protected getSession(authenticationToken: NodeId, activeOnly?: boolean): ServerSession | null {
+    public getSession(authenticationToken: NodeId, activeOnly?: boolean): ServerSession | null {
         return this.engine ? this.engine.getSession(authenticationToken, activeOnly) : null;
     }
 
@@ -1621,8 +1622,7 @@ export class OPCUAServer extends OPCUABaseServer {
                     case StatusCodes.BadCertificateIssuerTimeInvalid:
                         this.raiseEvent("AuditCertificateExpiredEventType", {
                             certificate: { dataType: DataType.ByteString, value: certificate },
-                            sourceName: { dataType: DataType.String, value: "Security/Certificate" },
-                            comment: { dataType: DataType.String, value: certificateStatus.toString() }
+                            sourceName: { dataType: DataType.String, value: "Security/Certificate" }
                         });
                         break;
                     case StatusCodes.BadCertificateRevoked:
@@ -1630,8 +1630,7 @@ export class OPCUAServer extends OPCUABaseServer {
                     case StatusCodes.BadCertificateIssuerRevocationUnknown:
                         this.raiseEvent("AuditCertificateRevokedEventType", {
                             certificate: { dataType: DataType.ByteString, value: certificate },
-                            sourceName: { dataType: DataType.String, value: "Security/Certificate" },
-                            comment: { dataType: DataType.String, value: certificateStatus.toString() }
+                            sourceName: { dataType: DataType.String, value: "Security/Certificate" }
                         });
                         break;
                     case StatusCodes.BadCertificateIssuerUseNotAllowed:
@@ -1639,8 +1638,7 @@ export class OPCUAServer extends OPCUABaseServer {
                     case StatusCodes.BadSecurityChecksFailed:
                         this.raiseEvent("AuditCertificateMismatchEventType", {
                             certificate: { dataType: DataType.ByteString, value: certificate },
-                            sourceName: { dataType: DataType.String, value: "Security/Certificate" },
-                            comment: { dataType: DataType.String, value: certificateStatus.toString() }
+                            sourceName: { dataType: DataType.String, value: "Security/Certificate" }
                         });
                         break;
                 }
@@ -2347,8 +2345,8 @@ export class OPCUAServer extends OPCUABaseServer {
         let response: any;
         /* istanbul ignore next */
         if (!message.session || message.session_statusCode !== StatusCodes.Good) {
-            const errMessage = "INVALID SESSION  !! ";
-            response = new ResponseClass({ responseHeader: { serviceResult: message.session_statusCode } });
+            const errMessage = "=>" + message.session_statusCode?.toString();
+            response = new ServiceFault({ responseHeader: { serviceResult: message.session_statusCode } });
             debugLog(chalk.red.bold(errMessage), chalk.yellow(message.session_statusCode!.toString()), response.constructor.name);
             return sendResponse(response);
         }
@@ -2451,23 +2449,28 @@ export class OPCUAServer extends OPCUABaseServer {
                     return sendError(StatusCodes.BadNothingToDo);
                 }
 
-                const results: any[] = subscriptionIds.map((subscriptionId: number) => actionToPerform(session, subscriptionId));
-
-                // resolve potential pending promises ....
-                for (let i = 0; i < results.length; i++) {
-                    if (results[i].then) {
-                        results[i] = await results[i];
-                    }
+                // check minimal
+                if (
+                    request.subscriptionIds.length >
+                    Math.min(
+                        this.engine.serverCapabilities.maxSubscriptionsPerSession,
+                        this.engine.serverCapabilities.maxSubscriptions
+                    )
+                ) {
+                    return sendError(StatusCodes.BadTooManyOperations);
                 }
 
+                const promises: Promise<T>[] = subscriptionIds.map((subscriptionId: number) =>
+                    actionToPerform(session, subscriptionId)
+                );
+                const results: T[] = await Promise.all(promises);
+
+                const serviceResult: StatusCode = StatusCodes.Good;
                 const response = new ResponseClass({
                     responseHeader: {
-                        serviceResult:
-                            request.subscriptionIds.length > this.engine.serverCapabilities.maxSubscriptionsPerSession
-                                ? StatusCodes.BadTooManyOperations
-                                : StatusCodes.Good
+                        serviceResult
                     },
-                    results
+                    results: results as any
                 });
                 sendResponse(response);
             }

package/source/server_end_point.ts

@@ -853,8 +853,9 @@ export class OPCUAServerEndPoint extends EventEmitter implements ServerSecureCha
         } else {
             debugLog("OPCUAServerEndPoint#_registerChannel called when end point is shutdown !");
             debugLog("  -> channel will be forcefully terminated");
-            channel.close();
-            channel.dispose();
+            channel.close(() => {
+                channel.dispose();
+            });
         }
     }
 
@@ -927,17 +928,22 @@ export class OPCUAServerEndPoint extends EventEmitter implements ServerSecureCha
             errorLog(chalk.bgRed.white("PREVENTING DDOS ATTACK => maxConnection =" + this.maxConnections));
 
             const unused_channels: ServerSecureChannelLayer[] = this.getChannels().filter((channel1: ServerSecureChannelLayer) => {
-                return !channel1.isOpened && !channel1.hasSession;
+                return !channel1.hasSession;
             });
             if (unused_channels.length === 0) {
+                doDebug && console.log(
+                    this.getChannels()
+                        .map(({ status, isOpened, hasSession }) => `${status} ${isOpened} ${hasSession}\n`)
+                        .join(" ")
+                );
                 // all channels are in used , we cannot get any
-                errorLog("All channels are in used ! let cancel some");
+                errorLog(`All channels are in used ! we cannot cancel any ${this.getChannels().length}`);
                 // istanbul ignore next
                 if (doDebug) {
                     console.log("  - all channels are used !!!!");
-                    dumpChannelInfo(this.getChannels());
+                    false && dumpChannelInfo(this.getChannels());
                 }
-                setTimeout(deny_connection, 10);
+                setTimeout(deny_connection, 1000);
                 return;
             }
             // istanbul ignore next
@@ -948,7 +954,7 @@ export class OPCUAServerEndPoint extends EventEmitter implements ServerSecureCha
                 );
             }
             const channel = unused_channels[0];
-            errorLog("Closing channel ", channel.hashKey);
+            errorLog(`${unused_channels.length} : Forcefully closing oldest channel that have no session: ${channel.hashKey}`);
             channel.close(() => {
                 // istanbul ignore next
                 if (doDebug) {

package/source/server_engine.ts

@@ -338,7 +338,7 @@ export interface ServerEngineOptions {
 export interface CreateSessionOption {
     clientDescription?: ApplicationDescription;
     sessionTimeout?: number;
-    server: IServerBase;
+    server?: IServerBase;
 }
 
 export type ClosingReason = "Timeout" | "Terminated" | "CloseSession" | "Forcing";
@@ -374,7 +374,7 @@ export class ServerEngine extends EventEmitter implements IAddressSpaceAccessor
     private _serverStatus: ServerStatusDataType;
     private _globalCounter: { totalMonitoredItemCount: number } = { totalMonitoredItemCount: 0 };
 
-    constructor(options: ServerEngineOptions) {
+    constructor(options?: ServerEngineOptions) {
         super();
 
         options = options || ({ applicationUri: "" } as ServerEngineOptions);
@@ -1423,7 +1423,7 @@ export class ServerEngine extends EventEmitter implements IAddressSpaceAccessor
      * @param  [options.clientDescription] {ApplicationDescription}
      * @return {ServerSession}
      */
-    public createSession(options: CreateSessionOption): ServerSession {
+    public createSession(options?: CreateSessionOption): ServerSession {
         options = options || {};
         options.server = options.server || {};
         debugLog("createSession : increasing serverDiagnosticsSummary cumulatedSessionCount/currentSessionCount ");
@@ -1645,9 +1645,10 @@ export class ServerEngine extends EventEmitter implements IAddressSpaceAccessor
             subscription.$session._unexposeSubscriptionDiagnostics(subscription);
         }
 
-        await ServerSidePublishEngine.transferSubscription(subscription, session.publishEngine, sendInitialValues);
         subscription.$session = session;
-
+    
+        await ServerSidePublishEngine.transferSubscription(subscription, session.publishEngine, sendInitialValues);
+    
         session._exposeSubscriptionDiagnostics(subscription);
 
         assert((subscription.publishEngine as any) === session.publishEngine);