node-opcua-pki 2.13.0 → 2.14.2

package/lib/misc/subject.ts

@@ -41,7 +41,6 @@ const _keys = {
 };
 
 export class Subject implements SubjectOptions {
-
     public readonly commonName?: string;
     public readonly organization?: string;
     public readonly organizationalUnit?: string;
@@ -51,8 +50,7 @@ export class Subject implements SubjectOptions {
     public readonly domainComponent?: string;
 
     constructor(options: SubjectOptions | string) {
-
-        if (typeof(options) === "string") {
+        if (typeof options === "string") {
             options = Subject.parse(options);
         }
         this.commonName = options.commonName;
@@ -65,9 +63,8 @@ export class Subject implements SubjectOptions {
     }
 
     public static parse(str: string): SubjectOptions {
-
-        const elements = str.split("/");
-        const options: any = {};
+        const elements = str.split(/\/(?=[^/]*?=)/);
+        const options: Record<string, unknown> = {};
 
         elements.forEach((element: string) => {
             if (element.length === 0) {
@@ -76,17 +73,16 @@ export class Subject implements SubjectOptions {
             const s: string[] = element.split("=");
 
             if (s.length !== 2) {
-                    throw new Error("invalid format for " + element);
+                throw new Error("invalid format for " + element);
             }
             const longName = (_keys as any)[s[0]];
             const value = s[1];
-            options[longName] = Buffer.from(value,"ascii").toString("utf8");
+            options[longName] = Buffer.from(value, "ascii").toString("utf8");
         });
         return options as SubjectOptions;
     }
 
     public toString() {
-
         let tmp = "";
         if (this.country) {
             tmp += "/C=" + this.country;
@@ -111,5 +107,4 @@ export class Subject implements SubjectOptions {
         }
         return tmp;
     }
-
 }

package/lib/pki/certificate_authority.ts

@@ -140,7 +140,7 @@ function construct_CertificateAuthority(certificateAuthority: CertificateAuthori
     }
 
     // tslint:disable:no-empty
-    displayTitle("Create Certificate Authority (CA)", (err?: Error | null) => { });
+    displayTitle("Create Certificate Authority (CA)", (err?: Error | null) => { /** */ });
 
     const indexFileAttr = path.join(caRootDir, "index.txt.attr");
     if (!fs.existsSync(indexFileAttr)) {
@@ -148,6 +148,7 @@ function construct_CertificateAuthority(certificateAuthority: CertificateAuthori
     }
 
     const caConfigFile = certificateAuthority.configFile;
+    // eslint-disable-next-line no-constant-condition
     if (1 || !fs.existsSync(caConfigFile)) {
         let data = configurationFileTemplate; // inlineText(configurationFile);
         data = data.replace(/%%ROOT_FOLDER%%/, make_path(caRootDir));
@@ -156,7 +157,7 @@ function construct_CertificateAuthority(certificateAuthority: CertificateAuthori
     }
 
     // http://www.akadia.com/services/ssh_test_certificate.html
-    const subjectOpt = ' -subj "' + subject.toString() + '" ';
+    const subjectOpt = " -subj \"" + subject.toString() + "\" ";
     const options = { cwd: caRootDir };
     processAltNames({} as Params);
 
@@ -268,8 +269,8 @@ export class CertificateAuthority {
     public readonly subject: Subject;
 
     constructor(options: CertificateAuthorityOptions) {
-        assert(options.hasOwnProperty("location"));
-        assert(options.hasOwnProperty("keySize"));
+        assert(Object.prototype.hasOwnProperty.call(options,"location"));
+        assert(Object.prototype.hasOwnProperty.call(options,"keySize"));
         this.location = options.location;
         this.keySize = options.keySize || 2048;
         this.subject = new Subject(options.subject || defaultSubject);
@@ -729,6 +730,7 @@ export class CertificateAuthority {
 }
 
 // tslint:disable:no-var-requires
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const thenify = require("thenify");
 const opts = { multiArgs: false };
 CertificateAuthority.prototype.initialize = thenify.withCallback(CertificateAuthority.prototype.initialize, opts);

package/lib/pki/certificate_manager.ts

@@ -66,7 +66,11 @@ import {
     setEnv,
 } from "./toolbox";
 
-import { withLock } from "@ster5/global-mutex"
+import { withLock } from "@ster5/global-mutex";
+// tslint:disable:max-line-length
+// tslint:disable:no-var-requires
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const thenify = require("thenify");
 
 type C = ((err?: Error | null, ...args: [any, ...any]) => void) | ((err?: Error | null) => void);
 
@@ -108,6 +112,15 @@ export interface CertificateManagerOptions {
     location: string;
 }
 
+export interface Callback11<C> {
+    (err: null, t: C): void;
+    (err: Error): void;
+}
+export interface Callback22 {
+    (err?: Error | null): void;
+    (err?: Error): void;
+}
+
 export interface CreateSelfSignCertificateParam1 extends CreateSelfSignCertificateParam {
     outputFile?: Filename; // default : own/cert/self_signed_certificate.pem
     subject: SubjectOptions | string;
@@ -197,14 +210,14 @@ export enum CertificateManagerState {
     Disposed = 4,
 }
 export class CertificateManager {
-    public untrustUnknownCertificate: boolean = true;
+    public untrustUnknownCertificate = true;
     public state: CertificateManagerState = CertificateManagerState.Uninitialized;
     public folderPoolingInterval = 5000;
 
     private readonly keySize: KeySize;
     private readonly location: string;
     private readonly _watchers: fs.FSWatcher[] = [];
-    private _readCertificatesCalled: boolean = false;
+    private _readCertificatesCalled = false;
     private readonly _filenameToHash: { [key: string]: string } = {};
 
     private readonly _thumbs: Thumbs = {
@@ -219,8 +232,8 @@ export class CertificateManager {
 
     constructor(options: CertificateManagerOptions) {
         options.keySize = options.keySize || 2048;
-        assert(options.hasOwnProperty("location"));
-        assert(options.hasOwnProperty("keySize"));
+        assert(Object.prototype.hasOwnProperty.call(options, "location"));
+        assert(Object.prototype.hasOwnProperty.call(options, "keySize"));
         assert(this.state === CertificateManagerState.Uninitialized);
 
         this.location = make_path(options.location, "");
@@ -463,8 +476,8 @@ export class CertificateManager {
             // certificate is not active yet
             debugLog(
                 chalk.red("certificate is invalid : certificate is not active yet !") +
-                "  not before date =" +
-                certificateInfo.notBefore
+                    "  not before date =" +
+                    certificateInfo.notBefore
             );
             isTimeInvalid = true;
         }
@@ -527,7 +540,6 @@ export class CertificateManager {
     public async initialize(): Promise<void>;
     public initialize(callback: (err?: Error) => void): void;
     public initialize(...args: any[]): any {
-
         const callback = args[0];
         assert(callback && callback instanceof Function);
 
@@ -535,13 +547,13 @@ export class CertificateManager {
             return callback();
         }
         this.state = CertificateManagerState.Initializing;
-        return this._initialize((err?: Error) => {
+        return this._initialize((err?: Error | null) => {
             this.state = CertificateManagerState.Initialized;
             return callback(err);
         });
     }
-    private _initialize(callback: (err?: Error) => void): void {
-        assert(this.state = CertificateManagerState.Initializing);
+    private _initialize(callback: ErrorCallback): void {
+        assert((this.state = CertificateManagerState.Initializing));
         const pkiDir = this.location;
         mkdir(pkiDir);
         mkdir(path.join(pkiDir, "own"));
@@ -555,7 +567,7 @@ export class CertificateManager {
         mkdir(path.join(pkiDir, "issuers"));
         mkdir(path.join(pkiDir, "issuers/certs")); // contains Trusted CA certificates
         mkdir(path.join(pkiDir, "issuers/crl")); // contains CRL of revoked CA certificates
-        
+
         this.withLock((callback) => {
             assert(this.state !== CertificateManagerState.Disposing);
             if (this.state === CertificateManagerState.Disposed) {
@@ -594,7 +606,7 @@ export class CertificateManager {
                     this._readCertificates(() => callback());
                 }
             });
-        }, callback);
+        }, callback as ErrorCallback);
     }
 
     public async dispose(): Promise<void> {
@@ -623,12 +635,13 @@ export class CertificateManager {
         }
     }
 
-    private withLock<C extends Function>(action: (callback: C) => void, callback: C) {
-        this
-            .withLock2(promisify<any>(action as any))
-            .then((t: any) => callback(null, t))
+    private withLock<T extends void = void>(action: (callback: Callback22) => void, callback: Callback22): void;
+    private withLock<T>(action: (callback: Callback11<T>) => void, callback: Callback11<T>): void;
+    // eslint-disable-next-line @typescript-eslint/ban-types
+    private withLock(action: Function, callback: Function): void {
+        this.withLock2(promisify<any>(action as any))
+            .then((t: unknown) => callback(null, t))
             .catch((err) => callback(err));
-
     }
     private async withLock2<T>(action: () => Promise<T>): Promise<T> {
         const lockFileName = path.join(this.rootDir, "mutex.lock");
@@ -644,21 +657,20 @@ export class CertificateManager {
     public async createSelfSignedCertificate(params: CreateSelfSignCertificateParam1): Promise<void>;
     public createSelfSignedCertificate(params: CreateSelfSignCertificateParam1, callback: ErrorCallback): void;
     public createSelfSignedCertificate(params: CreateSelfSignCertificateParam1, ...args: any[]): any {
-        const callback = args[0];
-        const self = this;
+        const callback = args[0] as ErrorCallback;
         assert(typeof params.applicationUri === "string", "expecting applicationUri");
-        if (!fs.existsSync(self.privateKey)) {
-            return callback(new Error("Cannot find private key " + self.privateKey));
+        if (!fs.existsSync(this.privateKey)) {
+            return callback(new Error("Cannot find private key " + this.privateKey));
         }
 
-        let certificateFilename = path.join(self.rootDir, "own/certs/self_signed_certificate.pem");
+        let certificateFilename = path.join(this.rootDir, "own/certs/self_signed_certificate.pem");
         certificateFilename = params.outputFile || certificateFilename;
 
-        const _params = (params as any) as CreateSelfSignCertificateWithConfigParam;
-        _params.rootDir = self.rootDir;
-        _params.configFile = self.configFile;
-        _params.privateKey = self.privateKey;
-        this.withLock<ErrorCallback>((callback) => {
+        const _params = params as unknown as CreateSelfSignCertificateWithConfigParam;
+        _params.rootDir = this.rootDir;
+        _params.configFile = this.configFile;
+        _params.privateKey = this.privateKey;
+        this.withLock((callback) => {
             createSelfSignCertificate(certificateFilename, _params, callback);
         }, callback);
     }
@@ -674,7 +686,7 @@ export class CertificateManager {
     ): any {
         assert(params);
         const _params = params as CreateSelfSignCertificateWithConfigParam;
-        if (_params.hasOwnProperty("rootDir")) {
+        if (Object.prototype.hasOwnProperty.call(_params, "rootDir")) {
             throw new Error("rootDir should not be specified ");
         }
         assert(typeof callback === "function");
@@ -685,22 +697,21 @@ export class CertificateManager {
         _params.configFile = this.configFile;
         _params.privateKey = this.privateKey;
 
-        this.withLock((callback) => {
+        this.withLock<string>((callback) => {
             // compose a file name for the request
             const now = new Date();
             const today = now.toISOString().slice(0, 10) + "_" + now.getTime();
             const certificateSigningRequestFilename = path.join(this.rootDir, "own/certs", "certificate_" + today + ".csr");
             createCertificateSigningRequest(certificateSigningRequestFilename, _params, (err?: Error) => {
-                return callback!(err!, certificateSigningRequestFilename);
+                if (err) {
+                    return callback(err);
+                }
+                return callback(null, certificateSigningRequestFilename);
             });
         }, callback);
     }
 
-    public async addIssuer(
-        certificate: DER,
-        validate: boolean = false,
-        addInTrustList: boolean = false
-    ): Promise<VerificationStatus> {
+    public async addIssuer(certificate: DER, validate = false, addInTrustList = false): Promise<VerificationStatus> {
         if (validate) {
             const status = await this.verifyCertificate(certificate);
             if (status !== VerificationStatus.Good && status !== VerificationStatus.BadCertificateUntrusted) {
@@ -826,10 +837,10 @@ export class CertificateManager {
             if (err) {
                 return callback(err);
             }
-            if (this._thumbs.rejected.hasOwnProperty(fingerprint)) {
+            if (Object.prototype.hasOwnProperty.call(this._thumbs.rejected, fingerprint)) {
                 return callback(null, "rejected");
             }
-            if (this._thumbs.trusted.hasOwnProperty(fingerprint)) {
+            if (Object.prototype.hasOwnProperty.call(this._thumbs.trusted, fingerprint)) {
                 return callback(null, "trusted");
             }
             return callback(null, "unknown");
@@ -861,8 +872,8 @@ export class CertificateManager {
                     newStatus === "rejected"
                         ? this.rejectedFolder
                         : newStatus === "trusted"
-                            ? this.trustedFolder
-                            : this.rejectedFolder;
+                        ? this.trustedFolder
+                        : this.rejectedFolder;
                 const certificateDest = path.join(destFolder, path.basename(certificateSrc));
 
                 debugLog("_moveCertificate1", fingerprint.substr(0, 10), "old name", certificateSrc);
@@ -911,8 +922,8 @@ export class CertificateManager {
         const serialNumber =
             certInfo.tbsCertificate.serialNumber || certInfo.tbsCertificate.extensions?.authorityKeyIdentifier?.serial || "";
 
-        const crl2 =
-            this._thumbs.crl[certInfo.tbsCertificate.extensions?.authorityKeyIdentifier?.authorityCertIssuerFingerPrint!] || null;
+        const key = certInfo.tbsCertificate.extensions?.authorityKeyIdentifier?.authorityCertIssuerFingerPrint || "<unknown>";
+        const crl2 = this._thumbs.crl[key] || null;
 
         if (crls.serialNumbers[serialNumber] || (crl2 && crl2.serialNumbers[serialNumber])) {
             return VerificationStatus.BadCertificateRevoked;
@@ -920,7 +931,7 @@ export class CertificateManager {
         return VerificationStatus.Good;
     }
 
-    private _pending_crl_to_process: number = 0;
+    private _pending_crl_to_process = 0;
     private _on_crl_process?: () => void;
     private queue: any[] = [];
     private _on_crl_file_added(index: { [key: string]: CRLData }, filename: string) {
@@ -1076,8 +1087,7 @@ export class CertificateManager {
     // make sure that all crls have been processed.
     private async waitAndCheckCRLProcessingStatus(): Promise<void> {
         return new Promise((resolve, reject) => {
-            const self = this;
-            if (self._pending_crl_to_process === 0) {
+            if (this._pending_crl_to_process === 0) {
                 setImmediate(resolve);
                 return;
             }
@@ -1090,9 +1100,6 @@ export class CertificateManager {
     }
 }
 
-// tslint:disable:no-var-requires
-// tslint:disable:max-line-length
-const thenify = require("thenify");
 const opts = { multiArgs: false };
 CertificateManager.prototype.rejectCertificate = thenify.withCallback(CertificateManager.prototype.rejectCertificate, opts);
 CertificateManager.prototype.trustCertificate = thenify.withCallback(CertificateManager.prototype.trustCertificate, opts);

package/lib/pki/templates/ca_config_template.cnf.ts

@@ -99,14 +99,14 @@ const config =
     "keyUsage                  = nonRepudiation, digitalSignature, keyEncipherment, dataEncipherment, keyAgreement\n" +
     "extendedKeyUsage          = critical,serverAuth ,clientAuth\n" +
     "subjectAltName            = $ENV::ALTNAME\n" +
-    'nsComment                 = "CA Generated by Node-OPCUA Certificate utility using openssl"\n' +
+    "nsComment                 = \"CA Generated by Node-OPCUA Certificate utility using openssl\"\n" +
     "[ v3_ca ]\n" +
     "subjectKeyIdentifier      = hash\n" +
     "authorityKeyIdentifier    = keyid:always,issuer:always\n" +
     "# authorityKeyIdentifier    = keyid\n" +
     "basicConstraints          = CA:TRUE\n" +
     "keyUsage                  = critical, cRLSign, keyCertSign\n" +
-    'nsComment                 = "CA Certificate generated by Node-OPCUA Certificate utility using openssl"\n' +
+    "nsComment                 = \"CA Certificate generated by Node-OPCUA Certificate utility using openssl\"\n" +
     "#nsCertType                 = sslCA, emailCA\n" +
     "#subjectAltName             = email:copy\n" +
     "#issuerAltName              = issuer:copy\n" +
@@ -118,7 +118,7 @@ const config =
     "basicConstraints          = critical, CA:FALSE\n" +
     "keyUsage                  = nonRepudiation, digitalSignature, keyEncipherment, dataEncipherment, keyAgreement\n" +
     "extendedKeyUsage          = critical,serverAuth ,clientAuth\n" +
-    'nsComment                 = "Self-signed certificate, generated by NodeOPCUA"\n' +
+    "nsComment                 = \"Self-signed certificate, generated by NodeOPCUA\"\n" +
     "subjectAltName            = $ENV::ALTNAME\n" +
     "\n" +
     "[ crl_ext ]\n" +

package/lib/pki/templates/simple_config_template.cnf.ts

@@ -15,7 +15,7 @@ const config =
     "# authorityKeyIdentifier    = keyid\n" +
     "basicConstraints            = CA:TRUE\n" +
     "keyUsage                    = critical, cRLSign, keyCertSign\n" +
-    'nsComment                   = "Self-signed Certificate for CA generated by Node-OPCUA Certificate utility"\n' +
+    "nsComment                   = \"Self-signed Certificate for CA generated by Node-OPCUA Certificate utility\"\n" +
     "#nsCertType                 = sslCA, emailCA\n" +
     "#subjectAltName             = email:copy\n" +
     "#issuerAltName              = issuer:copy\n" +
@@ -41,7 +41,7 @@ const config =
     "basicConstraints          = critical, CA:FALSE\n" +
     "keyUsage                  = nonRepudiation, digitalSignature, keyEncipherment, dataEncipherment, keyCertSign\n" +
     "extendedKeyUsage          = clientAuth,serverAuth \n" +
-    'nsComment                 = "certificate generated by Node-OPCUA Certificate utility and signed by a CA"\n' +
+    "nsComment                 = \"certificate generated by Node-OPCUA Certificate utility and signed by a CA\"\n" +
     "subjectAltName            = $ENV::ALTNAME\n" +
     "[ v3_selfsigned]\n" +
     "subjectKeyIdentifier      = hash\n" +
@@ -49,7 +49,7 @@ const config =
     "basicConstraints          = critical, CA:FALSE\n" +
     "keyUsage                  = nonRepudiation, digitalSignature, keyEncipherment, dataEncipherment, keyCertSign\n" +
     "extendedKeyUsage          = clientAuth,serverAuth \n" +
-    'nsComment                 = "Self-signed certificate generated by Node-OPCUA Certificate utility"\n' +
+    "nsComment                 = \"Self-signed certificate generated by Node-OPCUA Certificate utility\"\n" +
     "subjectAltName            = $ENV::ALTNAME\n" +
     "[ req_distinguished_name ]\n" +
     "countryName             = Country Name (2 letter code)\n" +

package/lib/pki/toolbox.ts

@@ -31,7 +31,6 @@ import * as child_process from "child_process";
 import * as fs from "fs";
 import * as os from "os";
 import * as path from "path";
-import * as util from "util";
 
 import { get_openssl_exec_path } from "../misc/install_prerequisite";
 import { Subject, SubjectOptions } from "../misc/subject";
@@ -42,18 +41,18 @@ import _simple_config_template from "./templates/simple_config_template.cnf";
 const exportedEnvVars: any = {};
 
 export function quote(str: string): string {
-    return '"' + str + '"';
+    return "\"" + str + "\"";
 }
 
 // tslint:disable-next-line:variable-name
 export const g_config = {
     opensslVersion: "unset",
-    silent: process.env.VERBOSE ? (!process.env.VERBOSE) : true,
+    silent: process.env.VERBOSE ? !process.env.VERBOSE : true,
     force: false,
 };
 
 const doDebug = process.env.NODEOPCUAPKIDEBUG || false;
-const displayError: boolean = true;
+const displayError = true;
 const displayDebug = !!process.env.NODEOPCUAPKIDEBUG || false;
 // tslint:disable-next-line:no-empty
 export function debugLog(...args: [any?, ...any[]]) {
@@ -95,11 +94,10 @@ export function setEnv(varName: string, value: string): void {
     if (["RANDFILE"].indexOf(varName) >= 0) {
         process.env[varName] = value;
     }
-
 }
 
 export function hasEnv(varName: string): boolean {
-    return exportedEnvVars.hasOwnProperty(varName);
+    return Object.prototype.hasOwnProperty.call(exportedEnvVars, varName);
 }
 
 export interface ExecuteOptions {
@@ -124,7 +122,7 @@ export function execute(cmd: string, options: ExecuteOptions, callback: (err: Er
         cmd,
         {
             cwd: options.cwd,
-            windowsHide: true
+            windowsHide: true,
         },
         (err: child_process.ExecException | null) => {
             // istanbul ignore next
@@ -174,7 +172,6 @@ export function useRandFile() {
 }
 
 function openssl_require2DigitYearInDate() {
-
     // istanbul ignore next
     if (!g_config.opensslVersion) {
         throw new Error(
@@ -276,9 +273,7 @@ export function execute_openssl_no_failure(
     execute_openssl(cmd, options, (err: Error | null, output?: string) => {
         // istanbul ignore next
         if (err) {
-            if (false) {
-                console.log(" (ignored error =  ERROR : )", err!.message);
-            }
+            debugLog(" (ignored error =  ERROR : )", err!.message);
         }
         callback(null, output);
     });
@@ -496,7 +491,7 @@ export function createCertificateSigningRequest(
 
     const subject = params.subject ? new Subject(params.subject).toString() : undefined;
     // process.env.OPENSSL_CONF  ="";
-    const subjectOptions = subject ? ' -subj "' + subject + '"' : "";
+    const subjectOptions = subject ? " -subj \"" + subject + "\"" : "";
     async.series(
         [
             (callback: (err?: Error) => void) => {
@@ -505,15 +500,15 @@ export function createCertificateSigningRequest(
             (callback: (err?: Error) => void) => {
                 execute_openssl(
                     "req -new" +
-                    "  -sha256 " +
-                    " -batch " +
-                    " -text " +
-                    configOption +
-                    " -key " +
-                    q(n(params.privateKey!)) +
-                    subjectOptions +
-                    " -out " +
-                    q(n(certificateSigningRequestFilename)),
+                        "  -sha256 " +
+                        " -batch " +
+                        " -text " +
+                        configOption +
+                        " -key " +
+                        q(n(params.privateKey!)) +
+                        subjectOptions +
+                        " -out " +
+                        q(n(certificateSigningRequestFilename)),
                     options,
                     (err: Error | null) => {
                         callback(err ? err : undefined);
@@ -678,13 +673,11 @@ export function createSelfSignCertificate(
     params: CreateSelfSignCertificateWithConfigParam,
     callback: (err?: Error | null) => void
 ) {
-
     ensure_openssl_installed((err) => {
         if (err) {
             return callback(err);
         }
         try {
-
             params.purpose = params.purpose || CertificatePurpose.ForApplication;
             assert(params.purpose, "Please provide a Certificate Purpose");
             /**
@@ -706,7 +699,7 @@ export function createSelfSignCertificate(
             processAltNames(params);
 
             adjustDate(params);
-            assert(params.hasOwnProperty("validity"));
+            assert(Object.prototype.hasOwnProperty.call(params, "validity"));
 
             let subject = new Subject(params.subject);
             subject = subject.toString();
@@ -718,15 +711,15 @@ export function createSelfSignCertificate(
 
             let extension: string;
             switch (params.purpose) {
-                case CertificatePurpose.ForApplication:
-                    extension = "v3_selfsigned";
-                    break;
-                case CertificatePurpose.ForCertificateAuthority:
-                    extension = "v3_ca";
-                    break;
-                case CertificatePurpose.ForUserAuthentication:
-                default:
-                    extension = "v3_selfsigned";
+            case CertificatePurpose.ForApplication:
+                extension = "v3_selfsigned";
+                break;
+            case CertificatePurpose.ForCertificateAuthority:
+                extension = "v3_ca";
+                break;
+            case CertificatePurpose.ForUserAuthentication:
+            default:
+                extension = "v3_selfsigned";
             }
 
             const tasks = [
@@ -741,19 +734,19 @@ export function createSelfSignCertificate(
                 (callback: ErrorCallback) => {
                     execute_openssl(
                         "req -new" +
-                        " -sha256 " +
-                        " -text " +
-                        " -extensions " +
-                        extension +
-                        " " +
-                        configOption +
-                        " -key " +
-                        q(n(params.privateKey!)) +
-                        " -out " +
-                        q(n(certificateRequestFilename)) +
-                        ' -subj "' +
-                        subject +
-                        '"',
+                            " -sha256 " +
+                            " -text " +
+                            " -extensions " +
+                            extension +
+                            " " +
+                            configOption +
+                            " -key " +
+                            q(n(params.privateKey!)) +
+                            " -out " +
+                            q(n(certificateRequestFilename)) +
+                            " -subj \"" +
+                            subject +
+                            "\"",
                         {},
                         callback
                     );
@@ -770,21 +763,21 @@ export function createSelfSignCertificate(
                 (callback: ErrorCallback) => {
                     execute_openssl(
                         " x509 -req " +
-                        " -days " +
-                        params.validity +
-                        " -extensions " +
-                        extension +
-                        " " +
-                        " -extfile " +
-                        q(n(configFile)) +
-                        " -in " +
-                        q(n(certificateRequestFilename)) +
-                        " -signkey " +
-                        q(n(params.privateKey!)) +
-                        " -text " +
-                        " -out " +
-                        q(certificate) +
-                        " -text ",
+                            " -days " +
+                            params.validity +
+                            " -extensions " +
+                            extension +
+                            " " +
+                            " -extfile " +
+                            q(n(configFile)) +
+                            " -in " +
+                            q(n(certificateRequestFilename)) +
+                            " -signkey " +
+                            q(n(params.privateKey!)) +
+                            " -text " +
+                            " -out " +
+                            q(certificate) +
+                            " -text ",
                         {},
                         callback
                     );
@@ -800,7 +793,6 @@ export function createSelfSignCertificate(
             callback(err as Error);
         }
     });
-
 }
 
 // tslint:disable-next-line:variable-name