node-opcua-address-space 2.90.0 → 2.90.1

package/src/ua_variable_type_impl.ts

@@ -40,6 +40,7 @@ import { _clone_children_references, ToStringBuilder, UAVariableType_toString }
 import * as tools from "./tool_isSupertypeOf";
 import { get_subtypeOfObj } from "./tool_isSupertypeOf";
 import { get_subtypeOf } from "./tool_isSupertypeOf";
+import { checkValueRankCompatibility } from "./check_value_rank_compatibility";
 
 const debugLog = make_debugLog(__filename);
 const doDebug = checkDebugFlag(__filename);
@@ -50,6 +51,7 @@ const errorLog = make_errorLog(__filename);
 let doTrace = checkDebugFlag("INSTANTIATE");
 const traceLog = errorLog;
 
+
 interface InstantiateS {
     propertyOf?: any;
     componentOf?: any;
@@ -83,7 +85,17 @@ export function topMostParentIsObjectTypeOrVariableType(addressSpace: AddressSpa
     return false;
 }
 export interface UAVariableTypeOptions extends InternalBaseNodeOptions {
-    /**  */
+    /**
+     * This attribute indicates whether the Value attribute of the Variableis an array and how many dimensions the array has.
+     * It may have the following values:
+     *   * n > 1: the Value is an array with the specified number of dimensions.
+     *   * OneDimension (1): The value is an array with one dimension.
+     *   * OneOrMoreDimensions (0): The value is an array with one or more dimensions.
+     *   * Scalar (−1): The value is not an array.
+     *   * Any (−2): The value can be a scalar or an array with any number of dimensions.
+     *   * ScalarOrOneDimension (−3): The value can be a scalar or a one dimensional array.
+     *   * All DataTypes are considered to be scalar, even if they have array-like semantics like ByteString and String.
+     */
     valueRank?: number;
     arrayDimensions?: number[] | null;
     historizing?: boolean;
@@ -227,6 +239,13 @@ export class UAVariableTypeImpl extends BaseNodeImpl implements UAVariableType {
         assert(dataType instanceof NodeId);
 
         const valueRank = options.valueRank !== undefined ? options.valueRank : this.valueRank;
+
+        const { result, errorMessage } = checkValueRankCompatibility(valueRank, this.valueRank);
+        if (!result) {
+            errorLog(errorMessage);
+            throw new Error(errorMessage);
+        }
+
         const arrayDimensions = options.arrayDimensions !== undefined ? options.arrayDimensions : this.arrayDimensions;
 
         // istanbul ignore next

package/test_helpers/test_fixtures/eurange_issue.xml

@@ -18,6 +18,7 @@
         <Alias Alias="HasProperty">i=46</Alias>
         <Alias Alias="HasSubtype">i=45</Alias>
         <Alias Alias="HasTypeDefinition">i=40</Alias>
+        <Alias Alias="PropertyType">i=68</Alias>
         <Alias Alias="Int32">i=6</Alias>
         <Alias Alias="Range">i=884</Alias>
         <Alias Alias="String">i=12</Alias>
@@ -33,7 +34,7 @@
 
     <UAVariable NodeId="ns=1;i=1301" BrowseName="Range" AccessLevel="3" DataType="Range">
         <References>
-            <Reference ReferenceType="HasTypeDefinition">i=1317</Reference>
+            <Reference ReferenceType="HasTypeDefinition">ns=1;i=1317</Reference>
             <Reference ReferenceType="HasModellingRule">i=78</Reference>
         </References>
         <Value>
@@ -54,7 +55,7 @@
     <UAVariableType NodeId="ns=1;i=1317" BrowseName="MyVariableType" AccessLevel="3" DataType="Range">
         <DisplayName>EURange</DisplayName>
         <References>
-            <Reference ReferenceType="HasSubtype" IsForward="false">i=68</Reference>
+            <Reference ReferenceType="HasSubtype" IsForward="false">PropertyType</Reference>
         </References>
         <Value>
             <ExtensionObject>