node-opcua-address-space 2.175.2 → 2.175.3

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "node-opcua-address-space",
-    "version": "2.175.2",
+    "version": "2.175.3",
     "description": "pure nodejs OPCUA SDK - module address-space",
     "main": "./dist/src/index_current.js",
     "types": "./dist/source/index.d.ts",
@@ -37,7 +37,7 @@
         "node-opcua-extension-object": "2.175.1",
         "node-opcua-factory": "2.175.1",
         "node-opcua-nodeid": "2.175.1",
-        "node-opcua-nodeset-ua": "2.175.2",
+        "node-opcua-nodeset-ua": "2.175.3",
         "node-opcua-numeric-range": "2.175.1",
         "node-opcua-object-registry": "2.175.1",
         "node-opcua-pseudo-session": "2.175.2",
@@ -59,7 +59,7 @@
         "humanize": "0.0.9",
         "node-opcua-benchmarker": "2.175.1",
         "node-opcua-leak-detector": "2.175.1",
-        "node-opcua-nodesets": "2.175.1",
+        "node-opcua-nodesets": "2.175.3",
         "node-opcua-packet-analyzer": "2.175.1",
         "node-opcua-schemas": "2.175.2",
         "node-opcua-service-filter": "2.175.2",
@@ -80,7 +80,7 @@
         "internet of things"
     ],
     "homepage": "http://node-opcua.github.io/",
-    "gitHead": "4e2a73e5b96bdf3bd3a88709c813289038caf19b",
+    "gitHead": "31f407d4ad2712b7bf2882d4dc70085f598b0fcd",
     "files": [
         "dist",
         "distHelpers",

package/src/nodeset_tools/construct_namespace_dependency.ts

@@ -71,13 +71,15 @@ export function _recomputeRequiredModelsFromTypes(namespace: INamespace, cache?:
 
         const namespaceIndex = dataType.namespace;
         consider(namespaceIndex);
+        // mark the dataType as visited *before* exploring its fields: a structure may refer to
+        // itself (directly or through a cycle), and marking it afterwards would recurse forever
+        _visitedDataType.add(dataType.toString());
         if (dataTypeNode.isStructure()) {
             const definition = dataTypeNode.getStructureDefinition();
             for (const field of definition.fields || []) {
                 exploreDataTypeField(field);
             }
         }
-        _visitedDataType.add(dataType.toString());
     }
 
     function exploreExtensionObject(e: ExtensionObject) {

package/src/ua_variable_impl.ts

@@ -758,26 +758,23 @@ export class UAVariableImpl<T extends UAVariableEvents & ListenerSignature<T>
             dataValue.value = variant1;
 
             if (dataValue.value.dataType === DataType.ExtensionObject) {
+                // early, detailed diagnostics on a malformed extension object (the actual throw
+                // happens below in _internal_set_dataValue).
                 const valueIsCorrect = this.checkExtensionObjectIsCorrect(dataValue.value.value);
                 if (!valueIsCorrect) {
                     errorLog("setValueFromSource Invalid value !");
                     errorLog(this.toString());
                     errorLog(dataValue.toString());
-                    this.checkExtensionObjectIsCorrect(dataValue.value.value);
                 }
-                // ----------------------------------
-                if (this.$extensionObject || this.$$extensionObjectArray) {
-                    // we have an extension object already bound to this node
-                    // the client is asking us to replace the object entirely by a new one
-                    // const ext = dataValue.value.value;
-                    this._internal_set_dataValue(dataValue);
-                    return;
-                } else {
-                    this.$dataValue = dataValue;
-                }
-            } else {
-                this._internal_set_dataValue(dataValue);
             }
+            // Route every value - scalar or ExtensionObject - through _internal_set_dataValue.
+            // This guarantees the change is consistently propagated to observers (historian,
+            // monitored items) and, when the node is a bound extension object (or a bound
+            // sub-structure child), cascaded through the proxy field setters by the overridden
+            // _inner_replace_dataValue. Previously ExtensionObject values were special-cased with a
+            // silent "this.$dataValue = dataValue" assignment that skipped notification for plain
+            // (unbound) extension object variables and threw on bound sub-structure children.
+            this._internal_set_dataValue(dataValue);
         } catch (err) {
             errorLog("UAVariable#setValueFromString Error : ", this.browseName.toString(), this.nodeId.toString());
             errorLog((err as Error).message);