node-opcua-address-space 2.112.0 → 2.113.1

package/distHelpers/add_event_generator_object.js

@@ -37,10 +37,6 @@ function add_eventGeneratorObject(namespace, parentFolder) {
         outputArguments: []
     });
     method.bindMethod((inputArguments, context, callback) => {
-        // xx console.log("In Event Generator Method");
-        // xx console.log(this.toString());
-        // xx console.log(context.object.toString());
-        // xx console.log("inputArguments ", inputArguments[0].toString());
         const message = inputArguments[0].value || "Hello from Event Generator Object";
         const severity = inputArguments[1].value || 0;
         const myEventType = namespace.addressSpace.findEventType("MyEventType", namespace.index);

package/distHelpers/add_event_generator_object.js.map

@@ -1 +1 @@
-{"version":3,"file":"add_event_generator_object.js","sourceRoot":"","sources":["../test_helpers/add_event_generator_object.ts"],"names":[],"mappings":";;;AAAA;;GAEG;AACH,mEAAgE;AAChE,2DAAuD;AAKvD,SAAgB,wBAAwB,CAAC,SAAqB,EAAE,YAA+B;IAC3F,MAAM,SAAS,GAAG,SAAS,CAAC,YAAY,CAAC;QACrC,UAAU,EAAE,aAAa;QACzB,SAAS,EAAE,eAAe,CAAC,qBAAqB;KACnD,CAAC,CAAC;IAEH,MAAM,QAAQ,GAAG,SAAS,CAAC,SAAS,CAAC;QACjC,UAAU,EAAE,sBAAsB;QAClC,aAAa,EAAE,CAAC;QAChB,WAAW,EAAE,YAAY;KAC5B,CAAC,CAAC;IAEH,QAAQ,CAAC,YAAY,CAAC;QAClB,MAAM,EAAE,SAAS;QACjB,aAAa,EAAE,sBAAsB;KACxC,CAAC,CAAC;IAEH,MAAM,MAAM,GAAG,SAAS,CAAC,SAAS,CAAC,QAAQ,EAAE;QACzC,UAAU,EAAE,sBAAsB;QAClC,cAAc,EAAE;YACZ;gBACI,QAAQ,EAAE,6BAAQ,CAAC,MAAM;gBACzB,WAAW,EAAE,EAAE,IAAI,EAAE,eAAe,EAAE;gBACtC,IAAI,EAAE,SAAS;aAClB;YACD;gBACI,QAAQ,EAAE,6BAAQ,CAAC,MAAM;gBACzB,WAAW,EAAE,EAAE,IAAI,EAAE,gBAAgB,EAAE;gBACvC,IAAI,EAAE,UAAU;aACnB;SACJ;QACD,eAAe,EAAE,EAAE;KACtB,CAAC,CAAC;IAEH,MAAM,CAAC,UAAU,CAAC,CAAC,cAAyB,EAAE,OAAwB,EAAE,QAA4C,EAAE,EAAE;QACpH,+CAA+C;QAC/C,mCAAmC;QACnC,6CAA6C;QAE7C,mEAAmE;QAEnE,MAAM,OAAO,GAAG,cAAc,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,mCAAmC,CAAC;QAC/E,MAAM,QAAQ,GAAG,cAAc,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,CAAC;QAE9C,MAAM,WAAW,GAAG,SAAS,CAAC,YAAY,CAAC,aAAa,CAAC,aAAa,EAAE,SAAS,CAAC,KAAK,CAAE,CAAC;QACzF,OAAO,CAAC,MAAmB,CAAC,UAAU,CAAC,WAAW,EAAE;YACjD,OAAO,EAAE;gBACL,QAAQ,EAAE,6BAAQ,CAAC,aAAa;gBAChC,KAAK,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE;aAC3B;YACD,QAAQ,EAAE;gBACN,QAAQ,EAAE,6BAAQ,CAAC,MAAM;gBACzB,KAAK,EAAE,QAAQ;aAClB;SACJ,CAAC,CAAC;QACH,MAAM,gBAAgB,GAAG;YACrB,eAAe,EAAE,EAAE;YACnB,UAAU,EAAE,oCAAW,CAAC,IAAI;SAC/B,CAAC;QACF,QAAQ,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;IACrC,CAAC,CAAC,CAAC;AACP,CAAC;AA7DD,4DA6DC"}
+{"version":3,"file":"add_event_generator_object.js","sourceRoot":"","sources":["../test_helpers/add_event_generator_object.ts"],"names":[],"mappings":";;;AAAA;;GAEG;AACH,mEAAgE;AAChE,2DAAuD;AAKvD,SAAgB,wBAAwB,CAAC,SAAqB,EAAE,YAA+B;IAC3F,MAAM,SAAS,GAAG,SAAS,CAAC,YAAY,CAAC;QACrC,UAAU,EAAE,aAAa;QACzB,SAAS,EAAE,eAAe,CAAC,qBAAqB;KACnD,CAAC,CAAC;IAEH,MAAM,QAAQ,GAAG,SAAS,CAAC,SAAS,CAAC;QACjC,UAAU,EAAE,sBAAsB;QAClC,aAAa,EAAE,CAAC;QAChB,WAAW,EAAE,YAAY;KAC5B,CAAC,CAAC;IAEH,QAAQ,CAAC,YAAY,CAAC;QAClB,MAAM,EAAE,SAAS;QACjB,aAAa,EAAE,sBAAsB;KACxC,CAAC,CAAC;IAEH,MAAM,MAAM,GAAG,SAAS,CAAC,SAAS,CAAC,QAAQ,EAAE;QACzC,UAAU,EAAE,sBAAsB;QAClC,cAAc,EAAE;YACZ;gBACI,QAAQ,EAAE,6BAAQ,CAAC,MAAM;gBACzB,WAAW,EAAE,EAAE,IAAI,EAAE,eAAe,EAAE;gBACtC,IAAI,EAAE,SAAS;aAClB;YACD;gBACI,QAAQ,EAAE,6BAAQ,CAAC,MAAM;gBACzB,WAAW,EAAE,EAAE,IAAI,EAAE,gBAAgB,EAAE;gBACvC,IAAI,EAAE,UAAU;aACnB;SACJ;QACD,eAAe,EAAE,EAAE;KACtB,CAAC,CAAC;IAEH,MAAM,CAAC,UAAU,CAAC,CAAC,cAAyB,EAAE,OAAwB,EAAE,QAA4C,EAAE,EAAE;QAEpH,MAAM,OAAO,GAAG,cAAc,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,mCAAmC,CAAC;QAC/E,MAAM,QAAQ,GAAG,cAAc,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,CAAC;QAE9C,MAAM,WAAW,GAAG,SAAS,CAAC,YAAY,CAAC,aAAa,CAAC,aAAa,EAAE,SAAS,CAAC,KAAK,CAAE,CAAC;QACzF,OAAO,CAAC,MAAmB,CAAC,UAAU,CAAC,WAAW,EAAE;YACjD,OAAO,EAAE;gBACL,QAAQ,EAAE,6BAAQ,CAAC,aAAa;gBAChC,KAAK,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE;aAC3B;YACD,QAAQ,EAAE;gBACN,QAAQ,EAAE,6BAAQ,CAAC,MAAM;gBACzB,KAAK,EAAE,QAAQ;aAClB;SACJ,CAAC,CAAC;QACH,MAAM,gBAAgB,GAAG;YACrB,eAAe,EAAE,EAAE;YACnB,UAAU,EAAE,oCAAW,CAAC,IAAI;SAC/B,CAAC;QACF,QAAQ,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;IACrC,CAAC,CAAC,CAAC;AACP,CAAC;AAxDD,4DAwDC"}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "node-opcua-address-space",
-    "version": "2.112.0",
+    "version": "2.113.1",
     "description": "pure nodejs OPCUA SDK - module address-space",
     "main": "./dist/src/index_current.js",
     "types": "./dist/source/index.d.ts",
@@ -22,36 +22,36 @@
         "chalk": "4.1.2",
         "dequeue": "^1.0.5",
         "lodash": "4.17.21",
-        "node-opcua-address-space-base": "2.112.0",
+        "node-opcua-address-space-base": "2.113.0",
         "node-opcua-assert": "2.105.0",
-        "node-opcua-basic-types": "2.111.0",
+        "node-opcua-basic-types": "2.113.0",
         "node-opcua-binary-stream": "2.110.0",
-        "node-opcua-client-dynamic-extension-object": "2.112.0",
+        "node-opcua-client-dynamic-extension-object": "2.113.0",
         "node-opcua-constants": "2.98.1",
-        "node-opcua-crypto": "4.4.0",
-        "node-opcua-data-access": "2.112.0",
-        "node-opcua-data-model": "2.112.0",
-        "node-opcua-data-value": "2.112.0",
-        "node-opcua-date-time": "2.111.0",
-        "node-opcua-debug": "2.110.0",
+        "node-opcua-crypto": "4.5.0",
+        "node-opcua-data-access": "2.113.0",
+        "node-opcua-data-model": "2.113.0",
+        "node-opcua-data-value": "2.113.0",
+        "node-opcua-date-time": "2.113.0",
+        "node-opcua-debug": "2.113.0",
         "node-opcua-enum": "2.110.0",
-        "node-opcua-extension-object": "2.112.0",
-        "node-opcua-factory": "2.112.0",
-        "node-opcua-nodeid": "2.110.0",
-        "node-opcua-nodeset-ua": "2.112.0",
-        "node-opcua-numeric-range": "2.112.0",
-        "node-opcua-object-registry": "2.110.0",
-        "node-opcua-pseudo-session": "2.112.0",
-        "node-opcua-service-browse": "2.112.0",
-        "node-opcua-service-call": "2.112.0",
-        "node-opcua-service-history": "2.112.0",
-        "node-opcua-service-translate-browse-path": "2.112.0",
-        "node-opcua-service-write": "2.112.0",
+        "node-opcua-extension-object": "2.113.0",
+        "node-opcua-factory": "2.113.0",
+        "node-opcua-nodeid": "2.113.0",
+        "node-opcua-nodeset-ua": "2.113.0",
+        "node-opcua-numeric-range": "2.113.0",
+        "node-opcua-object-registry": "2.113.0",
+        "node-opcua-pseudo-session": "2.113.0",
+        "node-opcua-service-browse": "2.113.0",
+        "node-opcua-service-call": "2.113.0",
+        "node-opcua-service-history": "2.113.0",
+        "node-opcua-service-translate-browse-path": "2.113.0",
+        "node-opcua-service-write": "2.113.0",
         "node-opcua-status-code": "2.110.0",
-        "node-opcua-types": "2.112.0",
+        "node-opcua-types": "2.113.0",
         "node-opcua-utils": "2.110.0",
-        "node-opcua-variant": "2.112.0",
-        "node-opcua-xml2json": "2.110.0",
+        "node-opcua-variant": "2.113.0",
+        "node-opcua-xml2json": "2.113.0",
         "semver": "^7.5.4",
         "set-prototype-of": "^1.0.0",
         "thenify": "^3.3.1",
@@ -60,11 +60,11 @@
     "devDependencies": {
         "mocha": "^10.2.0",
         "node-opcua-benchmarker": "2.110.0",
-        "node-opcua-leak-detector": "2.110.0",
+        "node-opcua-leak-detector": "2.113.0",
         "node-opcua-nodesets": "2.110.0",
-        "node-opcua-packet-analyzer": "2.112.0",
-        "node-opcua-service-filter": "2.112.0",
-        "node-opcua-test-fixtures": "2.112.0",
+        "node-opcua-packet-analyzer": "2.113.0",
+        "node-opcua-service-filter": "2.113.0",
+        "node-opcua-test-fixtures": "2.113.0",
         "should": "^13.2.3",
         "sinon": "^15.2.0",
         "source-map-support": "^0.5.21"
@@ -84,7 +84,7 @@
         "internet of things"
     ],
     "homepage": "http://node-opcua.github.io/",
-    "gitHead": "af1c21306612b11aa4265e9e6c094c91fe9beebb",
+    "gitHead": "5990ba93b03458f3d7304c36a99e5eb814bbcf3c",
     "files": [
         "dist",
         "distHelpers",

package/source/interfaces/alarms_and_conditions/condition_info_i.ts

@@ -10,6 +10,9 @@ export interface ConditionInfoOptions {
     quality?: StatusCode | null;
     severity?: UInt16 | null;
     retain?: boolean | null;
+
+    time?: Date | null;
+    receiveTime?: Date | null;
 }
 
 export interface ConditionInfo {

package/source/interfaces/alarms_and_conditions/condition_snapshot.ts

@@ -10,6 +10,7 @@ import { NodeId } from "node-opcua-nodeid";
 import { StatusCode } from "node-opcua-status-code";
 import { TimeZoneDataType } from "node-opcua-types";
 import { UtcTime } from "../state_machine/ua_state_machine_type";
+import { ISetStateOptions } from "../i_set_state_options";
 
 export interface ConditionSnapshot {
     on(eventName: "value_changed", eventHandler: (node: UAVariable, variant: Variant) => void): this;
@@ -62,7 +63,7 @@ export interface ConditionSnapshot extends EventEmitter {
      * @param value {Boolean}
      * @return void
      */
-    setEnabledState(value: boolean): void;
+    setEnabledState(value: boolean, options?: ISetStateOptions): void;
     /**
      * @method getEnabledStateAsString
      * @return {String}

package/source/interfaces/alarms_and_conditions/ua_condition_ex.ts

@@ -4,10 +4,11 @@ import { NodeId } from "node-opcua-nodeid";
 import { UACondition_Base } from "node-opcua-nodeset-ua";
 import { StatusCode } from "node-opcua-status-code";
 import { TimeZoneDataType } from "node-opcua-types";
+import { DataType } from "node-opcua-basic-types";
+import { ISetStateOptions } from "../i_set_state_options";
 import { UATwoStateVariableEx } from "../../ua_two_state_variable_ex";
 import { ConditionInfoOptions } from "./condition_info_i";
 import { ConditionSnapshot } from "./condition_snapshot";
-import { DataType } from "node-opcua-basic-types";
 
 
 
@@ -26,6 +27,7 @@ export interface UAConditionHelper {
     on(eventName: "branch_deleted", eventHandler: (branchId: string) => void): this;
 }
 
+
 export interface UAConditionHelper extends UABaseEventHelper {
     getBranchCount(): number;
     getBranches(): ConditionSnapshot[];
@@ -34,7 +36,7 @@ export interface UAConditionHelper extends UABaseEventHelper {
     deleteBranch(branch: ConditionSnapshot): void;
     getEnabledState(): boolean;
     getEnabledStateAsString(): string;
-    setEnabledState(requestedEnabledState: boolean): StatusCode;
+    setEnabledState(requestedEnabledState: boolean, options?: ISetStateOptions): StatusCode;
     setReceiveTime(time: Date): void;
     setLocalTime(time: TimeZoneDataType): void;
     setTime(time: Date): void;

package/source/interfaces/data_access/ua_multistate_discrete_ex.ts

@@ -13,6 +13,7 @@ import { DataType, Variant } from "node-opcua-variant";
 import { StatusCode } from "node-opcua-status-code";
 import { UAMultiStateDiscrete_Base } from "node-opcua-nodeset-ua";
 import { UAVariableT } from "node-opcua-address-space-base";
+import { ISetStateOptions } from "../i_set_state_options";
 
 export { UAMultiStateDiscrete } from "node-opcua-nodeset-ua";
 
@@ -21,6 +22,6 @@ export interface UAMultiStateDiscreteEx<T, DT extends DataType> extends UAVariab
     getValue(): number;
     getValueAsString(): string;
     getIndex(value: string): number;
-    setValue(value: string | number): void;
+    setValue(value: string | number, options?: ISetStateOptions): void;
     checkVariantCompatibility(value: Variant): StatusCode;
 }

package/source/interfaces/data_access/ua_multistate_value_discrete_ex.ts

@@ -5,6 +5,7 @@ import { DataType, Variant } from "node-opcua-variant";
 import { Int64, UInt64 } from "node-opcua-basic-types";
 import { UAMultiStateValueDiscrete_Base } from "node-opcua-nodeset-ua";
 import { UAVariableT } from "node-opcua-address-space-base";
+import { ISetStateOptions } from "../i_set_state_options";
 
 /**
  * @see https://reference.opcfoundation.org/v104/Core/docs/Part8/5.3.3/#5.3.3.4
@@ -27,7 +28,7 @@ export interface UAMultiStateValueDiscreteEx<T, DT extends DataType>
     getValueAsString(): string;
     getValueAsNumber(): number;
 
-    setValue(value: string | number | Int64): void;
+    setValue(value: string | number | Int64, options?: ISetStateOptions): void;
 
     findValueAsText(value: number | UInt64): Variant;
 }

package/source/interfaces/data_access/ua_two_state_discrete_ex.ts

@@ -2,6 +2,7 @@ import { LocalizedTextLike } from "node-opcua-data-model";
 import { DataType } from "node-opcua-variant";
 import { UAVariableT } from "node-opcua-address-space-base";
 import { UATwoStateDiscrete_Base } from "node-opcua-nodeset-ua";
+import { ISetStateOptions } from "../i_set_state_options";
 
 /**
  * @see https://reference.opcfoundation.org/v104/Core/VariableTypes/TwoStateDiscreteType/
@@ -10,5 +11,5 @@ export interface UATwoStateDiscreteEx extends UAVariableT<boolean, DataType.Bool
     // --- helpers ---
     getValue(): boolean;
     getValueAsString(): string;
-    setValue(value: boolean | LocalizedTextLike): void;
+    setValue(value: boolean | LocalizedTextLike, options?: ISetStateOptions): void;
 }

package/source/interfaces/i_set_state_options.ts

@@ -0,0 +1,4 @@
+export interface ISetStateOptions {
+    transitionTime?: Date;
+    effectiveTransitionTime?: Date;
+}

package/source/loader/decode_xml_extension_object.ts

@@ -18,7 +18,6 @@ function encodingNodeIdToDataTypeNode(addressSpace: IAddressSpace, encodingNodeI
     if (!encodingNode) {
         throw new Error("findDataTypeNode:  Cannot find encoding NodeId" + encodingNodeId.toString());
     }
-    // xx console.log("encodingNode", encodingNode.toString());
     const refs = encodingNode.findReferences("HasEncoding", false);
     const dataTypes = refs.map((ref) => addressSpace.findNode(ref.nodeId)).filter((obj: any) => obj !== null);
     // istanbul ignore next
@@ -40,7 +39,6 @@ export function makeDefinitionMap(addressSpace: IAddressSpace): DefinitionMap2 {
                 throw new Error("Expecting a DataType node here");
             }
             const name = dataTypeNode.browseName.name || "";
-            // console.log("yy)=", dataTypeNode.toString());
             if (dataTypeNode.isStructure()) {
                 const definition = dataTypeNode.getStructureDefinition();
                 return { name, definition };

package/source/loader/load_nodeset2.ts

@@ -881,10 +881,12 @@ function makeNodeSetParserEngine(addressSpace: IAddressSpace, options: NodeSetLo
                             break;
                         }
                         let captureXmlBody = this.bodyXML;
+                        // istanbul ignore next
                         if (doDebug) {
                             debugLog("xxxx ", chalk.yellow(captureXmlBody));
                         }
                         // this is a user defined Extension Object
+                        // istanbul ignore next
                         debugLog(
                             "load nodeset2: typeDefinitionId in ExtensionObject Default XML = " + xmlEncodingNodeId.toString()
                         );
@@ -1699,7 +1701,7 @@ function makeNodeSetParserEngine(addressSpace: IAddressSpace, options: NodeSetLo
                     // istanbul ignore next
                     // tslint:disable:no-console
                     if (types.isNativeError(err)) {
-                        console.log(" performPostLoadingTasks Err  => ", err.message, "\n", err);
+                        errorLog(" performPostLoadingTasks Err  => ", err.message, "\n", err);
                     }
                     await task(addressSpace1);
                 }
@@ -1748,7 +1750,7 @@ function makeNodeSetParserEngine(addressSpace: IAddressSpace, options: NodeSetLo
         finalSteps()
             .then(() => callback!())
             .catch((err1: Error) => {
-                console.log("Error ", renderError(err1));
+                errorLog("Error ", renderError(err1));
                 callback!(err1);
             });
     }

package/source/loader/make_xml_extension_object_parser.ts

@@ -210,7 +210,7 @@ const partials: { [key: string]: ReaderStateParserLike } = {
     Variant: {
         finish(this: any) {
             /** to do */
-            console.log(" Missing  Implemntation contact sterfive.com!");
+            warningLog(" Missing  Implemntation contact sterfive.com!");
         }
     },
 
@@ -279,8 +279,6 @@ function _makeTypeReader(
     const { name, definition } = definitionMap.findDefinition(n);
     const dataTypeName = name;
 
-    // console.log("NAME = ", dataTypeNodeId.toString(), name, definition);
-
     let reader: ReaderStateParserLike = readerMap[dataTypeName]!;
 
     if (reader) {
@@ -355,7 +353,6 @@ function _makeTypeReader(
         readerMap[dataTypeName] = reader;
         return { name, parser: reader };
     } else if (definition instanceof EnumDefinition) {
-        //  console.log("xxxx enum found !", definition.toString());
         const turnToInt = (value: any) => {
             // Green_100
             return parseInt(value.split("_")[1], 10);

package/source/loader/namespace_post_step.ts

@@ -43,6 +43,7 @@ export async function promoteObjectAndVariablesInNamespace(namespace: INamespace
 
                     promoter.promoter(a as any);
                     const after = a.constructor.name;
+                    // istanbul ignore next
                     if (doDebug) {
                         debugLog(`promoting ${a.browseName.toString()} from ${before} to ${after}`);
                     }

package/source/ua_two_state_variable_ex.ts

@@ -5,6 +5,7 @@ import { UAVariableT } from "node-opcua-address-space-base";
 import { LocalizedText } from "node-opcua-data-model";
 import { UAStateVariable, UATwoStateVariable_Base } from "node-opcua-nodeset-ua";
 import { DataType } from "node-opcua-variant";
+import { ISetStateOptions } from "./interfaces/i_set_state_options";
 
 /**
  * @see https://reference.opcfoundation.org/v104/Core/docs/Part9/5.2/
@@ -18,7 +19,7 @@ export interface UATwoStateVariableHelper {
     readonly isTrueSubStateOf: UAStateVariable<LocalizedText> | null;
 
     // --- helpers ---
-    setValue(boolValue: boolean): void;
+    setValue(boolValue: boolean, options?: ISetStateOptions): void;
 
     getValue(): boolean;
 

package/src/address_space.ts

@@ -56,7 +56,7 @@ import {
     ShutdownTask,
     RaiseEventData
 } from "node-opcua-address-space-base";
-import { make_errorLog } from "node-opcua-debug";
+import { make_debugLog, make_errorLog } from "node-opcua-debug";
 
 import { adjustBrowseDirection } from "../source/helpers/adjust_browse_direction";
 import { UARootFolder } from "../source/ua_root_folder";
@@ -79,6 +79,7 @@ import { BaseNodeImpl } from "./base_node_impl";
 
 const doDebug = false;
 const errorLog = make_errorLog(__filename);
+const debugLog = make_debugLog(__filename);
 
 // tslint:disable-next-line:no-var-requires
 const Dequeue = require("dequeue");
@@ -773,17 +774,18 @@ export class AddressSpace implements AddressSpacePrivate {
                 // add a property , but with a null variant
                 eventData._createValue(fullBrowsePath, node, { dataType: DataType.Null });
 
+                // istanbul ignore next
                 if (doDebug) {
                     if (node.modellingRule === "Mandatory") {
                         // tslint:disable:no-console
-                        console.log(
+                        errorLog(
                             chalk.red("ERROR : AddressSpace#constructEventData(eventType,options) " + "cannot find property ") +
                                 self.browseName.toString() +
                                 " => " +
                                 chalk.cyan(lowerName)
                         );
                     } else {
-                        console.log(
+                        errorLog(
                             chalk.yellow(
                                 "Warning : AddressSpace#constructEventData(eventType,options)" + " cannot find property "
                             ) +
@@ -842,18 +844,16 @@ export class AddressSpace implements AddressSpacePrivate {
 
             // istanbul ignore next
             if (doDebug) {
-                console.log(" " + chalk.bgWhite.cyan(self.browseName.toString()));
+                debugLog(" " + chalk.bgWhite.cyan(self.browseName.toString()));
             }
 
             for (const node of children) {
                 // only keep those that have a "HasModellingRule"
                 if (!(node as any).modellingRule) {
-                    // xx console.log(" skipping node without modelling rule", node.browseName.toString());
                     continue;
                 }
                 // ignore also methods
                 if (node.nodeClass === NodeClass.Method) {
-                    // xx console.log(" skipping method ", node.browseName.toString());
                     continue;
                 }
 
@@ -866,8 +866,6 @@ export class AddressSpace implements AddressSpacePrivate {
                 if (children2.length > 0) {
                     const lowerName = lowerFirstLetter(node.browseName.name!);
                     const standardName = node.browseName.toString();
-                    //  console.log(" Children to visit = ",lowerName,
-                    //  children.map(function(a){ return a.browseName.toString();}).join(" "));
                     for (const child2 of children2) {
                         _process_var(self, lowerName + ".", standardName + ".", child2);
                     }
@@ -1027,7 +1025,7 @@ export class AddressSpace implements AddressSpacePrivate {
         // to do verify that dataType is of type "Structure"
         /* istanbul ignore next */
         if (!_dataType.isSubtypeOf(this.findDataType("Structure")!)) {
-            console.log(_dataType.toString());
+            debugLog(_dataType.toString());
         }
         assert(_dataType.isSubtypeOf(this.findDataType("Structure")!));
         if (!_dataType._extensionObjectConstructor) {
@@ -1144,7 +1142,6 @@ export class AddressSpace implements AddressSpacePrivate {
         if (!obj) {
             // Object Not Found
             browseResult.statusCode = StatusCodes.BadNodeIdUnknown;
-            // xx console.log("xxxxxx browsing ",nodeId.toString() , " not found" );
         } else {
             browseResult.statusCode = StatusCodes.Good;
             browseResult.references = obj.browseNode(browseDescription, context);
@@ -1172,7 +1169,6 @@ export class AddressSpace implements AddressSpacePrivate {
      * @private
      */
     public _collectModelChange(view: UAView | null, modelChange: ModelChangeStructureDataType): void {
-        // xx console.log("in _collectModelChange", modelChange.verb, verbFlags.get(modelChange.verb).toString());
         this._modelChanges.push(modelChange);
     }
 
@@ -1253,7 +1249,6 @@ export class AddressSpace implements AddressSpacePrivate {
                 if (this._modelChanges.length === 0) {
                     return; // nothing to do
                 }
-                // xx console.log( "xx dealing with ",this._modelChanges.length);
                 // increase version number of participating nodes
 
                 // https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore
@@ -1269,7 +1264,6 @@ export class AddressSpace implements AddressSpacePrivate {
                     const eventTypeNode = this.findEventType("GeneralModelChangeEventType");
 
                     if (eventTypeNode) {
-                        // xx console.log("xx raising event on server object");
                         this.rootFolder.objects.server.raiseEvent(eventTypeNode, {
                             // Part 5 - 6.4.32 GeneralModelChangeEventType
                             changes: {
@@ -1421,7 +1415,6 @@ export class AddressSpace implements AddressSpacePrivate {
             const typeDefinitionNode = this.findNode(typeDefinition)!;
             typeDefinition = typeDefinitionNode.nodeId;
         }
-        // xx console.log("typeDefinition = ",typeDefinition);
         assert(typeDefinition instanceof NodeId);
         return typeDefinition;
     }
@@ -1573,6 +1566,5 @@ function _increase_version_number(node: BaseNode | null) {
             dataType: DataType.String,
             value: (previousValue + 1).toString()
         });
-        // xx console.log("xxx increasing version number of node ", node.browseName.toString(),previousValue);
     }
 }

package/src/alarms_and_conditions/condition.ts

@@ -21,7 +21,7 @@ export function _setAckedState(
     if (ackedState && requestedAckedState) {
         return StatusCodes.BadConditionBranchAlreadyAcked;
     }
-    self._set_twoStateVariable("AckedState", requestedAckedState);
+    self._set_twoStateVariable("AckedState", requestedAckedState,/* effective transition time will be now*/);
     return StatusCodes.Good;
 }
 

package/src/alarms_and_conditions/condition_snapshot_impl.ts

@@ -17,6 +17,7 @@ import { DataType, Variant } from "node-opcua-variant";
 
 import { ConditionSnapshot } from "../../source/interfaces/alarms_and_conditions/condition_snapshot";
 import { UtcTime } from "../../source/interfaces/state_machine/ua_state_machine_type";
+import { ISetStateOptions } from "../../source/interfaces/i_set_state_options";
 import { EventData } from "../event_data";
 import { UATwoStateVariableImpl } from "../state_machine/ua_two_state_variable";
 import { _setAckedState } from "./condition";
@@ -136,6 +137,7 @@ const _varTable = {
     "EnabledState.EffectiveDisplayName": 1,
     "EnabledState.Id": 1,
     "EnabledState.TransitionTime": 1,
+    "EnabledState.EffectiveTransitionTime": 1,
     EventId: 1,
     EventType: 1,
     LocalTime: 1,
@@ -143,6 +145,8 @@ const _varTable = {
     SourceNode: 1,
     Time: 1
 };
+
+
 type FullBrowsePath = string;
 export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnapshot {
     public static normalizeName = normalizeName;
@@ -222,7 +226,7 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
     public _get_var(varName: string): any {
         const c = this.condition as UAConditionImpl;
         if (!c.getEnabledState() && !Object.prototype.hasOwnProperty.call(_varTable, varName)) {
-            // xx console.log("ConditionSnapshot#_get_var condition enabled =", self.condition.getEnabledState());
+            // xx debuglog("ConditionSnapshot#_get_var condition enabled =", self.condition.getEnabledState());
             return disabledVar;
         }
 
@@ -238,6 +242,7 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
         const key = normalizeName(varName);
         // istanbul ignore next
         if (!Object.prototype.hasOwnProperty.call(this._map, key)) {
+            // istanbul ignore next
             if (doDebug) {
                 debugLog(" cannot find node " + varName);
                 debugLog("  map=", Object.keys(this._map).join(" "));
@@ -310,9 +315,6 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
         const eventId = addressSpace.generateEventId();
         const ret = this._set_var("EventId", DataType.ByteString, eventId.value);
 
-        // xx var branch = self; console.log("MMMMMMMMrenewEventId branch  " +
-        // branch.getBranchId().toString() + " eventId = " + branch.getEventId().toString("hex"));
-
         return ret;
     }
 
@@ -329,8 +331,8 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
      * @param value {Boolean}
      * @return void
      */
-    public setEnabledState(value: boolean): void {
-        return this._set_twoStateVariable("EnabledState", value);
+    public setEnabledState(value: boolean, options?: ISetStateOptions): void {
+        return this._set_twoStateVariable("EnabledState", value, options);
     }
 
     /**
@@ -615,7 +617,7 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
         return this._get_twoStateVariable("ConfirmedState");
     }
 
-    public setConfirmedStateIfExists(confirmedState: boolean): void {
+    public setConfirmedStateIfExists(confirmedState: boolean, options?: ISetStateOptions): void {
         confirmedState = !!confirmedState;
         const acknowledgeableCondition = this.condition as UAAcknowledgeableCondition;
         if (!acknowledgeableCondition.confirmedState) {
@@ -624,7 +626,7 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
             return;
         }
         // todo deal with Error code BadConditionBranchAlreadyConfirmed
-        return this._set_twoStateVariable("ConfirmedState", confirmedState);
+        return this._set_twoStateVariable("ConfirmedState", confirmedState, options);
     }
 
     public setConfirmedState(confirmedState: boolean): void {
@@ -649,21 +651,21 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
      * @method setSuppressedState
      * @param suppressed {Boolean}
      */
-    public setSuppressedState(suppressed: boolean): void {
+    public setSuppressedState(suppressed: boolean, options?: ISetStateOptions): void {
         suppressed = !!suppressed;
-        this._set_twoStateVariable("SuppressedState", suppressed);
+        this._set_twoStateVariable("SuppressedState", suppressed, options);
     }
 
     public getActiveState(): boolean {
         return this._get_twoStateVariable("ActiveState");
     }
 
-    public setActiveState(newActiveState: boolean): StatusCode {
+    public setActiveState(newActiveState: boolean, options?: ISetStateOptions): StatusCode {
         // xx var activeState = self.getActiveState();
         // xx if (activeState === newActiveState) {
         // xx     return StatusCodes.Bad;
         // xx }
-        this._set_twoStateVariable("ActiveState", newActiveState);
+        this._set_twoStateVariable("ActiveState", newActiveState, options);
         return StatusCodes.Good;
     }
 
@@ -706,7 +708,7 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
      * @param value
      * @private
      */
-    public _set_twoStateVariable(varName: string, value: boolean): void {
+    public _set_twoStateVariable(varName: string, value: boolean, options?: ISetStateOptions): void {
         value = !!value;
 
         const hrKey = ConditionSnapshotImpl.normalizeName(varName);
@@ -735,9 +737,7 @@ export class ConditionSnapshotImpl extends EventEmitter implements ConditionSnap
         // also change ConditionNode if we are on currentBranch
         if (this.isCurrentBranch()) {
             assert(twoStateNode instanceof UATwoStateVariableImpl);
-            twoStateNode.setValue(value as boolean);
-            // xx console.log("Is current branch", twoStateNode.toString(),variant.toString());
-            // xx console.log("  = ",twoStateNode.getValue());
+            twoStateNode.setValue(value as boolean, options);
         }
         this.emit("value_changed", node, variant);
     }

package/src/alarms_and_conditions/ua_acknowledgeable_condition_impl.ts

@@ -9,6 +9,7 @@ import { CallbackT, StatusCode, StatusCodes } from "node-opcua-status-code";
 import { DataType, VariantLike, VariantOptions } from "node-opcua-variant";
 import { INamespace, RaiseEventData, ISessionContext, UAEventType, UAMethod } from "node-opcua-address-space-base";
 import { CallMethodResultOptions } from "node-opcua-service-call";
+import { make_debugLog } from "node-opcua-debug";
 
 import { AddressSpacePrivate } from "../address_space_private";
 import { _install_TwoStateVariable_machinery } from "../state_machine/ua_two_state_variable";
@@ -20,7 +21,8 @@ import { _setAckedState } from "./condition";
 import { ConditionSnapshotImpl } from "./condition_snapshot_impl";
 import {  UAConditionImpl } from "./ua_condition_impl";
 
-
+const debugLog = make_debugLog(__filename);
+const doDebug = false;;
 export declare interface UAAcknowledgeableConditionImpl extends UAAcknowledgeableConditionEx, UAConditionImpl {
     on(eventName: string, eventHandler: any): this;
 }
@@ -258,8 +260,9 @@ export class UAAcknowledgeableConditionImpl extends UAConditionImpl implements U
         }
         assert(!branch.getConfirmedState(), "already confirmed ?");
         const conditionEventId = branch.getEventId();
-        // tslint:disable-next-line:no-console
-        console.log("autoConfirmBranch getAckedState ", branch.getAckedState());
+
+        // istanbul ignore next
+        doDebug && debugLog("autoConfirmBranch getAckedState ", branch.getAckedState());
         this._confirm_branch(conditionEventId, comment, branch, "Server/Confirm");
     }