node-opcua-address-space-for-conformance-testing 2.183.0 → 2.184.0

package/src/conformance_testing/ctt_folder.ts

@@ -109,10 +109,7 @@ function addBooleanScalarAndArray(ctt: CttFolder): void {
     ctt.typedVariable("Static/All Profiles/Arrays/Bool", "Boolean", 1);
 }
 
-// The one place this module learns where it sits on disk. `import.meta.dirname`
-// cannot be used while this package emits CommonJS (TS1470), so the ESM migration
-// has this single line to change rather than several scattered uses.
-const here = __dirname;
+const here = import.meta.dirname;
 
 function addImageVariable(ctt: CttFolder): void {
     // the abstract Image data type (the concrete ImagePNG/GIF/JPG/BMP nodes live under Simulation)
@@ -179,7 +176,7 @@ function addAnalogItemArrays(ctt: CttFolder): void {
         // element at engineeringUnitsRange.low, rather than a fixed 0 that falls outside an
         // unsigned range, keeps the node's own initial value conformant (PercentDeadband 006).
         const { engineeringUnitsRange, instrumentRange } = makeRange(dataType);
-        ctt.namespace.addAnalogDataItem({
+        const analogItem = ctt.namespace.addAnalogDataItem({
             organizedBy: folder,
             browseName: dataTypeName,
             nodeId: ctt.nodeId(`Static/DA Profile/AnalogItemType Arrays/${dataTypeName}`),
@@ -198,6 +195,19 @@ function addAnalogItemArrays(ctt: CttFolder): void {
             accessLevel: readWrite,
             userAccessLevel: readWrite
         });
+        // addAnalogDataItem builds EngineeringUnits read-only, EURange and InstrumentRange
+        // writable. A CTT run has to be able to change all three: Data Access Semantic Changes 013
+        // writes the three properties of these six items in one Write, and the six BadNotWritable
+        // results - legal, and on the script's accepted list - make it null those entries and then
+        // reuse the full-length expected-results array for its revert write, which its own
+        // WriteHelper refuses ("ExpectedOperationResultsArray[] (length: 18) must have the same
+        // size as Request.NodesToWrite[] (length: 12)"). Writable here, where the test nodes are
+        // configured, rather than changing what addAnalogDataItem gives every other server.
+        const engineeringUnitsProperty = analogItem.getPropertyByName("EngineeringUnits");
+        if (engineeringUnitsProperty) {
+            engineeringUnitsProperty.accessLevel = readWrite;
+            engineeringUnitsProperty.userAccessLevel = readWrite;
+        }
     }
 }
 
@@ -249,8 +259,19 @@ function addArrayItems(ctt: CttFolder): void {
             userAccessLevel: readWrite,
             value: options.value
         });
+        // the mandatory Properties of ArrayItemType are declared in namespace 0, so their
+        // BrowseName is 0:EURange and not <this namespace>:EURange - a client translating the
+        // standard browse path finds nothing otherwise. CTT Data Access Semantic Changes 014-017
+        // warned "Mandatory property 'EURange' missing" on every one of these nodes.
         const property = (browseName: string, dataType: string, value: Variant, valueRank = -1) =>
-            namespace.addVariable({ propertyOf: v, browseName, dataType, valueRank, value, modellingRule: "Mandatory" });
+            namespace.addVariable({
+                propertyOf: v,
+                browseName: { namespaceIndex: 0, name: browseName },
+                dataType,
+                valueRank,
+                value,
+                modellingRule: "Mandatory"
+            });
         property("Title", "LocalizedText", new Variant({ dataType: DataType.LocalizedText, value: { text: typeName } }));
         property("AxisScaleType", "AxisScaleEnumeration", new Variant({ dataType: DataType.Int32, value: 0 }));
         property("EURange", "Range", extensionObject(addressSpace.constructExtensionObject(rangeType, { low: 0, high: 100 })));

package/src/conformance_testing/simulation_variables.ts

@@ -23,7 +23,7 @@ export function addSimulationVariables(namespace: Namespace, scalarFolder: UAObj
         const dataType = findDataType(realTypeName);
         const randomFunc = getRandomFuncForType(dataType, custom);
 
-        // c8 ignore next
+        /* c8 ignore next */
         if (typeof randomFunc !== "function") {
             throw new Error(`a random function must exist for basicType ${dataTypeName}`);
         }

package/src/conformance_testing/static_variables.ts

@@ -13,10 +13,7 @@ import { typeAndDefaultValue } from "./type_defaults.js";
 
 const errorLog = make_errorLog("static_variables");
 
-// The one place this module learns where it sits on disk. `import.meta.dirname`
-// cannot be used while this package emits CommonJS (TS1470), so the ESM migration
-// has this single line to change rather than several scattered uses.
-const here = __dirname;
+const here = import.meta.dirname;
 
 export async function addStaticVariables(
     namespace: Namespace,