node-mac-recorder 2.8.2 → 2.8.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.8.2",
+	"version": "2.8.4",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/window_selector.mm

@@ -17,7 +17,8 @@ static NSView *g_overlayView = nil;
 static WindowSelectorOverlayView *g_selectedOverlayView = nil; // Track selected overlay
 static NSButton *g_selectButton = nil;
 static NSTimer *g_trackingTimer = nil;
-static NSDictionary *g_selectedWindowInfo = nil;
+static NSDictionary *g_selectedWindowInfo = nil; // Window info for recording
+static NSDictionary *g_clickedWindowInfo = nil; // Separate state for clicked selection (NOT for recording)
 static NSMutableArray *g_allWindows = nil;
 static NSDictionary *g_currentWindowUnderCursor = nil;
 static bool g_bringToFrontEnabled = true; // Default enabled
@@ -133,10 +134,10 @@ void updateScreenOverlays();
             // Deselect this window - return to normal highlight behavior
             self.isSelectedWindow = NO;
             
-            // Clear global selection
-            if (g_selectedWindowInfo) {
-                [g_selectedWindowInfo release];
-                g_selectedWindowInfo = nil;
+            // Clear global clicked selection (NOT recording selection)
+            if (g_clickedWindowInfo) {
+                [g_clickedWindowInfo release];
+                g_clickedWindowInfo = nil;
             }
             g_selectedOverlayView = nil;
             
@@ -150,19 +151,19 @@ void updateScreenOverlays();
                 [g_selectedOverlayView updateAppearance];
             }
             
-            // Select this window
+            // Select this window (for visual selection only, NOT for recording)
             self.isSelectedWindow = YES;
             
-            // Update global selected window info
-            if (g_selectedWindowInfo) {
-                [g_selectedWindowInfo release];
+            // Update global clicked window info (separate from recording selection)
+            if (g_clickedWindowInfo) {
+                [g_clickedWindowInfo release];
             }
-            g_selectedWindowInfo = [self.windowInfo retain];
+            g_clickedWindowInfo = [self.windowInfo retain];
             
             // Update global selected overlay reference
             g_selectedOverlayView = self;
             
-            NSLog(@"🎯 WINDOW SELECTED - Highlight blocked on this window: %@ - \"%@\"", 
+            NSLog(@"🎯 WINDOW CLICKED - Visual selection only (NOT recording): %@ - \"%@\"", 
                   [self.windowInfo objectForKey:@"appName"] ?: @"Unknown",
                   [self.windowInfo objectForKey:@"title"] ?: @"Untitled");
         }
@@ -292,14 +293,19 @@ void updateScreenOverlays();
 
 @implementation WindowSelectorDelegate
 - (void)selectButtonClicked:(id)sender {
-    if (g_selectedWindowInfo) {
-        // Use the selected window info (from click) instead of cursor position
-        NSLog(@"🎯 START RECORDING: Selected window confirmed - %@ - \"%@\"", 
+    if (g_clickedWindowInfo) {
+        // Copy clicked window info to recording selection
+        if (g_selectedWindowInfo) {
+            [g_selectedWindowInfo release];
+        }
+        g_selectedWindowInfo = [g_clickedWindowInfo retain];
+        
+        NSLog(@"🎯 START RECORDING: Clicked window confirmed for recording - %@ - \"%@\"", 
               [g_selectedWindowInfo objectForKey:@"appName"] ?: @"Unknown",
               [g_selectedWindowInfo objectForKey:@"title"] ?: @"Untitled");
         cleanupWindowSelector();
     } else {
-        NSLog(@"⚠️ No window selected - cannot start recording");
+        NSLog(@"⚠️ No window clicked - cannot start recording");
     }
 }
 
@@ -800,9 +806,9 @@ void updateOverlay() {
             BOOL isUnderCursor = (windowUnderCursor && 
                                 [g_currentWindowUnderCursor isEqualToDictionary:windowUnderCursor]);
             
-            // Check if this is the selected window
-            BOOL isSelected = (g_selectedWindowInfo && 
-                             [g_selectedWindowInfo isEqualToDictionary:windowUnderCursor]);
+                                // Check if this is the clicked window (visual selection)
+                    BOOL isSelected = (g_clickedWindowInfo &&
+                                     [g_clickedWindowInfo isEqualToDictionary:windowUnderCursor]);
             
             // Allow highlighting on all windows (including selected) but keep selection state
             overlayView.isActiveWindow = isUnderCursor; // Highlight if under cursor
@@ -855,6 +861,12 @@ void cleanupWindowSelector() {
         g_selectedOverlayView.isSelectedWindow = NO;
         g_selectedOverlayView = nil;
     }
+    
+    // Clear clicked window info (visual selection)
+    if (g_clickedWindowInfo) {
+        [g_clickedWindowInfo release];
+        g_clickedWindowInfo = nil;
+    }
 }
 
 // Recording preview functions
@@ -1537,6 +1549,10 @@ Napi::Value StartWindowSelection(const Napi::CallbackInfo& info) {
             [g_selectedWindowInfo release];
             g_selectedWindowInfo = nil;
         }
+        if (g_clickedWindowInfo) {
+            [g_clickedWindowInfo release];
+            g_clickedWindowInfo = nil;
+        }
         if (g_selectedOverlayView) {
             g_selectedOverlayView.isSelectedWindow = NO;
             g_selectedOverlayView = nil;