node-mac-recorder 2.7.3 → 2.7.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.7.3",
+	"version": "2.7.4",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/window_selector.mm

@@ -81,19 +81,19 @@ void updateScreenOverlays();
 
 - (void)updateAppearance {
     if (self.isSelectedWindow) {
-        // Selected window: bright background with thick border
+        // Selected window: bright background with thick border (2-3px)
         self.layer.backgroundColor = [[NSColor colorWithRed:0.6 green:0.4 blue:0.9 alpha:0.6] CGColor];
         self.layer.borderColor = [[NSColor colorWithRed:0.6 green:0.4 blue:0.9 alpha:1.0] CGColor];
-        self.layer.borderWidth = 3.0; // Thick border for selected window
+        self.layer.borderWidth = 2.5; // Thick border for selected window
         // Selected window appearance set
     } else if (self.isActiveWindow) {
-        // Active window (highlighted): brighter background with thin border
+        // Active window (highlighted): thin border (1px)
         self.layer.backgroundColor = [[NSColor colorWithRed:0.6 green:0.4 blue:0.9 alpha:0.4] CGColor];
         self.layer.borderColor = [[NSColor colorWithRed:0.6 green:0.4 blue:0.9 alpha:0.8] CGColor];
         self.layer.borderWidth = 1.0; // Thin border for highlighted window
         // Active window appearance set
     } else {
-        // Inactive window: dimmer background with no border
+        // Inactive window: no border
         self.layer.backgroundColor = [[NSColor colorWithRed:0.4 green:0.2 blue:0.6 alpha:0.25] CGColor];
         self.layer.borderColor = [[NSColor clearColor] CGColor];
         self.layer.borderWidth = 0.0; // No border for inactive window
@@ -123,15 +123,18 @@ void updateScreenOverlays();
 }
 
 - (void)mouseDown:(NSEvent *)event {
-    // Handle mouse click to toggle window selection
+    // Handle mouse click to toggle window selection (ONLY selection, no recording start)
     if (self.windowInfo) {
         // Check if this window is already selected
         BOOL wasSelected = (g_selectedWindowInfo && 
                            [g_selectedWindowInfo isEqualToDictionary:self.windowInfo]);
         
         if (wasSelected) {
-            // Deselect this window
-            self.isSelectedWindow = NO;
+            // Deselect this window - return to normal highlight behavior
+            if (g_selectedOverlayView) {
+                g_selectedOverlayView.isSelectedWindow = NO;
+                [g_selectedOverlayView updateAppearance];
+            }
             
             // Clear global selection
             if (g_selectedWindowInfo) {
@@ -140,10 +143,16 @@ void updateScreenOverlays();
             }
             g_selectedOverlayView = nil;
             
-            NSLog(@"🚫 WINDOW DESELECTED VIA CLICK: %@ - \"%@\"", 
+            NSLog(@"🚫 WINDOW DESELECTED - Back to normal highlight mode: %@ - \"%@\"", 
                   [self.windowInfo objectForKey:@"appName"] ?: @"Unknown",
                   [self.windowInfo objectForKey:@"title"] ?: @"Untitled");
         } else {
+            // Deselect previous window if any
+            if (g_selectedOverlayView && g_selectedOverlayView != self) {
+                g_selectedOverlayView.isSelectedWindow = NO;
+                [g_selectedOverlayView updateAppearance];
+            }
+            
             // Select this window
             self.isSelectedWindow = YES;
             
@@ -156,13 +165,15 @@ void updateScreenOverlays();
             // Update global selected overlay reference
             g_selectedOverlayView = self;
             
-            NSLog(@"🎯 WINDOW SELECTED VIA CLICK: %@ - \"%@\"", 
+            NSLog(@"🎯 WINDOW SELECTED - Highlight blocked on this window: %@ - \"%@\"", 
                   [self.windowInfo objectForKey:@"appName"] ?: @"Unknown",
                   [self.windowInfo objectForKey:@"title"] ?: @"Untitled");
         }
         
-        // Update overlay appearance
+        // Update appearance for this overlay
         [self updateAppearance];
+        
+        // DON'T start recording here - that's only for the "Start Record" button
     }
 }
 
@@ -796,12 +807,16 @@ void updateOverlay() {
             BOOL isSelected = (g_selectedWindowInfo && 
                              [g_selectedWindowInfo isEqualToDictionary:windowUnderCursor]);
             
-            // Update states
-            overlayView.isActiveWindow = isUnderCursor; // Highlight if under cursor
+            // If window is selected, don't allow highlighting on it
+            if (isSelected) {
+                overlayView.isActiveWindow = NO; // No highlight on selected window
+            } else {
+                overlayView.isActiveWindow = isUnderCursor; // Highlight if under cursor and not selected
+            }
             overlayView.isSelectedWindow = isSelected;
             
             NSLog(@"🎯 Overlay State Updated: Active=%s, Selected=%s", 
-                  isUnderCursor ? "YES" : "NO", isSelected ? "YES" : "NO");
+                  overlayView.isActiveWindow ? "YES" : "NO", isSelected ? "YES" : "NO");
         }
     }
 }