node-mac-recorder 2.5.10 → 2.6.1

package/index.js

@@ -37,7 +37,7 @@ class MacRecorder extends EventEmitter {
 
 		this.options = {
 			includeMicrophone: false, // Default olarak mikrofon kapalı
-			includeSystemAudio: true, // Default olarak sistem sesi açık
+			includeSystemAudio: false, // Default olarak sistem sesi kapalı - kullanıcı explicit olarak açmalı
 			quality: "medium",
 			frameRate: 30,
 			captureArea: null, // { x, y, width, height }
@@ -110,8 +110,8 @@ class MacRecorder extends EventEmitter {
 	 */
 	setOptions(options = {}) {
 		this.options = {
-			includeMicrophone: options.includeMicrophone || false,
-			includeSystemAudio: options.includeSystemAudio !== false, // Default true unless explicitly disabled
+			includeMicrophone: options.includeMicrophone === true, // Explicit true required, default false
+			includeSystemAudio: options.includeSystemAudio === true, // Explicit true required, default false  
 			captureCursor: options.captureCursor || false,
 			displayId: options.displayId || null, // null = ana ekran
 			windowId: options.windowId || null, // null = tam ekran
@@ -121,6 +121,53 @@ class MacRecorder extends EventEmitter {
 		};
 	}
 
+	/**
+	 * Mikrofon kaydını açar/kapatır
+	 */
+	setMicrophoneEnabled(enabled) {
+		this.options.includeMicrophone = enabled === true;
+		return this.options.includeMicrophone;
+	}
+
+	/**
+	 * Sistem sesi kaydını açar/kapatır
+	 */
+	setSystemAudioEnabled(enabled) {
+		this.options.includeSystemAudio = enabled === true;
+		return this.options.includeSystemAudio;
+	}
+
+	/**
+	 * Mikrofon durumunu döndürür
+	 */
+	isMicrophoneEnabled() {
+		return this.options.includeMicrophone === true;
+	}
+
+	/**
+	 * Sistem sesi durumunu döndürür
+	 */
+	isSystemAudioEnabled() {
+		return this.options.includeSystemAudio === true;
+	}
+
+	/**
+	 * Audio ayarlarını toplu olarak değiştirir
+	 */
+	setAudioSettings(settings = {}) {
+		if (typeof settings.microphone === 'boolean') {
+			this.setMicrophoneEnabled(settings.microphone);
+		}
+		if (typeof settings.systemAudio === 'boolean') {
+			this.setSystemAudioEnabled(settings.systemAudio);
+		}
+		
+		return {
+			microphone: this.isMicrophoneEnabled(),
+			systemAudio: this.isSystemAudioEnabled()
+		};
+	}
+
 	/**
 	 * Ekran kaydını başlatır (macOS native AVFoundation kullanarak)
 	 */
@@ -266,8 +313,8 @@ class MacRecorder extends EventEmitter {
 			try {
 				// Native kayıt başlat
 				const recordingOptions = {
-					includeMicrophone: this.options.includeMicrophone || false,
-					includeSystemAudio: this.options.includeSystemAudio !== false, // Default true unless explicitly disabled
+					includeMicrophone: this.options.includeMicrophone === true, // Only if explicitly enabled
+					includeSystemAudio: this.options.includeSystemAudio === true, // Only if explicitly enabled
 					captureCursor: this.options.captureCursor || false,
 					displayId: this.options.displayId || null, // null = ana ekran
 					windowId: this.options.windowId || null, // null = tam ekran

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.5.10",
+	"version": "2.6.1",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/window_selector.mm

@@ -62,14 +62,6 @@ bool hideScreenRecordingPreview();
         // Ensure no borders or decorations
         self.layer.borderWidth = 0.0;
         self.layer.cornerRadius = 0.0;
-        self.layer.borderColor = [[NSColor clearColor] CGColor];
-        self.layer.shadowOpacity = 0.0;
-        self.layer.shadowRadius = 0.0;
-        self.layer.shadowOffset = NSMakeSize(0, 0);
-        self.layer.masksToBounds = YES;
-        
-        // Disable focus ring and other default behaviors
-        [self setFocusRingType:NSFocusRingTypeNone];
     }
     return self;
 }
@@ -79,9 +71,9 @@ bool hideScreenRecordingPreview();
     
     if (!self.windowInfo) return;
     
-    // No background fill - completely transparent overlay
-    // [[NSColor colorWithRed:0.5 green:0.5 blue:0.5 alpha:0.15] setFill];
-    // NSRectFill(self.bounds);
+    // Background with transparency - purple tone (no border)
+    [[NSColor colorWithRed:0.5 green:0.3 blue:0.8 alpha:0.25] setFill];
+    NSRectFill(self.bounds);
     
     // Ensure no borders or frames are drawn
     // Text will be handled by separate label above button
@@ -104,14 +96,6 @@ bool hideScreenRecordingPreview();
         // Ensure no borders or decorations
         self.layer.borderWidth = 0.0;
         self.layer.cornerRadius = 0.0;
-        self.layer.borderColor = [[NSColor clearColor] CGColor];
-        self.layer.shadowOpacity = 0.0;
-        self.layer.shadowRadius = 0.0;
-        self.layer.shadowOffset = NSMakeSize(0, 0);
-        self.layer.masksToBounds = YES;
-        
-        // Disable focus ring and other default behaviors
-        [self setFocusRingType:NSFocusRingTypeNone];
     }
     return self;
 }
@@ -167,14 +151,6 @@ bool hideScreenRecordingPreview();
         // Ensure no borders or decorations
         self.layer.borderWidth = 0.0;
         self.layer.cornerRadius = 0.0;
-        self.layer.borderColor = [[NSColor clearColor] CGColor];
-        self.layer.shadowOpacity = 0.0;
-        self.layer.shadowRadius = 0.0;
-        self.layer.shadowOffset = NSMakeSize(0, 0);
-        self.layer.masksToBounds = YES;
-        
-        // Disable focus ring and other default behaviors
-        [self setFocusRingType:NSFocusRingTypeNone];
     }
     return self;
 }
@@ -184,10 +160,10 @@ bool hideScreenRecordingPreview();
     
     if (!self.screenInfo) return;
     
-    // No background fill - completely transparent overlay
+    // Background with transparency - purple tone (no border)
     // Ensure no borders or frames are drawn
-    // [[NSColor colorWithRed:0.5 green:0.5 blue:0.5 alpha:0.2] setFill];
-    // NSRectFill(self.bounds);
+    [[NSColor colorWithRed:0.5 green:0.3 blue:0.8 alpha:0.3] setFill];
+    NSRectFill(self.bounds);
     
     // Text will be handled by separate label above button
 }
@@ -747,24 +723,12 @@ bool showRecordingPreview(NSDictionary *windowInfo) {
         [g_recordingPreviewWindow setAlphaValue:1.0];
         [g_recordingPreviewWindow setCollectionBehavior:NSWindowCollectionBehaviorStationary | NSWindowCollectionBehaviorCanJoinAllSpaces];
         
-        // Ensure window layer has no borders or decorations
-        [g_recordingPreviewWindow setWantsLayer:YES];
-        [g_recordingPreviewWindow.layer setBorderWidth:0.0];
-        [g_recordingPreviewWindow.layer setCornerRadius:0.0];
-        [g_recordingPreviewWindow.layer setBorderColor:[[NSColor clearColor] CGColor]];
-        [g_recordingPreviewWindow.layer setMasksToBounds:YES];
-        
         // Remove any default window decorations and borders
         [g_recordingPreviewWindow setTitlebarAppearsTransparent:YES];
         [g_recordingPreviewWindow setTitleVisibility:NSWindowTitleHidden];
         [g_recordingPreviewWindow setMovable:NO];
         [g_recordingPreviewWindow setMovableByWindowBackground:NO];
         
-        // Additional window styling to completely remove borders
-        [g_recordingPreviewWindow setToolbar:nil];
-        [g_recordingPreviewWindow setShowsResizeIndicator:NO];
-        [g_recordingPreviewWindow setShowsToolbarButton:NO];
-        
         // Create preview view
         g_recordingPreviewView = [[RecordingPreviewView alloc] initWithFrame:screenFrame];
         [(RecordingPreviewView *)g_recordingPreviewView setRecordingWindowInfo:windowInfo];
@@ -872,31 +836,17 @@ bool startScreenSelection() {
             [overlayWindow setAlphaValue:1.0];
             [overlayWindow setCollectionBehavior:NSWindowCollectionBehaviorStationary | NSWindowCollectionBehaviorCanJoinAllSpaces];
             
-            // Ensure window layer has no borders or decorations
-            [overlayWindow setWantsLayer:YES];
-            [overlayWindow.layer setBorderWidth:0.0];
-            [overlayWindow.layer setCornerRadius:0.0];
-            [overlayWindow.layer setBorderColor:[[NSColor clearColor] CGColor]];
-            [overlayWindow.layer setMasksToBounds:YES];
-            
             // Remove any default window decorations and borders
             [overlayWindow setTitlebarAppearsTransparent:YES];
             [overlayWindow setTitleVisibility:NSWindowTitleHidden];
             [overlayWindow setMovable:NO];
             [overlayWindow setMovableByWindowBackground:NO];
             
-
-            
             // Create overlay view
             ScreenSelectorOverlayView *overlayView = [[ScreenSelectorOverlayView alloc] initWithFrame:screenFrame];
             [overlayView setScreenInfo:screenInfo];
             [overlayWindow setContentView:overlayView];
             
-            // Additional window styling to completely remove borders
-            [overlayWindow setToolbar:nil];
-            [overlayWindow setShowsResizeIndicator:NO];
-            [overlayWindow setShowsToolbarButton:NO];
-            
             // Create select button with more padding
             NSButton *selectButton = [[NSButton alloc] initWithFrame:NSMakeRect(0, 0, 200, 60)];
             [selectButton setTitle:@"Start Record"];
@@ -936,13 +886,9 @@ bool startScreenSelection() {
             [selectButton setTarget:g_delegate];
             [selectButton setAction:@selector(screenSelectButtonClicked:)];
             
-                                                                                                                                   // Remove focus ring and other default button behaviors
-              [selectButton setFocusRingType:NSFocusRingTypeNone];
-              [selectButton setShowsBorderOnlyMouseInside:NO];
-              [selectButton setBezelStyle:NSBezelStyleTexturedSquare];
-              [selectButton setKeyEquivalent:@""];
-              [selectButton setRefusesFirstResponder:YES];
-              [selectButton setState:NSControlStateValueOff];
+            // Remove focus ring and other default button behaviors
+            [selectButton setFocusRingType:NSFocusRingTypeNone];
+            [selectButton setShowsBorderOnlyWhileMouseInside:NO];
             
             // Create cancel button for screen selection
             NSButton *screenCancelButton = [[NSButton alloc] initWithFrame:NSMakeRect(0, 0, 120, 40)];
@@ -977,11 +923,7 @@ bool startScreenSelection() {
             
             // Remove focus ring and other default button behaviors
             [screenCancelButton setFocusRingType:NSFocusRingTypeNone];
-            [screenCancelButton setShowsBorderOnlyMouseInside:NO];
-            [screenCancelButton setBezelStyle:NSBezelStyleTexturedSquare];
-            [screenCancelButton setKeyEquivalent:@""];
-            [screenCancelButton setRefusesFirstResponder:YES];
-            [screenCancelButton setState:NSControlStateValueOff];
+            [screenCancelButton setShowsBorderOnlyWhileMouseInside:NO];
             
             // Create info label for screen
             NSTextField *screenInfoLabel = [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, screenFrame.size.width - 40, 60)];
@@ -1143,24 +1085,12 @@ bool showScreenRecordingPreview(NSDictionary *screenInfo) {
             [overlayWindow setAlphaValue:1.0];
             [overlayWindow setCollectionBehavior:NSWindowCollectionBehaviorStationary | NSWindowCollectionBehaviorCanJoinAllSpaces];
             
-            // Ensure window layer has no borders or decorations
-            [overlayWindow setWantsLayer:YES];
-            [overlayWindow.layer setBorderWidth:0.0];
-            [overlayWindow.layer setCornerRadius:0.0];
-            [overlayWindow.layer setBorderColor:[[NSColor clearColor] CGColor]];
-            [overlayWindow.layer setMasksToBounds:YES];
-            
             // Remove any default window decorations and borders
             [overlayWindow setTitlebarAppearsTransparent:YES];
             [overlayWindow setTitleVisibility:NSWindowTitleHidden];
             [overlayWindow setMovable:NO];
             [overlayWindow setMovableByWindowBackground:NO];
             
-            // Additional window styling to completely remove borders
-            [overlayWindow setToolbar:nil];
-            [overlayWindow setShowsResizeIndicator:NO];
-            [overlayWindow setShowsToolbarButton:NO];
-            
             [overlayWindow orderFront:nil];
             [overlayWindow makeKeyAndOrderFront:nil];
             
@@ -1218,37 +1148,19 @@ Napi::Value StartWindowSelection(const Napi::CallbackInfo& info) {
         [g_overlayWindow setAlphaValue:1.0];
         [g_overlayWindow setCollectionBehavior:NSWindowCollectionBehaviorStationary | NSWindowCollectionBehaviorCanJoinAllSpaces];
         
-        // Ensure window layer has no borders or decorations
-        [g_overlayWindow setWantsLayer:YES];
-        [g_overlayWindow.layer setBorderWidth:0.0];
-        [g_overlayWindow.layer setCornerRadius:0.0];
-        [g_overlayWindow.layer setBorderColor:[[NSColor clearColor] CGColor]];
-        [g_overlayWindow.layer setMasksToBounds:YES];
-        
         // Remove any default window decorations and borders
         [g_overlayWindow setTitlebarAppearsTransparent:YES];
         [g_overlayWindow setTitleVisibility:NSWindowTitleHidden];
         [g_overlayWindow setMovable:NO];
         [g_overlayWindow setMovableByWindowBackground:NO];
         
-        // Additional window styling to completely remove borders
-        [g_overlayWindow setToolbar:nil];
-        [g_overlayWindow setShowsResizeIndicator:NO];
-        [g_overlayWindow setShowsToolbarButton:NO];
-        
         // Create overlay view
         g_overlayView = [[WindowSelectorOverlayView alloc] initWithFrame:initialFrame];
         [g_overlayWindow setContentView:g_overlayView];
         
-        // Ensure view layer has no borders
-        [g_overlayView setWantsLayer:YES];
-        [g_overlayView.layer setBorderWidth:0.0];
-        [g_overlayView.layer setCornerRadius:0.0];
-        [g_overlayView.layer setBorderColor:[[NSColor clearColor] CGColor]];
-        [g_overlayView.layer setMasksToBounds:YES];
-        [g_overlayView.layer setShadowOpacity:0.0];
-        [g_overlayView.layer setShadowRadius:0.0];
-        [g_overlayView.layer setShadowOffset:NSMakeSize(0, 0)];
+        // Additional window styling to ensure no borders or decorations
+        [g_overlayWindow setMovable:NO];
+        [g_overlayWindow setMovableByWindowBackground:NO];
         
         // Create select button with purple theme
         g_selectButton = [[NSButton alloc] initWithFrame:NSMakeRect(0, 0, 200, 60)];
@@ -1284,11 +1196,7 @@ Napi::Value StartWindowSelection(const Napi::CallbackInfo& info) {
         
         // Remove focus ring and other default button behaviors
         [g_selectButton setFocusRingType:NSFocusRingTypeNone];
-        [g_selectButton setShowsBorderOnlyMouseInside:NO];
-        [g_selectButton setBezelStyle:NSBezelStyleTexturedSquare];
-        [g_selectButton setKeyEquivalent:@""];
-        [g_selectButton setRefusesFirstResponder:YES];
-        [g_selectButton setState:NSControlStateValueOff];
+        [g_selectButton setShowsBorderOnlyWhileMouseInside:NO];
         
         // Add select button directly to window (not view) for proper layering
         [g_overlayWindow.contentView addSubview:g_selectButton];
@@ -1325,11 +1233,7 @@ Napi::Value StartWindowSelection(const Napi::CallbackInfo& info) {
         
         // Remove focus ring and other default button behaviors
         [cancelButton setFocusRingType:NSFocusRingTypeNone];
-        [cancelButton setShowsBorderOnlyMouseInside:NO];
-        [cancelButton setBezelStyle:NSBezelStyleTexturedSquare];
-        [cancelButton setKeyEquivalent:@""];
-        [cancelButton setRefusesFirstResponder:YES];
-        [cancelButton setState:NSControlStateValueOff];
+        [cancelButton setShowsBorderOnlyWhileMouseInside:NO];
         
         // Add cancel button to window
         [g_overlayWindow.contentView addSubview:cancelButton];

package/test-audio-controls.js

@@ -0,0 +1,104 @@
+#!/usr/bin/env node
+
+const MacRecorder = require('./index');
+
+async function testAudioControls() {
+    console.log('🎵 Audio Control Test');
+    console.log('====================\n');
+
+    const recorder = new MacRecorder();
+
+    try {
+        // Test initial state
+        console.log('📋 Initial Audio State:');
+        console.log(`   Microphone: ${recorder.isMicrophoneEnabled() ? '🎤 ON' : '🔇 OFF'}`);
+        console.log(`   System Audio: ${recorder.isSystemAudioEnabled() ? '🔊 ON' : '🔇 OFF'}\n`);
+
+        // Test individual controls
+        console.log('🔧 Testing Individual Controls:\n');
+        
+        console.log('   Enabling microphone...');
+        recorder.setMicrophoneEnabled(true);
+        console.log(`   Microphone: ${recorder.isMicrophoneEnabled() ? '🎤 ON' : '🔇 OFF'}`);
+        
+        console.log('   Enabling system audio...');
+        recorder.setSystemAudioEnabled(true);
+        console.log(`   System Audio: ${recorder.isSystemAudioEnabled() ? '🔊 ON' : '🔇 OFF'}\n`);
+
+        console.log('   Disabling microphone...');
+        recorder.setMicrophoneEnabled(false);
+        console.log(`   Microphone: ${recorder.isMicrophoneEnabled() ? '🎤 ON' : '🔇 OFF'}`);
+        
+        console.log('   Disabling system audio...');
+        recorder.setSystemAudioEnabled(false);
+        console.log(`   System Audio: ${recorder.isSystemAudioEnabled() ? '🔊 ON' : '🔇 OFF'}\n`);
+
+        // Test bulk settings
+        console.log('🔧 Testing Bulk Audio Settings:\n');
+        
+        console.log('   Setting both to ON...');
+        let settings = recorder.setAudioSettings({
+            microphone: true,
+            systemAudio: true
+        });
+        console.log(`   Result: Microphone=${settings.microphone ? 'ON' : 'OFF'}, System Audio=${settings.systemAudio ? 'ON' : 'OFF'}\n`);
+
+        console.log('   Setting microphone OFF, system audio ON...');
+        settings = recorder.setAudioSettings({
+            microphone: false,
+            systemAudio: true
+        });
+        console.log(`   Result: Microphone=${settings.microphone ? 'ON' : 'OFF'}, System Audio=${settings.systemAudio ? 'ON' : 'OFF'}\n`);
+
+        // Test recording with different audio settings
+        const testOutput = `./test-output/audio-test-${Date.now()}.mov`;
+        
+        console.log('🎬 Testing Recording with Audio Settings:\n');
+        
+        // Test 1: No audio
+        console.log('   Test 1: No Audio Recording');
+        recorder.setAudioSettings({ microphone: false, systemAudio: false });
+        console.log(`   Starting 3-second recording: ${testOutput}`);
+        console.log(`   Audio settings: Mic=${recorder.isMicrophoneEnabled() ? 'ON' : 'OFF'}, System=${recorder.isSystemAudioEnabled() ? 'ON' : 'OFF'}`);
+        
+        await recorder.startRecording(testOutput);
+        await new Promise(resolve => setTimeout(resolve, 3000));
+        await recorder.stopRecording();
+        console.log('   ✅ Recording completed (no audio)\n');
+
+        // Test 2: Microphone only
+        console.log('   Test 2: Microphone Only Recording');
+        recorder.setAudioSettings({ microphone: true, systemAudio: false });
+        const testOutput2 = `./test-output/audio-test-mic-${Date.now()}.mov`;
+        console.log(`   Starting 3-second recording: ${testOutput2}`);
+        console.log(`   Audio settings: Mic=${recorder.isMicrophoneEnabled() ? 'ON' : 'OFF'}, System=${recorder.isSystemAudioEnabled() ? 'ON' : 'OFF'}`);
+        
+        await recorder.startRecording(testOutput2);
+        await new Promise(resolve => setTimeout(resolve, 3000));
+        await recorder.stopRecording();
+        console.log('   ✅ Recording completed (microphone only)\n');
+
+        // Test 3: System audio only
+        console.log('   Test 3: System Audio Only Recording');
+        recorder.setAudioSettings({ microphone: false, systemAudio: true });
+        const testOutput3 = `./test-output/audio-test-system-${Date.now()}.mov`;
+        console.log(`   Starting 3-second recording: ${testOutput3}`);
+        console.log(`   Audio settings: Mic=${recorder.isMicrophoneEnabled() ? 'ON' : 'OFF'}, System=${recorder.isSystemAudioEnabled() ? 'ON' : 'OFF'}`);
+        
+        await recorder.startRecording(testOutput3);
+        await new Promise(resolve => setTimeout(resolve, 3000));
+        await recorder.stopRecording();
+        console.log('   ✅ Recording completed (system audio only)\n');
+
+        console.log('✅ All audio control tests completed successfully!');
+        console.log('\n📁 Check test-output/ directory for video files.');
+
+    } catch (error) {
+        console.error('\n❌ Test failed:', error.message);
+        process.exit(1);
+    }
+}
+
+if (require.main === module) {
+    testAudioControls();
+}