node-mac-recorder 2.4.10 → 2.4.12

package/binding.gyp

@@ -20,32 +20,25 @@
       "xcode_settings": {
         "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
         "CLANG_CXX_LIBRARY": "libc++",
-        "MACOSX_DEPLOYMENT_TARGET": "12.3",
-        "ARCHS": ["arm64"],
-        "VALID_ARCHS": ["arm64"],
+        "MACOSX_DEPLOYMENT_TARGET": "10.15",
         "OTHER_CFLAGS": [
-          "-ObjC++",
-          "-fmodules"
-        ],
-        "CLANG_ENABLE_OBJC_ARC": "YES"
+          "-ObjC++"
+        ]
       },
       "link_settings": {
         "libraries": [
-          "-framework ScreenCaptureKit",
           "-framework AVFoundation",
           "-framework CoreMedia",
           "-framework CoreVideo",
           "-framework Foundation",
           "-framework AppKit",
+          "-framework ScreenCaptureKit",
           "-framework ApplicationServices",
           "-framework Carbon",
           "-framework Accessibility"
         ]
       },
-      "defines": [ 
-        "NAPI_DISABLE_CPP_EXCEPTIONS",
-        "USE_SCREENCAPTUREKIT=1"
-      ]
+      "defines": [ "NAPI_DISABLE_CPP_EXCEPTIONS" ]
     }
   ]
 } 

package/index.js

@@ -5,25 +5,16 @@ const fs = require("fs");
 // Native modülü yükle
 let nativeBinding;
 try {
-	// Prefer prebuild on arm64
-	if (process.platform === "darwin" && process.arch === "arm64") {
-		nativeBinding = require("./prebuilds/darwin-arm64/node.napi.node");
-	} else {
-		nativeBinding = require("./build/Release/mac_recorder.node");
-	}
+	nativeBinding = require("./build/Release/mac_recorder.node");
 } catch (error) {
 	try {
-		nativeBinding = require("./build/Release/mac_recorder.node");
-	} catch (_) {
-		try {
-			nativeBinding = require("./build/Debug/mac_recorder.node");
-		} catch (debugError) {
-			throw new Error(
-				'Native module not found. Please run "npm run build" to compile the native module.\n' +
-					"Original error: " +
-					error.message
-			);
-		}
+		nativeBinding = require("./build/Debug/mac_recorder.node");
+	} catch (debugError) {
+		throw new Error(
+			'Native module not found. Please run "npm run build" to compile the native module.\n' +
+				"Original error: " +
+				error.message
+		);
 	}
 }
 
@@ -127,11 +118,6 @@ class MacRecorder extends EventEmitter {
 			audioDeviceId: options.audioDeviceId || null, // null = default device
 			systemAudioDeviceId: options.systemAudioDeviceId || null, // null = auto-detect system audio device
 			captureArea: options.captureArea || null,
-			// Exclusion options
-			excludeCurrentApp: options.excludeCurrentApp || false,
-			excludeWindowIds: Array.isArray(options.excludeWindowIds)
-				? options.excludeWindowIds
-				: [],
 		};
 	}
 
@@ -181,12 +167,11 @@ class MacRecorder extends EventEmitter {
 							targetDisplayId = display.id; // Use actual display ID, not array index
 							// Koordinatları display'e göre normalize et
 							adjustedX = targetWindow.x - display.x;
-
+							
 							// Y coordinate conversion: CGWindow (top-left) to AVFoundation (bottom-left)
 							// Overlay'deki dönüşümle aynı mantık: screenHeight - windowY - windowHeight
 							const displayHeight = parseInt(display.resolution.split("x")[1]);
-							const convertedY =
-								displayHeight - targetWindow.y - targetWindow.height;
+							const convertedY = displayHeight - targetWindow.y - targetWindow.height;
 							adjustedY = Math.max(0, convertedY - display.y);
 							break;
 						}
@@ -221,9 +206,7 @@ class MacRecorder extends EventEmitter {
 						this.options.displayId = targetDisplayId;
 
 						// Recording için display bilgisini sakla (cursor capture için)
-						const targetDisplay = displays.find(
-							(d) => d.id === targetDisplayId
-						);
+						const targetDisplay = displays.find(d => d.id === targetDisplayId);
 						this.recordingDisplayInfo = {
 							displayId: targetDisplayId,
 							x: targetDisplay.x,
@@ -256,9 +239,7 @@ class MacRecorder extends EventEmitter {
 		if (this.options.displayId !== null && !this.recordingDisplayInfo) {
 			try {
 				const displays = await this.getDisplays();
-				const targetDisplay = displays.find(
-					(d) => d.id === this.options.displayId
-				);
+				const targetDisplay = displays.find(d => d.id === this.options.displayId);
 				if (targetDisplay) {
 					this.recordingDisplayInfo = {
 						displayId: this.options.displayId,
@@ -292,9 +273,6 @@ class MacRecorder extends EventEmitter {
 					windowId: this.options.windowId || null, // null = tam ekran
 					audioDeviceId: this.options.audioDeviceId || null, // null = default device
 					systemAudioDeviceId: this.options.systemAudioDeviceId || null, // null = auto-detect system audio device
-					// Exclusion options passthrough
-					excludeCurrentApp: this.options.excludeCurrentApp || false,
-					excludeWindowIds: this.options.excludeWindowIds || [],
 				};
 
 				// Manuel captureArea varsa onu kullan
@@ -332,13 +310,13 @@ class MacRecorder extends EventEmitter {
 							if (nativeStatus && !recordingStartedEmitted) {
 								recordingStartedEmitted = true;
 								clearInterval(checkRecordingStatus);
-
+								
 								// Kayıt gerçekten başladığı anda event emit et
 								this.emit("recordingStarted", {
 									outputPath: this.outputPath,
 									timestamp: Date.now(), // Gerçek başlangıç zamanı
 									options: this.options,
-									nativeConfirmed: true,
+									nativeConfirmed: true
 								});
 							}
 						} catch (error) {
@@ -350,12 +328,12 @@ class MacRecorder extends EventEmitter {
 									outputPath: this.outputPath,
 									timestamp: this.recordingStartTime,
 									options: this.options,
-									nativeConfirmed: false,
+									nativeConfirmed: false
 								});
 							}
 						}
 					}, 50); // Her 50ms kontrol et
-
+					
 					// Timeout fallback - 5 saniye sonra hala başlamamışsa emit et
 					setTimeout(() => {
 						if (!recordingStartedEmitted) {
@@ -365,11 +343,11 @@ class MacRecorder extends EventEmitter {
 								outputPath: this.outputPath,
 								timestamp: this.recordingStartTime,
 								options: this.options,
-								nativeConfirmed: false,
+								nativeConfirmed: false
 							});
 						}
 					}, 5000);
-
+					
 					this.emit("started", this.outputPath);
 					resolve(this.outputPath);
 				} else {
@@ -610,7 +588,7 @@ class MacRecorder extends EventEmitter {
 				width: options.windowInfo.width,
 				height: options.windowInfo.height,
 				windowRelative: true,
-				windowInfo: options.windowInfo,
+				windowInfo: options.windowInfo
 			};
 		} else if (this.recordingDisplayInfo) {
 			// Recording başlatılmışsa o display'i kullan
@@ -666,7 +644,7 @@ class MacRecorder extends EventEmitter {
 							if (this.cursorDisplayInfo.windowRelative) {
 								// Window-relative koordinatlar
 								coordinateSystem = "window-relative";
-
+								
 								// Window bounds kontrolü - cursor window dışındaysa kaydetme
 								if (
 									x < 0 ||
@@ -679,7 +657,7 @@ class MacRecorder extends EventEmitter {
 							} else {
 								// Display-relative koordinatlar
 								coordinateSystem = "display-relative";
-
+								
 								// Display bounds kontrolü
 								if (
 									x < 0 ||
@@ -704,9 +682,9 @@ class MacRecorder extends EventEmitter {
 								windowInfo: {
 									width: this.cursorDisplayInfo.width,
 									height: this.cursorDisplayInfo.height,
-									originalWindow: this.cursorDisplayInfo.windowInfo,
-								},
-							}),
+									originalWindow: this.cursorDisplayInfo.windowInfo
+								}
+							})
 						};
 
 						// Sadece eventType değiştiğinde veya pozisyon değiştiğinde kaydet
@@ -950,66 +928,9 @@ class MacRecorder extends EventEmitter {
 
 		return Promise.all(windowPromises);
 	}
-
-	// Window Selection Methods (ScreenCaptureKit compatible)
-	startWindowSelection() {
-		if (!nativeBinding.startWindowSelection) {
-			throw new Error('Window selection is not available in this build');
-		}
-		return nativeBinding.startWindowSelection();
-	}
-
-	stopWindowSelection() {
-		if (!nativeBinding.stopWindowSelection) {
-			return false;
-		}
-		return nativeBinding.stopWindowSelection();
-	}
-
-	getSelectedWindowInfo() {
-		if (!nativeBinding.getSelectedWindowInfo) {
-			return null;
-		}
-		return nativeBinding.getSelectedWindowInfo();
-	}
-
-	getWindowSelectionStatus() {
-		if (!nativeBinding.getWindowSelectionStatus) {
-			return { isSelecting: false, hasSelectedWindow: false };
-		}
-		return nativeBinding.getWindowSelectionStatus();
-	}
-
-	bringWindowToFront(windowId) {
-		if (!nativeBinding.bringWindowToFront) {
-			return false;
-		}
-		return nativeBinding.bringWindowToFront(windowId);
-	}
-
-	setBringToFrontEnabled(enabled) {
-		if (!nativeBinding.setBringToFrontEnabled) {
-			return false;
-		}
-		return nativeBinding.setBringToFrontEnabled(enabled);
-	}
-
-	showRecordingPreview(windowInfo) {
-		if (!nativeBinding.showRecordingPreview) {
-			return false;
-		}
-		return nativeBinding.showRecordingPreview(windowInfo);
-	}
-
-	hideRecordingPreview() {
-		if (!nativeBinding.hideRecordingPreview) {
-			return false;
-		}
-		return nativeBinding.hideRecordingPreview();
-	}
 }
 
 // WindowSelector modülünü de export edelim
-MacRecorder.WindowSelector = require("./window-selector");
+MacRecorder.WindowSelector = require('./window-selector');
 
 module.exports = MacRecorder;

package/install.js

@@ -2,7 +2,7 @@ const { spawn } = require("child_process");
 const fs = require("fs");
 const path = require("path");
 
-console.log("🔨 Installing node-mac-recorder...\n");
+console.log("🔨 Building native macOS recorder module...\n");
 
 // Check if we're on macOS
 if (process.platform !== "darwin") {
@@ -10,24 +10,7 @@ if (process.platform !== "darwin") {
 	process.exit(1);
 }
 
-// Prefer prebuilds on supported platforms
-const prebuildPath = path.join(
-	__dirname,
-	"prebuilds",
-	`darwin-${process.arch}`,
-	"node.napi.node"
-);
-if (
-	process.platform === "darwin" &&
-	process.arch === "arm64" &&
-	fs.existsSync(prebuildPath)
-) {
-	console.log("✅ Using prebuilt binary:", prebuildPath);
-	console.log("🎉 node-mac-recorder is ready to use (no compilation needed)");
-	process.exit(0);
-}
-
-// Fallback to building from source
+// Check if Xcode Command Line Tools are installed
 console.log("🔍 Checking Xcode Command Line Tools...");
 const xcodebuild = spawn("xcode-select", ["--print-path"], { stdio: "pipe" });
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.4.10",
+	"version": "2.4.12",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [
@@ -37,9 +37,6 @@
 		"install": "node install.js",
 		"build": "node-gyp build",
 		"rebuild": "node-gyp rebuild",
-		"prebuild:node-arm64": "prebuildify --platform darwin --arch arm64 --napi --strip",
-		"prebuild:electron-arm64": "prebuildify --platform darwin --arch arm64 --napi --strip --targets electron@27.0.0",
-		"prebuild:all-arm64": "npm run prebuild:node-arm64 && npm run prebuild:electron-arm64",
 		"clean": "node-gyp clean",
 		"test:window-selector": "node window-selector-test.js",
 		"example:window-selector": "node examples/window-selector-example.js"
@@ -48,8 +45,7 @@
 		"node-addon-api": "^7.0.0"
 	},
 	"devDependencies": {
-		"node-gyp": "^10.0.0",
-		"prebuildify": "^6.0.1"
+		"node-gyp": "^10.0.0"
 	},
 	"gypfile": true
 }

package/src/audio_capture.mm

@@ -1,11 +1,9 @@
-#import <ScreenCaptureKit/ScreenCaptureKit.h>
 #import <AVFoundation/AVFoundation.h>
 #import <CoreAudio/CoreAudio.h>
 
 @interface AudioCapture : NSObject
 
 + (NSArray *)getAudioDevices;
-+ (NSArray *)getSystemAudioDevices;
 + (BOOL)hasAudioPermission;
 + (void)requestAudioPermission:(void(^)(BOOL granted))completion;
 
@@ -16,39 +14,25 @@
 + (NSArray *)getAudioDevices {
     NSMutableArray *devices = [NSMutableArray array];
     
-    // Get microphone devices using AVFoundation
-    AVCaptureDeviceDiscoverySession *discoverySession = [AVCaptureDeviceDiscoverySession 
-        discoverySessionWithDeviceTypes:@[AVCaptureDeviceTypeBuiltInMicrophone, AVCaptureDeviceTypeExternalUnknown]
-        mediaType:AVMediaTypeAudio
-        position:AVCaptureDevicePositionUnspecified];
-    NSArray *audioDevices = discoverySession.devices;
+    // Get all audio devices
+    NSArray *audioDevices = [AVCaptureDevice devicesWithMediaType:AVMediaTypeAudio];
     
     for (AVCaptureDevice *device in audioDevices) {
         NSDictionary *deviceInfo = @{
             @"id": device.uniqueID,
             @"name": device.localizedName,
             @"manufacturer": device.manufacturer ?: @"Unknown",
-            @"type": @"microphone",
             @"isDefault": @([device isEqual:[AVCaptureDevice defaultDeviceWithMediaType:AVMediaTypeAudio]])
         };
         
         [devices addObject:deviceInfo];
     }
     
-    // Add system audio devices using Core Audio API
-    NSArray *systemDevices = [self getSystemAudioDevices];
-    [devices addObjectsFromArray:systemDevices];
-    
-    return [devices copy];
-}
-
-+ (NSArray *)getSystemAudioDevices {
-    NSMutableArray *devices = [NSMutableArray array];
-    
+    // Also get system audio devices using Core Audio
     AudioObjectPropertyAddress propertyAddress = {
         kAudioHardwarePropertyDevices,
         kAudioObjectPropertyScopeGlobal,
-        kAudioObjectPropertyElementMain  // Changed from kAudioObjectPropertyElementMaster (deprecated)
+        kAudioObjectPropertyElementMaster
     };
     
     UInt32 dataSize = 0;
@@ -65,41 +49,37 @@
                 AudioDeviceID deviceID = audioDeviceIDs[i];
                 
                 // Get device name
+                propertyAddress.mSelector = kAudioDevicePropertyDeviceNameCFString;
+                propertyAddress.mScope = kAudioObjectPropertyScopeGlobal;
+                
                 CFStringRef deviceName = NULL;
-                UInt32 size = sizeof(deviceName);
-                AudioObjectPropertyAddress nameAddress = {
-                    kAudioDevicePropertyDeviceNameCFString,
-                    kAudioDevicePropertyScopeOutput,  // Focus on output devices for system audio
-                    kAudioObjectPropertyElementMain
-                };
+                dataSize = sizeof(deviceName);
                 
-                status = AudioObjectGetPropertyData(deviceID, &nameAddress, 0, NULL, &size, &deviceName);
+                status = AudioObjectGetPropertyData(deviceID, &propertyAddress, 0, NULL, &dataSize, &deviceName);
                 
                 if (status == kAudioHardwareNoError && deviceName) {
-                    // Check if this is an output device
-                    AudioObjectPropertyAddress streamAddress = {
-                        kAudioDevicePropertyStreams,
-                        kAudioDevicePropertyScopeOutput,
-                        kAudioObjectPropertyElementMain
-                    };
+                    // Check if it's an input device
+                    propertyAddress.mSelector = kAudioDevicePropertyStreamConfiguration;
+                    propertyAddress.mScope = kAudioDevicePropertyScopeInput;
                     
-                    UInt32 streamSize = 0;
-                    status = AudioObjectGetPropertyDataSize(deviceID, &streamAddress, 0, NULL, &streamSize);
+                    AudioObjectGetPropertyDataSize(deviceID, &propertyAddress, 0, NULL, &dataSize);
                     
-                    if (status == kAudioHardwareNoError && streamSize > 0) {
-                        // This is an output device - can be used for system audio capture
-                        const char *name = CFStringGetCStringPtr(deviceName, kCFStringEncodingUTF8);
-                        NSString *deviceNameStr = name ? [NSString stringWithUTF8String:name] : @"Unknown Device";
+                    if (dataSize > 0) {
+                        AudioBufferList *bufferList = (AudioBufferList *)malloc(dataSize);
+                        AudioObjectGetPropertyData(deviceID, &propertyAddress, 0, NULL, &dataSize, bufferList);
                         
-                        NSDictionary *deviceInfo = @{
-                            @"id": [NSString stringWithFormat:@"%u", deviceID],
-                            @"name": deviceNameStr,
-                            @"manufacturer": @"System",
-                            @"type": @"system_audio",
-                            @"isDefault": @(NO)  // We'll determine default separately if needed
-                        };
+                        if (bufferList->mNumberBuffers > 0) {
+                            NSDictionary *deviceInfo = @{
+                                @"id": @(deviceID),
+                                @"name": (__bridge NSString *)deviceName,
+                                @"type": @"System Audio Input",
+                                @"isSystemDevice": @YES
+                            };
+                            
+                            [devices addObject:deviceInfo];
+                        }
                         
-                        [devices addObject:deviceInfo];
+                        free(bufferList);
                     }
                     
                     CFRelease(deviceName);
@@ -114,59 +94,23 @@
 }
 
 + (BOOL)hasAudioPermission {
-    // Check microphone permission using AVFoundation
-    AVAuthorizationStatus authStatus = [AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio];
-    return authStatus == AVAuthorizationStatusAuthorized;
+    if (@available(macOS 10.14, *)) {
+        AVAuthorizationStatus status = [AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio];
+        return status == AVAuthorizationStatusAuthorized;
+    }
+    return YES; // Older versions don't require explicit permission
 }
 
 + (void)requestAudioPermission:(void(^)(BOOL granted))completion {
-    [AVCaptureDevice requestAccessForMediaType:AVMediaTypeAudio completionHandler:^(BOOL granted) {
-        dispatch_async(dispatch_get_main_queue(), ^{
-            if (completion) {
+    if (@available(macOS 10.14, *)) {
+        [AVCaptureDevice requestAccessForMediaType:AVMediaTypeAudio completionHandler:^(BOOL granted) {
+            dispatch_async(dispatch_get_main_queue(), ^{
                 completion(granted);
-            }
-        });
-    }];
-}
-
-@end
-
-// ScreenCaptureKit Audio Configuration Helper
-API_AVAILABLE(macos(12.3))
-@interface SCKAudioConfiguration : NSObject
-
-+ (BOOL)configureAudioForStream:(SCStreamConfiguration *)config 
-                 includeMicrophone:(BOOL)includeMicrophone
-               includeSystemAudio:(BOOL)includeSystemAudio
-                  microphoneDevice:(NSString *)micDeviceID
-                systemAudioDevice:(NSString *)sysDeviceID;
-
-@end
-
-@implementation SCKAudioConfiguration
-
-+ (BOOL)configureAudioForStream:(SCStreamConfiguration *)config 
-                 includeMicrophone:(BOOL)includeMicrophone
-               includeSystemAudio:(BOOL)includeSystemAudio
-                  microphoneDevice:(NSString *)micDeviceID
-                systemAudioDevice:(NSString *)sysDeviceID {
-    
-    // Configure system audio capture (requires macOS 13.0+)
-    if (@available(macOS 13.0, *)) {
-        config.capturesAudio = includeSystemAudio;
-        config.excludesCurrentProcessAudio = YES;
-        
-        if (includeSystemAudio) {
-            // ScreenCaptureKit will capture system audio from the selected content
-            // Quality settings
-            config.channelCount = 2;  // Stereo
-            config.sampleRate = 48000; // 48kHz
-        } else {
-            config.capturesAudio = NO;
-        }
+            });
+        }];
+    } else {
+        completion(YES);
     }
-    
-    return YES;
 }
 
-@end
+@end 

package/src/cursor_tracker.mm

@@ -168,7 +168,7 @@ void writeToFile(NSDictionary *cursorData) {
                                                                options:0
                                                                  error:&error];
             if (jsonData && !error) {
-                NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
+                NSString *jsonString = [[[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding] autorelease];
                 
                 if (g_isFirstWrite) {
                     // İlk yazma - array başlat
@@ -292,6 +292,7 @@ void cleanupCursorTracking() {
     }
     
     if (g_timerTarget) {
+        [g_timerTarget autorelease];
         g_timerTarget = nil;
     }
     
@@ -351,12 +352,12 @@ Napi::Value StartCursorTracking(const Napi::CallbackInfo& info) {
     @try {
         // Dosyayı oluştur ve aç
         g_outputPath = [NSString stringWithUTF8String:outputPath.c_str()];
-        g_fileHandle = [NSFileHandle fileHandleForWritingAtPath:g_outputPath];
+        g_fileHandle = [[NSFileHandle fileHandleForWritingAtPath:g_outputPath] retain];
         
         if (!g_fileHandle) {
             // Dosya yoksa oluştur
             [[NSFileManager defaultManager] createFileAtPath:g_outputPath contents:nil attributes:nil];
-            g_fileHandle = [NSFileHandle fileHandleForWritingAtPath:g_outputPath];
+            g_fileHandle = [[NSFileHandle fileHandleForWritingAtPath:g_outputPath] retain];
         }
         
         if (!g_fileHandle) {