node-mac-recorder 2.24.8 → 2.24.10

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.24.8",
+	"version": "2.24.10",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -123,6 +123,10 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             MRLog(@"🔍 Scale factor: %.1fx → Standard display", scaleFactor);
         }
         
+        // H.264 4:2:0 CIFT boyut ister — bkz. screen_capture_kit.mm'deki ayni guard.
+        recordingSize.width = MAX(2.0, floor(recordingSize.width / 2.0) * 2.0);
+        recordingSize.height = MAX(2.0, floor(recordingSize.height / 2.0) * 2.0);
+
         MRLog(@"🎯 Recording size: %.0fx%.0f (using actual physical dimensions for Retina fix)", recordingSize.width, recordingSize.height);
         
         NSString *normalizedQuality = @"high";
@@ -140,7 +144,6 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
 
         NSString *codecKey = AVVideoCodecTypeH264;
         NSInteger bitrate = kAVFoundationHighQualityVideoBitrate;
-        NSNumber *qualityHint = @1.0;
 
         if ([normalizedQuality isEqualToString:@"low"]) {
             NSInteger multiplier = 10;
@@ -149,7 +152,6 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             bitrate = (NSInteger)(recordingSize.width * recordingSize.height * multiplier);
             bitrate = MAX(bitrate, minBitrate);
             bitrate = MIN(bitrate, maxBitrate);
-            qualityHint = @0.85;
         } else if ([normalizedQuality isEqualToString:@"medium"]) {
             NSInteger multiplier = 18;
             NSInteger minBitrate = 18 * 1000 * 1000;
@@ -157,7 +159,6 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             bitrate = (NSInteger)(recordingSize.width * recordingSize.height * multiplier);
             bitrate = MAX(bitrate, minBitrate);
             bitrate = MIN(bitrate, maxBitrate);
-            qualityHint = @0.9;
         } else { // high - çözünürlüğe DUYARLI yüksek kalite (eski sabit 50 Mbps yerine)
             NSInteger multiplier = 32; // ~0.53 bpp @60fps
             NSInteger minBitrate = kAVFoundationHighQualityVideoBitrate; // 100 Mbps taban
@@ -165,7 +166,6 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             bitrate = (NSInteger)(recordingSize.width * recordingSize.height * multiplier);
             bitrate = MAX(bitrate, minBitrate);
             bitrate = MIN(bitrate, maxBitrate);
-            qualityHint = @1.0;
         }
 
         MRLog(@"🎬 AVFoundation encoder (%@): %dx%d, codec=H.264 High Profile, bitrate=%.2fMbps",
@@ -183,14 +183,65 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
                 AVVideoMaxKeyFrameIntervalKey: @((int)fps),
                 AVVideoAllowFrameReorderingKey: @YES,
                 AVVideoExpectedSourceFrameRateKey: @((int)fps),
-                AVVideoQualityKey: qualityHint,
+                // AVVideoQualityKey BILEREK YOK — bkz. screen_capture_kit.mm:
+                // avc1 icin gecersiz, yazilim encoder yolunda AVAssetWriterInput
+                // istisna atip kaydi sessizce bos birakiyor.
                 AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
                 AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC
             }
         };
         
-        // Create video input
-        g_avVideoInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo outputSettings:videoSettings];
+        // Create video input — kademeli geri dusus (bkz. screen_capture_kit.mm).
+        // AVFoundation reddettigi sikistirma ozelliginde NSError degil ISTISNA
+        // atiyor; yakalanmazsa kayit sessizce bos cikiyor.
+        NSArray<NSDictionary *> *settingsTiers = @[
+            videoSettings,
+            @{
+                AVVideoCodecKey: codecKey,
+                AVVideoWidthKey: @((int)recordingSize.width),
+                AVVideoHeightKey: @((int)recordingSize.height),
+                AVVideoCompressionPropertiesKey: @{
+                    AVVideoAverageBitRateKey: @(bitrate),
+                    AVVideoMaxKeyFrameIntervalKey: @((int)fps),
+                    AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel
+                }
+            },
+            @{
+                AVVideoCodecKey: codecKey,
+                AVVideoWidthKey: @((int)recordingSize.width),
+                AVVideoHeightKey: @((int)recordingSize.height),
+                AVVideoCompressionPropertiesKey: @{ AVVideoAverageBitRateKey: @(bitrate) }
+            },
+            @{
+                AVVideoCodecKey: codecKey,
+                AVVideoWidthKey: @((int)recordingSize.width),
+                AVVideoHeightKey: @((int)recordingSize.height)
+            }
+        ];
+        g_avVideoInput = nil;
+        NSString *lastRejection = nil;
+        for (NSUInteger tier = 0; tier < settingsTiers.count; tier++) {
+            @try {
+                g_avVideoInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo
+                                                                   outputSettings:settingsTiers[tier]];
+            } @catch (NSException *exception) {
+                g_avVideoInput = nil;
+                lastRejection = exception.reason;
+                NSLog(@"⚠️ AVFoundation encoder settings tier %lu rejected: %@", (unsigned long)tier, exception.reason);
+                continue;
+            }
+            if (g_avVideoInput) {
+                if (tier > 0) {
+                    NSLog(@"⚠️ AVFoundation encoder fell back to settings tier %lu; last rejection: %@",
+                          (unsigned long)tier, lastRejection);
+                }
+                break;
+            }
+        }
+        if (!g_avVideoInput) {
+            NSLog(@"❌ AVFoundation: no accepted H.264 encoder settings (%@)", lastRejection ?: @"unknown");
+            return false;
+        }
         g_avVideoInput.expectsMediaDataInRealTime = YES;
         
         // Create pixel buffer adaptor with compatibility

package/src/cursor_tracker.mm

@@ -865,9 +865,30 @@ static bool g_leftMouseDown = false;
 static bool g_rightMouseDown = false;
 static NSString *g_lastEventType = @"move";
 
+// Erisilebilirlik izni durumu (istem GOSTERMEDEN).
+// NEDEN: izin yokken bile AX cagrilari yapiliyordu; macOS bunun uzerine
+// "Erisilebilirlik" izin dialogunu aciyor ve bu fonksiyon kayit boyunca
+// yuksek frekansta cagrildigi icin istem tekrar tekrar cikiyor. Durum
+// saniyede bir tazelenir: kullanici izni verdigi anda yol kendiliginden
+// devreye girer.
+static bool accessibilityTrustedCached(void) {
+    static CFAbsoluteTime lastCheck = 0;
+    static bool trusted = false;
+    CFAbsoluteTime now = CFAbsoluteTimeGetCurrent();
+    if (lastCheck == 0 || now - lastCheck > 1.0) {
+        trusted = AXIsProcessTrusted();
+        lastCheck = now;
+    }
+    return trusted;
+}
+
 // Accessibility tabanlı cursor tip tespiti
 static NSString* detectCursorTypeUsingAccessibility(CGPoint cursorPos) {
     @autoreleasepool {
+        if (!accessibilityTrustedCached()) {
+            return nil;
+        }
+
         AXUIElementRef systemWide = AXUIElementCreateSystemWide();
         if (!systemWide) {
             return nil;

package/src/screen_capture_kit.mm

@@ -936,8 +936,6 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
     SCKQualityBitrateForDimensions(normalizedQuality, width, height, encoderFPS,
                                    &bitrate, &bpp, &minBitrate, &maxBitrate);
 
-    NSNumber *qualityHint = [normalizedQuality isEqualToString:@"high"] ? @1.0 : ([normalizedQuality isEqualToString:@"medium"] ? @0.9 : @0.85);
-
     MRLog(@"🎬 Screen encoder (%@): %ldx%ld@%ldfps, codec=H.264 High Profile, bitrate=%.2fMbps (%.2f bpp, min=%ldMbps max=%ldMbps)",
           normalizedQuality,
           (long)width,
@@ -957,7 +955,14 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
         // edilebilir. Kapatmak fansiz makinelerde kare dusmesini azaltir.
         AVVideoAllowFrameReorderingKey: @NO,
         AVVideoExpectedSourceFrameRateKey: @(encoderFPS),
-        AVVideoQualityKey: qualityHint,
+        // AVVideoQualityKey BILEREK YOK: Apple belgesine gore yalnizca JPEG ve
+        // ProRes icin gecerli. H.264'te (avc1) donanim encoder'i onu sessizce
+        // yok sayiyordu, ama encoder yazilim yoluna dustugunde AVFoundation
+        // dogrulamasi sertlesiyor ve AVAssetWriterInput ISTISNA atiyor:
+        // "Compression property Quality is not supported for video codec type
+        // avc1". Istisna tum kayit kurulumunu iptal ettigi icin kayit "basladi"
+        // gorunup dosya hic olusmuyordu (editorde bos canvas). Kaliteyi zaten
+        // AVVideoAverageBitRateKey belirliyor.
         AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
         AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC,
         AVVideoAverageNonDroppableFrameRateKey: @(encoderFPS),
@@ -982,7 +987,75 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
         AVVideoCompressionPropertiesKey: compressionProps
     };
     
-    g_videoInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo outputSettings:videoSettings];
+    // AVFoundation, avc1 icin hangi sikistirma ozelligini kabul ettigine
+    // encoder yoluna gore karar veriyor ve reddettiginde NSError DEGIL ISTISNA
+    // atiyor. Istisna tum kayit kurulumunu iptal ettigi icin kayit "basladi"
+    // gorunup dosya hic olusmuyor; kullanici ancak editorde bos canvas gorunce
+    // anliyor. OLCULDU (macOS 26, 1x harici ekran, iTerm penceresi): once
+    // "Compression property Quality is not supported for video codec type avc1",
+    // o kaldirilinca "AverageNonDroppableFrameRate is not supported" — yani tek
+    // tek anahtar elemek guvenilir degil. Ayni ozelliklerle ayni ekrandaki baska
+    // pencereler sorunsuz calisiyor.
+    //
+    // Bu yuzden ayarlar KADEMELI denenir: once tam set, sonra yalnizca her
+    // encoder'in destekledigi cekirdek set, en sonda codec+boyut. Ilk kabul
+    // edilen kazanir; kayit hicbir kosulda sessizce bos cikmaz.
+    NSMutableArray<NSDictionary *> *settingsTiers = [NSMutableArray array];
+    [settingsTiers addObject:videoSettings];
+    [settingsTiers addObject:@{
+        AVVideoCodecKey: AVVideoCodecTypeH264,
+        AVVideoWidthKey: @(width),
+        AVVideoHeightKey: @(height),
+        AVVideoColorPropertiesKey: colorProps,
+        AVVideoCompressionPropertiesKey: @{
+            AVVideoAverageBitRateKey: @(bitrate),
+            AVVideoMaxKeyFrameIntervalKey: @(encoderFPS),
+            AVVideoAllowFrameReorderingKey: @NO,
+            AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel
+        }
+    }];
+    [settingsTiers addObject:@{
+        AVVideoCodecKey: AVVideoCodecTypeH264,
+        AVVideoWidthKey: @(width),
+        AVVideoHeightKey: @(height),
+        AVVideoCompressionPropertiesKey: @{ AVVideoAverageBitRateKey: @(bitrate) }
+    }];
+    [settingsTiers addObject:@{
+        AVVideoCodecKey: AVVideoCodecTypeH264,
+        AVVideoWidthKey: @(width),
+        AVVideoHeightKey: @(height)
+    }];
+
+    g_videoInput = nil;
+    NSString *lastRejection = nil;
+    for (NSUInteger tier = 0; tier < settingsTiers.count; tier++) {
+        @try {
+            g_videoInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo
+                                                             outputSettings:settingsTiers[tier]];
+        } @catch (NSException *exception) {
+            g_videoInput = nil;
+            lastRejection = exception.reason;
+            NSLog(@"⚠️ Video encoder settings tier %lu rejected: %@", (unsigned long)tier, exception.reason);
+            continue;
+        }
+        if (g_videoInput) {
+            if (tier > 0) {
+                NSLog(@"⚠️ Video encoder fell back to settings tier %lu (%ldx%ld); last rejection: %@",
+                      (unsigned long)tier, (long)width, (long)height, lastRejection);
+            }
+            break;
+        }
+    }
+    if (!g_videoInput) {
+        MRLog(@"❌ Video writer failed: no accepted encoder settings (%@)", lastRejection ?: @"unknown");
+        if (error) {
+            *error = [NSError errorWithDomain:@"ScreenCaptureKitRecorder" code:-101 userInfo:@{
+                NSLocalizedDescriptionKey: [NSString stringWithFormat:@"No accepted H.264 encoder settings: %@",
+                                            lastRejection ?: @"unknown"]
+            }];
+        }
+        return NO;
+    }
     g_videoInput.expectsMediaDataInRealTime = YES;
     
     AVAssetWriterInputPixelBufferAdaptor *pixelAdaptor = [AVAssetWriterInputPixelBufferAdaptor assetWriterInputPixelBufferAdaptorWithAssetWriterInput:g_videoInput sourcePixelBufferAttributes:@{
@@ -1786,6 +1859,18 @@ static void SCKPerformRecordingSetup(NSDictionary *config, SCShareableContent *c
                   (long)recordingHeight);
         }
 
+        // H.264 4:2:0 luma duzlemi CIFT boyut ister; tek sayili genislik/yukseklik
+        // encoder'i gereksiz yere yazilim yoluna itebiliyor. 1x harici ekranda
+        // pencere boyutlari dogrudan piksele esitlendigi icin (Retina'da 2x ile
+        // her zaman cift olur) tek sayilar yalnizca orada ortaya cikiyor.
+        // En fazla 1 piksel kirpilir; olcek/konum degismez.
+        // NOT: bu tek basina "bos kayit" hatasini cozmez — asil koruma asagidaki
+        // kademeli encoder ayari geri dususudur.
+        if (recordingWidth % 2 != 0) recordingWidth -= 1;
+        if (recordingHeight % 2 != 0) recordingHeight -= 1;
+        recordingWidth = MAX(2, recordingWidth);
+        recordingHeight = MAX(2, recordingHeight);
+
         SCStreamConfiguration *streamConfig = [[SCStreamConfiguration alloc] init];
         streamConfig.width = recordingWidth;
         streamConfig.height = recordingHeight;

package/src/window_selector.mm

@@ -898,10 +898,57 @@ bool activateWindowOwnerApp(int windowId) {
     }
 }
 
+// Hedef pencerenin sahibi uygulamayi ONE ALIR (Accessibility GEREKTIRMEZ).
+// bringWindowToFront'un AX yolu izin isterken bu yol yalnizca
+// NSRunningApplication kullanir; izin yokken tek calisan yol budur.
+static bool activateOwnerAppForWindow(int windowId) {
+    @autoreleasepool {
+        // Method 2: Light activation fallback (minimal app activation)
+        NSLog(@"   🔄 Trying minimal activation for window %d", windowId);
+    
+        // Get window info to find the process
+        CFArrayRef cgWindowList = CGWindowListCopyWindowInfo(kCGWindowListOptionAll, kCGNullWindowID);
+        if (cgWindowList) {
+            NSArray *windowArray = (__bridge NSArray *)cgWindowList;
+        
+            for (NSDictionary *windowInfo in windowArray) {
+                NSNumber *cgWindowId = [windowInfo objectForKey:(NSString *)kCGWindowNumber];
+                if ([cgWindowId intValue] == windowId) {
+                    // Get process ID
+                    NSNumber *processId = [windowInfo objectForKey:(NSString *)kCGWindowOwnerPID];
+                    if (processId) {
+                        // Light activation - only bring app to front, don't activate all windows
+                        NSRunningApplication *app = [NSRunningApplication runningApplicationWithProcessIdentifier:[processId intValue]];
+                        if (app) {
+                            // Use NSApplicationActivateIgnoringOtherApps only (no NSApplicationActivateAllWindows)
+                            [app activateWithOptions:NSApplicationActivateIgnoringOtherApps];
+                            NSLog(@"   ✅ App minimally activated: PID %d (specific window should be frontmost)", [processId intValue]);
+                            CFRelease(cgWindowList);
+                            return true;
+                        }
+                    }
+                    break;
+                }
+            }
+            CFRelease(cgWindowList);
+        }
+        return false;
+    }
+}
+
 // Bring window to front using Accessibility API
 bool bringWindowToFront(int windowId) {
     @autoreleasepool {
         @try {
+            // TCC istemi CIKMASIN: untrusted bir surecin systemWide element
+            // uzerindeki AX cagrilari macOS'a "Erisilebilirlik" dialogunu
+            // actiriyor — pencere kaydi HER baslatildiginda yeniden. Izin yoksa
+            // AX yolunu hic deneme; hafif aktivasyon zaten ayni isi goruyor.
+            // AXIsProcessTrusted() kendisi istem GOSTERMEZ.
+            if (!AXIsProcessTrusted()) {
+                return activateOwnerAppForWindow(windowId);
+            }
+
             // Method 1: Using Accessibility API (most reliable)
             AXUIElementRef systemWide = AXUIElementCreateSystemWide();
             if (!systemWide) return false;
@@ -965,35 +1012,8 @@ bool bringWindowToFront(int windowId) {
             
             CFRelease(systemWide);
             
-            // Method 2: Light activation fallback (minimal app activation)
-            NSLog(@"   🔄 Trying minimal activation for window %d", windowId);
-            
-            // Get window info to find the process
-            CFArrayRef cgWindowList = CGWindowListCopyWindowInfo(kCGWindowListOptionAll, kCGNullWindowID);
-            if (cgWindowList) {
-                NSArray *windowArray = (__bridge NSArray *)cgWindowList;
-                
-                for (NSDictionary *windowInfo in windowArray) {
-                    NSNumber *cgWindowId = [windowInfo objectForKey:(NSString *)kCGWindowNumber];
-                    if ([cgWindowId intValue] == windowId) {
-                        // Get process ID
-                        NSNumber *processId = [windowInfo objectForKey:(NSString *)kCGWindowOwnerPID];
-                        if (processId) {
-                            // Light activation - only bring app to front, don't activate all windows
-                            NSRunningApplication *app = [NSRunningApplication runningApplicationWithProcessIdentifier:[processId intValue]];
-                            if (app) {
-                                // Use NSApplicationActivateIgnoringOtherApps only (no NSApplicationActivateAllWindows)
-                                [app activateWithOptions:NSApplicationActivateIgnoringOtherApps];
-                                NSLog(@"   ✅ App minimally activated: PID %d (specific window should be frontmost)", [processId intValue]);
-                                CFRelease(cgWindowList);
-                                return true;
-                            }
-                        }
-                        break;
-                    }
-                }
-                CFRelease(cgWindowList);
-            }
+            // AX yolu pencereyi bulamadi → izinsiz de calisan hafif aktivasyon.
+            if (activateOwnerAppForWindow(windowId)) return true;
             
             return false;