node-mac-recorder 2.22.34 → 2.23.0

package/.claude/settings.local.json

@@ -50,7 +50,13 @@
       "Bash(ffmpeg:*)",
       "Bash(timeout 30 node:*)",
       "Bash(MAC_RECORDER_DEBUG=1 node test-camera-audio-sync.js:*)",
-      "WebSearch"
+      "WebSearch",
+      "mcp__plugin_context-mode_context-mode__ctx_execute_file",
+      "mcp__plugin_context-mode_context-mode__ctx_execute",
+      "mcp__plugin_context-mode_context-mode__ctx_batch_execute",
+      "Bash(nm -D /System/Library/Frameworks/AppKit.framework/AppKit)",
+      "Bash(otool -L /System/Library/Frameworks/AppKit.framework/AppKit)",
+      "Bash(mdfind -name CoreCursor)"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.22.34",
+	"version": "2.23.0",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -36,7 +36,8 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
                                            bool includeSystemAudio,
                                            NSString* audioDeviceId,
                                            NSString* audioOutputPath,
-                                           double requestedFrameRate) {
+                                           double requestedFrameRate,
+                                           NSString* qualityPreset) {
     
     if (g_avIsRecording) {
         NSLog(@"❌ AVFoundation recording already in progress");
@@ -123,43 +124,61 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         
         MRLog(@"🎯 Recording size: %.0fx%.0f (using actual physical dimensions for Retina fix)", recordingSize.width, recordingSize.height);
         
-        // Video settings with macOS compatibility
-        NSString *codecKey;
-        if (@available(macOS 10.13, *)) {
-            codecKey = AVVideoCodecTypeH264;
-        } else {
-            // Fallback for older macOS versions
-            codecKey = AVVideoCodecH264;
+        NSString *normalizedQuality = @"high";
+        if ([qualityPreset isKindOfClass:[NSString class]] && qualityPreset.length > 0) {
+            normalizedQuality = [qualityPreset lowercaseString];
+            if (![normalizedQuality isEqualToString:@"low"] &&
+                ![normalizedQuality isEqualToString:@"medium"] &&
+                ![normalizedQuality isEqualToString:@"high"]) {
+                normalizedQuality = @"high";
+            }
         }
-        
-        NSInteger bitrate = (NSInteger)(recordingSize.width * recordingSize.height * 100);
-        bitrate = MAX(bitrate, 120 * 1000 * 1000);
-        bitrate = MIN(bitrate, 500 * 1000 * 1000);
+        BOOL useProRes = [normalizedQuality isEqualToString:@"high"];
 
-        NSLog(@"🎬 ULTRA QUALITY AVFoundation: %dx%d, bitrate=%.2fMbps",
-              (int)recordingSize.width, (int)recordingSize.height, bitrate / (1000.0 * 1000.0));
-
-        // Resolve target FPS
         double fps = requestedFrameRate > 0 ? requestedFrameRate : 60.0;
         if (fps < 1.0) fps = 1.0;
         if (fps > 120.0) fps = 120.0;
 
-        NSDictionary *videoSettings = @{
-            AVVideoCodecKey: codecKey,
-            AVVideoWidthKey: @((int)recordingSize.width),
-            AVVideoHeightKey: @((int)recordingSize.height),
-            AVVideoCompressionPropertiesKey: @{
-                AVVideoAverageBitRateKey: @(bitrate),
-                AVVideoMaxKeyFrameIntervalKey: @((int)fps),
-                AVVideoAllowFrameReorderingKey: @YES,
-                AVVideoExpectedSourceFrameRateKey: @((int)fps),
-                AVVideoQualityKey: @(1.0),
-                AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
-                AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC
-            }
-        };
+        NSDictionary *videoSettings = nil;
+        if (useProRes) {
+            MRLog(@"🎬 AVFoundation encoder (high): %dx%d, codec=ProRes 422 HQ",
+                  (int)recordingSize.width, (int)recordingSize.height);
+            videoSettings = @{
+                AVVideoCodecKey: AVVideoCodecTypeAppleProRes422HQ,
+                AVVideoWidthKey: @((int)recordingSize.width),
+                AVVideoHeightKey: @((int)recordingSize.height)
+            };
+        } else {
+            NSString *codecKey = AVVideoCodecTypeH264;
+            NSInteger multiplier = [normalizedQuality isEqualToString:@"medium"] ? 18 : 10;
+            NSInteger minBitrate = [normalizedQuality isEqualToString:@"medium"] ? (18 * 1000 * 1000) : (10 * 1000 * 1000);
+            NSInteger maxBitrate = [normalizedQuality isEqualToString:@"medium"] ? (80 * 1000 * 1000) : (45 * 1000 * 1000);
+            NSInteger bitrate = (NSInteger)(recordingSize.width * recordingSize.height * multiplier);
+            bitrate = MAX(bitrate, minBitrate);
+            bitrate = MIN(bitrate, maxBitrate);
+            NSNumber *qualityHint = [normalizedQuality isEqualToString:@"medium"] ? @0.9 : @0.85;
+
+            MRLog(@"🎬 AVFoundation encoder (%@): %dx%d, codec=H.264, bitrate=%.2fMbps",
+                  normalizedQuality,
+                  (int)recordingSize.width,
+                  (int)recordingSize.height,
+                  bitrate / (1000.0 * 1000.0));
 
-        NSLog(@"🔧 Using codec: %@", codecKey);
+            videoSettings = @{
+                AVVideoCodecKey: codecKey,
+                AVVideoWidthKey: @((int)recordingSize.width),
+                AVVideoHeightKey: @((int)recordingSize.height),
+                AVVideoCompressionPropertiesKey: @{
+                    AVVideoAverageBitRateKey: @(bitrate),
+                    AVVideoMaxKeyFrameIntervalKey: @((int)fps),
+                    AVVideoAllowFrameReorderingKey: @YES,
+                    AVVideoExpectedSourceFrameRateKey: @((int)fps),
+                    AVVideoQualityKey: qualityHint,
+                    AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
+                    AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC
+                }
+            };
+        }
         
         // Create video input
         g_avVideoInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo outputSettings:videoSettings];

package/src/mac_recorder.mm

@@ -21,7 +21,8 @@ extern "C" {
                                    bool includeSystemAudio,
                                    NSString* audioDeviceId,
                                    NSString* audioOutputPath,
-                                   double frameRate);
+                                   double frameRate,
+                                   NSString* qualityPreset);
     bool stopAVFoundationRecording();
     bool isAVFoundationRecording();
     NSString* getAVFoundationAudioPath();
@@ -728,7 +729,8 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                                                    bool includeSystemAudio,
                                                    NSString* audioDeviceId,
                                                    NSString* audioOutputPath,
-                                                   double frameRate);
+                                                   double frameRate,
+                                                   NSString* qualityPreset);
 
             // A/V SYNC: Start camera non-blocking BEFORE AVFoundation
             if (captureCamera) {
@@ -742,7 +744,8 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             MRLog(@"🎯 SYNC: Starting screen recording");
             bool avResult = startAVFoundationRecording(outputPath, displayID, windowID, captureRect,
                                                       captureCursor, includeMicrophone, includeSystemAudio,
-                                                      audioDeviceId, audioOutputPath, frameRate);
+                                                      audioDeviceId, audioOutputPath, frameRate,
+                                                      qualityPreset ?: @"high");
 
             if (avResult) {
                 MRLog(@"🎥 RECORDING METHOD: AVFoundation");

package/src/screen_capture_kit.mm

@@ -776,48 +776,59 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
         return NO;
     }
     
-    NSInteger bitrate = 0;
-    NSInteger bitrateMultiplier = 0;
-    NSInteger minBitrate = 0;
-    NSInteger maxBitrate = 0;
     NSString *normalizedQuality = SCKNormalizeQualityPreset(g_qualityPreset);
-    SCKQualityBitrateForDimensions(normalizedQuality, width, height, &bitrate, &bitrateMultiplier, &minBitrate, &maxBitrate);
-
-    NSNumber *qualityHint = @1.0;
-    if ([normalizedQuality isEqualToString:@"medium"]) {
-        qualityHint = @0.9;
-    } else if ([normalizedQuality isEqualToString:@"low"]) {
-        qualityHint = @0.85;
-    }
-
-    MRLog(@"🎬 Screen encoder (%@): %ldx%ld, multiplier=%ld, bitrate=%.2fMbps (min=%ldMbps max=%ldMbps)",
-          normalizedQuality,
-          (long)width,
-          (long)height,
-          (long)bitrateMultiplier,
-          bitrate / (1000.0 * 1000.0),
-          (long)(minBitrate / (1000 * 1000)),
-          (long)(maxBitrate / (1000 * 1000)));
-
-    NSDictionary *compressionProps = @{
-        AVVideoAverageBitRateKey: @(bitrate),
-        AVVideoMaxKeyFrameIntervalKey: @(MAX(1, g_targetFPS)),
-        AVVideoAllowFrameReorderingKey: @YES,
-        AVVideoExpectedSourceFrameRateKey: @(MAX(1, g_targetFPS)),
-        AVVideoQualityKey: qualityHint,  // 0.0-1.0, higher is better
-        AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
-        AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC,
-        // Add data rate limits for consistent quality during motion
-        AVVideoAverageNonDroppableFrameRateKey: @(MAX(1, g_targetFPS)),
-        AVVideoMaxKeyFrameIntervalDurationKey: @(1.0)  // Keyframe at least every second
-    };
-
-    NSDictionary *videoSettings = @{
-        AVVideoCodecKey: AVVideoCodecTypeH264,
-        AVVideoWidthKey: @(width),
-        AVVideoHeightKey: @(height),
-        AVVideoCompressionPropertiesKey: compressionProps
-    };
+    BOOL useProRes = [normalizedQuality isEqualToString:@"high"];
+
+    NSDictionary *videoSettings = nil;
+
+    if (useProRes) {
+        // Screen Studio-style: ProRes 422 HQ — intra-frame, visually lossless,
+        // hardware-accelerated on Apple Silicon. Best for editor scrubbing & high-zoom clarity.
+        MRLog(@"🎬 Screen encoder (high): %ldx%ld, codec=ProRes 422 HQ",
+              (long)width, (long)height);
+
+        videoSettings = @{
+            AVVideoCodecKey: AVVideoCodecTypeAppleProRes422HQ,
+            AVVideoWidthKey: @(width),
+            AVVideoHeightKey: @(height)
+        };
+    } else {
+        NSInteger bitrate = 0;
+        NSInteger bitrateMultiplier = 0;
+        NSInteger minBitrate = 0;
+        NSInteger maxBitrate = 0;
+        SCKQualityBitrateForDimensions(normalizedQuality, width, height, &bitrate, &bitrateMultiplier, &minBitrate, &maxBitrate);
+
+        NSNumber *qualityHint = [normalizedQuality isEqualToString:@"medium"] ? @0.9 : @0.85;
+
+        MRLog(@"🎬 Screen encoder (%@): %ldx%ld, codec=H.264, multiplier=%ld, bitrate=%.2fMbps (min=%ldMbps max=%ldMbps)",
+              normalizedQuality,
+              (long)width,
+              (long)height,
+              (long)bitrateMultiplier,
+              bitrate / (1000.0 * 1000.0),
+              (long)(minBitrate / (1000 * 1000)),
+              (long)(maxBitrate / (1000 * 1000)));
+
+        NSDictionary *compressionProps = @{
+            AVVideoAverageBitRateKey: @(bitrate),
+            AVVideoMaxKeyFrameIntervalKey: @(MAX(1, g_targetFPS)),
+            AVVideoAllowFrameReorderingKey: @YES,
+            AVVideoExpectedSourceFrameRateKey: @(MAX(1, g_targetFPS)),
+            AVVideoQualityKey: qualityHint,
+            AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
+            AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC,
+            AVVideoAverageNonDroppableFrameRateKey: @(MAX(1, g_targetFPS)),
+            AVVideoMaxKeyFrameIntervalDurationKey: @(1.0)
+        };
+
+        videoSettings = @{
+            AVVideoCodecKey: AVVideoCodecTypeH264,
+            AVVideoWidthKey: @(width),
+            AVVideoHeightKey: @(height),
+            AVVideoCompressionPropertiesKey: compressionProps
+        };
+    }
     
     g_videoInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo outputSettings:videoSettings];
     g_videoInput.expectsMediaDataInRealTime = YES;