node-mac-recorder 2.22.10 → 2.22.11

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.22.10",
+	"version": "2.22.11",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/electron_safe/screen_capture_electron.mm

@@ -50,6 +50,30 @@ static void initializeSafeQueue() {
     initializeSafeQueue();
 }
 
++ (BOOL)shouldAllowElectronWindows {
+    NSString *flag = [[[NSProcessInfo processInfo] environment] objectForKey:@"CREAVIT_ALLOW_ELECTRON_WINDOWS"];
+    if (!flag) return NO;
+
+    NSString *normalized = [[flag lowercaseString] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
+    return [normalized isEqualToString:@"1"] ||
+           [normalized isEqualToString:@"true"] ||
+           [normalized isEqualToString:@"yes"] ||
+           [normalized isEqualToString:@"on"];
+}
+
++ (BOOL)shouldSkipWindowOwner:(NSString *)appName {
+    if (!appName || appName.length == 0) return YES;
+    if ([appName containsString:@"WindowServer"] || [appName containsString:@"Dock"]) return YES;
+
+    if (![self shouldAllowElectronWindows]) {
+        if ([appName containsString:@"Electron"] || [appName containsString:@"node"]) {
+            return YES;
+        }
+    }
+
+    return NO;
+}
+
 + (BOOL)startRecordingWithPath:(NSString *)outputPath options:(NSDictionary *)options {
     if (@available(macOS 12.3, *)) {
         return [self startRecordingModern:outputPath options:options];
@@ -432,8 +456,7 @@ static void initializeSafeQueue() {
                         
                         NSString *appName = window.owningApplication.applicationName ?: @"Unknown";
                         
-                        // Skip Electron windows (our overlay)
-                        if ([appName containsString:@"Electron"] || [appName containsString:@"node"]) continue;
+                        if ([self shouldSkipWindowOwner:appName]) continue;
                         
                         NSDictionary *windowInfo = @{
                             @"id": @(window.windowID),

package/src/electron_safe/window_selector_electron.mm

@@ -12,6 +12,30 @@ static void initializeWindowQueue() {
     });
 }
 
+static BOOL ShouldAllowElectronWindows(void) {
+    NSString *flag = [[[NSProcessInfo processInfo] environment] objectForKey:@"CREAVIT_ALLOW_ELECTRON_WINDOWS"];
+    if (!flag) return NO;
+
+    NSString *normalized = [[flag lowercaseString] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
+    return [normalized isEqualToString:@"1"] ||
+           [normalized isEqualToString:@"true"] ||
+           [normalized isEqualToString:@"yes"] ||
+           [normalized isEqualToString:@"on"];
+}
+
+static BOOL ShouldSkipWindowOwner(NSString *appName) {
+    if (!appName || appName.length == 0) return YES;
+    if ([appName containsString:@"WindowServer"] || [appName containsString:@"Dock"]) return YES;
+
+    if (!ShouldAllowElectronWindows()) {
+        if ([appName containsString:@"Electron"] || [appName containsString:@"node"]) {
+            return YES;
+        }
+    }
+
+    return NO;
+}
+
 // NAPI Function: Get Windows (Electron-safe)
 Napi::Value GetWindowsElectronSafe(const Napi::CallbackInfo& info) {
     Napi::Env env = info.Env();
@@ -38,11 +62,7 @@ Napi::Value GetWindowsElectronSafe(const Napi::CallbackInfo& info) {
                                 
                                 NSString *appName = window.owningApplication.applicationName ?: @"Unknown";
                                 
-                                // Skip Electron windows (our overlay) and system windows
-                                if ([appName containsString:@"Electron"] || 
-                                    [appName containsString:@"node"] ||
-                                    [appName containsString:@"WindowServer"] ||
-                                    [appName containsString:@"Dock"]) continue;
+                                if (ShouldSkipWindowOwner(appName)) continue;
                                 
                                 NSDictionary *windowInfo = @{
                                     @"id": @(window.windowID),
@@ -94,11 +114,7 @@ Napi::Value GetWindowsElectronSafe(const Napi::CallbackInfo& info) {
                             NSString *appName = (__bridge NSString*)ownerName;
                             NSString *windowTitle = windowName ? (__bridge NSString*)windowName : @"";
                             
-                            // Skip Electron windows and system windows
-                            if ([appName containsString:@"Electron"] || 
-                                [appName containsString:@"node"] ||
-                                [appName containsString:@"WindowServer"] ||
-                                [appName containsString:@"Dock"]) continue;
+                            if (ShouldSkipWindowOwner(appName)) continue;
                             
                             // Get window bounds
                             CGRect bounds = CGRectZero;

package/src/window_selector.mm

@@ -56,6 +56,31 @@ static id g_screenKeyEventMonitor = nil;
 static NSTimer *g_screenTrackingTimer = nil;
 static NSInteger g_currentActiveScreenIndex = -1;
 
+static bool shouldAllowElectronWindows() {
+    NSString *flag = [[[NSProcessInfo processInfo] environment] objectForKey:@"CREAVIT_ALLOW_ELECTRON_WINDOWS"];
+    if (!flag) return false;
+
+    NSString *normalized = [[flag lowercaseString] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
+    return [normalized isEqualToString:@"1"] ||
+           [normalized isEqualToString:@"true"] ||
+           [normalized isEqualToString:@"yes"] ||
+           [normalized isEqualToString:@"on"];
+}
+
+static bool shouldSkipSelectableWindowOwner(NSString *windowOwner) {
+    if (!windowOwner || [windowOwner length] == 0) return true;
+    if ([windowOwner isEqualToString:@"WindowServer"]) return true;
+    if ([windowOwner isEqualToString:@"Dock"]) return true;
+
+    if (!shouldAllowElectronWindows()) {
+        if ([windowOwner containsString:@"Electron"] || [windowOwner containsString:@"node"]) {
+            return true;
+        }
+    }
+
+    return false;
+}
+
 // Record icon helpers
 static NSImage *CreateRecordIconImage(CGFloat size) {
     const CGFloat leadingInset = 24.0;
@@ -757,12 +782,7 @@ NSArray* getAllSelectableWindows() {
                 
                 // Skip system windows, dock, menu bar, etc.
                 if ([windowLayer intValue] != 0) continue; // Only normal windows
-                if (!windowOwner || [windowOwner length] == 0) continue;
-                if ([windowOwner isEqualToString:@"WindowServer"]) continue;
-                if ([windowOwner isEqualToString:@"Dock"]) continue;
-                
-                // Skip Electron windows (our own overlay)
-                if ([windowOwner containsString:@"Electron"] || [windowOwner containsString:@"node"]) continue;
+                if (shouldSkipSelectableWindowOwner(windowOwner)) continue;
                 
                 // Extract bounds
                 int x = [[bounds objectForKey:@"X"] intValue];
@@ -802,8 +822,7 @@ NSDictionary* getWindowUnderCursor(CGPoint point) {
         for (NSDictionary *window in g_allWindows) {
             NSString *appName = [window objectForKey:@"appName"];
             
-            // Skip Electron windows (our own overlay)
-            if (appName && ([appName containsString:@"Electron"] || [appName containsString:@"node"])) {
+            if (shouldSkipSelectableWindowOwner(appName)) {
                 continue;
             }