node-mac-recorder 2.21.6 → 2.21.8

package/.claude/settings.local.json

@@ -10,7 +10,9 @@
       "Bash(MAC_RECORDER_DEBUG=1 node:*)",
       "Read(//private/tmp/test-recording/**)",
       "Bash(MAC_RECORDER_DEBUG=1 timeout 5 node:*)",
-      "Read(//private/tmp/**)"
+      "Read(//private/tmp/**)",
+      "Bash(ffprobe:*)",
+      "Bash(MAC_RECORDER_DEBUG=1 timeout 8 node:*)"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.21.6",
+	"version": "2.21.8",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/audio_recorder.mm

@@ -369,4 +369,37 @@ NSString *currentStandaloneAudioRecordingPath() {
     return g_audioRecorder.outputPath;
 }
 
+// C API for AVFoundation integration
+void* createNativeAudioRecorder() {
+    return (__bridge_retained void*)[[NativeAudioRecorder alloc] init];
+}
+
+bool startNativeAudioRecording(void* recorder, const char* deviceId, const char* outputPath) {
+    if (!recorder || !outputPath) {
+        return false;
+    }
+
+    NativeAudioRecorder* audioRecorder = (__bridge NativeAudioRecorder*)recorder;
+    NSString* deviceIdStr = deviceId ? [NSString stringWithUTF8String:deviceId] : nil;
+    NSString* outputPathStr = [NSString stringWithUTF8String:outputPath];
+
+    NSError* error = nil;
+    return [audioRecorder startRecordingWithDeviceId:deviceIdStr outputPath:outputPathStr error:&error];
+}
+
+bool stopNativeAudioRecording(void* recorder) {
+    if (!recorder) {
+        return false;
+    }
+
+    NativeAudioRecorder* audioRecorder = (__bridge NativeAudioRecorder*)recorder;
+    return [audioRecorder stopRecording];
+}
+
+void destroyNativeAudioRecorder(void* recorder) {
+    if (recorder) {
+        CFRelease(recorder);
+    }
+}
+
 }

package/src/avfoundation_recorder.mm

@@ -7,6 +7,12 @@
 #include <string>
 #import "logging.h"
 
+// Import audio recorder
+extern "C" void* createNativeAudioRecorder(void);
+extern "C" bool startNativeAudioRecording(void* recorder, const char* deviceId, const char* outputPath);
+extern "C" bool stopNativeAudioRecording(void* recorder);
+extern "C" void destroyNativeAudioRecorder(void* recorder);
+
 static AVAssetWriter *g_avWriter = nil;
 static AVAssetWriterInput *g_avVideoInput = nil;
 static AVAssetWriterInputPixelBufferAdaptor *g_avPixelBufferAdaptor = nil;
@@ -16,6 +22,8 @@ static CGRect g_avCaptureRect = CGRectZero;
 static bool g_avIsRecording = false;
 static int64_t g_avFrameNumber = 0;
 static CMTime g_avStartTime;
+static void* g_avAudioRecorder = nil;
+static NSString* g_avAudioOutputPath = nil;
 
 // AVFoundation screen recording implementation
 extern "C" bool startAVFoundationRecording(const std::string& outputPath, 
@@ -197,7 +205,38 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         }
         
         g_avFrameNumber = 0;
-        
+
+        // Start audio recording if requested
+        if (includeMicrophone || includeSystemAudio) {
+            MRLog(@"🎤 Starting audio capture (mic=%d, system=%d)", includeMicrophone, includeSystemAudio);
+
+            // Generate audio output path
+            NSString *videoDir = [outputPathStr stringByDeletingLastPathComponent];
+            NSString *audioFilename = [NSString stringWithFormat:@"avf_audio_%ld.mov", (long)[[NSDate date] timeIntervalSince1970]];
+            g_avAudioOutputPath = [videoDir stringByAppendingPathComponent:audioFilename];
+
+            MRLog(@"🎤 Audio output: %@", g_avAudioOutputPath);
+
+            // Create audio recorder
+            g_avAudioRecorder = createNativeAudioRecorder();
+
+            if (g_avAudioRecorder) {
+                const char* deviceIdCStr = audioDeviceId ? [audioDeviceId UTF8String] : NULL;
+                const char* outputPathCStr = [g_avAudioOutputPath UTF8String];
+
+                if (startNativeAudioRecording(g_avAudioRecorder, deviceIdCStr, outputPathCStr)) {
+                    MRLog(@"✅ Audio recording started");
+                } else {
+                    NSLog(@"❌ Failed to start audio recording");
+                    destroyNativeAudioRecorder(g_avAudioRecorder);
+                    g_avAudioRecorder = nil;
+                    g_avAudioOutputPath = nil;
+                }
+            } else {
+                NSLog(@"❌ Failed to create audio recorder");
+            }
+        }
+
         // Start capture timer (10 FPS for Electron compatibility)
         dispatch_queue_t captureQueue = dispatch_queue_create("AVFoundationCaptureQueue", DISPATCH_QUEUE_SERIAL);
         g_avTimer = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER, 0, 0, captureQueue);
@@ -348,9 +387,18 @@ extern "C" bool stopAVFoundationRecording() {
     if (!g_avIsRecording) {
         return true;
     }
-    
+
     g_avIsRecording = false;
-    
+
+    // Stop audio recording if active
+    if (g_avAudioRecorder) {
+        MRLog(@"🛑 Stopping audio recording");
+        stopNativeAudioRecording(g_avAudioRecorder);
+        destroyNativeAudioRecorder(g_avAudioRecorder);
+        g_avAudioRecorder = nil;
+        MRLog(@"✅ Audio recording stopped");
+    }
+
     @try {
         // Stop timer with Electron-safe cleanup
         if (g_avTimer) {

package/src/mac_recorder.mm

@@ -343,10 +343,18 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             MRLog(@"   Reason: ScreenCaptureKit has thread safety issues in Electron (SIGTRAP crashes)");
         }
 
-        // Force AVFoundation for debugging/testing OR Electron
-        BOOL forceAVFoundation = (getenv("FORCE_AVFOUNDATION") != NULL) || isElectron;
-        if (getenv("FORCE_AVFOUNDATION") != NULL) {
-            MRLog(@"🔧 FORCE_AVFOUNDATION environment variable detected");
+        // CRITICAL FIX: ScreenCaptureKit causes segmentation faults
+        // Forcing AVFoundation for ALL environments until issue is resolved
+        // TODO: Implement audio capture in AVFoundation
+        BOOL forceAVFoundation = YES;
+
+        MRLog(@"🔧 CRITICAL: ScreenCaptureKit disabled globally (segfault issue)");
+        MRLog(@"   Using AVFoundation for stability");
+        MRLog(@"   ⚠️  WARNING: Audio capture not available in AVFoundation mode");
+        MRLog(@"   Audio files will be created but will be empty");
+
+        if (isElectron) {
+            MRLog(@"⚡ Electron environment detected - using stable AVFoundation");
         }
 
         // Electron-first priority: ALWAYS use AVFoundation in Electron for stability