node-mac-recorder 2.21.30 → 2.21.32

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.21.30",
+	"version": "2.21.32",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/camera_recorder.mm

@@ -724,27 +724,43 @@ static BOOL MRIsContinuityCamera(AVCaptureDevice *device) {
     MRLog(@"🛑 CameraRecorder: Stopping session (external device safe)...");
 
     self.isShuttingDown = YES;
-    self.isRecording = NO;
-
-    // Stop delegate FIRST to prevent new frames
-    [self.videoOutput setSampleBufferDelegate:nil queue:nil];
 
-    // Stop session on background thread to avoid blocking
+    // Stop session on background thread to avoid blocking, but wait briefly so we capture trailing frames.
     AVCaptureSession *sessionToStop = self.session;
-    dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0), ^{
-        @autoreleasepool {
-            @try {
-                if ([sessionToStop isRunning]) {
-                    MRLog(@"🛑 Stopping AVCaptureSession (camera)...");
-                    [sessionToStop stopRunning];
-                    MRLog(@"✅ AVCaptureSession stopped (camera)");
+
+    dispatch_group_t sessionStopGroup = NULL;
+    if (sessionToStop) {
+        sessionStopGroup = dispatch_group_create();
+        dispatch_group_enter(sessionStopGroup);
+        dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0), ^{
+            @autoreleasepool {
+                @try {
+                    if ([sessionToStop isRunning]) {
+                        MRLog(@"🛑 Stopping AVCaptureSession (camera)...");
+                        [sessionToStop stopRunning];
+                        MRLog(@"✅ AVCaptureSession stopped (camera)");
+                    }
+                } @catch (NSException *exception) {
+                    MRLog(@"⚠️ CameraRecorder: Exception while stopping session: %@", exception.reason);
                 }
-            } @catch (NSException *exception) {
-                MRLog(@"⚠️ CameraRecorder: Exception while stopping session: %@", exception.reason);
+                dispatch_group_leave(sessionStopGroup);
             }
-            // Release happens automatically when block completes
+        });
+    }
+
+    if (sessionStopGroup) {
+        dispatch_time_t sessionTimeout = dispatch_time(DISPATCH_TIME_NOW, (int64_t)(2 * NSEC_PER_SEC));
+        long waitResult = dispatch_group_wait(sessionStopGroup, sessionTimeout);
+        if (waitResult != 0) {
+            MRLog(@"⚠️ CameraRecorder: AVCaptureSession stop timed out after 2s (continuing shutdown)");
         }
-    });
+    }
+
+    // Now detach delegate to prevent further callbacks
+    if (self.videoOutput) {
+        [self.videoOutput setSampleBufferDelegate:nil queue:nil];
+    }
+    self.isRecording = NO;
 
     // CRITICAL FIX: Check if assetWriter exists before trying to finish it
     // If no frames were captured, assetWriter will be nil
@@ -801,7 +817,7 @@ static BOOL MRIsContinuityCamera(AVCaptureDevice *device) {
 - (void)captureOutput:(AVCaptureOutput *)output
  didOutputSampleBuffer:(CMSampleBufferRef)sampleBuffer
         fromConnection:(AVCaptureConnection *)connection {
-    if (!self.isRecording || self.isShuttingDown) {
+    if (!self.isRecording) {
         return;
     }
 

package/src/sync_timeline.mm

@@ -71,7 +71,7 @@ BOOL MRSyncShouldHoldVideoFrame(CMTime timestamp) {
         }
 
         CMTime elapsed = CMTimeSubtract(timestamp, g_videoFirstTimestamp);
-        CMTime maxWait = CMTimeMakeWithSeconds(1.5, 600);
+        CMTime maxWait = CMTimeMakeWithSeconds(0.25, 600); // Kamera gecikmesini minimumda tut
         if (CMTIME_COMPARE_INLINE(elapsed, >, maxWait)) {
             g_audioReady = YES;
             g_videoFirstTimestamp = kCMTimeInvalid;
@@ -85,9 +85,9 @@ BOOL MRSyncShouldHoldVideoFrame(CMTime timestamp) {
     });
 
     if (logHold) {
-        MRLog(@"⏸️ Video pipeline waiting for audio to begin (holding frames up to 1.5s)");
+        MRLog(@"⏸️ Video pipeline waiting for audio to begin (holding frames up to 0.35s)");
     } else if (logRelease) {
-        MRLog(@"▶️ Video pipeline resume forced (audio not detected within 1.5s)");
+        MRLog(@"▶️ Video pipeline resume forced (audio not detected within 0.35s)");
     }
 
     return shouldHold;