node-mac-recorder 2.21.19 → 2.21.21

package/.claude/settings.local.json

@@ -5,7 +5,11 @@
       "Bash(chmod:*)",
       "Bash(node test-sync.js:*)",
       "Bash(node:*)",
-      "Bash(ALLOW_CONTINUITY_CAMERA=1 node:*)"
+      "Bash(ALLOW_CONTINUITY_CAMERA=1 node:*)",
+      "Bash(awk:*)",
+      "Bash(ffprobe:*)",
+      "Bash(sw_vers:*)",
+      "Bash(system_profiler:*)"
     ],
     "deny": [],
     "ask": []

package/index.js

@@ -449,8 +449,8 @@ class MacRecorder extends EventEmitter {
 				const originalBaseName = path.basename(outputPath, path.extname(outputPath));
 				const extension = path.extname(outputPath);
 
-				// Remove any existing timestamp from filename (pattern: -1234567890)
-				const cleanBaseName = originalBaseName.replace(/-\d{13}$/, '');
+				// Remove any existing timestamp from filename (pattern: -1234567890 or _1234567890)
+				const cleanBaseName = originalBaseName.replace(/[-_]\d{13}$/, '');
 
 				// Reconstruct path with sessionTimestamp
 				outputPath = path.join(outputDir, `${cleanBaseName}-${sessionTimestamp}${extension}`);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.21.19",
+	"version": "2.21.21",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -120,16 +120,30 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             codecKey = AVVideoCodecH264;
         }
         
+        // QUALITY FIX: ULTRA HIGH quality screen recording
+        // ProMotion displays may capture at 10 FPS - use very high bitrate for perfect quality
+        NSInteger bitrate = (NSInteger)(recordingSize.width * recordingSize.height * 30);
+        bitrate = MAX(bitrate, 30 * 1000 * 1000);  // Minimum 30 Mbps
+        bitrate = MIN(bitrate, 120 * 1000 * 1000); // Maximum 120 Mbps
+
+        NSLog(@"🎬 ULTRA QUALITY AVFoundation: %dx%d, bitrate=%.2fMbps",
+              (int)recordingSize.width, (int)recordingSize.height, bitrate / (1000.0 * 1000.0));
+
         NSDictionary *videoSettings = @{
             AVVideoCodecKey: codecKey,
             AVVideoWidthKey: @((int)recordingSize.width),
             AVVideoHeightKey: @((int)recordingSize.height),
             AVVideoCompressionPropertiesKey: @{
-                AVVideoAverageBitRateKey: @(recordingSize.width * recordingSize.height * 8),
-                AVVideoMaxKeyFrameIntervalKey: @30
+                AVVideoAverageBitRateKey: @(bitrate),
+                AVVideoMaxKeyFrameIntervalKey: @30,
+                AVVideoAllowFrameReorderingKey: @YES,
+                AVVideoExpectedSourceFrameRateKey: @60,
+                AVVideoQualityKey: @(0.95),  // 0.0-1.0, higher is better
+                AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
+                AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC
             }
         };
-        
+
         NSLog(@"🔧 Using codec: %@", codecKey);
         
         // Create video input

package/src/screen_capture_kit.mm

@@ -33,6 +33,10 @@ static BOOL g_audioWriterStarted = NO;
 static NSInteger g_configuredSampleRate = 48000;
 static NSInteger g_configuredChannelCount = 2;
 
+// Frame rate debugging
+static NSInteger g_frameCount = 0;
+static CFAbsoluteTime g_firstFrameTime = 0;
+
 static void CleanupWriters(void);
 static AVAssetWriterInputPixelBufferAdaptor * _Nullable CurrentPixelBufferAdaptor(void) {
     if (!g_pixelBufferAdaptorRef) {
@@ -90,6 +94,10 @@ static void CleanupWriters(void) {
         }
         g_videoWriterStarted = NO;
         g_videoStartTime = kCMTimeInvalid;
+
+        // Reset frame counting
+        g_frameCount = 0;
+        g_firstFrameTime = 0;
     }
     
     if (g_audioWriter) {
@@ -217,6 +225,17 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
     if (!appended) {
         NSLog(@"⚠️ Failed appending pixel buffer: %@", g_videoWriter.error);
     }
+
+    // Frame rate debugging
+    g_frameCount++;
+    if (g_firstFrameTime == 0) {
+        g_firstFrameTime = CFAbsoluteTimeGetCurrent();
+    }
+    if (g_frameCount % 60 == 0) {
+        CFAbsoluteTime elapsed = CFAbsoluteTimeGetCurrent() - g_firstFrameTime;
+        double actualFPS = g_frameCount / elapsed;
+        MRLog(@"📊 Frame stats: %ld frames in %.1fs = %.1f FPS", (long)g_frameCount, elapsed, actualFPS);
+    }
 }
 @end
 
@@ -310,11 +329,27 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
         return NO;
     }
     
+    // QUALITY FIX: ULTRA HIGH quality for screen recording
+    // ProMotion displays may run at 10Hz (low power) = 10 FPS capture
+    // Solution: Use VERY HIGH bitrate so each frame is perfect quality
+    // Use 30x multiplier for ULTRA quality (was 6x - way too low!)
+    NSInteger bitrate = (NSInteger)(width * height * 30);
+    bitrate = MAX(bitrate, 30 * 1000 * 1000);  // Minimum 30 Mbps for crystal clear screen recording
+    bitrate = MIN(bitrate, 120 * 1000 * 1000); // Maximum 120 Mbps for ultra quality
+
+    MRLog(@"🎬 ULTRA QUALITY Screen encoder: %ldx%ld, bitrate=%.2fMbps",
+          (long)width, (long)height, bitrate / (1000.0 * 1000.0));
+
     NSDictionary *compressionProps = @{
-        AVVideoAverageBitRateKey: @(width * height * 6),
-        AVVideoMaxKeyFrameIntervalKey: @30
+        AVVideoAverageBitRateKey: @(bitrate),
+        AVVideoMaxKeyFrameIntervalKey: @30,
+        AVVideoAllowFrameReorderingKey: @YES,
+        AVVideoExpectedSourceFrameRateKey: @60,
+        AVVideoQualityKey: @(0.95),  // 0.0-1.0, higher is better (0.95 = excellent)
+        AVVideoProfileLevelKey: AVVideoProfileLevelH264HighAutoLevel,
+        AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC
     };
-    
+
     NSDictionary *videoSettings = @{
         AVVideoCodecKey: AVVideoCodecTypeH264,
         AVVideoWidthKey: @(width),
@@ -602,13 +637,20 @@ extern "C" NSString *ScreenCaptureKitCurrentAudioPath(void) {
             }
         }
         
-        // Configure stream with extracted options
+        // Configure stream with HIGH QUALITY settings
         SCStreamConfiguration *streamConfig = [[SCStreamConfiguration alloc] init];
         streamConfig.width = recordingWidth;
         streamConfig.height = recordingHeight;
-        streamConfig.minimumFrameInterval = CMTimeMake(1, 30); // 30 FPS
+        streamConfig.minimumFrameInterval = CMTimeMake(1, 60); // 60 FPS for smooth recording
         streamConfig.pixelFormat = kCVPixelFormatType_32BGRA;
         streamConfig.scalesToFit = NO;
+
+        // QUALITY FIX: Set high quality encoding parameters
+        if (@available(macOS 13.0, *)) {
+            streamConfig.queueDepth = 8; // Larger queue for smoother capture
+        }
+
+        MRLog(@"🎬 ScreenCaptureKit config: %ldx%ld @ 60fps", (long)recordingWidth, (long)recordingHeight);
         
         BOOL shouldCaptureMic = includeMicrophone ? [includeMicrophone boolValue] : NO;
         BOOL shouldCaptureSystemAudio = includeSystemAudio ? [includeSystemAudio boolValue] : NO;