node-mac-recorder 2.21.11 → 2.21.13

package/.claude/settings.local.json

@@ -1,19 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(node-gyp:*)",
-      "Bash(node:*)",
-      "Bash(timeout:*)",
-      "Bash(open:*)",
-      "Read(//Users/onur/codes/**)",
-      "Bash(log show:*)",
-      "Bash(MAC_RECORDER_DEBUG=1 node:*)",
-      "Read(//private/tmp/test-recording/**)",
-      "Bash(MAC_RECORDER_DEBUG=1 timeout 5 node:*)",
-      "Read(//private/tmp/**)",
-      "Bash(ffprobe:*)",
-      "Bash(MAC_RECORDER_DEBUG=1 timeout 8 node:*)",
-      "Bash(cat:*)"
+      "Bash(ffmpeg:*)"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.21.11",
+	"version": "2.21.13",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/audio_recorder.mm

@@ -103,11 +103,13 @@ static dispatch_queue_t g_audioCaptureQueue = nil;
     
     CMFormatDescriptionRef formatDescription = CMSampleBufferGetFormatDescription(sampleBuffer);
     const AudioStreamBasicDescription *asbd = formatDescription ? CMAudioFormatDescriptionGetStreamBasicDescription(formatDescription) : NULL;
-    
-    double sampleRate = asbd ? asbd->mSampleRate : 44100.0;
-    NSUInteger channels = asbd ? asbd->mChannelsPerFrame : 2;
+
+    double sampleRate = asbd ? asbd->mSampleRate : 48000.0;  // Default to 48kHz (not 44.1kHz)
+    NSUInteger channels = asbd ? asbd->mChannelsPerFrame : 1;  // Default to mono
     channels = MAX((NSUInteger)1, channels);
 
+    MRLog(@"🎤 Audio format: %.0f Hz, %lu channel(s)", sampleRate, (unsigned long)channels);
+
     AudioChannelLayout layout = {0};
     size_t layoutSize = 0;
     if (channels == 1) {
@@ -122,7 +124,8 @@ static dispatch_queue_t g_audioCaptureQueue = nil;
         AVFormatIDKey: @(kAudioFormatMPEG4AAC),
         AVSampleRateKey: @(sampleRate),
         AVNumberOfChannelsKey: @(channels),
-        AVEncoderBitRateKey: @(192000)
+        AVEncoderBitRateKey: @(256000),  // Increased from 192k to 256k for better quality
+        AVEncoderAudioQualityKey: @(AVAudioQualityHigh)
     } mutableCopy];
 
     if (layoutSize > 0) {
@@ -191,7 +194,17 @@ static dispatch_queue_t g_audioCaptureQueue = nil;
         }
         return NO;
     }
-    
+
+    // Configure audio output settings to ensure proper PCM format
+    NSDictionary *audioOutputSettings = @{
+        AVFormatIDKey: @(kAudioFormatLinearPCM),
+        AVLinearPCMBitDepthKey: @(16),
+        AVLinearPCMIsFloatKey: @(NO),
+        AVLinearPCMIsBigEndianKey: @(NO),
+        AVLinearPCMIsNonInterleaved: @(NO)
+    };
+    [self.audioOutput setAudioSettings:audioOutputSettings];
+
     if (!g_audioCaptureQueue) {
         g_audioCaptureQueue = dispatch_queue_create("native_audio_recorder.queue", DISPATCH_QUEUE_SERIAL);
     }

package/src/camera_recorder.mm

@@ -9,6 +9,12 @@ static AVVideoCodecType const AVVideoCodecTypeVP9 = @"vp09";
 #endif
 
 static BOOL MRAllowContinuityCamera() {
+    // Check environment variable first (allows runtime override)
+    if (getenv("ALLOW_CONTINUITY_CAMERA")) {
+        return YES;
+    }
+
+    // Check Info.plist
     static dispatch_once_t onceToken;
     static BOOL allowContinuity = NO;
     dispatch_once(&onceToken, ^{
@@ -16,9 +22,6 @@ static BOOL MRAllowContinuityCamera() {
         if ([continuityKey respondsToSelector:@selector(boolValue)] && [continuityKey boolValue]) {
             allowContinuity = YES;
         }
-        if (!allowContinuity && getenv("ALLOW_CONTINUITY_CAMERA")) {
-            allowContinuity = YES;
-        }
     });
     return allowContinuity;
 }
@@ -127,9 +130,12 @@ static BOOL MRIsContinuityCamera(AVCaptureDevice *device) {
         [deviceTypes addObject:AVCaptureDeviceTypeExternalUnknown];
     }
 
-    // ALWAYS add Continuity Camera type - filtering happens later
-    if (@available(macOS 14.0, *)) {
-        [deviceTypes addObject:AVCaptureDeviceTypeContinuityCamera];
+    // Add Continuity Camera ONLY if permission is available (to avoid system warning)
+    // But we still want to show external devices that happen to be Continuity cameras
+    if (allowContinuity) {
+        if (@available(macOS 14.0, *)) {
+            [deviceTypes addObject:AVCaptureDeviceTypeContinuityCamera];
+        }
     }
 
     AVCaptureDeviceDiscoverySession *discoverySession =
@@ -139,12 +145,10 @@ static BOOL MRIsContinuityCamera(AVCaptureDevice *device) {
 
     for (AVCaptureDevice *device in discoverySession.devices) {
         BOOL continuityCamera = MRIsContinuityCamera(device);
-        // ONLY skip Continuity cameras when permission is missing
-        // Regular USB/external cameras should ALWAYS be listed
-        if (continuityCamera && !allowContinuity) {
-            MRLog(@"⏭️ Skipping Continuity Camera (permission required): %@", device.localizedName);
-            continue;
-        }
+
+        // NOTE: We list ALL cameras including Continuity Camera
+        // The permission check happens at RECORDING time, not listing time
+        // This allows users to see the device even if permission is missing
         
         // Determine the best (maximum) resolution format for this device
         CMVideoDimensions bestDimensions = {0, 0};