node-mac-recorder 2.21.10 → 2.21.12

package/.claude/settings.local.json

@@ -1,19 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(node-gyp:*)",
-      "Bash(node:*)",
-      "Bash(timeout:*)",
-      "Bash(open:*)",
-      "Read(//Users/onur/codes/**)",
-      "Bash(log show:*)",
-      "Bash(MAC_RECORDER_DEBUG=1 node:*)",
-      "Read(//private/tmp/test-recording/**)",
-      "Bash(MAC_RECORDER_DEBUG=1 timeout 5 node:*)",
-      "Read(//private/tmp/**)",
-      "Bash(ffprobe:*)",
-      "Bash(MAC_RECORDER_DEBUG=1 timeout 8 node:*)",
-      "Bash(cat:*)"
+      "Bash(ffmpeg:*)"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.21.10",
+	"version": "2.21.12",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/audio_recorder.mm

@@ -122,7 +122,8 @@ static dispatch_queue_t g_audioCaptureQueue = nil;
         AVFormatIDKey: @(kAudioFormatMPEG4AAC),
         AVSampleRateKey: @(sampleRate),
         AVNumberOfChannelsKey: @(channels),
-        AVEncoderBitRateKey: @(192000)
+        AVEncoderBitRateKey: @(256000),  // Increased from 192k to 256k for better quality
+        AVEncoderAudioQualityKey: @(AVAudioQualityHigh)
     } mutableCopy];
 
     if (layoutSize > 0) {

package/src/avfoundation_recorder.mm

@@ -212,22 +212,26 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             MRLog(@"🎤 Starting audio capture (mic=%d, system=%d)", includeMicrophone, includeSystemAudio);
 
             // Use provided audio output path or generate one
+            NSString *audioPath = nil;
             if (audioOutputPath && [audioOutputPath length] > 0) {
-                g_avAudioOutputPath = audioOutputPath;
-                MRLog(@"🎤 Using provided audio path: %@", g_avAudioOutputPath);
+                audioPath = audioOutputPath;
+                MRLog(@"🎤 Using provided audio path: %@", audioPath);
             } else {
                 NSString *videoDir = [outputPathStr stringByDeletingLastPathComponent];
                 NSString *audioFilename = [NSString stringWithFormat:@"avf_audio_%ld.mov", (long)[[NSDate date] timeIntervalSince1970]];
-                g_avAudioOutputPath = [videoDir stringByAppendingPathComponent:audioFilename];
-                MRLog(@"🎤 Generated audio path: %@", g_avAudioOutputPath);
+                audioPath = [videoDir stringByAppendingPathComponent:audioFilename];
+                MRLog(@"🎤 Generated audio path: %@", audioPath);
             }
 
             // Ensure .mov extension
-            if (![g_avAudioOutputPath.pathExtension.lowercaseString isEqualToString:@"mov"]) {
-                g_avAudioOutputPath = [[g_avAudioOutputPath stringByDeletingPathExtension] stringByAppendingPathExtension:@"mov"];
-                MRLog(@"🔧 Fixed audio extension to .mov: %@", g_avAudioOutputPath);
+            if (![audioPath.pathExtension.lowercaseString isEqualToString:@"mov"]) {
+                audioPath = [[audioPath stringByDeletingPathExtension] stringByAppendingPathExtension:@"mov"];
+                MRLog(@"🔧 Fixed audio extension to .mov: %@", audioPath);
             }
 
+            // Copy to retain the string (ARC will manage it)
+            g_avAudioOutputPath = [audioPath copy];
+
             // Create audio recorder
             g_avAudioRecorder = createNativeAudioRecorder();
 
@@ -404,9 +408,14 @@ extern "C" bool stopAVFoundationRecording() {
     // Stop audio recording if active
     if (g_avAudioRecorder) {
         MRLog(@"🛑 Stopping audio recording");
-        stopNativeAudioRecording(g_avAudioRecorder);
-        destroyNativeAudioRecorder(g_avAudioRecorder);
+        @try {
+            stopNativeAudioRecording(g_avAudioRecorder);
+            destroyNativeAudioRecorder(g_avAudioRecorder);
+        } @catch (NSException *exception) {
+            NSLog(@"⚠️ Exception while stopping audio: %@", exception.reason);
+        }
         g_avAudioRecorder = nil;
+        g_avAudioOutputPath = nil;
         MRLog(@"✅ Audio recording stopped");
     }
 

package/src/camera_recorder.mm

@@ -9,6 +9,12 @@ static AVVideoCodecType const AVVideoCodecTypeVP9 = @"vp09";
 #endif
 
 static BOOL MRAllowContinuityCamera() {
+    // Check environment variable first (allows runtime override)
+    if (getenv("ALLOW_CONTINUITY_CAMERA")) {
+        return YES;
+    }
+
+    // Check Info.plist
     static dispatch_once_t onceToken;
     static BOOL allowContinuity = NO;
     dispatch_once(&onceToken, ^{
@@ -16,9 +22,6 @@ static BOOL MRAllowContinuityCamera() {
         if ([continuityKey respondsToSelector:@selector(boolValue)] && [continuityKey boolValue]) {
             allowContinuity = YES;
         }
-        if (!allowContinuity && getenv("ALLOW_CONTINUITY_CAMERA")) {
-            allowContinuity = YES;
-        }
     });
     return allowContinuity;
 }
@@ -127,9 +130,12 @@ static BOOL MRIsContinuityCamera(AVCaptureDevice *device) {
         [deviceTypes addObject:AVCaptureDeviceTypeExternalUnknown];
     }
 
-    // ALWAYS add Continuity Camera type - filtering happens later
-    if (@available(macOS 14.0, *)) {
-        [deviceTypes addObject:AVCaptureDeviceTypeContinuityCamera];
+    // Add Continuity Camera ONLY if permission is available (to avoid system warning)
+    // But we still want to show external devices that happen to be Continuity cameras
+    if (allowContinuity) {
+        if (@available(macOS 14.0, *)) {
+            [deviceTypes addObject:AVCaptureDeviceTypeContinuityCamera];
+        }
     }
 
     AVCaptureDeviceDiscoverySession *discoverySession =
@@ -139,12 +145,10 @@ static BOOL MRIsContinuityCamera(AVCaptureDevice *device) {
 
     for (AVCaptureDevice *device in discoverySession.devices) {
         BOOL continuityCamera = MRIsContinuityCamera(device);
-        // ONLY skip Continuity cameras when permission is missing
-        // Regular USB/external cameras should ALWAYS be listed
-        if (continuityCamera && !allowContinuity) {
-            MRLog(@"⏭️ Skipping Continuity Camera (permission required): %@", device.localizedName);
-            continue;
-        }
+
+        // NOTE: We list ALL cameras including Continuity Camera
+        // The permission check happens at RECORDING time, not listing time
+        // This allows users to see the device even if permission is missing
         
         // Determine the best (maximum) resolution format for this device
         CMVideoDimensions bestDimensions = {0, 0};