node-mac-recorder 2.18.8 → 2.18.10

package/.claude/settings.local.json

@@ -1,18 +1,12 @@
 {
   "permissions": {
     "allow": [
-      "Bash(node:*)",
-      "Bash(chmod:*)",
-      "Bash(cat:*)",
-      "Bash(git checkout:*)",
-      "WebSearch",
-      "WebFetch(domain:stackoverflow.com)",
-      "Bash(timeout:*)",
-      "Bash(grep:*)",
-      "Bash(./test-cleanup.sh:*)",
-      "Bash(FORCE_AVFOUNDATION=1 node test-avfoundation-dpr.js)",
-      "Bash(FORCE_AVFOUNDATION=1 node test-cursor-fix.js)",
-      "Bash(pkill:*)"
+      "Bash(FORCE_AVFOUNDATION=1 node test-cursor-simple.js)",
+      "Bash(FORCE_AVFOUNDATION=1 timeout 10 node test-cursor-simple.js)",
+      "Bash(jq:*)",
+      "Bash(FORCE_AVFOUNDATION=1 timeout 15 node test-cursor-position.js)",
+      "Bash(FORCE_AVFOUNDATION=1 timeout 8 node test-cursor-debug.js)",
+      "Bash(FORCE_AVFOUNDATION=1 timeout 5 node test-cursor-debug.js)"
     ],
     "deny": [],
     "ask": []

package/index.js

@@ -253,10 +253,10 @@ class MacRecorder extends EventEmitter {
 						// Recording için display bilgisini sakla (cursor capture için)
 						const targetDisplay = displays.find(d => d.id === targetDisplayId);
 
-						// CRITICAL FIX: Get actual physical dimensions for proper cursor scaling
-						// This fixes cursor coordinate issues on Retina displays during AVFoundation recording
-						const cursorPosition = nativeBinding.getCursorPosition();
-						const displayScalingInfo = cursorPosition.displayInfo;
+						// CRITICAL FIX: For now, use logical dimensions to avoid cross-display scaling issues
+						// This prevents using wrong display's physical dimensions
+						let displayScalingInfo = null;
+						// TODO: Implement proper per-display scaling detection in native layer
 
 						this.recordingDisplayInfo = {
 							displayId: targetDisplayId,
@@ -308,10 +308,10 @@ class MacRecorder extends EventEmitter {
 				}
 
 				if (targetDisplay) {
-					// CRITICAL FIX: Get actual physical dimensions for proper cursor scaling
-					// This fixes cursor coordinate issues on Retina displays during AVFoundation recording
-					const cursorPosition = nativeBinding.getCursorPosition();
-					const displayScalingInfo = cursorPosition.displayInfo;
+					// CRITICAL FIX: For now, use logical dimensions to avoid cross-display scaling issues
+					// This prevents using wrong display's physical dimensions
+					const displayScalingInfo = null;
+					// TODO: Implement proper per-display scaling detection in native layer
 
 					this.recordingDisplayInfo = {
 						displayId: targetDisplay.id,
@@ -823,6 +823,23 @@ class MacRecorder extends EventEmitter {
 
 						// Apply video-relative transformation for all recording types
 						if (this.cursorDisplayInfo && this.cursorDisplayInfo.videoRelative) {
+							// FILTER: Only record cursor when it's on the target display
+							// Use cached display info to avoid async calls
+							const displayX = this.cursorDisplayInfo.displayX;
+							const displayY = this.cursorDisplayInfo.displayY;
+							const displayWidth = this.cursorDisplayInfo.displayWidth;
+							const displayHeight = this.cursorDisplayInfo.displayHeight;
+
+							const onTargetDisplay = position.x >= displayX &&
+								position.x < (displayX + displayWidth) &&
+								position.y >= displayY &&
+								position.y < (displayY + displayHeight);
+
+							if (!onTargetDisplay) {
+								// Skip cursor data when cursor is on different display
+								return;
+							}
+
 							// Step 1: Transform global → display-relative coordinates
 							const displayRelativeX = position.x - this.cursorDisplayInfo.displayX;
 							const displayRelativeY = position.y - this.cursorDisplayInfo.displayY;
@@ -937,6 +954,13 @@ class MacRecorder extends EventEmitter {
 					this.cursorCaptureFile = null;
 				}
 
+				// Native cursor tracking'i durdur
+				try {
+					nativeBinding.stopCursorTracking();
+				} catch (nativeError) {
+					console.warn('Native cursor tracking stop failed:', nativeError.message);
+				}
+
 				// Değişkenleri temizle
 				this.lastCapturedData = null;
 				this.cursorCaptureStartTime = null;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.18.8",
+	"version": "2.18.10",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [