node-mac-recorder 2.18.4 → 2.18.5

package/.claude/settings.local.json

@@ -10,7 +10,9 @@
       "Bash(timeout:*)",
       "Bash(grep:*)",
       "Bash(./test-cleanup.sh:*)",
-      "Bash(FORCE_AVFOUNDATION=1 node test-avfoundation-dpr.js)"
+      "Bash(FORCE_AVFOUNDATION=1 node test-avfoundation-dpr.js)",
+      "Bash(FORCE_AVFOUNDATION=1 node test-cursor-fix.js)",
+      "Bash(pkill:*)"
     ],
     "deny": [],
     "ask": []

package/index.js

@@ -705,8 +705,18 @@ class MacRecorder extends EventEmitter {
 			// Calculate video offset based on recording type
 			let videoOffsetX = 0;
 			let videoOffsetY = 0;
-			let videoWidth = options.displayInfo.width || options.displayInfo.logicalWidth;
-			let videoHeight = options.displayInfo.height || options.displayInfo.logicalHeight;
+			// CRITICAL FIX: Use physical dimensions for video when scale factor > 1 (AVFoundation)
+			// AVFoundation records at physical resolution, ScreenCaptureKit at logical resolution
+			let videoWidth, videoHeight;
+			if (options.displayInfo.scaleFactor && options.displayInfo.scaleFactor > 1.0) {
+				// AVFoundation case: use physical dimensions to match actual video size
+				videoWidth = options.displayInfo.physicalWidth || options.displayInfo.width || options.displayInfo.logicalWidth;
+				videoHeight = options.displayInfo.physicalHeight || options.displayInfo.height || options.displayInfo.logicalHeight;
+			} else {
+				// ScreenCaptureKit case: use logical dimensions
+				videoWidth = options.displayInfo.width || options.displayInfo.logicalWidth;
+				videoHeight = options.displayInfo.height || options.displayInfo.logicalHeight;
+			}
 
 			if (options.recordingType === 'window' && options.windowId) {
 				// For window recording: offset = window position in display
@@ -759,8 +769,13 @@ class MacRecorder extends EventEmitter {
 				scaleFactor: this.recordingDisplayInfo.scaleFactor || 1.0,
 				videoOffsetX: 0,
 				videoOffsetY: 0,
-				videoWidth: this.recordingDisplayInfo.width || this.recordingDisplayInfo.logicalWidth,
-				videoHeight: this.recordingDisplayInfo.height || this.recordingDisplayInfo.logicalHeight,
+				// CRITICAL FIX: Use physical dimensions for video when scale factor > 1 (AVFoundation)
+				videoWidth: (this.recordingDisplayInfo.scaleFactor > 1.0) ?
+					(this.recordingDisplayInfo.physicalWidth || this.recordingDisplayInfo.width || this.recordingDisplayInfo.logicalWidth) :
+					(this.recordingDisplayInfo.width || this.recordingDisplayInfo.logicalWidth),
+				videoHeight: (this.recordingDisplayInfo.scaleFactor > 1.0) ?
+					(this.recordingDisplayInfo.physicalHeight || this.recordingDisplayInfo.height || this.recordingDisplayInfo.logicalHeight) :
+					(this.recordingDisplayInfo.height || this.recordingDisplayInfo.logicalHeight),
 				videoRelative: true,
 				recordingType: options.recordingType || 'display'
 			};
@@ -812,32 +827,20 @@ class MacRecorder extends EventEmitter {
 							const displayRelativeX = position.x - this.cursorDisplayInfo.displayX;
 							const displayRelativeY = position.y - this.cursorDisplayInfo.displayY;
 
-							// CRITICAL FIX: Apply physical scaling for AVFoundation recording
-							// AVFoundation records at physical resolution while cursor coordinates are logical
-							let scaledX = displayRelativeX;
-							let scaledY = displayRelativeY;
-
-							if (this.cursorDisplayInfo.scaleFactor && this.cursorDisplayInfo.scaleFactor > 1.0) {
-								// Scale logical cursor coordinates to match physical video dimensions
-								scaledX = displayRelativeX * this.cursorDisplayInfo.scaleFactor;
-								scaledY = displayRelativeY * this.cursorDisplayInfo.scaleFactor;
-								coordinateSystem = "video-relative-scaled";
-							}
-
 							// Step 2: Transform display-relative → video-relative coordinates
-							x = scaledX - this.cursorDisplayInfo.videoOffsetX;
-							y = scaledY - this.cursorDisplayInfo.videoOffsetY;
-							coordinateSystem = this.cursorDisplayInfo.scaleFactor > 1.0 ? "video-relative-scaled" : "video-relative";
-
-							// Bounds check for video area (use physical video dimensions for AVFoundation)
-							const videoWidth = this.cursorDisplayInfo.physicalWidth || this.cursorDisplayInfo.videoWidth;
-							const videoHeight = this.cursorDisplayInfo.physicalHeight || this.cursorDisplayInfo.videoHeight;
+							// videoWidth/Height already account for physical vs logical dimensions
+							x = displayRelativeX - this.cursorDisplayInfo.videoOffsetX;
+							y = displayRelativeY - this.cursorDisplayInfo.videoOffsetY;
+							coordinateSystem = "video-relative";
 
-							const outsideVideo = x < 0 || y < 0 || x >= videoWidth || y >= videoHeight;
+							// Bounds check for video area using correct video dimensions
+							const outsideVideo = x < 0 || y < 0 ||
+								x >= this.cursorDisplayInfo.videoWidth ||
+								y >= this.cursorDisplayInfo.videoHeight;
 
 							// For debugging - add metadata if cursor is outside video area
 							if (outsideVideo) {
-								coordinateSystem = coordinateSystem + "-outside";
+								coordinateSystem = "video-relative-outside";
 							}
 						}
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.18.4",
+	"version": "2.18.5",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [